- Apr 14, 2020
-
-
Andreas Fernandez authored
To improve the user experience, the search filter in the "New Content Element" wizard is automatically focussed when the modal appears. Resolves: #91014 Releases: master Change-Id: I3e0f18bd454955af63cd797138de7b2118d9d2ac Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64129 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Josef Glatz <josefglatz@gmail.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Benni Mack authored
This change adds two changes 'blank_line_after_opening_tag' => true, 'single_trait_insert_per_statement' => true, to our PHP-CS Fixer configuration, adopting more rules related to PSR-12. Resolves: #91020 Releases: master Change-Id: I180b2cbceb077911bddeb42d9f131e5b32244ed2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64158 Tested-by:Oliver Bartsch <bo@cedev.de> Tested-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
Benni Mack authored
With this change the default values for new records in DataHandler are now respected based on the resolved page ID, allowing to deal with pageTS for specific sites or subpages. Resolves: #89211 Releases: master, 9.5 Change-Id: I4d889a857f04f2284c8643cd4253653fea0f2e19 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63406 Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Tested-by:
Jonas Eberle <flightvision@googlemail.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Benni Mack authored
DataHandler does not set "-1" for versioned records in workspaces anymore, thus making it a lot easier to find the real PID for a versioned record without always having to fetch the live version for it. This is ground-breaking, as this opens the door for a lot of improvements when accessing versions via overlays. An upgrade wizard will migrate all pid=-1 records to their equivalent pids, and discard all already published / archived versions. Resolves: #89555 Releases: master Change-Id: I31c32451827c1f94764bb0ba22ad8207c8b3d4fd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61699 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Manuel Selbach <manuel_selbach@yahoo.de> Tested-by:
-
Tymoteusz Motylewski authored
The old TS Conditions syntax with two blocks combined with && is deprecated so it should not be used as an example in the changelog. It was deprecated in: https://docs.typo3.org/c/typo3/cms-core/master/en-us/Changelog/9.5/Deprecation-86068-OldConditionSyntax.html Releases: master, 9.5 Resolves: #91017 Change-Id: I60d2fc7c26d8a72f75c82355d4c0d64cf27827c1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64060 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
-
Benni Mack authored
PSR-15 and Request/Response handling has been proven to be a worthy replacement for most logic related for outputting content in the TYPO3 Frontend. In order to thin out TSFE in future TYPO3 versions, various hooks have been deprecated as they can also be used with proper PSR-15 middlewares. * $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['pageIndexing'] * $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['isOutputting'] * $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['tslib_fe-contentStrReplace'] * $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['contentPostProc-output'] The following methods are marked as deprecated as well: * $TSFE->isOutputting() * $TSFE->processContentForOutput() Resolves: #91012 Releases: master Change-Id: I455f110f7f3e774de9d8ccd4adfcbd1ed5538cec Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64118 Tested-by:
-
- Apr 13, 2020
-
-
Benni Mack authored
Due to wrong prefixes of TCA type=slug fields for custom records e.g. in ext:news, a new configuration `prefix` is introduced. A `userFunc` can be assigned to the new field which then allows to provide a custom base url based on e.g. the correct detail page. The default behaviour, which is used for pages, is still applied, when no custom base url is given. Resolves: #89573 Releases: master Change-Id: I529ff26ddeba200b56f0c23aca55daa187c3f40d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62270 Tested-by:
-
Manuel Selbach authored
With this change all field will be cast to a datatype, that is searchable with `like` to prevent errors. Before that change e.g. for table `sys_file_reference` the field `uid_local` is configured as label field. The query that is built, will then try to do a like search on that field, which breaks on certain DBMS. Resolves: #81802 Resolves: #82837 Releases: master, 9.5 Change-Id: I65cc11e6c6388919a34b45a8738d8e1c64881983 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63885 Tested-by:
-
Alexander Schnitzler authored
As a preparation to be compatible with PSR-12, all spaces in strict type declerations are removed. Releases: master Resolves: #91009 Change-Id: I2b7c2fda42b44168b5c4c6b21711eede2eadaf2e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62104 Tested-by:
-
Timo Poppinga authored
Add the HTTP methods 'PURGE' and 'BAN' to $supportedMethods, to support clear cache requests for proxy caches like varnish. Resolves: #90968 Releases: master, 9.5 Change-Id: I2d4737319d23b362af689eadd21b6c3134a894e4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64093 Tested-by:
Timo Poppinga <timo.poppinga@zdrei.com> Tested-by:
-
Georg Ringer authored
Make sure that the key in ArrayBrowser::getSearchKeys() is always cast to string. Resolves: #91007 Releases: master Change-Id: I28aa780a92f9425df486cb0dadee3930b4a54f14 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64124 Tested-by:
Christian Eßl <indy.essl@gmail.com> Tested-by:
-
- Apr 12, 2020
-
-
Andreas Fernandez authored
Navigating in the RteLinkBrowser by e.g. switching tabs or browsing the file tree now recovers the selections of the underlying ckeditor. This allows to invoke a browser search, navigate within the link browser and place a link afterwards. Resolves: #91006 Related: #90952 Releases: master, 9.5 Change-Id: If2d943f0b2a8b86babead8c1397d6222b0c0da7d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64121 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Gerrit Mohrmann authored
When forwarding to the logout action in felogin extbase plugin the missing arguments is now set to resolve the actionUri. Resolves: #91005 Releases: master Change-Id: If64210ad9ed853e910e7b6f34dfcdb2458957821 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64120 Tested-by:
-
Benni Mack authored
To overcome external images via FluidEmail and apply the similar behaviour as in LoginController, the <f:image> and <f:uri.image> ViewHelpers do not process external images but just return them, allowing logins again with custom login images and "sendNotificationEmail" settings turned on. Resolves: #90656 Releases: master Change-Id: I8ae70da66ee506c085a88690f27d0930b4bfc99d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63635 Tested-by:
-
Benni Mack authored
The code in cObj->checkPidArray() and cObj->checkPid() is checking for valid page records, which semantically belongs to PageRepository. As this code is now added to PageRepository, it is built in a more flexible way now, and available for all core relevant parts, not just Frontend logic. The method cObj->checkPid(), previously marked as internal, is removed. Resolves: #90928 Releases: master Change-Id: I4e6c089ed7efcab208a1aa3bb79599cf2c719787 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64042 Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
-
Benni Mack authored
Some methods in GeneralUtility nowadays are wrappers to native PHP methods. We encourage people to use the PHP API directly. * GeneralUtility::IPv6Hex2Bin() * GeneralUtility::IPv6Bin2Hex() * GeneralUtility::compressIPv6() * GeneralUtility::milliseconds() In addition, these methods are unused by Core * GeneralUtility::linkThisUrl() * GeneralUtility::flushDirectory() Reasoning: In order to make our code less coupled, TYPO3 Core should use native PHP where it makes sense, instead of relying on GeneralUtility in all places. Resolves: #91001 Releases: master Change-Id: I9e3a2f4a4bb42facad2d79f959b36482dba23ec8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64091 Tested-by:
-
Christian Eßl authored
When copying a tt_content record in list module, the DataHandler would internally look up the 'copyAfterDuplFields' settings in TCA and ensure, that those fields are copied from its new neighboring record. In TYPO3 core, the 'copyAfterDuplFields' settings are only used by the table tt_content with 'colPos,sys_language_uid' as its values. This makes sense for copying records, but the same behaviour, that stems from TYPO3s very early days, was also used when records where moved around with the DataHandler. When an editor changes the position of a tt_content record in the list module, the record would then always automatically adopt the colPos/sys_language_uid of its new neighbour, which is usually not expected or desired, and often leads to much confusion and broken content grids. The code responsible for 'copyAfterDuplFields' is now removed from DataHandler::moveRecord_raw(), while retaining the behaviour for DataHandler::copyRecord(). Moving around tt_content records in the page module to different columns or languages is not affected by this change, as the colPos/sys_language_uid changes there are set in a separate update statement. Resolves: #72988 Resolves: #59901 Resolves: #39798 Resolves: #25216 Resolves: #14873 Releases: master, 9.5 Change-Id: Ic9c57fe2712b0996bc7b53cce4bcdc275c2820cb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63646 Tested-by:
-
Benni Mack authored
Since the ObjectManagerInterface methods. - isRegistered() - getScope() are internal, they are substituted by PHP's internal code, and avoid look ups to the custom ObjectContainer code. Two constants and further methods about Singleton checks within Extbase's internal ObjectContainer are removed as they are now unused as well. Resolves: #91002 Releases: master Change-Id: I1ed9ae2749aeabb6ab352057e639946289dde96a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64083 Tested-by:
-
Daniel Siepmann authored
Provide concrete classes that will be instantiated multiple times with different options. E.g. provide an RssWidget implementation, that can be used multiple times with different rss feed urls. Split configuration for UI (title, icon, …) from concrete implementation. A new WidgetConfigurationInterface is in place and used. Resolves: #90660 Resolves: #90852 Releases: master Change-Id: I194615164b7d3d1cbd63751ddfd1f66f71db64cf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63563 Tested-by:
Koen Wouters <koen.wouters@maxserv.com> Tested-by:
Richard Haeser <richard@maxserv.com> Tested-by:
Riny van Tiggelen <info@online-gamer.nl> Tested-by:
Susanne Moog <look@susi.dev> Reviewed-by:
-
Anja Leichsenring authored
The test have been disabled due to flakiness, let's give them another chance to prove themselves valuable. Resolves: #79730 Releases: master, 9.5 Change-Id: I8f0f64971438effb4b8baa62819d44c2920742de Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63937 Tested-by:
-
Jonas Eberle authored
This omits type="text/javascript" by default for JavaScript assets. Resolves: #91000 Releases: master Change-Id: If8b6a0270a1afe35face8a410beea0736ac43cef Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64117 Tested-by:
-
Josef Glatz authored
The link to the extension file scanner is removed to avoid any exception when running a scan if no extension is available at all. Visually, it's grayed out like the disabled "Update TYPO3 Core" card in composer mode and the link is removed. Releases: master, 9.5 Resolves: #90981 Change-Id: I53d41111b51ed74d142894c56a4378fc9d958e8d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64100 Tested-by:
-
- Apr 11, 2020
-
-
Tobi Kretschmann authored
Using mm tables, the value that is stored in the database does not represent the uid of the selected item. Much rather it is the amount of selected items. If three items are selected the value within the database field is "3". Whereas using multiple select without mm table, it is stored as a comma-separated list of uids. Releases: master, 9.5 Resolves: #90925 Change-Id: I110cbf0fd19fab1135958c445a846a1af9c24510 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64062 Tested-by:
Jörg Bösche <typo3@joergboesche.de> Tested-by:
Sebastian Hofer <sebastian.hofer@marit.ag> Tested-by:
-
Michael Schams authored
This change makes language labels for backend module names consistent by following the rule "first letter of both words upper-case" (e.g. "Admin Tools"). Resolves: #90993 Releases: master Change-Id: I58aef178b3c0a781e1046e381340ad29fa19c7ea Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64114 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
-
- Apr 10, 2020
-
-
Georg Ringer authored
The message of the exception introduced with #89857 needs some improvements. Resolves: #90996 Releases: master, 9.5 Change-Id: If0bc77ac8bcdab44a6468dc7bd1eb3543673e7a8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64116 Tested-by:
-
Georg Ringer authored
Improve rendering of the password forgotten link if additional login providers are registered. Resolves: #90978 Releases: master Change-Id: I0e064b7bfa7836ac2341d4d96ccc61c056c03269 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64104 Tested-by:
Florian Wessels <f.wessels@bitmotion.de> Tested-by:
-
Volker Diels-Grabsch authored
This commit fixes a string-with-boolean comparison in a switch case. Instead, this complex case is moved down to the default case where all other complex cases are handled as well. Resolves: #90992 Related: #89857 Related: #72053 Releases: master, 9.5 Change-Id: I43730176e1a46a2bc63ea4d45bcf4511c1970aab Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64113 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
- Apr 09, 2020
-
-
Releases: master Resolves: #90990 Related: #88921 Change-Id: I9a3997bde020b500a1bd1a6712ae0e405001a452 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64110 Tested-by:
Daniel Siepmann <coding@daniel-siepmann.de> Reviewed-by:
-
Tymoteusz Motylewski authored
Add test for TreeController, so we're safe when refactoring or doing performance optimizations. Besides that moved pages in a workspace were not considered when calculating permissions on the rootline due to missing workspace overlays. Resolves: #90831 Releases: 9.5, master Change-Id: Ic3ab08d2502e8c9a3f08e737552c2e1d2a56a66c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63848 Tested-by:
-
- Apr 08, 2020
-
-
Benni Mack authored
The master $GLOBALS[LANG] object should have a more streamlined API and some methods and public properties are now deprecated, in order to make this API much more stateless. Resolves: #90964 Releases: master Change-Id: I201cf1b7300e385e3b87ab282290aae8e27041da Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64056 Tested-by:
-
Alexander Schnitzler authored
Releases: master Resolves: #90913 Change-Id: If38a526547518e93b3002ffa01accebf4a12e5b3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64032 Tested-by:
-
Christian Eßl authored
The changes in #18079 have a small, but nasty typo, that makes it impossible to correctly check if the page is a sysfolder. Resolves: #90975 Related: #18079 Releases: master Change-Id: Iec8d119a9d29adec742f322a66102ce77a6eb16a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64095 Tested-by:
-
Christian Eßl authored
Resolves: #90976 Releases: master, 9.5 Change-Id: I3827e0796f7dc016b3095b5e8917905b85523712 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64096 Tested-by:
-
Christian Eßl authored
Resolves: #90960 Releases: master Change-Id: I71933b194a4c366914c9d462b91cf605ed454a76 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64103 Tested-by:
-
Nikita Hovratov authored
The key should be 4 instead of 5 (index starts at 0). Resolves: #90982 Releases: master Change-Id: Iee33a74d8f569082aa495025892131acc0a392a7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64101 Tested-by:
-
Georg Ringer authored
The row must only be processed if available. Resolves: #90979 Releases: master Change-Id: I0ce76b196c32d8528d0bce0467782c3da4daefba Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64099 Reviewed-by:
-
Andreas Fernandez authored
This patch updates the Docker configuration to use mssql 2019 as mssql 2017 images don't get updates anymore. Additionally to the mssql update, the shuffled chunking to 50 jobs is reverted as it didn't bring any benefit but even more hassle as the stages failed earlier and more often. Instead, the jobs are now grouped by PHP version which allows smaller chunks and reduced the probability to clog the build queue. To workaround errors thrown by Gerrit on heavy load, the cherry-pick command is now executed up to five times, with a short sleep between each execution. Last but not least we check whether there is actually a dangling Docker container instead of hard killing non-existent containers which pollutes our log. Resolves: #90965 Releases: master, 9.5 Change-Id: Ied60297127b86c3375d310759bf441ad9e10aeed Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64087 Tested-by:
-
Daniel Siepmann authored
These changes in the SuggestWizardController allow users to override allowed tables in group fields with columnsOverrides. Typical usecases for this is to use the records field for tt_content elements. Resolves: #76661 Releases: master Change-Id: Ic566c793f8d953802f5f6ff670fde485c19ed9db Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59444 Tested-by:
-
- Apr 07, 2020
-
-
Daniel Siepmann authored
With https://review.typo3.org/c/Packages/TYPO3.CMS/+/64018 several @var annotations have been adjusted to reflect the actual used type of properties. This however led to the issue that several properties of Extbase models had one type as annotation but used more than one specific type internally. Adding the additional type made phpstan happy but broke the property mapper of Extbase, which expects just one type to be annotated via @var. Therefore, the @var annotations in the affected models have been reverted to their original state and the reoccurring errors have been put onto phpstans list of ignored errors. Resolves: #90969 Releases: master Change-Id: I91944a631b9e1ff300ada25953577d852a998270 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64094 Tested-by:
-
Georg Ringer authored
Force value to be a string instead of null in ConstantConfigurationParser to avoid exceptions. Resolves: #90900 Releases: master Change-Id: I968e86f95577eaa3d9d57e367cfb707f9a3e4ff5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64089 Tested-by:
-
