[BUGFIX] Keep language or colPos when moving a record in list module
When copying a tt_content record in list module, the DataHandler would internally look up the 'copyAfterDuplFields' settings in TCA and ensure, that those fields are copied from its new neighboring record. In TYPO3 core, the 'copyAfterDuplFields' settings are only used by the table tt_content with 'colPos,sys_language_uid' as its values. This makes sense for copying records, but the same behaviour, that stems from TYPO3s very early days, was also used when records where moved around with the DataHandler. When an editor changes the position of a tt_content record in the list module, the record would then always automatically adopt the colPos/sys_language_uid of its new neighbour, which is usually not expected or desired, and often leads to much confusion and broken content grids. The code responsible for 'copyAfterDuplFields' is now removed from DataHandler::moveRecord_raw(), while retaining the behaviour for DataHandler::copyRecord(). Moving around tt_content records in the page module to different columns or languages is not affected by this change, as the colPos/sys_language_uid changes there are set in a separate update statement. Resolves: #72988 Resolves: #59901 Resolves: #39798 Resolves: #25216 Resolves: #14873 Releases: master, 9.5 Change-Id: Ic9c57fe2712b0996bc7b53cce4bcdc275c2820cb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63646 Tested-by:TYPO3com <noreply@typo3.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
Showing
- typo3/sysext/core/Classes/DataHandling/DataHandler.php 0 additions, 8 deletionstypo3/sysext/core/Classes/DataHandling/DataHandler.php
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Modify/DataSet/changeContentSorting.csv 2 additions, 2 deletions...aHandling/Regular/Modify/DataSet/changeContentSorting.csv
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Modify/DataSet/changeContentSortingAndCopyDraftPage.csv 10 additions, 10 deletions...r/Modify/DataSet/changeContentSortingAndCopyDraftPage.csv
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Modify/DataSet/changeContentSortingAndCopyLivePage.csv 2 additions, 2 deletions...ar/Modify/DataSet/changeContentSortingAndCopyLivePage.csv
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Modify/DataSet/changeContentSortingNDeleteLiveRecord.csv 2 additions, 2 deletions.../Modify/DataSet/changeContentSortingNDeleteLiveRecord.csv
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Modify/DataSet/changeContentSortingNDeleteMovedRecord.csv 2 additions, 2 deletions...Modify/DataSet/changeContentSortingNDeleteMovedRecord.csv
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Modify/DataSet/moveContentToDifferentPageNChangeSorting.csv 2 additions, 2 deletions...dify/DataSet/moveContentToDifferentPageNChangeSorting.csv
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Publish/DataSet/changeContentSorting.csv 2 additions, 2 deletions...Handling/Regular/Publish/DataSet/changeContentSorting.csv
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Publish/DataSet/moveContentToDifferentPageNChangeSorting.csv 2 additions, 2 deletions...lish/DataSet/moveContentToDifferentPageNChangeSorting.csv
Please register or sign in to comment