- Sep 28, 2023
-
-
Andreas Fernandez authored
This patch updates the `alwan` color picker library to the recent version 1.4, allowing us to implement localization at a later point. Executed commands: npm install --save alwan@^1.4.0 npm run build Resolves: #102061 Releases: main Change-Id: I9d30b575ad936a10c63ead7bec5e1e5c504981e7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81293 Tested-by:Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
core-ci <typo3@b13.com>
-
Georg Ringer authored
Make the controller a bit more slim by moving database related code to the repository. Resolves: #101958 Releases: main Change-Id: I6a6f52236dcb6190d20e77f4356424e846702476 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81091 Reviewed-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Nikita Hovratov authored
Resolves: #102060 Releases: main, 12.4 Change-Id: I22acca2ecdff371a88c3cf060ac5c6707735bf73 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81292 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
Benjamin Franzke authored
Adapt to the user expection for a style selector to only show applicable styles. The list becomes overwhelming in case a lot of specific styles (like table formatting) are shown for unrelated elements. Resolves: #99673 Related: #101627 Releases: main, 12.4 Change-Id: I482935e91c863b601676b078fab0e9ba3acd62fa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81269 Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
Stefan Bürk authored
Sending a redirect response with a empty `Location` is invalid per RFC. Browser vendor are dealing differntly with it. * Firefox executes a redirect to the current url, leading to an `endless` redirect chain - stopping it after some recursions with a coresponding notice in the network tab. * Chrome determines this and is doing nothing at all with it - leading to a white page. From the [1] RFC regarding invalid URI spec for `Location`: > Note: Some recipients attempt to recover from Location > fields that are not valid URI references. This > specification does not mandate or define such > processing, but does allow it for the sake of > robustness. A matching redirect record with a manually entered `/` as redirect target leads in TYPO3 v11 to this behaviour. This can be mitigated by selecting the corresponding site root. For TYPO3 v12 and upwards a change in the LinkHandling has been introduced which properly handles the `/` in the link generation and correctly returning a `/` as redirect url. That change has quite some impact and is not reasonable to be backported to TYPO3 v11 within #100958. This change adds an additionally guard to the `RedirectHandler` to handle empty redirect urls as endless loop, just logging it and not responding with an redirect. This helps in v11 and keeps a safety guard for the future in this place. [1] https://datatracker.ietf.org/doc/html/rfc7231#section-7.1.2 Resolves: #100791 Related: #100958 Releases: main, 12.4, 11.5 Change-Id: I2af2d5bf759a277ade45bd0f7740ffe0099003b3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80983 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Rafael Kähm <rafael.kaehm@dkd.de> Reviewed-by:
-
- Sep 27, 2023
-
-
Torben Hansen authored
The feature toggle `security.usePasswordPolicyForFrontendUsers` has been introduced in TYPO3 12.3 to provide a smooth migration path for websites using the deprecated TypoScript based password validation in the password recovery process of ext:felogin. Since the TypoScript based password validation in ext:felogin has been removed with #101097, the previously introduced feature toggle has become obsolete. This change removes the feature toggle `security.usePasswordPolicyForFrontendUsers` and all related code. Resolves: #102023 Related: #97390 Related: #101097 Releases: main Signed-off-by:
Torben Hansen <derhansen@gmail.com> Change-Id: If09ba49e403fe5e3aaf99d054e0dd9b355a93f24 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81186 Tested-by:
-
Stefan Bürk authored
With #98375 hooks in the `Page Module` has been replaced by modern PSR-14 events to customize the `Page Module` rendering. The related PSR-14 events are: * TYPO3\CMS\Backend\View\Event\IsContentUsedOnPageLayoutEvent * TYPO3\CMS\Backend\View\Event\ModifyDatabaseQueryForContentEvent * TYPO3\CMS\Backend\View\Event\PageContentPreviewRenderingEvent This change adds some basic example how to implement event listener for these events to the corresponding feature ReST changelog file. Resolves: #102046 Related: #98375 Releases: main, 12.4 Change-Id: Ie7bdd8f365accc0224c28365da2f54e908520bd2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81263 Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Chris Müller <typo3@krue.ml> Tested-by:
-
Oliver Klee authored
Also streamline some comments. Resolves: #101988 Releases: main Change-Id: Ia1a592dd58c950a48c37f6b8fa80168a22a1ce41 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81128 Tested-by:
Thomas Hohn <tho@gyldendal.dk> Reviewed-by:
Andreas Nedbal <andy@pixelde.su> Tested-by:
-
Andreas Fernandez authored
When the form is in "Preview" mode and an integrator either saves or switches to the form settings, the stage itself is updated to be in "Edit" mode again, but the internal state remains in "Preview" mode, causing glitches in the UI. This patch now disables the preview state in the form model everytime the "stage area", containing the editing interface, is rendered. Resolves: #102031 Releases: main, 12.4, 11.5 Change-Id: I84b0817bb99201527dbd4b950e560631e7b1d94f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81253 Reviewed-by:
-
Stefan Bürk authored
Storages using the local storage driver with a non existing base folder are put offline automatically. However, the file list module displays a to generic error message not pointing to that fact. This change adds a concrete check for this case and displays a more specific error flash message in the file list module now. This can be tested by creating a additional local storage with a non-existing relative path, for example: `fileadmin/not-existing-folder/` Resolves: #85323 Releases: main, 12.4, 11.5 Change-Id: Ie3ad64a99c0871d258470ffc858639dee4de1108 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81155 Tested-by: -
Andreas Fernandez authored
This commit updates all Symfony components to version 6.3, as 6.2 ran out of support. Please see the upgrade document at [1]. Executed command: composer require \ symfony/config:^6.3 \ symfony/console:^6.3 \ symfony/dependency-injection:^6.3 \ symfony/doctrine-messenger:^6.3 \ symfony/expression-language:^6.3 \ symfony/filesystem:^6.3 \ symfony/finder:^6.3 \ symfony/http-foundation:^6.3 \ symfony/mailer:^6.3 \ symfony/messenger:^6.3 \ symfony/mime:^6.3 \ symfony/options-resolver:^6.3 \ symfony/property-access:^6.3 \ symfony/property-info:^6.3 \ symfony/rate-limiter:^6.3 \ symfony/routing:^6.3 \ symfony/uid:^6.3 \ symfony/yaml:^6.3 \ -W [1]: https://github.com/symfony/symfony/blob/6.3/UPGRADE-6.3.md Resolves: #102043 Releases: main, 12.4 Change-Id: Ia306d0ad34cc3fdb72a51259464491dc64fbdbc3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81257 Tested-by: -
Andreas Fernandez authored
The context menu component now uses the `URLSearchParams` API to build a query string for AJAX requests, being a replacement for manual string composition. Resolves: #101963 Releases: main, 12.4 Change-Id: Ifa5f46df04dc9a66f80e3d414ac0aeaa7ecb1368 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81094 Reviewed-by:
-
Stefan Bürk authored
The doctrine team realeased `doctrine/dbal 3.7.0` recently and this change raises the dependency to that version. Extension authors activating `doctrine/dbal` deprecation will then get the newest `doctrine/dbal` deprecations included in that release. That helps in preparation for planned `doctrine/dbal 4.x` upgrade with TYPO3 v13 to avoid stumpling into breaking changes. Used command(s): > composer require --no-update \ -d typo3/sysext/core \ "doctrine/dbal":"^3.7.0" ; \ composer require --no-update \ -d typo3/sysext/install \ "doctrine/dbal":"^3.7.0" ; \ composer require --no-update \ -d typo3/sysext/redirects \ "doctrine/dbal":"^3.7.0" ; \ composer require \ "doctrine/dbal":"^3.7.0" Resolves: #102042 Releases: main, 12.4 Change-Id: I34ee939fc94078df2006ad338d1e7ff1cac14a5f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81258 Reviewed-by:Nikita Hovratov <nikita.h@live.de> Tested-by:
-
Andreas Fernandez authored
Resolves: #102040 Related: #101790 Releases: main, 12.4 Change-Id: I7a6a21fd98d1a9506da864d983b1f40b03f4259e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81256 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
- Sep 26, 2023
-
-
Sven Proffe authored
Releases: main, 12.4 Resolves: #102039 Related: #97449 Change-Id: I5f7d314e40e53d09505bad92b5ce49bcc3ea8f10 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81254 Tested-by:
-
J. Peter M. Schuler authored
Feature #76085 introduced an admin panel option which shows red boxes with section and partials for easier debugging. However sometimes no partial name is shown in the output, because the retrieved name is not cleaned correctly. Resolves: #97509 Related: #76085 Releases: main, 12.4, 11.5 Change-Id: I087e3688fa8d5703c621e182f80b594492c11115 Signed-off-by:
J. Peter M. Schuler <j.peter.m.schuler@uni-due.de> Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74484 Reviewed-by:
-
Thomas Hohn authored
Remove fallback for CKEditor removePlugins as a string. It must now be an array. Resolves: #101192 Related: #98613 Releases: main Change-Id: Ifd1bb7591c63f7e5e02bce18caea21c4c42ccff4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79554 Tested-by:
-
Benjamin Franzke authored
In case a link with an invalid CSS class is edited, the class value is not simply invalidated and shown as empty (which isn't true), but a virtual select option "[ INVALID VALUE (…) ]" is added (and selected) that documents the fact that the current value invalid, but will be preserved upon updates. (as in FormEngine) This allows the editor to choose between preserving, removing or changing to another css class value. With this change applied, we can not properly remove empty value. Note that empty values previously implicitly preserved existing values, which made it impossible to remove a link title or target. Resolves: #102012 Resolves: #102013 Releases: main, 12.4 Change-Id: Iefae377a9e18467e8eb9111ef3ef7a96c89b6ce1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81176 Reviewed-by:
-
Andreas Nedbal authored
Another GFX-setting that enables PNG generation for temporary files. PNG files offer many benefits, one of them being faster generation using image processors. We previously held back on removing this setting because the temporary images using gdlib_png were significantly darker than the GIF files, but this stems from the TYPO3 default configuration using the RGB colorspace (if nothing else is set) in combination with ImageMagick. The sRGB colorspace, as recommended in the preset, should be used. If GraphicsMagick is used, generating temporary images using the RGB colorspace works fine. With this knowledge it is safe to remove the setting, but a migration notice has been left notifying users of each image processor of required migration steps. Resolves: #102020 Releases: main Change-Id: I4be795406cbb010d4b668a2de588c4591c443cf3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81184 Tested-by:
-
Chris Müller authored
Outdated manuals which are not supported anymore are removed. The missing system extensions manuals are added. Some special cases: - t3install was renamed to t3upgrade (as the Installation Guide was also renamed to Upgrade Guide) - t3l10n and t3translate are duplicates, t3l10n was removed The current list of manuals is maintained in https://github.com/TYPO3-Documentation/TYPO3CMS-Example-ExtensionManual Resolves: #102035 Releases: main, 12.4 Change-Id: I344f8a17d1c5de9dbcdc5148bed5322518d72b0c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81218 Tested-by:
Lina Wolf <112@linawolf.de> Tested-by:
-
Chris Müller authored
Additionally, convert a paragraph into an attention directive to be more outstanding. Resolves: #102037 Related: #101113 Releases: main Change-Id: Ifcc5b86d844f8043784e5a251977216578a8c908 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81219 Reviewed-by:
-
- Sep 25, 2023
-
-
Ramón Schlosser authored
Resolves: #102029 Releases: main, 12.4, 11.5 Change-Id: Idfa299ece1011727da09421ee148a820dc4e0326 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81234 Reviewed-by:
-
Chris Müller authored
Resolves: #102019 Releases: main, 12.4 Change-Id: Ib65eaf32d3bff91b943d965684eb2f0fcf25a44d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81182 Tested-by:
-
Chris Müller authored
With the change in #101933 the AfterUserLoggedInEvent is also dispatched when a frontend user is successfully logged in. Therefore, this event is added to the list of available events (although that event is not in the felogin namespace) to ease the access for the developer who looks for appropriate events regarding felogin. Resolves: #102030 Related: #101933 Releases: main Change-Id: I26bcc1cbc7648e91eeef9b9bd2564afcb8ebc268 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81216 Reviewed-by:
-
Benjamin Franzke authored
The karma unit testing framework has been deprecated and suggests to use modern alternatives instead. We use one of the recommended alternatives named @web/test-runner which is toolset by the modern-web.dev and open-wc.org initiatives. It is based on mocha and es-dev-server, which allows to run our JavaScript modules natively in the browser (without having to bundle them via rollup). Note that compiled test files have been removed from the source tree, since we configure es-dev-server to transpile them on demand, allowing error output from tests to be using original line numbers and unmangled identifiers. The tests are executed in chrome by default (locally and CI). They can be executed via: # Run once npm run test # Run tests whenever files change npm run watch:build npm run watch:test # Open browser with devtools and debug mode activated MODE=dev npm run watch:test -- --debug Configuration is prepared to run in other browsers via playwright. Example: # https://playwright.dev/docs/browsers#install-system-dependencies npx playwright install --with-deps BROWSERS=chrome,chromium,firefox,webkit npm run test Commands executed: npm remove \ karma \ karma-chrome-launcher \ karma-coverage \ karma-jasmine \ karma-junit-reporter \ karma-rollup-preprocessor \ jasmine-core \ @types/jasmine npm install --save-dev \ @web/test-runner \ @web/test-runner-playwright \ @web/dev-server-import-maps \ @web/dev-server-esbuild \ @open-wc/testing \ sinon git rm -rf \ typo3/sysext/core/Tests/JavaScript \ typo3/sysext/backend/Tests/JavaScript npm run build Resolves: #101960 Releases: main, 12.4 Change-Id: Ia2fa94a9f6d66664d9fce72e7443aaeb12e0ca08 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81040 Tested-by:
-
Benni Mack authored
This change adds more examples to getImageScale to have a good test bed in place before we move code around for v13. Resolves: #102026 Releases: main, 12.4 Change-Id: I82bfa00fb8f8342270505071d161de2462b782ea Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81189 Reviewed-by:
-
Georg Ringer authored
After deleting a log entry, the user must be properly redirected to the list action. Resolves: #102003 Releases: main, 12.4 Change-Id: I6caf8fb958acc92823d83fcacac6276ec7ab1d25 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81177 Reviewed-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
-
Torben Hansen authored
The `AfterUserLoggedInEvent` introduced with TYPO3 12.3 is currently only triggered for a successful backend login. With this change, the `AfterUserLoggedInEvent` is now also dispatched, when a successful frontend user login is performed. Resolves: #101933 Releases: main Signed-off-by:
-
Chris Müller authored
Resolves: #102028 Related: #100333 Releases: main, 12.4 Change-Id: If44aa9106de3fe1ae94eae45b5f97b1c842b7e0f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81214 Reviewed-by:
-
Benjamin Franzke authored
Remove selection link attributes after updating an existing link that has been selected with a collapsed selection (that is when the cursor is placed anywhere inside the link). We missed to cleanup all our (and ckeditor's) link related attributes after creating a collapsed selection ("cursor placed after the link") after a link was updated. Adapt to upstream logic to cleanup link attributes as seen in https://github.com/ckeditor/ckeditor5/blob/v39.0.2/packages/ckeditor5-link/src/linkcommand.ts#L206-L208 The logic is slightly modified to use the same generic approach in https://github.com/ckeditor/ckeditor5/blob/v39.0.2/packages/ckeditor5-link/src/linkediting.ts#L697 included our workaround from #101429 Resolves: #102006 Releases: main, 12.4 Change-Id: I79f23a1c309213fbf12017ecb485c7d963fe5a2f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81172 Tested-by:Benjamin Kott <benjamin.kott@outlook.com> Reviewed-by:
-
Benjamin Franzke authored
RTE link classes that are configured via `buttons.link.properties.class.allowedClasses` are selectable in all link types in the link browser. Specific classes can be limited to specific link types with a separate configuration option `classesAnchor.{id}.type|class`. When such limits are active, classes that are *not* configured to associated/limited to a specfic type, remain listed and available for *all* link types. When an existing link with such type of globally allowed class is opened its value was cleared because it was not defined in the set of limits. This was an inconsistency as the link class was still selectable, but the selection was removed upon reoping such link. Such values are now preserved. Resolves: #102005 Releases: main, 12.4, 11.5 Change-Id: I0ad4273819f1d5a8e06f587b94fefb4598a07c13 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81168 Reviewed-by: -
Benjamin Franzke authored
The GHS (General HTML Support [1]) attribute `htmlA` is used by the style plugin to apply or remove style classes. Make sure to use the same attribute interface in order for CSS class usage to be interopable across our set of CKEditor5 plugins. Note that our custom `linkClass` attribute prevented the CKEditor5 style plugin from parsing existing classes, as this plugin expects CSS classes to be available on the `htmlA` attribute (defined in the nested `classes` array). [1] https://ckeditor.com/docs/ckeditor5/latest/features/html/general-html-support.html Resolves: #101429 Resolves: #101427 Releases: main, 12.4 Change-Id: I704982cd950f0c7cacb1c99bac6a70f417caf40a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81051 Reviewed-by:
-
Torben Hansen authored
The documentation for the PSR-14 event `PasswordChangeEvent` currently states, that it is possible to mark a password as invalid. This functionality has been removed in TYPO3 v13. This change corrects the documentation of the `PasswordChangeEvent` event. Resolves: #102024 Relates: #100355 Releases: main Signed-off-by:
-
- Sep 22, 2023
-
-
Benni Mack authored
When using "file.crop" via TypoScript, PHP 8 requires strict types for float values. Therefore, all values, which were strings before, are now properly casted to floats, avoiding PHP errors. Example TypoScript: page.10 = IMAGE page.10 { file = 1:/myimage.jpg file.ext = png file.width = 200 file.height = 200 file.crop = 50,50,100,100 } Resolves: #101994 Releases: main, 12.4 Change-Id: I73c2dc9128fded7874b506ddb37026077f5a67a6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81156 Tested-by: -
Benni Mack authored
Resolves: #101185 Releases: main, 12.4, 11.5 Change-Id: If54f9308ac2928ce9521228593d6a3ef88713d51 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81157 Reviewed-by:
-
Oliver Bartsch authored
This will prevent type errors in case given folder parameter is set but not a Folder object. Resolves: #102016 Related: #102014 Releases: main, 12.4 Change-Id: I828cab2ab1a5a649ba6fdf08375453b4c3382432 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81179 Reviewed-by:
Jochen Roth <rothjochen@gmail.com> Tested-by:
-
Jochen Roth authored
Currently, when linking to a non-existing folder in and the user clicks on save an error is thrown. This has been fixed by returning early with a empty string in case the folder object is null. Resolves: #102014 Releases: main, 12.4 Change-Id: I548737fae5e6957fe59bf414b70737bea28700b5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81178 Tested-by:
-
Christian Kuhn authored
The exception became unused with removal of signal/slot in v10. Resolves: #102010 Releases: main Change-Id: I81c944adcbe287db0e7f196de220328bba8fee0f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81175 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Benni Mack authored
This change removes the cache "imagesizes" along with the public methods within GraphicalFunctions. The main reason for having cache_imagesizes back in TYPO3 v4.x was that detecting the image sizes was done via ImageMagick solely. Nowadays, the ImageInfo functionality is used, which uses - getimagesize() - exif_read_data() before falling back to ImageMagick identify. Most places in TYPO3 Core already use ImageInfo directly without using the cache. A image size calculation is nowadays with SSD much faster than a decade before, whereas a DB cache (by default) for cache_imagesizes has a much more latency. As cache_imagesizes is solely used for local files, remote FAL drivers do not have a problem here as well. Removed public methods: - GraphicalFunctions->cacheImageDimensions() - GraphicalFunctions->getCachedImageDimensions() The main public method GraphicalFunctions->getImageDimensions() still continues to exist and work as before. Resolves: #102009 Releases: main Change-Id: I6075e796b5e729733bd60eb7d2e005f5f5cc4b33 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81105 Tested-by:
-
Georg Ringer authored
The most used view is the indexing information of a page and its subpages and not a general statistic. Therefore the default action should be the detail action. Resolves: #102000 Releases: main, 12.4 Change-Id: I4822b9aea8f4310837d4d55ac9376d45ac2c4df7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81163 Tested-by:
-
