- Jul 14, 2022
-
-
Oliver Klee authored
This helps static code analysis in extensions. Resolves: #97893 Releases: main, 11.5 Change-Id: Ie2eee8244438cc8d4624608ce261f5418540c672 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75097 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Frank Naegler authored
Resolves: #97036 Releases: main, 11.5 Change-Id: I4342011309a35233d278aec73e36a6dcf542babc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75131 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Benni Mack authored
This change adapts the QuerySettings functionality for Extbase in v12 to allow to work with a LanguageAspect which contains all information regarding the language ID and the overlay mode. For this reason, the following method definitions are removed within Extbase's QuerySettingsInterface - setLanguageOverlayMode() - getLanguageOverlayMode() - setLanguageUid() - getLanguageUid() However, it is still possible to use the existing methods on the QuerySettings implementation of TYPO3 for TYPO3 v12. It is now recommended to use ->getLanguageAspect() and ->setLanguageAspect(). This change is a pre-requisite to extend language handling across TYPO3 and Extbase. Resolves: #97926 Releases: main Change-Id: I38a685fcfdb98d5ec3c82b02e6cc78df12062fa0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75093 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
linawolf authored
The reference "Inside TYPO3" is not available anymore since TYPO3 8.7. The sentences are quite useless anyway. Releases: main, 11.5, 10.4 Resolves: #97913 Change-Id: I2d496726db8b22de667d230a99f7d17341fd309d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75157 Tested-by:
Sybille Peters <sypets@gmx.de> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Andreas Fernandez authored
To clean up cluttered severity definitions for flash messages and reports, a new `ContextualFeedback` enum is introduced. The enum is backed, means it holds actual values, which match the previously known integer values for severities. An internal `transform()` method may be used to maintain backward compatibility where needed and to trigger deprecation notices. Resolves: #97787 Releases: main Change-Id: I44b706c929277bc765bf302b2b1d32aa1da31f85 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74925 Tested-by:
Frank Nägler <frank.naegler@typo3.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
-
Oliver Bartsch authored
In case GU::createVersionNumberedFilename() receives a file with an absolute path, no back path should be resolved since the resolved path will always be invalid, which led to no version number got added to the filename anymore. This is now fixed by checking for the path being absolute. Resolves: #97939 Releases: main, 11.5, 10.4 Change-Id: I5bb0150fa27b8c9c1af2aa99bd8baacd55889245 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75179 Reviewed-by:
-
Benni Mack authored
Symfony 5.4 ships with a new feature to add "aliases" to routes. TYPO3 can now replace legacy and complicated names for routes or modules with new ones while keeping backwards-compatibility with old links / references. See https://symfony.com/blog/new-in-symfony-5-4-route-aliasing for more details. Module registration now allows to define "aliases" (array), same for route registration. As an example, complicated module name such as "web_WorkspacesWorkspaces" is renamed to "workspaces_admin" which reflects the current possibilities for module identifiers much better. An upgrade wizard migrates the current backend user and backend group permissions ("userMods" and "groupMods") to the new logic. Resolves: #96515 Releases: main Change-Id: I3c6c9a3be3fddabe2910df4890528cc4f85a4586 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72960 Tested-by:
-
Nikita Hovratov authored
Resolves: #97938 Releases: main, 11.5 Change-Id: I711a541a9d38f7cd9ea2b1828a5353a8d1f7e0e3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75176 Tested-by:
-
Christian Kuhn authored
The testing-framework functional test db snapshot helper expects the database to be empty when withDatabaseSnapshot() is called. Rows should only be populated within the create callback. There was a workaround in testing-framework to relax this restriction due to unfortunate backend user related setup code flow. This has been resolved with #97928, so the testing-framework snapshot can be more strict on this now. The patch adapts a couple of snapshot usages to align to this enforced restriction. $ composer req --dev typo3/testing-framework:dev-main Change-Id: I50d6dda3671729bd603899e37e7c7d0979c094fe Resolves: #97935 Related: #97928 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75174 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
-
Nicole Cordes authored
If a record with associated inline records gets copied, the DataHandler always handles the record creation as new versions. This raises some warning when the corresponding table doesn't support workspaces. This patch prevents warnings when a corresponding irre-table cannot create any new version of a record. Resolves: #97712 Releases: main, 11.5 Change-Id: Iadcdf693f82d021eca5af1350855803ba433c37b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75166 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Christian Kuhn authored
Using functional test related .yaml scenario setup which uses DataHandler to prime the test database is pretty slow. TreeControllerTest can speed up using the withDatabaseSnapshot() method to cache db results for subsequent tests. Resolves: #97934 Releases: main Change-Id: I4c8f40f181f77bf07a0b26825138cb1577fe441e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75173 Tested-by:
-
Stefan Bürk authored
Two functional tests use the testing-framework db snapshot feature without really needing it. Those can be simplified. This patch removes the `withDatabaseSnapshot()` usage, and cleans one test which fails to free an only partially fetched db result set, which otherwise leads to fails with sqlite. Resolves: #97932 Releases: main Change-Id: I52d97000c1e8129bc0faa601d990e5274f416d4f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75171 Tested-by:
-
- Jul 13, 2022
-
-
Christian Kuhn authored
The testing-framework method setUpBackendUserFromFixture() is kinda flawed since it does two things at once: It creates db records and creates global state. This is unfortunate in various cases, especially when db snapshoting is used. Additionally, it relies on a class property which defaults to a fixture file delivered by testing-framework in XML format. We want to get rid of the .xml fixtures, and we don't want that the testing-framework delivers default fixtures. The patch adapts all usages of the property and of method setUpBackendUserFromFixture() by splitting it into two calls to first insert a local extension fixture .csv file and to then call the backend user init helper method. This finishes the removal of .xml fixture uses in the core. $ composer req --dev typo3/testing-framework:dev-main Change-Id: I32a5c43a6c8176a9e9182d08e08b42b5ff279634 Resolves: #97928 Related: #96856 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75168 Tested-by:
-
Benjamin Kott authored
Resolves: #97929 Releases: main Change-Id: I2957673006b874a3d35a605c7bf204bedf897334 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75169 Tested-by:
-
Frank Naegler authored
This patch combines the two fields base and path into a new field identifier. In the backend UI, the new TCA type folder is used to select the folder. This change improves the performance in the backend if the storage contains a massive amount of folders and subfolders. Besides that, the usability is better because of the browsing feature of the folder type. Resolves: #97922 Related: #52374 Release: main Change-Id: I3054ef98d31fd1615174d2fed68f639cf78f5f6c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75163 Tested-by:
-
Benni Mack authored
"config.doctypeSwitch" was used to bring TYPO3's Frontend into "Quirks Mode" when using XHTML, important for Internet Explorer. Internet Explorer is not supported by Microsoft anymore, and XHTML is superseded by HTML5. For this reason, TYPO3 Core should not support such an edge-case anymore. Resolves: #97927 Releases: main Change-Id: Ifa9ad9dd460d1c9690cefcd905be469b6d508574 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75167 Tested-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
-
Christian Kuhn authored
This avoids using importDataSet() in functional tests using .xml fixture files from the testing framework. Usages are converted to importCSVDataSet(), fixture files are added as .csv to the according extension. XML handling in functional tests is now down to setUpBackendUserFromFixture() which will be prepared in testing-framework and adapted in core with another patch. Change-Id: Ifc3cc30d4b824775dc6ccc7e1d982d9d122f39d9 Resolves: #97924 Related: #96856 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75165 Tested-by:
-
linawolf authored
Releases: main Resolves: #97915 Change-Id: I5dd0812847d1984b312e1d452ff38232b20f100a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75159 Tested-by:
Lina Wolf <112@linawolf.de> Reviewed-by:
-
Christian Kuhn authored
The acceptance test base class in testing-framework now allows to load .csv instead of .xml files to prime the database with records. These files are easier to read and maintain and we avoid a fixture dependency to the testing-framework this way. $ composer req --dev typo3/testing-framework:dev-main Change-Id: I7055215a2006d985af1b19929157bdef2190854d Resolves: #97921 Related: #96856 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75156 Tested-by:
-
Stefan Bürk authored
Docblock annotations with more then one space between a wildcard character `*` and the annotation start character `@` was not found. Additionally, annotation identifiers did not regonize hyphens as valid identifier character, thus cutting of e.g. phpstan annoations. This patch now properly finds annotions with multi-space separations and annotation identifiers containing hyphens. Additionally, two phpstan specific annotations are allowed. > https://phpstan.org/writing-php-code/phpdoc-types#local-type-aliases Summarized contained tasks: > find multi-space separated annotations e.g. `* @<AnnotationIdentifier>` > properly extract full annotation identifier containing hyphens e.g. `* @annoation-identifier-with-hyphen` > add `@phpstan-type` and `@phpstan-import-type` as allowed annotation, but only on class level, and not on class-property or class-method level Resolves: #97917 Resolves: #97918 Resolves: #97919 Releases: main, 11.5, 10.4 Change-Id: Iab69ffd87d407088f1237168e19b67a8dc846c8f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75160 Tested-by:
-
Andreas Fernandez authored
The NoopPasswordHash fixture is currently used in MFA provider tests only. To declutter the Tests/ directory, the fixture directory is now moved to core/Tests/Unit/Authentication/Mfa/Provider/. Resolves: #97920 Releases: main, 11.5 Change-Id: I86544bf897a26a2565278e2432831adde7154be8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75161 Tested-by:
-
- Jul 12, 2022
-
-
Andreas Fernandez authored
Since Symfony 5.x, the Command class offers constants for possible return values to be used in a commands `execute()` method. All commands are adjusted. Resolves: #97912 Releases: main Change-Id: I14f7e13ceb1b10cb21528bb420a6f8c1a20f8ab3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75154 Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
-
Larry Garfield authored
PHPStan identified these code paths as impossible. On code inspection that's true, so they have been removed as dead code. That allowed for the properties of the class to be typed. Small related cleanup is included to make verifying that the code paths were indeed dead easier. Resolves: #97621 Releases: main Change-Id: Icc5e53ef72fedb9fc5de659b22229d61c8502f1e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74636 Tested-by:
-
Andreas Fernandez authored
With the removal of datatables in #86343 the search terms used to filter tables were not stored anymore, leading to unfiltered tables after requesting pages with such again. This is found to be annoying in the extension manager when many extensions with the same prefix need to get managed. The search terms are now stored in the browser session and the local extension list is filtered again when visiting the extension manager. Resolves: #93628 Related: #86343 Releases: main, 11.5 Change-Id: Ib99e1fbf0ad420826164f8fed019c5235f8c43d5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75153 Tested-by:
-
Christian Kuhn authored
The 'installer' acceptance test related environment setup files have been part of typo3/testing-framework, but they should be part of ext:core since they're core monorepo specific and not a concern of the general testing-framework. The patch moves the codeception environment setup files from TF to core and raises TF which removed them already. Resolves: #97910 Releases: main Change-Id: Id95e1872afd3a6edeb6c3facdcbaab11522bec7a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75152 Tested-by:
-
Shehfinaz Kadavil authored
The existing condition checks if opcache_invalidate and opcache_reset are disabled, the new condition also checks if the function opcache_invalidate exists. Resolves: #97826 Releases: main, 11.5 Change-Id: Ibb201946b358a592f3c5b264646d100867e5e385 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75126 Tested-by:
-
Oliver Bartsch authored
When using a <button> in a bootsrap dropdown menu, additional button classes, such as ".btn" are not necessary, but might lead to display errors. Those classes are therefore now removed. Resolves: #97909 Releases: main Change-Id: I1c3ef81dce52e31d15a3d93c1e215f033b22a4a1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75130 Tested-by:
-
Benni Mack authored
With this change, Extbase consistently returns objects with a "uid" of the default language, and not the localized ID, depending on the query settings. This way, side effects related to the Persistence Storage are removed, as the persistence session is storing the UID + the localized UID as identifier. Resolves: #59992 Releases: main Change-Id: I42c0643ec2eb666c69446aef698fb180152bee08 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75099 Tested-by:
-
Daniel authored
Like the surrounding $conf['max'], this array index access should also be secured. Releases: main, 11.5 Resolves: #97908 Change-Id: I36ad5cf3d9eac5655e8721c8913bed43ab26377f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75129 Reviewed-by:
-
Christian Kuhn authored
Migrate some further usages of XML fixture imports to CSV in functional tests. This resolves all missing cases that don't use the "PACKAGE:" prefix. Resolves: #97907 Related: #96856 Releases: main Change-Id: I95057abf900bf9c24badc3a58ef7b4f96239292f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75128 Tested-by:
-
Christian Kuhn authored
iconfile target should be Extension.svg instead of Extension.gif Resolves: #97906 Releases: main Change-Id: Icf0bc949982d635644c1a59c5c278d726c165825 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75124 Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
-
Andreas Fernandez authored
flatpickr always defaults to 12:00 if no other value is given, being quite inconvenient. The options `defaultHour` and `defaultMinute` are now provided to set the current time when opening flatpickr on an empty input field. Resolves: #97798 Releases: main, 11.5 Change-Id: Ic222c2ff0e3bf111c498c16dd27ecdc703909342 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75086 Tested-by:
-
Jochen Roth authored
The list and page view currently do not show details about the record to be deleted. The content of the delete modal has been enhanced with record title and relations (if one does exist) and the buttons and modal title now use the same labels. Resolves: #92670 Related: #94780 Releases: main Change-Id: I4e3a48f4d37a46ad825eef95a7c8bc610301c419 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72001 Tested-by:
-
Nikita Hovratov authored
This patch reverts #91148 and #97897. This change had some side effects in FlexForm value displaying outside the intended diff-view. Resolves: #97904 Related: #91148 Related: #97897 Releases: main, 11.5 Change-Id: I6d5af76dea80b457de5a690e3065ccb700b2a507 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75115 Tested-by:
-
Benni Mack authored
This is a precursor for several language-related Extbase bugfixes, allowing to hand over a custom LanguageAspect into PageRepository->getRecordOverlay() instead of the legacy naming conventions. Resolves: #97903 Releases: main, 11.5 Change-Id: I06f6e889bc0e9f052a79fc8f719b090bface0f77 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75100 Tested-by:
-
Andreas Fernandez authored
Executed commands: cd Build nvm use yarn add @typo3/icons@^3.2.0 grunt build Resolves: #97902 Releases: main Change-Id: I8bbc547dd7e6cd266a155daed6ddf2796b08ec0d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75112 Tested-by: -
Frank Naegler authored
Since TYPO3 version 10.4, the custom page type is not restricted to any range of numbers. This limitation no longer exists, and any number is allowed. The ElementBrowserPageTreeView just now also respect this and allows to link to other any doktype beside: - PageRepository::DOKTYPE_RECYCLER - PageRepository::DOKTYPE_SYSFOLDER Resolves: #97626 Releases: main, 11.5, 10.4 Change-Id: Iffc3f705f74cc7516464fdb00adb456141657948 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75105 Tested-by:
-
Oliver Bartsch authored
The rollback link for a single field change is now displayed again in the rollback view of the history module by using the correct variable in the template. Additionally, an unintended change in #91148 is resolved, which would also display the rollback link in the normal history list view. Resolves: #97901 Releases: main, 11.5 Change-Id: I2606d0585a5f1d196adab5f83340ff3033dced1c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75111 Tested-by:
-
- Jul 11, 2022
-
-
Sybille Peters authored
Add the following information to impexp documentation: - export functionality is restricted to admin users and users for which the new User TSconfig option options.impexp.enableExportForNonAdminUser has been set - export functionality poses security risk as explained in patch https://review.typo3.org/c/Packages/TYPO3.CMS/+/74902 - the same restrictions apply to the import functionality (which is not new but has not been documented) Resolves: #97899 Releases: main, 11.5, 10.4 Change-Id: Icb16dc97505a3bbe671357555bb786705121cb67 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75110 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
-
Sybille Peters authored
The vendor namespace TYPO3.CMS.Form is no longer used in the form configuration. This patch removes the namespace from snippets within the documentation. Resolves: #97896 Related: #97517 Releases: main Change-Id: I52c9c0533d2934781de963209f21d23f1fe9aa2d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75106 Tested-by:
-
