- Sep 06, 2022
-
-
Stephan Großberndt authored
README.md and CONTRIBUTING.md use the current repository links with this change. The change also includes several minor edits. Resolves: #98260 Releases: main, 11.5, 10.4 Change-Id: I77d4741df4134ae0babec2415cd8f5345592e29e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75607 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Torben Hansen <derhansen@gmail.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Benjamin Kott authored
Commands executed: npm install --save-dev grunt-stylelint@^0.18 stylelint@^14.11 stylelint-order stylelint-scss npm run build Resolves: #98267 Releases: main Change-Id: I06887ef24d7e1f0614b6881624851fbe26fa6617 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75618 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
Stefan Bürk authored
With PHP8.2 setting dynamic properties has been deprecated. This is also valid if it is set through unserialization and emits a deprecation warning. Thus this fails hard in tests. Thus one test fails, which is expclicitly testing unserialization with invalid dynamic class properties. This change moves the test to unitDeprecated tests, which will not fail on deprecation warnings. This acts pre-patch to update PHP8.2 testing to `PHP8.2.0 RC1`. Resolves: #98266 Releases: main, 11.5 Change-Id: I7bf87b0ade906727f6222d31a1b735f452717138 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75616 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Benjamin Kott authored
During the migration to bootstrap the scaffold was reworked and is now flowing incorrectly. The introduction flex on the body has multiple side effects, for example incorrect layering of modals that are anchored directly on the body. This patch aims to reduce the differences on different implementations of the scaffold, as well as removing the flex bugs. Resolves: #98263 Releases: main Change-Id: I900c44d56243aa0cff4b4f6561f456991a4d7295 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75614 Tested-by:
-
Georg Ringer authored
Set the content language of RichText elements based on the direction of the site language of the given element. Resolves: #97778 Releases: main Change-Id: Iaf95886d82a417df5e9149d0d3296baaf6fb3b9c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74966 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Tested-by:
-
Torben Hansen authored
* Use strict function argument and return types where possible * Removed superfluous argument and return type doc comments * Replaced deprecated strftime usage * Removed invalid extension key for LocalizationUtility usage * Replaced switch statement with match expression * Removed superfluous type casts Resolves: #98184 Releases: main Change-Id: If2f4060f80f26c2116eb668220d009b7ae4281b1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75527 Tested-by:
Susanne Moog <look@susi.dev> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Benni Mack authored
This change removes all usages of "getRecordOverlay" to slowly phase out "getRecordOverlay" as a legacy method, where new PSR-14 events can be added into getLanguageOverlay() properly. This is a pre-patch to introduce new PSR-14 events and remove the old hooks. Resolves: #98182 Releases: main Change-Id: I55ce26928633f211891fb8a5cbe32755fc96704d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75524 Tested-by:
-
Andreas Fernandez authored
The support for jQuery in the module `@typo3/backend/popover` has been dropped. Passing jQuery elements to the module's methods is not possible anymore. Resolves: #98261 Releases: main Change-Id: I8716ad1762d67faf51b67eacec82435690f5b097 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75535 Tested-by:
-
- Sep 05, 2022
-
-
Andreas Fernandez authored
The FormEngine review module broke with the introduction of Bootstrap 5 due to changed API of its Popover module. Our internal Popover wrapper is now used to render the list of failed fields again. This also introduces another bugfix in the Popover wrapper which updates the Popover's content once it was rendered already. Additionally, a nasty workaround is added: previously, the field id was stored as a data attribute to the list item in the validation list. Somewhere in the Popover > Bootstrap > PopperJS handling, those custom data attributes are removed before rendering the HTML. To circumvent this issue, the field is now added as last element in the `classList` DOMTokenList for later use. Resolves: #94774 Releases: main, 11.5 Change-Id: I00d8196102f08548c8ec3433c1d0f0c8c7f05d04 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75536 Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
-
Andreas Fernandez authored
Some small JavaScripts used in EXT:impexp and EXT:info are migrated to remove the dependency on jQuery. Resolves: #98211 Releases: main Change-Id: If0c80465f8dc6770e529ac986266c14256aa79cb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75553 Tested-by:
-
Andreas Fernandez authored
The check for `inData.action` didn't work anymore for a long time as `action` is not set in the controllers anymore. To check if we're in the export view, the existing check for `import.mode` is re-used instead. Resolves: #98258 Releases: main, 11.5 Change-Id: I7ce3e572d2fe90ded1f6d100461c616b0b768e5f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75603 Tested-by:
-
- Sep 02, 2022
-
-
Stefan Bürk authored
PHPStan fails with composer max installation due changes in the detection. Raising the version to corresponding version leads to abnormal performance decrease. Thus not an option we can use. This change pins phpstan to a fixed version to avoid failing nightlies until the performance issue in the PHPStan tool has been fixed. See: https://github.com/phpstan/phpstan/issues/7903 Used commands: > composer req --dev "phpstan/phpstan":"1.8.2" Resolves: #98253 Releases: main, 11.5 Change-Id: I38a31b87c36b9ae4c5915422dd3f09a6fca38b57 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75600 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
-
Josef Glatz authored
All values are default values except the redirectTTL value. Releases: main, 11.5, 10.4 Resolves: #98238 Change-Id: Ifef0b35445828aa4b82084b5a4216174b9ad3e89 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75595 Tested-by:
Chris Müller <typo3@krue.ml> Tested-by:
-
Stefan Bürk authored
PHP8.1 introduced native return types to native methods and interfaces, which crashes if they are not compatible. As a workaround the introduced `#[\ReturnTypeWillChange]` attribute can be used to mitigate this, which has been used to mitigate quite some issues with it. PHPStan has released a new version which fixes a bunch of bugs, which detects more issues in core. These will be addressed with the dedicated PHPStan raise patch #98246. However, one issue cannot be solved or added to the baseline and must be fixed beforehand. The reason is, that phpstan also evaluates the PHPDoc return type. This change uses the `#[\ReturnTypeWillChange]` attribute to silence this as a backportable intermediate solution. Resolves: #98251 Related: #98246 Releases: main, 11.5 Change-Id: I24e7d24e735d2dffbca0eca21de602c40f7e7d2a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75599 Tested-by:
-
Andreas Fernandez authored
Items were previously rendered in BackendController into a large HTML string that was passed to Fluid. This commit resolves an open TODO and moves the rendering of the toolbar items to the Topbar partial. The data attribute `toolbar-identifier` is unused and therefore removed. Resolves: #98214 Releases: main Change-Id: I8fd0e65b9f30aaf27271be47d1b77ea7960d17ba Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75555 Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
-
Nikita Hovratov authored
With patch #97786 a bug was fixed, to only toggle inline controls in their own scope. For this a new helper class was introduced and added for vanilla inline controls. However, there are two other special inline control types for record selectors. Most commonly known from the FileSelector for FAL. The helper class is now added there as well. Resolves: #98233 Related: #97786 Releases: main, 11.5 Change-Id: Ifb2eb4205ecec50540a70943163c639f04de5ea1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75596 Tested-by:
Henrik Ziegenhain <henrik@ziegenhain.me> Tested-by:
Jörg Bösche <typo3@joergboesche.de> Tested-by:
Harry Glatz <glatz@analog.de> Tested-by:
-
- Sep 01, 2022
-
-
Nikita Hovratov authored
Resolves: #98234 Related: #97462 Releases: main Change-Id: I415b289ce4cb889e5b6fb85e9fb0746aac771865 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75593 Tested-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
-
- Aug 30, 2022
-
-
Lina Wolf authored
Releases: main, 11.5 Resolves: #98219 Change-Id: Ib60a14ff4a80eb4333187d3eff4ebf2a0262383d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75559 Tested-by:
Lina Wolf <112@linawolf.de> Reviewed-by:
-
linawolf authored
Replace the todo with information. Thanks at Florian Weiss for pointing this out and providing me with the screenshot Releases: main, 11.5 Resolves: #98215 Change-Id: Ia14e18ecd260ee9dfa98dae88aa68e8e7b4f1612 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75556 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
-
- Aug 28, 2022
-
-
Stefan Bürk authored
Symfony recently released new version v5.4.12 and v6.1.4 of the framework which contains a change in `symfony/mailer` throwing a TransportException and passing null as 2nd ($code) argument. This is deprecated since PHP8.1 and emits now a corresponding depcreaction warning in some circumenstances and breaking one mailer unit test. See: https://github.com/symfony/symfony/issues/47402 This change temporarly skips the test for PHP8.1 until the fix has been merged and released a new version by symfony. Resolves: #98216 Releases: main, 11.5 Change-Id: I12a18f425bd573e1943dddad909c7c3256c1fd87 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75557 Tested-by:
-
- Aug 26, 2022
-
-
Stefan Bürk authored
Core php file header check got silently be disabled. Since then the one or other file header error has slipped into the core. It also pops up from time to time in reviews of patches that file headers are missing (or are wrong). This change ensures that file headers are checked again and can be fixed by given contributers the proper tools at hand. Changes: * add cglFixMyCommitFileHeader.(sh|bat) * add cglHeader and cglHeaderGit to runTests.sh along with proper help text * extend pre-commit hook to execute both fixer scripts side-by-side with error output and fixing possibility * fix minor issue with header comment php-cs-fixer config Additionally the cglHeader check is added to gitlab workflow pre-merge (commit files) and nightly (all files). Slipped in errors has been fixed with a dedicated change #98204. Resolves: #98203 Related: #98204 Releases: main Change-Id: I9567d1dcf8fb53d4901a575213c0ff16dc33ffd2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75549 Tested-by:
-
- Aug 25, 2022
-
-
Stefan Bürk authored
Automatic check of php file header has been silently disabled somewhere in the past, thus wrong file headers has slipped into the core. With #98203 this will be ensured again. To avoid making nightly core ci unhappy this change acts as pre-patch to streamline the file header issues. * add missing file headers * fix invalid file headers * move file headers to the right place Resolves: #98204 Related: #98203 Releases: main Change-Id: I37bf8e08fcab37f05352f2c315f4084b77211ef3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75550 Tested-by:
-
Benjamin Franzke authored
Update (most) vulnerable dependencies/packages found by `npm audit fix --force --dry-run`. Notes redarding package changes: * The outdated grunt-postcss plugin is replaced by a (maintained) fork for compatibility with newer grunt versions. * karma is updated to v6 and pulls in @types/node which conflicts with TypeScript type definitions by @types/requirejs. Therefore 3rd party type declarations from packages (@types/*) are now explicitly enabled in tsconfig.json – note that there is no other way to exclude from typeRoots: https://github.com/microsoft/TypeScript/issues/18588 * grunt-lintspaces and grunt-contrib-imagemin are replaced as these packages have been not been updated to not depend on vulnerabe dependencies, while grunt-lintspaces and grunt-contrib-imagemin would cause downgrades to older version when running `npm audit fix --force` (because only the older versions do not depend on vulnerable software). * (grunt-contrib-)imagemin is replaced by squoosh (by google) as a) imagemin dependencies ("bin-build" > "download") rely on vulnerable versions of "got". Neither of these packages is currently updated,see https://github.com/kevva/download/issues/224 b) imagemin is unmaintained: https://github.com/imagemin/imagemin/issues/385 and suggests squoosh as replacement * stylefmt is replaced by a maintained fork. There is one remaining packages that pulls in a vulnerability alerts: * jquery-ui is marked as vulnerable (severity: high), but worked on in a separate patch #96497. (We don't actually use the vulnerable library parts though). Vulnerability report before this patch: 74 vulnerabilities (1 low, 30 moderate, 38 high, 5 critical) Vulnerability report after this patch: 1 high severity vulnerability (this is jquery-ui) Commands executed: # Supposed to be non breaking, but broke grunt-css npm audit fix npm remove grunt-postcss npm install @lodder/grunt-postcss # Preparation for `npm audit fix --force` (breaking changes) npm install grunt@^1.5 npm install grunt-lintspaces@^0.10.0 npm remove grunt-lintspaces npm install --save-dev lintspaces-cli npm remove grunt-contrib-imagemin npm install --save-dev npm remove stylefmt npm install --save-dev @ronilaukkarinen/stylefmt npm audit fix --force Releases: main Resolves: #98198 Change-Id: I09df87fe131a499790e6c5f95f1c51e9216b71c2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75539 Tested-by:
-
- Aug 24, 2022
-
-
Daniel Hettler authored
Properly guard array key access for "sheetTitle" in `\TYPO3\CMS\Backend\Form\Container\FlexFormTabsContainer->render()`. Resolves: #98201 Releases: main, 11.5 Change-Id: Iafa5fd4623d53501e655739d7aabc543d26ed216 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75546 Tested-by:
-
Oliver Bartsch authored
InlineControlContainer allows to add custom controls via a userFunc (hook). However, since the resultArray was not passed to the userFunc, e.g. no JS module could be added for the custom control. This is now fixed by passing the resultArray by reference to the userFunc. Resolves: #98199 Releases: main, 11.5 Change-Id: I404d2673a65bb40cf7f389fb5c0f7bec7dcd7c4c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75543 Tested-by:
-
Tobias Jungmann authored
If a preview page is already open, clicking on the "view" button in the content editor window would not reload the page. That means, that the preview page would not show changes if the preview page url and the target url are similar (e.g. only differentiate in hash/query or are exactly the same). This patch looks if a window with the given windowName is already open (looking in `this.windows` did not work well because the existing windows aren't saved in a global context, yet) and compares the URL of an open window (if there's one) with the given URL. If the URLs are similiar (i.e. the origin and the path name are the same) the page will be reloaded. Resolves: #93706 Releases: main, 11.5 Change-Id: Ib3d9e49f56e6ef45df1cd7d82fa58dffb74a3750 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75164 Tested-by:
-
Stefan Bürk authored
With #95819 the detection of Domain Object properties was changed to use ClassSchema in order to support uninitialized properties is models. This was not possible with `DomainObjectInterface::_getProperties()` which used `get_object_vars()` under the hood. However, with mentioned change, other properties which had been ignored by `get_object_vars()` were now propagated to persistence, even if those properties were not configured in TCA. The change in behavior is considered a regression and is now addressed: The retrieval of the property value is delayed until after it is ensured that the property is a persistable property (which asserts that we are not reading from private properties). Resolves: #98148 Related: #95819 Releases: main, 11.5 Change-Id: I94d41715a49953045d32361a00bc274c15112a1e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75534 Reviewed-by:
theline <typo3@root-access.de> Reviewed-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Reviewed-by:
-
Stefan Frömken authored
Releases: main Resolves: #98196 Change-Id: I55b2c082c96e580d345c32f04bc47d941e50425a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75540 Tested-by:
-
Torben Hansen authored
The constant `TODAYS_SPECIAL` has never been used in TYPO3 core and also 3rd party extensions in TER do not make use of it. The constant can therefore be removed safely from the class. Resolves: #98195 Releases: main Change-Id: I187817b2641d97c48832e757ad0de710e49ce31f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75538 Tested-by:
-
- Aug 23, 2022
-
-
Benjamin Franzke authored
Yarn has been added to TYPO3 back in 2017 because npm shrinkwrap files were not stable and package-lock.json and `npm ci` not yet established. By now the yarn version in TYPO3 (v1) got outdated and an update to yarn v3 would be required sooner or later. The update to yarn v3 brings quite some problems for the TYPO3 codebase: - Yarn v3 is executed/proxied through yarn v1 (installed on the developer machine) – therefore the yarn v3 executable needs to be tracked within git. See https://yarnpkg.com/cli/set/version#details - Yarn v3 pulls in @types/node (through the "got" package) for unknown reasons, causing clashes with TypeScript declarations for requirejs (window.require vs node's require()) As package-lock.json is solid thesedays, there is no real need to depend on yarn anymore. We basically switch to npm because that switch is way more straightforward than migrating to yarn v3 and it removes one dependency. Note that `npm install` properly honors `package-lock.json` these days (no implicit version upgrades due to the lock file), but is faster than `npm ci`, therefore it is used in `grunt build` and runTests.sh for all developer oriented build-targets. All CI checks use `npm ci` to enfore a clean install. We set the required npm verson to v8 in order to use the newest package-lock.json v3 format and .nvmrc is updated to suggest the recent nodejs v16 LTS release, as npm v8 is shipped with nodejs v16 by default. Note that node v14 may still be used to compile packages, but npm v8 is needed for dependency installation (installable via `npm install -g npm` in node v14 installations). For that reason the CI docker images are updated to use nodejs v16 instead of nodejs v14, see following ticket for details: https://git.typo3.org/typo3/CI/testing-infrastructure/-/issues/3 Executed Commands: cd Build/ # be sure the node_modules folder dir and is updated yarn install sed -i 's/"yarn": "^1.22.0"/"npm": ">=8.0.0 <9.0.0"/' package.json rm -f package-lock.json # npm install >= v7 can read yarn.lock and will create # package-lock.json as a result npm install git add package-lock.json git rm -f yarn.lock npm remove "jquery-ui" # The use of `git@` in the HTTPS URLs is a workaround for NPM's # auto-rewrite that results in an SSH URL being used instead, # which fails to install in CI. # See npm/cli#2610 for more information. npm install "git+https://git@github.com/jquery/jquery-ui#1.11.4" # Fix fsevents not being installed npm install rollup@~2.32.0 # Explicitly pull in popperjs which would be included by npm's # resolver in npm >8.5 npm install @popperjs/core@^2.11.6 # Let npm build a new, fully clean tree, without old yarn cruft rm -rf node_modules/ npm install grunt default Resolves: #96355 Related: #83038 Releases: main Change-Id: I88c1ecb1b12dcd117ac4200307af72d330c76d27 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72642 Tested-by:
-
- Aug 22, 2022
-
-
Kevin Appelt authored
The check if the image has to be processed has been moved to dedicated methods to enhance readability and testability The condition still checks if the image is wider than the defined maximum width. The check if the entire image is used should now be easier to understand. No offset and 100% of the width and height of the image correspond to the full image and negated in its entirety. Resolves: #98118 Releases: main, 11.5 Change-Id: I8283e2f74310654455fb247e84c9e4204f3e1dd4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75422 Tested-by:
Sascha Egerer <sascha@sascha-egerer.de> Tested-by:
-
Oliver Hader authored
Avoid undefined array key warning in case 'config' is not given in TypoScript settings. Resolves: #98145 Releases: main, 11.5 Change-Id: I20df94bd34f9f7197eee7905f5aa1c2af35d0601 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75529 Tested-by:
-
- Aug 21, 2022
-
-
Peter Kraume authored
Resolves: #98183 Releases: main, 11.5 Change-Id: Ib4d123e86a9b158b86e20322fc53ca94ff5b9be7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75525 Tested-by:
Thomas Löffler <loeffler@spooner-web.de> Reviewed-by:
-
- Aug 19, 2022
-
-
Andreas Fernandez authored
Previous TYPO3 installations allowed to configure an interface selector in the backend login that gave the authenticating backend user the possibility to choose whether to get redirected to frontend or backend by configuring `$GLOBALS['TYPO3_CONF_VARS']['BE']['interfaces'] = 'backend,frontend'`. If only one option was configured, the redirect to either backend or frontend was enforced, where `backend` was the default configuration. This feature was meaningful once TYPO3 shipped EXT:feedit, but was conceptually broken ever since, as the matter of fact a TYPO3 installation can contain multiple site roots was overseen and a user may get redirected to the wrong frontend. Also, if EXT:adminpanel is not installed, there is no one-click solution to access the TYPO3 backend. Resolves: #98179 Releases: main Change-Id: Ic759e6c1016d70c07dc8862a0b8c21b14c3d904b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75487 Tested-by:
-
Andreas Fernandez authored
If a record is edited via single field mode (aka "columnsOnly"), the label field as defined via TCA may be missing, rendering "[No title]" in the notification message. Before compiling the notification message, it is now checked whether the label exists already. If not, the label of the record is fetched from the database, if such label field is configured via TCA at all. Resolves: #98142 Releases: main Change-Id: I2babfcae354b1fad15c653e61449353cd2efb8a4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75443 Tested-by:
-
Chris Müller authored
If either labels or base are not given, the default values kick in: labels = iec and base = 1024 With the new fallback values in place test ContentObjectRendererTest notAllStdWrapProcessorsAreCallableWithEmptyConfiguration() needs a minor adaption. Resolves: #98154 Releases: main, 11.5 Change-Id: Ib2a242454197be94a75fb3d5bffbb8d0be8a1523 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75484 Tested-by:
-
Andreas Fernandez authored
The context menu module now passes the dataset bound to a context menu item to the respective callback action, excluding `callback-action` and `callback-module`. The context menu items bound to `this` in the respective callback actions are not required anymore, allowing to ditch jQuery in the `context-menu-actions` modules. For this reason, binding the context menu item to `this` is deprecated, usages will trigger a deprecation log entry in the browser's console. Resolves: #98168 Releases: main Change-Id: Ibaf3c5b343323dcd29bd9aae3212ebcee91d83ef Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75491 Tested-by:
-
Andreas Fernandez authored
The patches #98164 and #98165 conflicted with each other as one made the modal API stricter while the other populated the modal with a soon-to-be invalid configuration. This currently breaks all subsequent builds. The modals received objects of type `Node` which are not consumable by jQuery's `append()` method. To solve this issue, `Node` is now converted to a `DocumentFragment`, which can be consumed by all involved parties. Resolves: #98177 Related: #98164 Related: #98165 Releases: main Change-Id: I4524b383e559d3b1342c0bf95e435caec6d36cc6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75517 Tested-by:
-
Larry Garfield authored
Doing so allows us to remove an unnecessary test, as well. 'mixed' type declarations not included to allow backporting. Used command: > ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #98027 Releases: main Change-Id: I3c499e557c5d5bc31bf471e577760f4268fa26cc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75295 Tested-by:
-
Torben Hansen authored
This patch fixes a warning on PHP 8.1, when a FlexForm has a sheet with no fields in it. Resolves: #98166 Releases: main, 11.5 Change-Id: Iec814a10bb755fb78a8de95b432d8cb6042a07d3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75490 Tested-by:
-
