[TASK] Update vulnerable build dependencies
Update (most) vulnerable dependencies/packages found by `npm audit fix --force --dry-run`. Notes redarding package changes: * The outdated grunt-postcss plugin is replaced by a (maintained) fork for compatibility with newer grunt versions. * karma is updated to v6 and pulls in @types/node which conflicts with TypeScript type definitions by @types/requirejs. Therefore 3rd party type declarations from packages (@types/*) are now explicitly enabled in tsconfig.json – note that there is no other way to exclude from typeRoots: https://github.com/microsoft/TypeScript/issues/18588 * grunt-lintspaces and grunt-contrib-imagemin are replaced as these packages have been not been updated to not depend on vulnerabe dependencies, while grunt-lintspaces and grunt-contrib-imagemin would cause downgrades to older version when running `npm audit fix --force` (because only the older versions do not depend on vulnerable software). * (grunt-contrib-)imagemin is replaced by squoosh (by google) as a) imagemin dependencies ("bin-build" > "download") rely on vulnerable versions of "got". Neither of these packages is currently updated,see https://github.com/kevva/download/issues/224 b) imagemin is unmaintained: https://github.com/imagemin/imagemin/issues/385 and suggests squoosh as replacement * stylefmt is replaced by a maintained fork. There is one remaining packages that pulls in a vulnerability alerts: * jquery-ui is marked as vulnerable (severity: high), but worked on in a separate patch #96497. (We don't actually use the vulnerable library parts though). Vulnerability report before this patch: 74 vulnerabilities (1 low, 30 moderate, 38 high, 5 critical) Vulnerability report after this patch: 1 high severity vulnerability (this is jquery-ui) Commands executed: # Supposed to be non breaking, but broke grunt-css npm audit fix npm remove grunt-postcss npm install @lodder/grunt-postcss # Preparation for `npm audit fix --force` (breaking changes) npm install grunt@^1.5 npm install grunt-lintspaces@^0.10.0 npm remove grunt-lintspaces npm install --save-dev lintspaces-cli npm remove grunt-contrib-imagemin npm install --save-dev npm remove stylefmt npm install --save-dev @ronilaukkarinen/stylefmt npm audit fix --force Releases: main Resolves: #98198 Change-Id: I09df87fe131a499790e6c5f95f1c51e9216b71c2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75539 Tested-by:core-ci <typo3@b13.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benjamin Franzke <bfr@qbus.de>
Showing
- Build/Gruntfile.js 8 additions, 29 deletionsBuild/Gruntfile.js
- Build/package-lock.json 5807 additions, 13936 deletionsBuild/package-lock.json
- Build/package.json 6 additions, 6 deletionsBuild/package.json
- Build/testing-docker/local/docker-compose.yml 1 addition, 1 deletionBuild/testing-docker/local/docker-compose.yml
- Build/tsconfig.json 16 additions, 0 deletionsBuild/tsconfig.json
- typo3/sysext/adminpanel/Resources/Public/Css/adminpanel.css 1 addition, 1 deletiontypo3/sysext/adminpanel/Resources/Public/Css/adminpanel.css
- typo3/sysext/adminpanel/Resources/Public/JavaScript/admin-panel.js 1 addition, 1 deletion...ext/adminpanel/Resources/Public/JavaScript/admin-panel.js
- typo3/sysext/adminpanel/Resources/Public/JavaScript/modules/cache.js 1 addition, 1 deletion...t/adminpanel/Resources/Public/JavaScript/modules/cache.js
- typo3/sysext/adminpanel/Resources/Public/JavaScript/modules/preview.js 1 addition, 1 deletion...adminpanel/Resources/Public/JavaScript/modules/preview.js
- typo3/sysext/backend/Resources/Public/Css/backend.css 2 additions, 2 deletionstypo3/sysext/backend/Resources/Public/Css/backend.css
- typo3/sysext/backend/Resources/Public/JavaScript/action-button/deferred-action.js 1 addition, 1 deletion...ources/Public/JavaScript/action-button/deferred-action.js
- typo3/sysext/backend/Resources/Public/JavaScript/action-dispatcher.js 1 addition, 1 deletion.../backend/Resources/Public/JavaScript/action-dispatcher.js
- typo3/sysext/backend/Resources/Public/JavaScript/ajax-data-handler.js 1 addition, 1 deletion.../backend/Resources/Public/JavaScript/ajax-data-handler.js
- typo3/sysext/backend/Resources/Public/JavaScript/clipboard-panel.js 5 additions, 5 deletions...xt/backend/Resources/Public/JavaScript/clipboard-panel.js
- typo3/sysext/backend/Resources/Public/JavaScript/color-picker.js 1 addition, 1 deletion...ysext/backend/Resources/Public/JavaScript/color-picker.js
- typo3/sysext/backend/Resources/Public/JavaScript/column-selector-button.js 1 addition, 1 deletion...end/Resources/Public/JavaScript/column-selector-button.js
- typo3/sysext/backend/Resources/Public/JavaScript/context-help.js 1 addition, 1 deletion...ysext/backend/Resources/Public/JavaScript/context-help.js
- typo3/sysext/backend/Resources/Public/JavaScript/context-menu-actions.js 1 addition, 1 deletion...ckend/Resources/Public/JavaScript/context-menu-actions.js
- typo3/sysext/backend/Resources/Public/JavaScript/context-menu.js 1 addition, 1 deletion...ysext/backend/Resources/Public/JavaScript/context-menu.js
- typo3/sysext/backend/Resources/Public/JavaScript/copy-to-clipboard.js 1 addition, 1 deletion.../backend/Resources/Public/JavaScript/copy-to-clipboard.js
Please register or sign in to comment