Skip to content
Snippets Groups Projects
Commit 2e9a6710 authored by Andreas Fernandez's avatar Andreas Fernandez
Browse files

[BUGFIX] List invalid field in FormEngine review

The FormEngine review module broke with the introduction of Bootstrap 5
due to changed API of its Popover module.

Our internal Popover wrapper is now used to render the list of failed
fields again. This also introduces another bugfix in the Popover wrapper
which updates the Popover's content once it was rendered already.

Additionally, a nasty workaround is added: previously, the field id was
stored as a data attribute to the list item in the validation list.
Somewhere in the Popover > Bootstrap > PopperJS handling, those custom
data attributes are removed before rendering the HTML. To circumvent
this issue, the field is now added as last element in the `classList`
DOMTokenList for later use.

Resolves: #94774
Releases: main, 11.5
Change-Id: I00d8196102f08548c8ec3433c1d0f0c8c7f05d04
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75536


Tested-by: default avatarBenjamin Franzke <bfr@qbus.de>
Tested-by: default avatarcore-ci <typo3@b13.com>
Tested-by: default avatarJochen <rothjochen@gmail.com>
Tested-by: default avatarAndreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: default avatarBenjamin Franzke <bfr@qbus.de>
Reviewed-by: default avatarJochen <rothjochen@gmail.com>
Reviewed-by: default avatarAndreas Fernandez <a.fernandez@scripting-base.de>
parent 258645ae
No related merge requests found
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment