- Aug 06, 2019
-
-
Benjamin Franzke authored
Use constructor injection for middleware dependencies, moving away from GeneralUtility::makeInstance based Singleton lookup. Dependencies which are already configured to be optionally injectable via constructor arguments (e.g. for unit tests) are changed to be required constructor arguments. Since the introduction of symfony dependency injection the fallback to GeneralUtility::makeInstance is no longer used – therefore it is dropped. Releases: master Resolves: #88800 Change-Id: I6dbec2f91fc78c1b06dd179323fb7a4810c13baa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61322 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Susanne Moog <look@susi.dev> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
-
- Aug 05, 2019
-
-
Oliver Bartsch authored
This fixes a typo in a variable in QueryView. Resolves: #88920 Releases: master, 9.5 Change-Id: I59b4034931b3f8837aef6dda0c56e342c3552926 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61441 Tested-by:
Stefan P <spo@snk.de> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Joerg Kummer <typo3@enobe.de> Reviewed-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
-
Georg Ringer authored
Use the correct variables in f:uri.action which have been switched with #87629. Resolves: #88915 Releases: master Change-Id: Icbdc3c7319bf2459a8eed2ca79961204e6d6153c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61438 Tested-by:
Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de> Tested-by:
Josef Glatz <josefglatz@gmail.com> Tested-by:
-
Andreas Fernandez authored
This patch sets the correct default value for page action callbacks passed for `TYPO3/CMS/Backend/PageActions`. Empty strings are not treated properly, also the argument of `PageRenderer::loadRequireJsModule` sets the default value to null. Resolves: #88649 Related: #88532 Releases: master, 9.5 Change-Id: Ic5ce5eca5c0f2845ff9453e5f8d50de7cd650356 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61409 Reviewed-by:
Frank Naegler <frank.naegler@typo3.org> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
-
Andreas Fernandez authored
This patch updates nikic/php-parser to version 4.2.2, which brings better support for PHP 7.3 and adds initial support for PHP 7.4. Changelog: https://raw.githubusercontent.com/nikic/PHP-Parser/v4.2.2/CHANGELOG.md Composer command: composer require nikic/php-parser:^4.2 Resolves: #88914 Releases: master, 9.5 Change-Id: I6d7feb8851be6e5565cb069fb33c279f916f4667 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61435 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
- Aug 04, 2019
-
-
Andreas Fernandez authored
Resolves: #88911 Releases: master Change-Id: I310f0fb85cfa40b70ce65274e6e04fc21586ce0b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61434 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Andreas Fernandez authored
`$GLOBALS['TSFE']->fe_user` is not available in the RedirectService. This patch now explicitly passes the `frontend.user` attribute of the current request to the RedirectService. Resolves: #88906 Releases: master Change-Id: Iae876d6a14f29e675295503be3be80008bcccbb1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61430 Tested-by:
-
Benjamin Franzke authored
When symfony/dependency-injection crawls the available classes a ReflectionException [1] occurs when the base class or interface of an analyzed class is not available. This currently happens for scheduler tasks and status reports in composer mode. The dependency to external base classes/interfaces is missing in the respective composer.json files and therefore EXT:scheduler and EXT:reports are not guaranteed to be availble. Exclude the affected status report and scheduler task classes from autowiring and autoconfiguration in order to fix this issue. Note: Dependency injection can still be added for these classes, but as long as the implicit dependencies to EXT:scheduler and EXT:reports are not fixed, these classes will need to be wired manually. Example: TYPO3\CMS\Reports\Task\SystemStatusUpdateTask: autoconfigure: false autowire: false public: true arguments: - '@cache.core' [1] Uncaught ReflectionException: Class TYPO3\CMS\Scheduler\Task\AbstractTask not found in […]/typo3/sysext/reports/Classes/Task/SystemStatusUpdateTask.php:28 Resolves: #88825 Resolves: #88912 Releases: master Change-Id: I74113aa87336bbde02b8754639eafc4158dc3717 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61342 Tested-by: -
Anja Leichsenring authored
The new minor version of phpunit comes with a (probably) bug in their mock API that causes errors in reflection and ClassSchema construction. Also, partial mock with a function that does not exist, will now throw a warning. Resolves: #88910 Releases: master Change-Id: Ic43fc0f72f2f5cab97a7907f4f66ffe82516300b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61433 Reviewed-by:
-
- Aug 03, 2019
-
-
Michael Blunck authored
This only applies to table elements where no text enclosure is configured. Resolves: #88418 Releases: master, 9.5 Change-Id: I8ba7cefe0da37fd7987858c1302dac9f3ba2ff10 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61423 Tested-by:
Marco Bresch <marco.bresch@starfinanz.de> Tested-by:
-
Michael Blunck authored
Pagetree uses javascript for search. Cropping causes issues because not the full title is searched. As the pagetree is neither scrollable nor resizable, cropping does not make sense anyway and is therefor removed. Resolves: #88700 Releases: master, 9.5 Change-Id: I23bd7d1b46a7c455effa0d0452fb6bbeef8ab8eb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61417 Reviewed-by:
Thomas Anders <me@naderio.de> Reviewed-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
-
Georg Großberger authored
The function readdir may skip files inside a directory when its content is changed, like a file being deleted. This can cause not all files inside being deleted To avoid this, we collect all entries inside a directory and close the read descriptor before deleting all entries inside. Resolves: #88524 Releases: master, 9.5 Change-Id: I06168e77dccc41ae60b49abd7644ee3748e85588 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61408 Tested-by:
Matthias Vogel <typo3@kanti.de> Reviewed-by:
Marc von Schalscha <msa@starfinanz.de> Reviewed-by:
-
Jonas Eberle authored
This loads AdditionalConfiguration.php even if LocalConfiguration.php could not be loaded. Before this change, configuration for the install tool could only be given if a LocalConfiguration was present. With this change, AdditionalConfiguration (if present) is applied on top of DefaultConfiguration. In a FIRST_INSTALL scenario, this enables (among others) the correct evaluation of a set trustedHostsPattern in AdditionalConfiguration. Resolves: #88846 Resolves: #86356 Releases: master, 9.5 Change-Id: I6c0e39eb57ce6b28b493f1ae9716b478b643dda9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61374 Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by:
Maik Peuser <maik.peuser@verdure.de> Reviewed-by:
Tobi Kretschmann <tobi@tobishome.de> Tested-by:
Randy Fay <randy@randyfay.com> Tested-by:
-
Felix Heller authored
Resolves: #88900 Releases: master, 9.5 Change-Id: I37e53ddbe634d58bf1dfaf4578ac2c03a1a93d90 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61413 Tested-by:
-
dominikdoerr authored
This fixes some typos to make the comments more readable. Resolves: #88584 Releases: master, 9.5 Change-Id: I165a80f2f4d82c1090f4413140c6b584c7b93ecd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61414 Reviewed-by:
-
Pascal Rinker authored
Fix the sorting in documentation changelog that orders the versions currently wrong. Resolves: #88883 Releases: master Change-Id: Icb3e67b16c345b0bf7923cb995072c6f28e9d596 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61415 Tested-by:
Roman Schilter <roman.schilter10@gmail.com> Tested-by:
-
- Aug 02, 2019
-
-
Oliver Bartsch authored
This prevents various errors, caused by clicking the localization button in the recordlist multiple times. Resolves: #88731 Releases: master, 9.5 Change-Id: I93499d3892b9897038f8cfbd5f6dab33dc585bb1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61411 Tested-by:
-
Jan Delius authored
This change adds the language dependencies individually to the array instead of completely overwriting them as a string. Since the dependencies are iterated in the core, this function only adds to the array instead of overwriting the first index. Resolves: #88045 Releases: master, 9.5 Change-Id: I3101bf8f9873ffa5ceeee3cc9e9ace36858f39a4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60356 Tested-by:
theline <typo3@theline.capella.uberspace.de> Tested-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
-
Benni Mack authored
When a workspace record is published, the "old", then unused record has the values: - workspace-id: 0 - online-id: > 0 - pid: -1 This way, it is not possible to actually find out from which workspace something was published. This only happens when not swapping (exchanging data) but doing real "publishing" from a workspace. What happens is that the database is filled with obsolete "previously online" records that have no value anymore. These records are now deleted, thus, the database is kept clean. Previously only a CLI command allowed to remove them, however, they are not needed at all, so the CLI command is for existing projects that use workspaces in non-swapping mode. Resolves: #88497 Releases: master Change-Id: I9393c801de5b62484efc7ef82e389dfff6715a78 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60882 Tested-by:
-
Andreas Fernandez authored
Currently, when the changelogs get rendered in the Install Tool, for each document the tags get rendered in the document itself, which has a huge negative impact on rendering performance. This patch changes the rendering to the triggered deferred, when the document is opened. Resolves: #88882 Releases: master, 9.5 Change-Id: Ie5be93fb0a8b3d1aa2532b2d1a29c1948778c9d7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61401 Tested-by:
-
Markus Klein authored
Make sure there is actually an 'items' array in the processedTCA before validating the items. Resolves: #88624 Releases: master, 9.5, 8.7 Change-Id: I1fb6d47ac017ce6950926387387ad19d8445af74 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61122 Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
-
Georg Ringer authored
If only the slug field should be rendered in the record list, all fields which are required to generate the slug are added as well. This makes it possible to have a simple mass update option for slug fields. Resolves: #88156 Releases: master, 9.5 Change-Id: Ie8463691bc715c92668f65170948ad2518520528 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61317 Tested-by:
-
Georg Ringer authored
The ContentObjectRenderer should not care about sending mails, therefore it has been marked as deprecated. Resolves: #88850 Releases: master Change-Id: Ibbeefe313dd0b306a69d3ff77703fae49f02ae1d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61384 Tested-by:
-
Oliver Hader authored
Calling the frontend with an URL that does not contain a valid base URI for a configured language resulted in a temporary redirect (307) to the base URI of the default language. In order to allow detecting outdated links returning a page not found (404) is used. Example: https://example.org/en/ is the base URI of a valid language + https://example.org/ -> redirects to default language /en/ (307) + https://example.org/nothing/ -> responds a page not found (404) Releases: master, 9.5 Resolves: #88838 Change-Id: I9a3eeb53da8e0bb92799d8e29404513699411078 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61346 Tested-by:
Chris Müller <typo3@krue.ml> Tested-by:
-
Benni Mack authored
The FileCollector is e.g. used for resolving references in the FILES cObject. The check for TSFE can be removed since the ->getFileReferences functionality should be used at any time, as the functionality always handles overlays depending on the $referenceRecord given. Resolves: #88859 Releases: master Change-Id: I500421a12cced80e133b12a0caf6dcf289c6bd9a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61350 Tested-by:
-
Daniel Siepmann authored
All links processed by TypoLink now will add rel="noopener noreferrer" if necessary. They are only added for target="_blank" and external hosts. Resolves: #78488 Releases: master Change-Id: I24f6a7756e7905ed641e193aff5d1d94375233c0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59194 Tested-by:
-
Markus Klein authored
'l10n_mode' => 'prefixLangTitle' does not make sense for checkboxes and group types Add language sync to those fields, so those can be overwritten in translations. Resolves: #88511 Releases: master, 9.5 Change-Id: Ib64b5455139100c113d3ded76e0b140b43542c4d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60891 Tested-by:
-
Andreas Fernandez authored
The UI of the "Manage Language Packs" modal is optimized: - Buttons are grouped into a `btn-group` - Language name is rendered next to the buttons - Space is added between extension icon and title Resolves: #88885 Releases: master Change-Id: I728ef22a5983ae7d419f88b7ceffd552ef2a1b33 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61398 Tested-by:
-
linawolf authored
This explains where `TypoScriptService` was moved to. In order to ease the migration the documentation now mentions the full class name. Releases: master, 9.5, 8.7 Resolves: #88868 Change-Id: Id83c83e3932fdea6a29127c1de6bee9320fa9110 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61396 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
-
Georg Ringer authored
Fix missing parts after the migration from swiftmailer to symfony/mime Resolves: #88849 Releases: master Change-Id: I3d30589cac44ff7d387a49857bb1f7820c580138 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61383 Tested-by:
-
- Aug 01, 2019
-
-
Andreas Fernandez authored
For organizational purposes the Install Tool JavaScript modules are now grouped into directories matching their parent module. Resolves: #88880 Releases: master Change-Id: Ifc9844f6e044e1b1ea6ebd394a433d7bf1ae014e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61397 Tested-by:
-
- Jul 31, 2019
-
-
Andreas Fernandez authored
This patch deprecates the global variable `T3_THIS_LOCATION`. This variable is mostly used to attach a returnUrl argument to links, triggered via a redirect on an onclick event. In most cases this is not necessary anymore, also it's considered bad practice not to use regular links in an href attribute. Resolves: #88854 Releases: master Change-Id: I9d90a59b83b956f0bf1e380a55d6c3a4c2d469b5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61385 Tested-by:
-
Guido Schmechel authored
Extend field length of source_path and target Resolves: #88336 Releases: master, 9.5 Change-Id: I46c241b5782b0a0b8b2947cf0b063340785aa4fe Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61381 Tested-by: Daniel Windloff Tested-by:
Jonas Eberle <flightvision@googlemail.com> Tested-by:
-
Guido Schmechel authored
The Command Request Handler now displays the current Application Context when executing the CLI context. Resolves: #88318 Releases: master Change-Id: If8994eee4e08c78f71972524873edfd7f0db07f0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61382 Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
- Jul 30, 2019
-
-
Andreas Fernandez authored
With #88787 the method `makeReturnUrl()` is used to append the returnUrl to the links. The method already attaches the `returnUrl` argument, this patch removes the superfluous arguments. Resolves: #88864 Related: #88787 Releases: master Change-Id: I95103a11215e5ec1157a7a239130fdd95996f14a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61391 Tested-by:
-
Andreas Fernandez authored
The global JavaScript variable `T3_RETURN_URL` containing the returnUrl sent either via GET or POST has been marked as deprecated. Resolves: #88862 Releases: master Change-Id: I77e94932ef117428100dcd413380940ff33a9b9a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61390 Tested-by:
-
Daniel Windloff authored
Replace the clear cache button with a spinner during the AJAX request. While the request is executed, the button is no clickable due to addiional properties and classes being set. Resolves: #88781 Releases: master Change-Id: I06d53010d8bd5435ac6fc91ea17ecc6378043f14 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61307 Tested-by:
-
Andreas Fernandez authored
The JavaScript function `jumpSelf` is only used to some clipboard actions. Moving the links to a regular `href` has the same effect, rendering this very function useless. Resolves: #88857 Releases: master Change-Id: I3ef6e9c7bcbeb214cc24286c3bd4e9eb3dd8835f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61388 Tested-by:
-
- Jul 29, 2019
-
-
Andreas Fernandez authored
Resolves: #88855 Related: #88787 Releases: master Change-Id: I3578c36fac2a6bb57704d41ccfa60a6dbd4727b9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61386 Tested-by:
-
Alexander Schnitzler authored
Class \TYPO3\CMS\Extbase\Core\Bootstrap calls method \TYPO3\CMS\Extbase\Mvc\ResponseInterface::shutdown() which does not declare a strict return type yet. Thus, it's possible that the returned value is not of type string which then violates the return type promise of method handleRequest() of the Bootstrap class. Therefore, the return value is explicitly casted to string. Releases: master Resolves: #88829 Change-Id: Ibea2451e87c5c66070e5ce4ed5f30c408b7412cd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61345 Tested-by:
Armin Vieweg <armin@v.ieweg.de> Reviewed-by:
-
