Skip to content
Snippets Groups Projects
Commit 9d7d35d5 authored by Jonas Eberle's avatar Jonas Eberle Committed by Tobi Kretschmann
Browse files

[BUGFIX] Make sure AdditionalConfiguration is loaded

This loads AdditionalConfiguration.php even if LocalConfiguration.php
could not be loaded.

Before this change, configuration for the install tool could only be
given if a LocalConfiguration was present.

With this change, AdditionalConfiguration (if present) is applied
on top of DefaultConfiguration.

In a FIRST_INSTALL scenario, this enables (among others) the correct
evaluation of a set trustedHostsPattern in AdditionalConfiguration.

Resolves: #88846
Resolves: #86356
Releases: master, 9.5
Change-Id: I6c0e39eb57ce6b28b493f1ae9716b478b643dda9
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61374


Reviewed-by: default avatarMathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: default avatarOliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: default avatarAndreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: default avatarGuido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: default avatarMarc von Schalscha <msa@starfinanz.de>
Reviewed-by: default avatarMaik Peuser <maik.peuser@verdure.de>
Reviewed-by: default avatarTobi Kretschmann <tobi@tobishome.de>
Tested-by: default avatarTYPO3com <noreply@typo3.com>
Tested-by: default avatarRandy Fay <randy@randyfay.com>
Tested-by: default avatarMaik Peuser <maik.peuser@verdure.de>
Tested-by: default avatarTobi Kretschmann <tobi@tobishome.de>
parent d0a62815
Branches
Tags
No related merge requests found
......@@ -340,13 +340,15 @@ class ConfigurationManager
} else {
throw new \UnexpectedValueException('LocalConfiguration invalid.', 1349272276);
}
if (@is_file($this->getAdditionalConfigurationFileLocation())) {
require $this->getAdditionalConfigurationFileLocation();
}
} else {
// No LocalConfiguration (yet), load DefaultConfiguration only
// No LocalConfiguration (yet), load DefaultConfiguration
$GLOBALS['TYPO3_CONF_VARS'] = $this->getDefaultConfiguration();
}
// Load AdditionalConfiguration
if (@is_file($this->getAdditionalConfigurationFileLocation())) {
require $this->getAdditionalConfigurationFileLocation();
}
}
/**
......
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment