- Sep 04, 2020
-
-
Tizian Schmidlin authored
Precision of `uniqid()` on Windows systems without passing `$more_entropy=true` has only single-second-resolution which will lead to non-unique ids on subsequent calls. In order to mitigate this issue TYPO3 provides the function `StringUtility::getUniqueId($prefix = '')` which calls `uniqid()` with parameter `$more_entropy` always set to true. Using `uniqid()`, especially with `$more_entropy` set to true, is quite slow, but for the purposes TYPO3 is using it (i.e. creating unique field names for backend forms, path identifiers in some modules etc.) it is good enough and another solution would not provide any measurable benefit. Resolves: #91553 Releases: master, 10.4 Change-Id: Ib4443e72621eee6df2daf5bf23054e1a01325783 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64652 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Jörg Bösche <typo3@joergboesche.de> Tested-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Benni Mack authored
The method "shouldExcludeTableFromReferenceIndex()" which also incorporates a PSR-14 currently only skips references FROM a specific table, but in order to keep consistency, they should also be excluded TO this specific table. Resolves: #89100 Releases: master, 10.4 Change-Id: I0bee4fb12cb461e51a97180addd0b0358fba8412 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65572 Tested-by:
Claus Harup <ch@typoconsult.dk> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
Claus Harup <ch@typoconsult.dk> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Daniel Goerz <daniel.goerz@posteo.de>
-
Alexander Schnitzler authored
ext:scheduler This patch fixes incompatible type usage in function arguments and is preparatory work for introducing native type hints and strict mode in all core files. Releases: master, 10.4 Resolves: #92159 Change-Id: I8e6a06a81cc12ff4c1bbdb69611d1d1bfd48d109 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65538 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Jörg Bösche <typo3@joergboesche.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Andreas Fernandez authored
This patch updates some tools used for our assets generation toolchain. Most notable changes: - Since typescript-eslint has been updated to a new major version, its configuration changes slightly - TypeScript is updated to 3.9 Executed commands: yarn add --dev \ "@typescript-eslint/eslint-plugin"@^3.8.0 \ "@typescript-eslint/parser"@^3.8.0 \ "@typescript-eslint/typescript-estree"@^3.8.0 \ autoprefixer@^9.8.6 \ eslint@^7.6.0 \ grunt-eslint@^23.0.0 \ grunt-lintspaces@^0.9.0 \ jasmine-core@^3.6.0 \ karma@^5.1.1 \ karma-coverage@^2.0.3 \ karma-jasmine@^3.3.1 \ terser@^5.0.0 \ typescript@~3.9.0 grunt build Resolves: #91952 Releases: master, 10.4 Change-Id: Ib6726998bea0faf68e71d8374ee0d729a34b0c1e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65223 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- Sep 03, 2020
-
-
Henrik Elsner authored
This adds migration of the replyToAddress field of the email finishers in EXT:form Resolves: #92122 Relates: #80420 Releases: master, 10.4 Change-Id: If70b13cf04dbb708274a2ba59dda35b758ae5025 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65496 Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Björn Jacob <bjoern.jacob@tritum.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
MonTea authored
Releases: master, 10.4 Resolves: #92185 Change-Id: I6f73180a29440caa87367f47d219955e51e08691 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65547 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Benni Mack authored
When a newly created record in a workspace is added, two records are created: * t3ver_state=-1 (the versioned record NEW_PLACEHOLDER_VERSION which contains the data) * t3ver_state=1 (the placeholder NEW_PLACEHOLDER) When the record is now moved (= sorting or pid is changed) then the versioned record was previously not updated sorting or pid values. This change keeps both records in sync making it easier to have a consistent setup. This is helpful when working on versioned records (and not on the pairs = overlays) directly. Resolves: #92182 Releases: master, 10.4 Change-Id: Idc7632b12cc03a04eac1430f84cf67bf1ec24e73 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65535 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Andreas Fernandez authored
With this patch, the path resolving for certain assets is now completely handled by PageRenderer by using the EXT: prefix. Resolves: #91365 Releases: master, 10.4, 9.5 Change-Id: Ia23650244f70f5e4cdf8d953bfcb2f0fcf01ef6a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64781 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Jörg Bösche <typo3@joergboesche.de> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Benni Mack authored
When adding a new record (or moving a record) in a workspace, the TCA[table][ctrl][label] field is filled with a static label (e.g. "[PLACEHOLDER, WS #1]") which only makes sense for TCA tables where the label field is an input field, otherwise label fields (in sys_file_metadata) which are numeric ("sys_file_metadata.file") will never be allowed to be translated. Resolves: #61689 Releases: master, 10.4 Change-Id: Ic115777c0b6adc6c98cac913cd7b74cfd126d479 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65542 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Alexander Schnitzler authored
The Permission class unnecessarily had been implemented as Enumeration although the features of the Enumeration base class hadn't been used. As the Permission class only handles boolean flags, it is now implemented as bit set, which improves the performance in comparison to Enumeration classes. Releases: master Resolves: #89465 Change-Id: I73eff34090a7ea8e02f7d538e2db52045c86d438 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61099 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
-
David Wong authored
TYPO3 configuration knows a global date format configuration within the installation tool. See TYPO3_CONF_VARS/SYS/ddmmyy Use this global format as the default for Sys log TYPO3_CONF_VARS/SYS/ddmmyy is more efficient than TYPO3_CONF_VARS/SYS/USdateFormat ddmmyy ( Y-M-D | M-D-Y | D-M-Y) USdateFormat ( M-D-Y | D-M-Y) Releases: master, 10.4 Resolves: #91961 Change-Id: I06984ecda056511b1668b7bbd4dfa77b5333322c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65231 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
-
- Sep 02, 2020
-
-
Richard Haeser authored
Pages that are deleted or moved in the current workspace are shown correctly in the page tree now, especially when fetching pages only on a specific level or when filtering. Resolves: #92041 Resolves: #92057 Resolves: #92096 Resolves: #91652 Releases: master, 10.4, 9.5 Change-Id: Iaf966b7e85ba9b5c5771033db943e5a426de54e7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65362 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Richard Haeser <richard@richardhaeser.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Christian Kuhn authored
The main workspace module ReviewController uses the extbase ActionController. There is little reason to do so: There is only one action, no injection is used, no other extbase magic. The patch drops extbase usage from ext:workspaces and keeps the module name so permission settings need no change. Resolves: #92147 Releases: master Change-Id: I03a7dcd50501318487a20ecda54ca832a492d4e9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65512 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Helmut Hummel authored
The ThumbnailController outputs raw data of image files as a response to a file process request. This is a massive and unnecessary performance hit, when using a remote storage, as the files need to get downloaded from the remote to be then delivered by TYPO3. This is now changed to simply redirect to the file URL. Also the mime-type check for images is replaced with an isImage() call to the processed file, in order to also properly deliver thumbnails of PDF files. Also clarify in code, that ProcessedFile::CONTEXT_IMAGEPREVIEW isn't capable of handling any other processing instruction than "width" and "height". Also fix delivering an icon as thumbnail, when the processed file isn't an image. Last but not least, fix the 404 response by using a HtmlResponse instead of a plain Response object, because the plain Response object needs a resource and cannot deal with plain strings. Releases: master, 10.4, 9.5 Resolves: #91976 Change-Id: I218a8ba29ae0790be2603e8fab72f4eef1b8a47b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65279 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Jörg Bösche <typo3@joergboesche.de> Tested-by:
Helmut Hummel <typo3@helhum.io> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Helmut Hummel <typo3@helhum.io>
-
- Sep 01, 2020
-
-
Oliver Bartsch authored
As it's highly discouraged to check for global constants in ext_localconf.php due to limited caching the example code is updated to not propose this check anymore. Resolves: #90974 Releases: master, 10.4, 9.5 Change-Id: I32e9d39d9a5a975986fd009ccf60a0fcf1a8fed0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65511 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Jörg Bösche <typo3@joergboesche.de> Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Björn Jacob <bjoern.jacob@tritum.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Christian Kuhn authored
Field workspace_perms=1 for backend users or groups enables editing of the live workspace. When ext:workspaces is loaded, we can assume the extension is actively used in the instance. If so, many backend users most likely should NOT have live edit access and the flag is probably given to only a small group of editors by assigning a 'chief editor' group or similar that carries the flag. The patch sets workspace_perms for new backend users by default to 0 when ext:workspaces is loaded, making it more unlikely admins accidentially give live edit access to users. Resolves: #92134 Releases: master, 10.4 Change-Id: Id69a60c732e3dc9a55d8dd861ca1a89792f49af1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65506 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Simon Gilli authored
The EventDispatcherInterface and LoggerInterface are now provided to newly created Symfony\Component\Mailer\Transport\AbstractTransport decendents. This makes sure all provided events are available. To be compatible with the Symfony's events interface an adapter is added which conforms to symfony/event-dispatcher-contracts. Used composer commands: - composer require symfony/event-dispatcher-contracts:^2.0 --no-update \ --working-dir=typo3/sysext/core - composer require symfony/event-dispatcher-contracts:^2.0 --no-update - composer update --lock Resolves: #92066 Releases: master, 10.4 Change-Id: I634848a6057d3a92c17e3a4ac88a87d2dfdda937 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65405 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Markus Gerdes <markus@madaxel.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Markus Gerdes <markus@madaxel.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Helmut Hummel authored
Always output a progress bar and information that it is actually doing something even when not called with --verbose When no output is required or wanted, the global option --quiet can be used instead. To further improve the command, --no-progress is added which removes the progress bar output, and shows messages instead. Last but not least, output success or error messages for each of the language pack fetches and exit with error code when failures occurred. To not make the command always fail when private extensions are used, individual extensions can be skipped. Releases: master, 10.4 Resolves: #91988 Change-Id: Ie7b7717f7f6fc2f884e974dbca564ca5a2c013af Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65289 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Jörg Bösche <typo3@joergboesche.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- Aug 31, 2020
-
-
Kevin Ditscheid authored
The method retrieveYamlFilesFromExtensionFolders actually returns an array of strings and not an array of File objects. Releases: master, 10.4 Resolves: #92047 Change-Id: Ic031c28891612420c57c2caefc3608772806d7c7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65365 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Jörg Bösche <typo3@joergboesche.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Christian Kuhn authored
The classes QueryView and QueryGenerator in the core extension are detail implementations of the databases search functionality of the lowlevel extension. The patch merges both classes into one, moves it to the lowlevel extension and deprecates the old classes. Minor refactorings like protecting properties and methods is applied to the new class to enable further refactoring if desired. Change-Id: If8b16e8eeb39ed1e3d3aa52eed02b6c27a114e1a Resolves: #92129 Related: #92080 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65457 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Christian Kuhn authored
Deprecation removals for v11 accidentially dropped the rollback handling of the element history controller. Resolves: #92137 Related: #91544 Releases: master Change-Id: I5f479a83222f735c3d2236d70586949396391f00 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65507 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Jörg Bösche <typo3@joergboesche.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Johannes Rebhan authored
This adds the missing ability to generate absolute URLs with the f:widget.link ViewHelper, which is possible with other linking ViewHelpers as well. Resolves: #91994 Releases: master, 10.4 Change-Id: I6f7142849cf13c97376bccaaa80a0e9f3aa2123a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65316 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Jörg Bösche <typo3@joergboesche.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Alexander Schnitzler authored
Instead of using the be.widget.paginate widget, backend users and groups are now paginated with a QueryResultPaginator and the pagination is build with the help of a SimplePagination instance. Releases: master Resolves: #92000 Change-Id: Ie3b476b7bf4da4556eeed4b0d1302fee22fd1fa0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64522 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Jörg Bösche <typo3@joergboesche.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Oliver Hader authored
Issue #69135 fixed issue #60249, but introduced an invalid call to `BackendUtility::selectVersionsOfRecord`. The scope was to handle all versions in all workspaces (`$workspace=null`). As a result, without patch, command 'cleanup:versions' reports too many unused placeholder rows and the action command 'cleanup:versions --action=unused_placeholders' deletes too many. Resolves: #92139 Related: #69135 Related: #60249 Releases: master, 10.4, 9.5 Change-Id: I4d0694d2657c9bf12a5200b6474f1ed1f083d98e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65508 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- Aug 30, 2020
-
-
Daniel Windloff authored
The following hooks in the RecordListController are used to add additional content above or below the main controller content: * $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS'] ['recordlist/Modules/Recordlist/index.php']['drawHeaderHook'] * $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS'] ['recordlist/Modules/Recordlist/index.php']['drawFooterHook'] As this functionality could be useful, it should be migrated to a PSR-14 event. Both hook implementations use a meaningful parameter set (the request object) and return the additional content as string. As there is no dependency to the parent object (the class instance of the class where the hooks are placed), they could be migrated to a psr-14 event without a breaking change. Therefore, a PSR-14 event has been implemented to replace the hook functionality. An event listener has been created to provide a compatibility layer for both hooks. This allows a proper deprecation without breaking the hooks. The event listener (compatibility layer) could be removed in later versions without any changes in the controller class. Releases: master Resolves: #92062 Change-Id: I50e4897bae256ec165861bccd8356db107c78962 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65401 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
-
Patrick Schriner authored
Filter status_code is not properly passed when building pagination arguments in backend redirects module. Resolves: #92125 Releases: master, 10.4 Change-Id: I7c3ace16e9d22eed9ac104876fdb68fdd615c2e7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65497 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
-
Daniel Windloff authored
The TCA configuration `searchFields` in the `ctrl` section has been introduced in TYPO3 4.6. This configuration allows setting the search columns. Those columns are taken into account by the search in the TYPO3 backend. To enable a smooth transition between TYPO3 4.5 and 4.6, the hook `$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['mod_list'] ['getSearchFieldList']` has been introduced as well. It allows to set the `searchFields` for the list module's search. As this transition should be finished now, the hook has been removed. Extension authors are encouraged to set the `searchFields` via the TCA configuration. Releases: master Resolves: #92128 Change-Id: I3afef4f248797345e4feac14a10a7c7797bc86e3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65502 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
-
Daniel Windloff authored
The property `HTMLcode` was only used to collect the output for the tables in `generateList()`. Therefore, `generateList()` returns the collected output and the property `HTMLcode` has been removed. Releases: master Resolves: #92130 Change-Id: I938174a4f25b08281b54883c7f0f3cf62c70c9f8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65504 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
-
Daniel Windloff authored
The following items have been removed as they haven't any impact: * `_LOCALIZATION_` * `_CLIPBOARD_` * `_CONTROL_` `_LOCALIZATION_` and `_CLIPBOARD_` are always filtered out. `_CONTROL_` is always added, if not selected in the field selection. Furthermore, the `ctrl` values `tstamp` and `crdate` could be added by any user regardless of the column name (respecting the configuration in TCA). Finally, the column showing the references is added, if selected. Releases: master, 10.4 Resolves: #80396 Change-Id: Ie809a0e6f76e62166dc2d6f9cecfb3c68750e70e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65501 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
-
Stefan Froemken authored
As UID of sys_file and sys_file_metadata are ambiguous the UID of meta data is accessible with key metadata_uid now. That way UID of sys_file_metadata is accessible in mergedProperties, too. Resolves: #92010 Releases: master, 10.4 Change-Id: I6fa7dedb793fb0f0e0027be60fe8e16fe93b9862 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65332 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Jörg Bösche <typo3@joergboesche.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Daniel Windloff authored
The properties `iLimit` and `totalItems` were only used in the `getTable()` method and in subordinated methods for the pagination. Therefore, they have been replaced by local variables. Releases: master Resolves: #92127 Change-Id: Idb3db75a3f0da62d594cb1a4eadde5c15d5b7a8e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65500 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- Aug 28, 2020
-
-
Daniel Windloff authored
The actual limit, used in the getTable(), depends on various configurations, current view (default view, single table view) and current action (view, search or csv export). To get a better overview, the patch moves limit handling to the getTable() method, so limit handling in start() and generateList() can be removed. The properties itemsLimitPerTable and itemsLimitSingleTable are removed as well. The configured limit (excluding search and CSV export) is now forced to be in a range from 5 to 10000. For translated pages, the pages configuration is used to set the limit. The limit is set by the following chain: [default view with multiple tables; single table view] - default value [20; 100] - if page ts config is set [itemsLimitPerTable; itemsLimitSingleTable] - if tca configuration is set [maxDBListItems; maxSingleDBListItems] - a forced range from 5 to 10000 - if limit is set in the search - no limit for a csv export Releases: master Resolves: #92103 Change-Id: I823c039aa063df8f99e08e190990c5e34466c253 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65461 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
Daniel Windloff authored
The property `fixedL` was only used once (see `ElementBrowserRecordList`, `BackendUtility::getRecordTitlePrep`). The removal of the second parameter `fixedL` in `getRecordTitlePrep` hasn't changed the behaviour, as the backend user's UC `titleLen` is used as default constraint anyway. Therefore, the property `fixedL` has been removed. Releases: master Resolves: #92114 Change-Id: Ib15a268e3c81f72737a310c71fc3800b13288c30 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65470 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
Daniel Windloff authored
The property `counter` is not used anymore, so it's getting removed. Releases: master Resolves: #92115 Change-Id: I009bb526e025a47f48bd1eb417eb0fff666a9f7f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65471 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Jörg Bösche <typo3@joergboesche.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
Daniel Windloff authored
The information about the page record is only needed in the `addPageIdConstraint` method. The information is now collected there and the property `pageRecord` has been removed. Releases: master Resolves: #92116 Change-Id: I3f96f52b58441e85d60a2bc4d70a9bc5ff9f4d5e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65492 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
Christian Kuhn authored
When a record that exists in live is deleted in a workspace, a new 'delete placeholder' record is created in the workspace. This record is used to mark the live workspace record as 'to be deleted' when the workspace is published. Those delete placeholder are not shown in the page tree and not in the page module. The page / element is simply gone. Only the list module renders those records. This is confusing usability wise: A user clicks on 'delete' in list module, reloads the module, and the record is back again. Additionally, there is an even more confusing mechanism: The 'waste' icon is substituted by a different icon called 'restore'. 'restore' however does not actually restore changes that may have been done to the record in the workspace before, instead it simply sets the delete placeholder record to deleted, which makes the underlying live record 'shine through' in the workspace again. Interacting with delete placeholder records is also useless, for instance edited content of delete placeholder records is always gone in the end. So most action icons don't make sense. Looking at the lifecycle of workspace records, there are only two final results: A change is either discarded, or is published to live. This is managed exclusively in the workspace module. Having the third option 'restore' in the list module - that is basically the same as discarding a delete placeholder in workspace module - is very confusing. The best option would be to not render delete placeholder rows in the list module at all. Unfortunately this can't be done due to the workspace overlay mechanics: Especially the count and limit / pagination handling in list module is done on db level before the module knows that certain rows shouldn't be rendered. We need to have some serious refactoring before this can be solved. For now, the solution is to still render delete placeholder records in list module, to 'strike through' their title (similar to workspace module) and to disable all control icons and the click menu on them. This way the final fate of a delete placeholder can be decided only in the workspace module - just like all other workspace records. Change-Id: Id8a95c41f2bbe90ea68f40e376a4d36d3a2019b8 Resolves: #90679 Resolves: #52700 Releases: master, 10.4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65495 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by: Daniel Windloff Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by: Daniel Windloff Reviewed-by:
Björn Jacob <bjoern.jacob@tritum.de> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
- Aug 27, 2020
-
-
Christian Kuhn authored
Setting TCA[$someTable]['ctrl']['thumbnail'] to some image related column made the list module show attached images as preview. Until core v8, this has been used for tt_content and has been dropped for this table because two different fields (images, media) are used and the setting could not cope with that. For extensions with own tables, this setting has been used very seldom. It also partially destroys the list module view. The patch drops evaluation of this ctrl setting in the list module. With this gone, the 'thumbnailsByDefault' setting of the user settings module only affects the file list module. The file list module has it's own checkbox to toggle image preview rendering, so the setup module checkbox has little benefit and is removed as well. This additionally fixes a bug that thumbnail preview rendering in file list module can't be turned off if the setup module checkbox is set. Additionally, the patch drops some unused css for the list module, 'typo3-dblist' simply does not exist as class. Change-Id: If9365b5a26e708cc4d4d57cfcddd728cf97d7811 Resolves: #92118 Related: #79622 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65493 Tested-by:
Achim Fritz <af@achimfritz.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by: Daniel Windloff Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Achim Fritz <af@achimfritz.de> Reviewed-by: Daniel Windloff Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
-
- Aug 26, 2020
-
-
Simon Ackermann authored
Add the specific way to override a RTE configuration preset for a flexform field Resolves: #92102 Releases: master, 10.4, 9.5 Change-Id: I88a621aff48c43833cf5ee9a8e97403322a33a05 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65460 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Jörg Bösche <typo3@joergboesche.de> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
Andreas Fernandez authored
This patch wraps operands in parentheses which could otherwise cause unwanted side-effects. In most cases null coalesce operators are affected. Resolves: #92104 Releases: master, 10.4, 9.5 Change-Id: I95815354090516f09b61655126c61ccc8714a751 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65331 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Jörg Bösche <typo3@joergboesche.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
Christian Kuhn authored
When relations are added in a workspace, the 'info' modal of the parent record does not reflect those. The patch changes the reference resolving to work with the overlay record uid if given. This fixes reference record display for inline records including file references. There are further issues with the rendered record, those however are resolved by other core methods and can be fixed with other patches. Resolves: #45148 Releases: master, 10.4 Change-Id: I7d32a1218eaa2ed47c6cba27e0e52b54e70ae68f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65453 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Achim Fritz <af@achimfritz.de> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Achim Fritz <af@achimfritz.de> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-