- Jan 09, 2024
-
-
Christian Kuhn authored
Based on the new PageInformation object attached to the Request from #102715, we can get rid of usages of TSFE->MP property. The patch does this and streamlines an admin panel class and the seo CanonicalGenerator class along the way. Change-Id: I0597fdfe5392128a6ae1932305e21a7d25076e29 Resolves: #102797 Related: #102715 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82277 Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
-
Stefan Bürk authored
TYPO3 v12 upgraded to Doctrine DBAL 3.2 with #96287 and cloned a couple of doctrine PDO related classes to provide the mandatory `resource to string` mapping for PDO drivers. At that point this was the only way to mitigate the fact, that `final` has been added to these classes with Doctrine DBAL 3.1 [1]. The doctrine team introduced the new driver middleware concept with Doctrine DBAL 3.0.0 [2] and allows the decorator pattern to be used for Driver, Driver/Connection, Driver/Statement and Driver/Result. General support for connection driver middlewares (#100089) and global driver middlewares (#102496) has been added meanwhile to TYPO3. Additionally, sortable configuration for middlewares has been improved with #102586. This change migrates towards the driver middleware pattern and reduces the code required to be maintained and check on doctrine upgrades because cloned and changed classes can be removed and replaced by minimal decorator implementations. `\TYPO3\CMS\Core\Database\Middleware\UsableForConnectionInterface` has been added with #102587 which helps to limit the driver mapping to supported `pdo_*` driver only. The superfluous internal classes are removed as non-breaking following the TYPO3 core policies. [1] https://github.com/doctrine/dbal/blob/3.7.x/UPGRADE.md#bc-break-changes-in-driver-classes [2] https://github.com/doctrine/dbal/pull/4157 Resolves: #102588 Related: #102587 Related: #102586 Related: #102496 Related: #100089 Related: #96287 Releases: main Change-Id: Ia17d104129a1199fa318baf0b66be29445f0f72b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82071 Tested-by:
core-ci <typo3@b13.com> Tested-by:
-
Oliver Bartsch authored
Declare EXT:backend Event classes, only having readonly properties, as readonly. Additionally, adds readonly to properties, which previously missed the declaration. Resolves: #102789 Releases: main Change-Id: Ic88d7243bce82844b50462dacaf8381333301fed Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82409 Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
-
Oliver Bartsch authored
Declare EXT:core Event classes, only having readonly properties, as readonly. Additionally, adds readonly to properties, which previously missed the declaration. Resolves: #102791 Releases: main Change-Id: I7937d6f2db4062aa4eb69389e1b30fbdf4552812 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82410 Reviewed-by:
-
Oliver Bartsch authored
This replaces the previously available hook $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_content.php']['getImgResource'] which is therefore now removed. The hook required implementations to implement the `ContentObjectGetImageResourceHookInterface`, which is now deprecated as it's unused due to the hook removal. Resolves: #102755 Releases: main Change-Id: I8fb387d035fe4d8ecb904b1e379b0bf1872193e6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82332 Reviewed-by:
-
Stefan Bürk authored
The `\TYPO3\CMS\Core\Service\OpcodeCacheService->isClearable()` method checks for existence of opcache function and if they are listed in the `disable_functions` configuration. It seems, that in some environments both methods are missing and not listed in the disabled methods. Even if this sounds odd when the opcache extension is installed but both methods are not available, we add it to the check to avoid the missleading error message: Call to undefined function TYPO3\CMS\Core\Service\opcache_reset() Resolves: #102734 Releases: main, 12.4, 11.5 Change-Id: Icc17a276e8881f502a687db7ca57fc05ecb8981e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82361 Tested-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
-
Oliver Bartsch authored
Replace the hard-coded `sys_language_uid` name with the actually configured `languageField` value. Resolves: #102758 Releases: main, 12.4 Change-Id: I74d0624c0b79b3085247d5d58f091857ff228411 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82354 Tested-by:
-
Andreas Kienast authored
This commit updates the `flag-icons` and its related build packages `filesize` and `sharpen` to their respective latest version. See changelog at [1]. Executed commands: npm install --save-dev \ filesize@^10.1.0 \ flag-icons@^7.1.0 \ sharp@^0.33.1 npm run build [1] https://github.com/lipis/flag-icons/blob/v7.1.0/CHANGELOG.md Resolves: #102780 Releases: main, 12.4 Change-Id: Ife74d3679d18ec374e40140183c69f912e5b1439 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82397 Tested-by:Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
-
Andreas Kienast authored
The supported node version is raised to 18.19, see https://nodejs.org/en/blog/release/v18.19.0 for further details. Resolves: #102787 Releases: main, 12.4 Change-Id: I9a199b748b9c3859188fa7ae7809526afe4fda43 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82399 Reviewed-by:
-
Stefan Bürk authored
New `core-testing-*` images has been build and released. [1] This change update used image version to: * core-testing-nodejs18:1.1.0 * core-testing-nodejs18-chrome:1.1.0 * core-testing-apache24:1.2.0 Additionally, the allowed npm engine in `Build/package.json` is set accordingly. [1] https://git.typo3.org/typo3/CI/testing-infrastructure/-/commit/614aa2cc6173a49195a74772fb22fbcf0b3d25f2 Resolves: #102782 Releases: main, 12.4, 11.5 Change-Id: I639f446e46b21fe2969a107eace39f9977eee933 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82401 Tested-by:
-
- Jan 08, 2024
-
-
Chris Müller authored
As `canBeUsedForConnection()` is defined in the `UsableForConnectionInterface`, this interface must be implemented. As it also extends the `\Doctrine\DBAL\Driver\Middleware` interface, mentioning that interface can be omitted. Resolves: #102784 Related: #102587 Releases: main Change-Id: If59008fb5a75a9fe9a8b700868f6852056f0f3cf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82403 Tested-by:
-
Benni Mack authored
Back in TYPO3 v7, the "target" request attribute for BE routes was added with PSR-7, before Routing with PSR-15 and the new Module API in TYPO3 v12 was added. It contained the PHP class and method to be called as Request endpoint. The Route object which is now used consistently, can now be used and the target request attribute for backend requests is removed again. Resolves: #102781 Releases: main Change-Id: I1e62e6c3395af9075f1433a1cb0547e4146b2807 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82400 Reviewed-by:
-
Benni Mack authored
The following methods now have a strict method signature for all arguments and their return types. - PageRepository->getPage() - PageRepository->getPage_noCheck() - PageRepository->getPageOverlay() - PageRepository->getPagesOverlay() - PageRepository->checkRecord() - PageRepository->getRawRecord() - PageRepository->enableFields() - PageRepository->getMultipleGroupsWhereClause() - PageRepository->versionOL() Calling one of the methods now require proper arguments of the respective types. Resolves: #102775 Releases: main Change-Id: I789453974001113263bc1fdff047adf0eb92c570 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82364 Reviewed-by:
-
Benni Mack authored
TYPO3 v13 will require PHP 8.2 as minimum PHP version to be used. Used commands: > composer config platform.php 8.2.0 > composer req "php:^8.2" --no-update > composer update --lock Resolves: #102779 Releases: main Change-Id: I4765cd4421ad3d6311f8e2a2411e15725ca45de8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82371 Reviewed-by:
-
Andreas Kienast authored
This commit updates `luxon` to 3.4.4. See changelog at [1]. Executed commands: npm install --save luxon@^3.4.4 npm install --save-dev @types/luxon@^3.4.0 npm run build [1] https://github.com/moment/luxon/blob/3.4.4/CHANGELOG.md Resolves: #102777 Releases: main, 12.4 Change-Id: I15419f8693779b8a51eebd2fb9a3e3d822a247c4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82370 Reviewed-by: -
Andreas Kienast authored
This commit updates the JavaScript testing suite, including all related dependencies. As a new requirement, `@types/mocha` is installed as well. Executed commands: npm install --save-dev \ @open-wc/testing@^4.0.0 \ @web/dev-server-esbuild@^1.0.1 \ @web/dev-server-import-maps@^0.2.0 \ @web/test-runner@^0.18.0 \ @web/test-runner-playwright@^0.11.0 \ @types/mocha@^10.0.6 \ sinon@^17.0.1 npm run build npm run test Resolves: #102778 Releases: main, 12.4 Change-Id: Ic2e044a98a1d2536b75420b6b17ef98923d5b6bc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82392 Reviewed-by: -
Andreas Kienast authored
Executed commands: npm install --save sortablejs@^1.15.1 npm install --save-dev @types/sortablejs@^1.15.7 npm run build Resolves: #102776 Releases: main, 12.4 Change-Id: I8a9969d87c87b8df708e9e7d7d9cb08a86ae7e54 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82369 Reviewed-by: -
Stefan Bürk authored
TYPO3 integrated the Doctrine DBAL Driver Middleware concept for connection (#100089) and all connections (#102496) along with a enhanced configuration ability (#102586). This change adds a specific driver middleware interface to TYPO3, which can be used to determine if a registered driver middleware can be used for a specific connection. `\TYPO3\CMS\Core\Database\Middleware\UsableForConnectionInterface` requires the implementation of following method to a custom driver middleware implementation if used: public function canBeUsedForConnection( string $identifier, array $connectionParams ): bool { ... } This allows extension authors to provide driver middlewares in a generic way, but ensure it is only taken into account if further requirements are met. Resolves: #102587 Related: #102586 Related: #102496 Related: #100089 Releases: main Change-Id: Idff667177a3bb55e9e00cfc7eaf2670101f0a548 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82070 Reviewed-by: -
Christian Kuhn authored
Resolves: #102774 Releases: main Change-Id: Id67074c625e71dded57bcde5d43a8963f2599f79 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82368 Tested-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Reviewed-by:
-
Peter Kraume authored
Resolves: #102772 Releases: main, 12.4 Change-Id: I483a54dc85e0505b336634c55709c543075a3b13 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82366 Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
-
Oliver Bartsch authored
Some controllers / modules are not registered as dedicated modules but only as route, e.g. FormEngine. This is now respected by the start module evaluation, making the redirect feature working again for those use cases. Resolves: #102743 Related: #102665 Releases: main, 12.4 Change-Id: I1398d7aacdcd5d8a3c433fdb21f8710e34668d63 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82301 Reviewed-by:
-
- Jan 07, 2024
-
-
Torben Hansen authored
When working with a `FileReference` object, it is currently not possible to delete the file reference with the `delete()` method, since it has never been implemented. The `delete()` functionality can however be useful when working manually with file references. This change implements the missing functionality. Resolves: #102770 Releases: main, 12.4 Change-Id: I5fd8a26f9e4b98de1a6f7553be0da6b53f3bab1b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82362 Tested-by:
-
- Jan 06, 2024
-
-
Benni Mack authored
This change does not render a page translation anymore if it was deleted (t3ver_state=2). It also enables the dropdown to create a new page translation but then DataHandler does not allow this anymore. This patch needs more work in DataHandler for "delete translation in WS + create a new translation in WS" Resolves: #98544 Releases: main, 12.4 Change-Id: Ie3a786f28faaf13c4165667ff8fc8a6d98f6e6db Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79717 Reviewed-by:
-
Benni Mack authored
When doing language overlays in PageRepository an overlaid language for a page received special properties: * "_PAGES_OVERLAY_UID" (the UID of the translated page) * "_PAGES_OVERLAY" (a flag indicating that a translation happened) * "_PAGES_OVERLAY_LANGUAGE" (the sys_language_uid record) * "_PAGES_OVERLAY_REQUESTEDLANGUAGE" (info which language was requested) For regular records (non-pages) only one special property was used "_LOCALIZED_UID". This patch unifies the properties, as this was a historical technical debt due to "pages" vs. "pages_language_overlays" and other records. "_PAGES_OVERLAY_UID" is replaced with "_LOCALIZED_UID", "_PAGES_OVERLAY" is removed as a isset check for "_LOCALIZED_UID" can be used "_PAGES_OVERLAY_LANGUAGE" is replaced in favor of the native "sys_language_uid" field "_PAGES_OVERLAY_REQUESTEDLANGUAGE" is replaced with "_REQUESTED_OVERLAY_LANGUAGE" and now also available for non-page records As seen in the changes, some code can now be simplified due to superfluous checks on "_PAGES_OVERLAY_UID" and directly using "_LOCALIZED_UID". Releases: main Resolves: #102627 Change-Id: I7b5c9de66cccc4d2f0907d4d9c51a5b66aa4d4e8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82300 Tested-by:
-
Chris Müller authored
Resolves: #102765 Related: #102586 Releases: main Change-Id: Ic56dfc57ca6f6363a02b78f2a30d6d9521fccb97 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82356 Tested-by:
Lina Wolf <112@linawolf.de> Reviewed-by:
-
Oliver Bartsch authored
Resolves: #102740 Releases: main Change-Id: I353e2110935de792bda454705a5bc3e6ab1b2553 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82296 Tested-by:
-
Chris Müller authored
Resolves: #102764 Related: #102586 Releases: main Change-Id: Idef16b854a5c6e5ef86697339ca3e8c5d4bd39b9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82355 Reviewed-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
-
Anja Leichsenring authored
New phpstan find some questionable null fallback occurences, that are not obvious. Add a baseline for now. > composer req --dev phpstan/phpstan:^1.10.51 > ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #102756 Releases: main, 12.4 Change-Id: I3eef057d4fd04fe92f813bad7e1873718f6da765 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82352 Reviewed-by:
Thomas Hohn <tho@gyldendal.dk> Tested-by:
-
- Jan 05, 2024
-
-
Oliver Bartsch authored
Using `treatIdAsReference` it's also possible to pass a file reference uid to the ThumbnailViewHelper. To allow processing such reference, the original file is now fetched to call `process` on it. Resolves: #102571 Releases: main, 12.4 Change-Id: If2f9cad99045d19c6dcc4b95bba6b7de71405956 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82297 Reviewed-by:
-
Simon Schaufelberger authored
It was decided that PageRenderer won't become final. Resolves: #102752 Releases: main Change-Id: I19001ae5f89ca89930d6dc381ace12e92ca815d2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82310 Tested-by:
Chris Müller <typo3@krue.ml> Tested-by:
Torben Hansen <derhansen@gmail.com> Reviewed-by:
-
Christian Rath-Ulrich authored
In the file list module, a file thumbnail does not contain alternative text. To exclude these thumbnails from screen readers and thus improve accessibility, an empty `alt` tag is set. This applies to both the list and tile view. Resolves: #102416 Releases: main, 12.4 Change-Id: Iaf0ce6736f669c0852f96c022fa55c128aecdb9e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81811 Tested-by:
-
Oliver Bartsch authored
It's unlikely but possible that the `languageField` of a record does not use `sys_language_uid` as name. This is now properly respected in DataHandler. Resolves: #102757 Releases: main, 12.4 Change-Id: Icdb2b599e6ada75c3562c59a41f2b2449ec61d63 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82353 Reviewed-by:
-
Oliver Bartsch authored
An additional check is applied to prevent an InvalidArgumentException for cases where `checkPid_value` contains an empty string. Resolves: #102751 Releases: main, 12.4 Change-Id: I906837e75ab505af1e46f55eeccd068c24005e98 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82309 Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
- Jan 04, 2024
-
-
Benni Mack authored
PHP-CS-Fixer rule `array_indentation` is activated to have consistent indentation of arrays. In addition, a full run of php-cs-fixer without caches shows also affected areas where comments did not apply properly. Resolves: #102753 Releases: main, 12.4, 11.5 Change-Id: I759149606c4b042f1ac4329d4f5b7166d591456b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79239 Reviewed-by:
-
Garvin Hicking authored
A new CLI Symfony Command option `--all` is added to the CLI command `bin/typo3 cleanup:localprocessedfiles` that allows to reset all entries in the database to force re-creating processed files. When developing FAL features or updating installations with large user-generated content fileadmin storages, it may be helpful to clean the sys_file_processedfile database table completely to force a rebuild (i.e. when new FAL-Processors are added). This table holds all locally generated processed files with specific crop or size variants (or references to unaltered originals, or "proxy" entries). The new command option will also report the numbers of deleted records before execution, and allows you to review execution. It is not set by default. Also, a small error in the output has been fixed that counted the number of database records wrongly. Tests were added for the new option. Resolves: #102582 Releases: main Change-Id: I7c490cc2c803e136cbd8db2ddcdbf25ac96ec796 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82064 Reviewed-by:
Guido Schmechel <guido.schmechel@brandung.de> Tested-by:
-
Benni Mack authored
This change enables symfony 7 in addition to symfony 6 in TYPO3. Symfony7 requires PHP 8.2, thus is not installed by default for the time being, as this change is also allowed for TYPO3 v12 support when running with PHP 8.2 and composer. Used commands: composer req -W \ "symfony/config:^6.4 || ^7.0" \ "symfony/console:^6.4 || ^7.0" \ "symfony/dependency-injection:^6.4 || ^7.0" \ "symfony/doctrine-messenger:^6.4 || ^7.0" \ "symfony/expression-language:^6.4 || ^7.0" \ "symfony/filesystem:^6.4 || ^7.0" \ "symfony/finder:^6.4 || ^7.0" \ "symfony/http-foundation:^6.4 || ^7.0" \ "symfony/mailer:^6.4 || ^7.0" \ "symfony/messenger:^6.4 || ^7.0" \ "symfony/mime:^6.4 || ^7.0" \ "symfony/options-resolver:^6.4 || ^7.0" \ "symfony/property-access:^6.4 || ^7.0" \ "symfony/property-info:^6.4 || ^7.0" \ "symfony/rate-limiter:^6.4 || ^7.0" \ "symfony/routing:^6.4 || ^7.0" \ "symfony/uid:^6.4 || ^7.0" \ "symfony/var-dumper:^6.4 || ^7.0" \ "symfony/yaml:^6.4 || ^7.0" composer req --dev -W \ "codeception/codeception:^5.0.13" \ "codeception/module-filesystem:^3.0.1" \ "friendsofphp/php-cs-fixer:^3.46" \ "symfony/translation:^6.4 || ^7.0" Resolves: #102746 Releases: main, 12.4 Change-Id: I6bbbfb0bc6e26c00fba0010234b5c8b698cf0a81 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82304 Tested-by:
-
Oliver Bartsch authored
Resolves: #102744 Releases: main Change-Id: I1b50b5f7abefd455eae143de70ac8b7f0f02c89d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82303 Reviewed-by:
-
Oliver Bartsch authored
It's now possible to define a specific field for a foreign table, holding the id of an associated item group. This therefore enables the item groups feature also for select fields, fetching its items from a foreign table. The new option is called `foreign_table_item_group`. In case an item group of a foreign item is not defined in the `itemsGroup` config of the local field, the group id is used as label. This is the same as if a static item contains a not configured group. Resolves: #95808 Related: #91008 Releases: main Change-Id: I111d5c1bd4507347a3a7e15e9779d010580838dd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82171 Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
-
Anja Leichsenring authored
TYPO3 uses a composer package [1] to import locales along with translations and a custom script has been added to create and update included translation files. This change updates the language files with the last updates and requires the package with the current highest version as minimum. Used command(s): > composer req --dev \ "sokil/php-isocodes-db-i18n":"^4.0.18" > Build/Scripts/runTests.sh \ -s checkIsoDatabase \ -p 8.1 [1] sokil/php-isocodes-db-i18n Resolves: #102747 Releases: main, 12.4 Change-Id: I4d6603484c4fca213c66f0df0feff13bc1011b29 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82306 Reviewed-by:
-
- Jan 03, 2024
-
-
Sascha Nowak authored
Message handlers had to be registered in the extensions `Services.yaml` file with the `messenger.message_handler` tag. This patch enables automatic message handlers registration by using the existing `\Symfony\Component\Messenger\Attribute\AsMessageHandler` symfony PHP attribute. Resolves: #101700 Releases: main Change-Id: I8dbd24d43f61c66b7e445b71ae1db3a178aa4991 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82284 Tested-by:
Daniel Goerz <daniel.goerz@b13.com> Reviewed-by:
-
