[!!!][TASK] Unify _PAGES_OVERLAY_UID and _LOCALIZED_UID
When doing language overlays in PageRepository an overlaid language for a page received special properties: * "_PAGES_OVERLAY_UID" (the UID of the translated page) * "_PAGES_OVERLAY" (a flag indicating that a translation happened) * "_PAGES_OVERLAY_LANGUAGE" (the sys_language_uid record) * "_PAGES_OVERLAY_REQUESTEDLANGUAGE" (info which language was requested) For regular records (non-pages) only one special property was used "_LOCALIZED_UID". This patch unifies the properties, as this was a historical technical debt due to "pages" vs. "pages_language_overlays" and other records. "_PAGES_OVERLAY_UID" is replaced with "_LOCALIZED_UID", "_PAGES_OVERLAY" is removed as a isset check for "_LOCALIZED_UID" can be used "_PAGES_OVERLAY_LANGUAGE" is replaced in favor of the native "sys_language_uid" field "_PAGES_OVERLAY_REQUESTEDLANGUAGE" is replaced with "_REQUESTED_OVERLAY_LANGUAGE" and now also available for non-page records As seen in the changes, some code can now be simplified due to superfluous checks on "_PAGES_OVERLAY_UID" and directly using "_LOCALIZED_UID". Releases: main Resolves: #102627 Change-Id: I7b5c9de66cccc4d2f0907d4d9c51a5b66aa4d4e8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82300 Tested-by:Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
Showing
- Build/phpstan/phpstan-baseline.neon 0 additions, 5 deletionsBuild/phpstan/phpstan-baseline.neon
- typo3/sysext/core/Classes/Domain/Page.php 3 additions, 6 deletionstypo3/sysext/core/Classes/Domain/Page.php
- typo3/sysext/core/Classes/Domain/Repository/PageRepository.php 9 additions, 11 deletions.../sysext/core/Classes/Domain/Repository/PageRepository.php
- typo3/sysext/core/Classes/Routing/PageRouter.php 1 addition, 1 deletiontypo3/sysext/core/Classes/Routing/PageRouter.php
- typo3/sysext/core/Classes/Utility/RootlineUtility.php 1 addition, 1 deletiontypo3/sysext/core/Classes/Utility/RootlineUtility.php
- typo3/sysext/core/Documentation/Changelog/13.0/Breaking-102627-RemovedSpecialPropertiesOfPageArraysInPageRepository.rst 73 additions, 0 deletions...-RemovedSpecialPropertiesOfPageArraysInPageRepository.rst
- typo3/sysext/core/Tests/Functional/Domain/Repository/PageRepositoryTest.php 21 additions, 28 deletions...Tests/Functional/Domain/Repository/PageRepositoryTest.php
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_irre_csv/Configuration/TypoScript/JsonRenderer.typoscript 1 addition, 1 deletion...irre_csv/Configuration/TypoScript/JsonRenderer.typoscript
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_irre_foreignfield/Configuration/TypoScript/JsonRenderer.typoscript 1 addition, 1 deletion...ignfield/Configuration/TypoScript/JsonRenderer.typoscript
- typo3/sysext/core/Tests/Functional/Fixtures/Frontend/JsonRenderer.typoscript 1 addition, 1 deletion...ests/Functional/Fixtures/Frontend/JsonRenderer.typoscript
- typo3/sysext/extbase/Classes/Persistence/Generic/Storage/Typo3DbBackend.php 1 addition, 6 deletions...se/Classes/Persistence/Generic/Storage/Typo3DbBackend.php
- typo3/sysext/frontend/Classes/ContentObject/Menu/AbstractMenuContentObject.php 13 additions, 13 deletions.../Classes/ContentObject/Menu/AbstractMenuContentObject.php
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php 2 additions, 2 deletions...ntend/Classes/Controller/TypoScriptFrontendController.php
- typo3/sysext/frontend/Classes/Resource/FileCollector.php 1 addition, 6 deletionstypo3/sysext/frontend/Classes/Resource/FileCollector.php
- typo3/sysext/frontend/Classes/Typolink/DatabaseRecordLinkBuilder.php 1 addition, 1 deletion...t/frontend/Classes/Typolink/DatabaseRecordLinkBuilder.php
- typo3/sysext/frontend/Classes/Typolink/PageLinkBuilder.php 1 addition, 1 deletiontypo3/sysext/frontend/Classes/Typolink/PageLinkBuilder.php
- typo3/sysext/frontend/Tests/Unit/ContentObject/Menu/AbstractMenuContentObjectTest.php 2 additions, 2 deletions...Unit/ContentObject/Menu/AbstractMenuContentObjectTest.php
- typo3/sysext/seo/Classes/HrefLang/HrefLangGenerator.php 2 additions, 2 deletionstypo3/sysext/seo/Classes/HrefLang/HrefLangGenerator.php
Please register or sign in to comment