- Sep 24, 2020
-
-
Oliver Bartsch authored
With #82489 a condition, introduced in #71918, was changed as it misused the `['appearance']['enabledControls']['new']` property to hide the newRecordLink button while actually only the "new" button of inline records controls should be hidden. To provide the possibility to hide the newRecordLink, independent of the controls, a new property `showNewRecordLink` was introduced. This new property is however superfluous as the newRecordLink button can already be hidden by setting `['appearance']['levelLinksPosition']` to `none`. Therefore the newly introduced `showNewRecordLink` property along with the condition is removed and the RST is updated and moved to the correct directory. Resolves: #92397 Relates: #82489 Releases: master, 10.4 Change-Id: I49cf98c98a9df125f4fbf1737ccdacbf915fb683 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65846 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
- Sep 23, 2020
-
-
Alexander Schnitzler authored
This patch fixes incompatible type usage in function arguments and is preparatory work for introducing native type hints and strict mode in all core files. Releases: master, 10.4 Resolves: #92271 Change-Id: Ia8ba882db3129ad42785d5d39b49a31d2f81b27b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65657 Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Benni Mack authored
This patch adds "Create new content and localize it" tests. This change adds tests to show that newly created records contain their proper l10n_parent fields when publishing the default language without publishing translated records. Resolves: #92393 Releases: master, 10.4 Change-Id: If608103b1c698774a6604902fbf1600ce6df0a79 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65811 Tested-by:
-
Christian Kuhn authored
Dealing with workspace-discard, where rows are always fully dropped in DB, the expensive reference index operation does not need to be performed at all. It can be substituted with straight db-delete calls for affected sys_refindex rows. Change-Id: Iaa61ef2345c63394fa3286cc9d5dabc5b1a4bb55 Resolves: #92392 Releases: master, 10.4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65841 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
Alexander Schnitzler authored
Replace ObjectManager->get() with GeneralUtility::makeInstance() Releases: master Resolves: #92243 Change-Id: Idcf8436699e5d6845cab95d5332a536c156748dd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65651 Tested-by:
-
Alexander Schnitzler authored
This patch fixes incompatible type usage in function arguments and is preparatory work for introducing native type hints and strict mode in all core files. Releases: master, 10.4 Resolves: #92278 Change-Id: I242553c64f934fbce2dc7762c4fcce4d01b5a0c9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65676 Tested-by:
-
Alexander Schnitzler authored
This patch fixes incompatible type usage in function arguments and is preparatory work for introducing native type hints and strict mode in all core files. Releases: master, 10.4 Resolves: #92109 Change-Id: I475507b4b075c1de5cedd82875e49aefe1a42a79 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65464 Tested-by:
-
Benni Mack authored
When a moved content element in a workspace got copied (or the whole page that the content element is put), then the content element is added twice to the target page. This patch skips moved placeholders completely. Resolves: #92388 Releases: master, 10.4 Change-Id: I8c1b4631627eef80b1740c77b63e541d36ab5f53 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65838 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
Christian Kuhn authored
When deleting children in a relation, reference index rows pointing to a child must be updated, otherwise dangling reference index rows are left, leading to all kinds of trouble. Change-Id: I8e8086846ae53c5a32aafc553b6ea66d4a17d7fb Resolves: #67676 Releases: master, 10.4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65809 Tested-by:
-
Alexander Schnitzler authored
This patch fixes incompatible type usage in function arguments and is preparatory work for introducing native type hints and strict mode in all core files. Releases: master, 10.4 Resolves: #92268 Change-Id: Ic8b6ce1a310181167728d3edd930dcfc18351266 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65661 Tested-by:
-
Oliver Bartsch authored
Resolves: #92387 Releases: master Change-Id: Iad9786b51f401c8c11d3c4c0b906fe5054723522 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65837 Tested-by:
-
Alexander Schnitzler authored
This patch fixes incompatible type usage in function arguments and is preparatory work for introducing native type hints and strict mode in all core files. Releases: master, 10.4 Resolves: #92256 Change-Id: Iffa47071ef75ff1453d76864acef853240da81df Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65670 Tested-by:
-
Alexander Schnitzler authored
This patch fixes incompatible type usage in function arguments and is preparatory work for introducing native type hints and strict mode in all core files. Releases: master, 10.4 Resolves: #92270 Change-Id: I5e0ec227a6dd382d13fa69b06515621d8efc596a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65669 Tested-by:
-
Alexander Schnitzler authored
This patch fixes incompatible type usage in function arguments and is preparatory work for introducing native type hints and strict mode in all core files. Releases: master, 10.4 Resolves: #92276 Change-Id: I28290de708946358794bfa73cac9c7c49ec1cc8b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65682 Tested-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
-
Benni Mack authored
When using BackendWorkspaceRestriction the DB query fetches newly created records of ALL workspaces, not just the currently given workspace. For this reason it is highly discouraged to use this restriction but use the main WorkspaceRestriction instead. This change adapts all remaining places which especially is relevant when having multiple NEW PLACEHOLDERs in various workspaces to only work on the current workspace. Resolves: #92209 Releases: master, 10.4 Change-Id: Ie8b2321270b4804fa59cef1fa712cd820242ee40 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65582 Tested-by:
-
Benni Mack authored
Some older PHP versions could not handle DateTime::createFromFormat() with negative integers. This change adds tests to show that this actually works. Resolves: #73637 Releases: master, 10.4 Change-Id: Ief4112bee6d8fc95fa46dc84cb0cfc6b4a3faff1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65834 Tested-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Tested-by:
-
Georg Ringer authored
Check if there are any columns before iterating over those in the fluid page module. Resolves: #91497 Releases: master, 10.4 Change-Id: I2157c39f8bc6af00c8b37774f8dfb0c6ec834000 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65808 Tested-by:
Josef Glatz <josefglatz@gmail.com> Tested-by:
Georg Tiefenbrunn <georg.tiefenbrunn@gmail.com> Tested-by:
Claus Due <claus@phpmind.net> Reviewed-by:
-
Oliver Hader authored
Using `GlobalEventHandler` in combination with checkboxes and unchecking on item uses and empty string `''` as value for that particular parameter (e.g. `&setting=`). However, some scenarios in the TYPO3 backend rely on receiving `&setting=0` instead - e.g. see BackendUtility::getModuleData(). New attribute `data-empty-value` has been introduced to achieve that. Resolves: #92378 Releases: master, 10.4 Change-Id: Idc372b8c572212fc26cf2bae7fa6e74c2a2a9c59 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65832 Tested-by:
Richard Haeser <richard@richardhaeser.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Georg Ringer authored
Properly check if the variable is defined. Resolves: #92375 Releases: master, 10.4 Change-Id: I99d3da3147b263758958caae029dbbc433751d75 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65806 Tested-by:
-
Madaxel authored
The protected member $queuedMessages of MemorySpool is now initialized as empty array to prevent exceptions on accessing it in magic methods like __toString(). Resolves: #92135 Releases: master, 10.4 Change-Id: I2e12c52be02caa82e3fbdb1014433709589b9752 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65804 Reviewed-by:
-
Christian Kuhn authored
Protected class member $resolvedIds is only used in get(), so it can be turned into a local variable. Resolves: #92379 Releases: master, 10.4 Change-Id: I889f1c9ac60b990da15f866603c441aecc16472d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65810 Tested-by:
-
Georg Ringer authored
To make debugging easier and to be in sync with redirects by EXT:redirects, page doktypes which trigger a redirect now also provide the header X-Redirect-By. Resolves: #92334 Releases: master Change-Id: Ia01e358b5cb50dcac4d57f8469f572cf7eaaaedd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65752 Tested-by:
-
- Sep 22, 2020
-
-
Oliver Bartsch authored
Since #71918 the property ['appearance']['enabledControls']['new'] is misused to hide the newRecordLink button of TCA=inline. This is incorrect because according to documentation enabledControls only manages the controls, shown in the header of each inline record. This makes sense for use-cases where e.g. an inline column has maxitems=1 set. Therefore the control to create a new inline record afterwards is not needed. The newRecordLink is however definitely needed to create at least this one inline record. Furthermore ['enabledControls']['new'] is the only enabledControls property used in InlineControlContainer, which also indicates its misuse there. This check is therefore now replaced by a new dedicated property `showNewRecordLink`, so it is still possible for extension authors to hide the newRecordLink independent of the new button in the inline records controls. For backwards compatibility the newRecordLink is only hidden if the `showNewRecordLink` is explicit set to FALSE. If not set the newRecordLink is shown. Resolves: #82489 Related: #71918 Releases: master, 10.4 Change-Id: Ic504ff95ff30804d86a686d71922622c19b0c859 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65701 Tested-by:
-
Alexander Schnitzler authored
Since validators have an internal state (prototypes) they must not have services injected. Also, the ValidatorResolver must not use the object manager directly to create validator instances. Releases: master Resolves: #92238 Change-Id: If4869634338d363bed81e3182d9a75ede9b0d440 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65646 Tested-by:
-
Christian Kuhn authored
Within DataHandler processing, updating the reference index is an expensive task since it needs tons of queries to do the job. With DataHandler instances and it's sub instances created for relations and localizations, the code tends to update the reference index for the same table/uid combination multiple times: As example, core test IRRE/ForeignField/Modify copyParentContent() copies a content element with one hotel, one offer and one price around. This leads to 3 update reference index calls for the tt_content element, 4 for the hotel, 4 for the offer and 3 for the price. Of course, the situation is worse in workspaces. There have been various attempts over the years to reduce the query load, usually by adding runtime caches everywhere. With proper sys_refindex functional test coverage in place, we can however finally solve the root problem: The patch adds the helper object ReferenceIndexUpdater to fill a registry with to-update workspace/table/uid combinations. The object is carried around within DataHandler and RelationHandler to DataHandler sub instances. Only the outer most instance of a DataHandler then finally executes the update() operations in one go and only once per combination. The patch tries to be rather conservative to allow a 10.4 backport. For master, there should be further mess-reducing cleanup patches to streamline related parts of the ReferenceIndex update process. Result: The DataHandler query load is reduced significantly. It heavily depends on the structure that is changed, to get an idea, the above test goes down from 448 queries to 346 queries! Change-Id: I49f5ed73114ca5d6e2cb75fa43846bde5ea72d26 Resolves: #92356 Related: #88134 Releases: master, 10.4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65796 Tested-by:
-
Oliver Hader authored
As a backend user, it is possible to preview a hidden page & record in a workspace, however, without a user it is not possible. Adding the tests also discovered that access to a "hidden" page should result in a 404 instead of 403 response (even though the page has access restrictions or not) in a live environment. This change adds tests to ensure this functionality is always working. Resolves: #92225 Resolves: #84098 Resolves: #86346 Releases: master, 10.4 Change-Id: I746717473bb93681c7b998d61c4f72eab4ec2ef3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/58829 Tested-by:
-
Simon Gilli authored
This patch adds the missing field `flag` from the site configuration to the LanguageMenuProcessor. The field could be used now to show the flag icon in a language menu out of the box and without workarounds. Resolves: #84926 Releases: master, 10.4 Change-Id: Ie27bed551a96cae8c6b20913105ff95db7f61942 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65800 Tested-by:
Alexander Nitsche <typo3@alexandernitsche.com> Tested-by:
-
Oliver Bartsch authored
The ext:linkvalidator ValidatorTask has been improved. Therefore the task was switched from marker based templates to FluidEmail. The mail content was extended for a proper list of broken links along with all necessary information such as record id, page id, and so on. This allows editors now to easily access the records with broken links without having to visit the backend module first. Because of heavy refactoring and introduction of a new PSR-14 event, extension authors are now able to fully customize the mail content and the configuration (such as to, from, subject) dynamically (e.g. adding another recipient only on production context). Both the task and its field provider got added strict types. The task however currently still needs some type casts for backwards compatibilty as the tasks state is stored as serialized string in the database. The whole link analyzing process was moved into the dedicated class `LinkAnalyzerResult`. A new field `languages` is introduced which allows to restrict the report to the defined languages which is handy if different tasks should be used (e.g. editors responsible for only one localization). Resolves: #29342 Releases: master Change-Id: Ibe070038ef66f876de38e47d6f82f4f090af96ce Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65549 Tested-by:
Sybille Peters <sypets@gmx.de> Tested-by:
-
Georg Ringer authored
The rendertype `InputLinkElement` renders a preview of the link since #28171. If a link to a page contains a fragment, this information has been added to the preview. Resolves: #92366 Releases: master Change-Id: I326fec85aa5bd535f675a435e8ea851fe96c892e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65801 Tested-by:
-
Oliver Bartsch authored
The EmailFinisher class evaluates the defined "translation language" which can be used to define the language of the mail content independent of the current frontend language. The corresponding option is however missing in the EmailToSender configuration. This leads to side effects if e.g. EmailToReceiver is configured with this option before EmailToSender. The EmailToSender finisher then automatically also uses this language without any possibility to prevent this behaviour. Therefore the missing configuration option for defining a translation language is now also available in the EmailToSender finisher configuration like already claimed in the documentation. Resolves: #92304 Releases: master, 10.4 Change-Id: Id81a5f616d439b4e4e844e270cadde3888ace46d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65733 Tested-by:
-
- Sep 21, 2020
-
-
Daniel Goerz authored
This patch removes the feature switch "rearrangedRedirectMiddlewares" and changes the default ordering of redirect middlewares. Resolves: #92352 Releases: master Change-Id: I3fe5d8eb8eaeb77c5502d5b87c8c457d7634f474 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65799 Tested-by:
-
Benjamin Serfhos authored
Releases: master Resolves: #91890 Change-Id: I64d7a355ca4e88b4f73c4cb46fce60ca7b0605c6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65317 Tested-by:
-
Ingo Fabbri authored
FileSpool uses GeneralUtility::mkdir_deep() if path does not exist. mkdir_deep() also tries to fix permissions. Even if this fails, there are further writable-checks down the line in \TYPO3\CMS\Core\Mail\FileSpool constructor. Resolves: #92303 Releases: master, 10.4, 9.5 Change-Id: I4d388ab458455eb1f940e0452fcde07967e1ca67 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65748 Reviewed-by:
Bernhard Berger <bernhard.berger@gmail.com> Reviewed-by:
-
Alexander Schnitzler authored
This patch fixes incompatible type usage in function arguments and is preparatory work for introducing native type hints and strict mode in all core files. Releases: master, 10.4 Resolves: #92274 Change-Id: Ia8e8fd47389dab32080fa82976d1c72aad5457c9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65668 Reviewed-by:
Sascha Egerer <sascha@sascha-egerer.de> Reviewed-by:
-
Alexander Schnitzler authored
This patch fixes incompatible type usage in function arguments and is preparatory work for introducing native type hints and strict mode in all core files. Releases: master, 10.4 Resolves: #92257 Change-Id: I686d520009ac4fed95127c2c6098109cbc91bf46 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65681 Tested-by:
-
- Sep 20, 2020
-
-
Oliver Bartsch authored
Instead of displaying the JSON value of the `crop` field, which has no value for editors, the otherLanguageContent wizard is replaced with a new wizard which renders cropped thumbnails for other languages by respecting the corresponding cropping configuration. Resolves: #77815 Releases: master, 10.4 Change-Id: I23ed0df13593330b303af1ec71f5a1c49476cf1e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65533 Tested-by:
-
Georg Ringer authored
To enable image manipulation from external images, the cross origin check is disabled. Resolves: #92224 Releases: master, 10.4 Change-Id: I7ed1366c488f019345f75be3ea300917a57db3d8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65686 Tested-by:
-
Christian Kuhn authored
When publishing workspace changes to live, many sys_refindex rows are not updated properly, especially if dealing with workspace-new or workspace-moved rows and relations. To update the reference index for relations, the data handler uses class ReferenceIndex, which uses class RelationHandler, which uses PlainDataResolver. All of these classes are workspace aware and pick the current user workspace if not explicitely told otherwise. When publishing records, a given user is currently in some workspace, but the reference index needs to be fixed for live. This explicit runtime workspace switch is lost in the ReferenceIndex. The patch hands over given workspace context from ReferenceIndex to RelationHandler during publish. This one-liner fixes tons of broken reference index cases. It also reveals a couple of still missing entries. Those will be tackled with another patch. Change-Id: Ib7647baad827fa8f148763efe91b331e5ad4484e Resolves: #92348 Releases: master, 10.4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65771 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
Benni Mack authored
Editors should never see the "editlock" field, which locks the record for editing of admins only. In order to achieve this, the fields pages.editlock and tt_content.editlock are changed to never be shown for non-admins and on top, the field is not shown in setting permissions within be_groups.allowed_exclude_fields anymore. Resolves: #87100 Releases: master, 10.4 Change-Id: I39b9212f0e955fd1a284b15014fcf00078cab16e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65694 Tested-by:
-
Christian Futterlieb authored
Requests to /favicon.ico should not stop rewrite processing. They could trigger a static route or could be handeled by an error handler. Change-Id: Iceff3719604f3d6a2ce2fe2a810cb33e7b4cebb2 Resolves: #92237 Releases: master, 10.4, 9.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65645 Tested-by:
Frank Nägler <frank.naegler@typo3.org> Tested-by:
Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by:
-
