Skip to content
Snippets Groups Projects
Commit f1bcb7e5 authored by Ingo Fabbri's avatar Ingo Fabbri Committed by Daniel Goerz
Browse files

[BUGFIX] Remove pre-checks on "transport_spool_filepath"

FileSpool uses GeneralUtility::mkdir_deep() if path does not exist.
mkdir_deep() also tries to fix permissions.
Even if this fails, there are further writable-checks down the line
in \TYPO3\CMS\Core\Mail\FileSpool constructor.

Resolves: #92303
Releases: master, 10.4, 9.5
Change-Id: I4d388ab458455eb1f940e0452fcde07967e1ca67
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65748


Reviewed-by: default avatarBernhard Berger <bernhard.berger@gmail.com>
Reviewed-by: default avatarBenni Mack <benni@typo3.org>
Reviewed-by: default avatarDaniel Goerz <daniel.goerz@posteo.de>
Tested-by: default avatarBenni Mack <benni@typo3.org>
Tested-by: default avatarDaniel Goerz <daniel.goerz@posteo.de>
Tested-by: default avatarTYPO3com <noreply@typo3.com>
parent 455f8ebf
Branches
Tags
No related merge requests found
......@@ -185,8 +185,8 @@ class TransportFactory implements SingletonInterface, LoggerAwareInterface
switch ($mailSettings['transport_spool_type']) {
case self::SPOOL_FILE:
$path = GeneralUtility::getFileAbsFileName($mailSettings['transport_spool_filepath']);
if (empty($path) || !file_exists($path) || !is_writable($path)) {
throw new \RuntimeException('The Spool Type filepath must be available and writeable for TYPO3 in order to be used. Be sure that it\'s not accessible via the web.', 1518558797);
if (empty($path)) {
throw new \RuntimeException('The Spool Type filepath must be configured for TYPO3 in order to be used. Be sure that it\'s not accessible via the web.', 1518558797);
}
$spool = GeneralUtility::makeInstance(FileSpool::class, $path);
break;
......
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment