Skip to content
Snippets Groups Projects
Commit 849d4c05 authored by Christian Kuhn's avatar Christian Kuhn Committed by Benni Mack
Browse files

[TASK] Local variable $resolvedIds in PlainDataResolver

Protected class member $resolvedIds is only used
in get(), so it can be turned into a local variable.

Resolves: #92379
Releases: master, 10.4
Change-Id: I889f1c9ac60b990da15f866603c441aecc16472d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65810


Tested-by: default avatarTYPO3com <noreply@typo3.com>
Tested-by: default avatarGeorg Ringer <georg.ringer@gmail.com>
Tested-by: default avatarBenni Mack <benni@typo3.org>
Reviewed-by: default avatarGeorg Ringer <georg.ringer@gmail.com>
Reviewed-by: default avatarBenni Mack <benni@typo3.org>
parent 091b642b
Branches
Tags
No related merge requests found
......@@ -67,11 +67,6 @@ class PlainDataResolver
*/
protected $keepMovePlaceholder = true;
/**
* @var int[]
*/
protected $resolvedIds;
/**
* @param string $tableName
* @param int[] $liveIds
......@@ -135,26 +130,22 @@ class PlainDataResolver
*/
public function get()
{
if (isset($this->resolvedIds)) {
return $this->resolvedIds;
}
$this->resolvedIds = $this->processVersionOverlays($this->liveIds);
if ($this->resolvedIds !== $this->liveIds) {
$this->resolvedIds = $this->reindex($this->resolvedIds);
$resolvedIds = $this->processVersionOverlays($this->liveIds);
if ($resolvedIds !== $this->liveIds) {
$resolvedIds = $this->reindex($resolvedIds);
}
$tempIds = $this->processSorting($this->resolvedIds);
if ($tempIds !== $this->resolvedIds) {
$this->resolvedIds = $this->reindex($tempIds);
$tempIds = $this->processSorting($resolvedIds);
if ($tempIds !== $resolvedIds) {
$resolvedIds = $this->reindex($tempIds);
}
$tempIds = $this->applyLiveIds($this->resolvedIds);
if ($tempIds !== $this->resolvedIds) {
$this->resolvedIds = $this->reindex($tempIds);
$tempIds = $this->applyLiveIds($resolvedIds);
if ($tempIds !== $resolvedIds) {
$resolvedIds = $this->reindex($tempIds);
}
return $this->resolvedIds;
return $resolvedIds;
}
/**
......
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment