- Jan 31, 2020
-
-
Sebastian Michaelsen authored
In template tree view the property path is now shown in the title attribute of each node to help the user orient and navigate through a deeply nested tree. Resolves: #90237 Releases: master, 9.5 Change-Id: I175c38eda3168c04e9d5f5b6d96a7bdc74121799 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63064 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Susanne Moog <look@susi.dev> Reviewed-by:
-
- Jan 30, 2020
-
-
Benni Mack authored
Within all refactorings, fetching the correct backend layout and relevant colPos information was still called via callUserFunction which is not needed at all, as it is a static information (class + method name) so a regular method call via PHP works just fine. Resolves: #90254 Releases: master Change-Id: I712e86b3a5d343bad3b4752a21dac9cbdc510f46 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63073 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Benni Mack authored
The so-called "singleton factory instance" is a wrapper around makeInstance which can be used directly anyways. With Dependency Injection this is not even necessary anymore, and should be avoided under all circumstances. The constructor does not cache anything, so this can be replaced completely. SingletonInterface + DI should be sufficient already. Resolves: #90260 Releases: master Change-Id: I964ddb90425b273c6e7588781c4b7e3fe39ddd18 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63076 Tested-by:
-
Daniel Siepmann authored
As `rowCount()` is not supported across all DBMS (e.g. sqlite). The logic is kept, but instead of relying on row count, the list of items is built first, and checked afterwards. Resolves: #90231 Releases: master Change-Id: Iad0dc46c507d300708c9bc9d53aad6d6840a3446 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63061 Tested-by:
Sybille Peters <sypets@gmx.de> Tested-by:
-
mehrlich authored
Resolves: #90252 Releases: master, 9.5 Change-Id: Ibacf2dab8a246bcb09f02be65765aa0760ba041b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63072 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
Ralf Zimmermann <ralf.zimmermann@tritum.de> Reviewed-by:
-
Benni Mack authored
Until TYPO3 v9, PageLayoutView was a subclass of AbstractDatabaseRecordList, so it inherited a lot of logic, which was never used in this class. The code can safely be removed, as PageLayoutView is only used in Page Module (web_layout) and Info Module ("Page Information"). Resolves: #90246 Releases: master Change-Id: Ie1fbd1fb2131d1b7d6dee9342a82f54c4dd5e563 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63069 Tested-by:
-
- Jan 29, 2020
-
-
Benni Mack authored
When commenting out the line SystemEnvironmentBuilder::initializeBasicErrorReporting() then Unit Tests run with notices, showing notices as errors. This happened due to recent updates of the TYPO3 testing framework v6. The fix to overcome this is https://review.typo3.org/c/Packages/TYPO3.CMS/+/62926 but the preferred clean ups are done beforehand. Resolves: #90245 Releases: master Change-Id: Ieb43f2f9524fb18c221b9c690de7116c994f5260 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63068 Tested-by:
-
Alexander Schnitzler authored
- Add phpdoc for variables to let phpstan know their type - Do not use ::class syntax for PHP 7.4 classes (yet) - Add missing class properties - Do not unset non-existing variables Releases: master Resolves: #90207 Change-Id: I01ae756c03f7dfc286bedd2577979e0d79ca3d9b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63039 Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
-
Daniel Siepmann authored
Children of $array in ArrayUtility::getValueByPath() may contain other datatypes than array, therefore check the datatype by is_array() before calling array_key_exists() in order to avoid a PHP warning. Resolves: #90241 Releases: master, 9.5, 8.7 Change-Id: Ibde8f854a28a0aef68ed33ed172299cb4e1ff2ca Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63066 Reviewed-by:
Stephan Großberndt <stephan.grossberndt@typo3.org> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
-
- Jan 28, 2020
-
-
Elias Häußler authored
Resolves: #90227 Releases: master, 9.5, 8.7 Change-Id: If905b071639844b9080e1ffd903a15cb211ed7f2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63055 Tested-by:
-
Daniel Siepmann authored
Resolves: #90232 Releases: master Change-Id: If9b030c8f984914d41482d0ab5fd7f94e1385b58 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63060 Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
Oliver Hader authored
Injects configuration to constructor directly, avoids using MockBuilder to define internal values (part of configuration). Resolves: #90230 Releases: master, 9.5 Change-Id: I7759b071192ed09572f3a7ed7e7779e51a4eb9f4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63058 Tested-by:
-
Manuel Selbach authored
With this change the wrong introduced type hint will be changed and enriched with some detail information. Resolves: #90223 Releases: master Change-Id: I3437889fb355571c88f1902b217faf11d56dd158 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63052 Tested-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Tested-by:
-
Oliver Hader authored
Changes concerning route `defaults`: + defaults are mapped now (e.g. `1` <=> `one`) + defaults are applied now when having multiple parameters in a route path (e.g. `{default}/{required}` + defaults are applied now for types `Plugin` and `Extbase` (type `Simple` worked in most cases) + enforced defaults are considered now (e.g. `{!default}` + `Route` instances get `_appliedDefault` option set now - which contains deflated values and still needs to be inflated manually Changes concerning route `requirements`: + requirements are deflated now for being processed as Symfony routes (resulting in requirements being correctly applied now in enhancers) + requirements are skipped now for parameters having corresponding aspects defined ("aspects take precedence over requirements") References: + https://symfony.com/blog/new-in-symfony-4-3-always-include-route-default-values + https://symfony.com/doc/4.3/routing.html#parameters-validation + https://symfony.com/doc/4.3/routing.html#optional-parameters Resolves: #86895 Releases: master, 9.5 Change-Id: Ia260e407dcc657a2e7c85628da9e001d94952c37 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62885 Tested-by: -
Elias Häußler authored
The new TypoScript condition `tree.rootLineIds` which was introduced with #88962 is currently not documented in the original feature RST where the new symfony expression language was introduced. In order to keep the list of available TypoScript conditions up to date in this document, the new condition was added accordingly. Additionally, some minor code highlights were fixed in the document. Related: #90221 Releases: master Change-Id: Ib7aef851d10361b9de124cb55ba8a005d1b2d6c4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63050 Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
-
- Jan 27, 2020
-
-
Christian Eßl authored
If a TCA field config of type="none" with the l10n_mode="exclude" is present, the DataHandler will try to persist the field when saving a translated version of the record, even though fields of type="none" must not be persisted. Resolves: #87781 Releases: master, 9.5 Change-Id: Ie99495ff95fcf1ceaac0c5d050653e21d3af2afd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61960 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
Henning Liebe <h.liebe@neusta.de> Reviewed-by:
Felix P. <f.pachowsky@neusta.de> Reviewed-by:
Steffen Frese <steffenf14@gmail.com> Reviewed-by:
Tobi Kretschmann <tobi@tobishome.de> Reviewed-by:
Sascha Rademacher <sascha.rademacher+typo3@gmail.com> Reviewed-by:
-
Benni Mack authored
The public property in ReferenceIndex->WSOL was removed in 2006 and documented like that, but it has no effect, as it was never evaluated since 14 years. This property is removed, as the recommended way is to use the ->setWorkspaceId() anyway since a few years. Resolves: #90217 Releases: master Change-Id: Ib3b58c6823ec78cb0b51f19b104aa80186f0dfe6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63047 Reviewed-by:
-
Michael Stucki authored
If the language synchronization process is called on an inline relation within another inline relation when there is more than one language which should be synchronized, the process fails with the following exception: #1486233164: Child record was not processed The problem happens because of a non-unique cache identifier which leads to incomplete operation. Resolves: #81314 Resolves: #85168 Resolves: #85914 Releases: master, 9.5, 8.7 Change-Id: Icbfc96e5dae387b620e917db168e9e14de5f3820 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60722 Tested-by: -
Claus Due authored
The newly added class \TYPO3\CMS\Backend\View\PageLayoutViewDrawEmptyColposContent incorrectly assumes that colPos values are always strings when they may very well be integers. This patch casts the possibly-integer value to string before use of trim(). Releases: master Resolves: #90211 Change-Id: I8fb145c76f2bd6b0bca187be3b4c5b05fd3c3d80 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63044 Tested-by:
-
- Jan 26, 2020
-
-
Elias Häußler authored
A new TypoScript condition `workspace` has been added which allows checking of several workspace parameters against a given expression. Currently, only workspace id and state can be used within conditions. Example: [workspace.workspaceId === 0] # This matches if the current workspace id equals 0 [end] [workspace.isLive] # This can be used to check if the current workspace is live [end] [workspace.isOffline] # This can be used to check if the current workspace is offline [end] Resolves: #90203 Releases: master Change-Id: I4113fc31e28c2d187f2398cc346088144d621639 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63035 Tested-by: -
Alexander Schnitzler authored
Method FormViewHelper::renderRequestHashField isn't in use any more since removing the old Extbase property mapper in TYPO3 version 6.2. Back then it was forgotten to remove said superfluous method. Releases: master Resolves: #90206 Change-Id: I2f1ae48d182718aef9fb2ae972f9b1d34909e21f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63038 Tested-by:
-
- Jan 25, 2020
-
-
Andreas Fernandez authored
The grunt module `grunt-newer` is introduced to act with changed files only instead of copying or minifying all files all the time. Used command: yarn add --dev grunt-newer Resolves: #90200 Releases: master Change-Id: Idcf34b402f089757a5b5209398abec1bba3288a2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63031 Tested-by:
-
Andreas Fernandez authored
Since ECMAScript brings some nice features in later releases (e.g. native support for async / await), we upgrade our build chain to use ES2017. This removes a lot of polyfills introduced by TypeScript and it's considered safe to upgrade the used ES standard as all browsers supported by TYPO3 support this standard as well. Resolves: #90199 Releases: master Change-Id: I6d8257a368a3eb51e2fff4f7610c7826f209c7e7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63026 Reviewed-by:
-
Kevin Appelt authored
By loading the uncached site configuration, no direct changes to the configuration files are overridden when using the Site management module. Resolves: #89492 Releases: master, 9.5 Change-Id: I4ef3ac08692e709fc2953bc17b5759d6f55f463f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62090 Tested-by:
-
Elias Häußler authored
With patch #88962 an obsolete expression has been introduced within the ConditionMatcher class which is now removed. Resolves: #90201 Related: #88962 Releases: master Change-Id: I8911ae8fad5e725d70d968e4250ccfcda87246c4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63033 Tested-by:
-
Philipp Parzer authored
The missing rendering for the fieldControl option for `SelectSingleElements` was added. It is now possible to use the fieldControl option for SelectSingleElements to add nodes and wizards. Resolves: #89032 Releases: master Change-Id: Ie0d3bcb848eba0e068f29c2e659df265f7b25f81 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61566 Tested-by:
-
Sybille Peters authored
If someone returns to the list of broken links after editing a record, the record must be checked again to refresh the list of broken links. Resolves: #83847 Releases: master Change-Id: Ica70f900093fdf5697569f85cea299d923723d13 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/57131 Tested-by:
Jonas Eberle <flightvision@googlemail.com> Tested-by:
-
Andreas Fernandez authored
If the AJAX API receives a pre-composed URL with a path in front, the current location of the document is now prepended. Resolves: #90198 Releases: master Change-Id: I94dcd12f83016ad1604e64f0e3d9bc6e61be5605 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63030 Tested-by:
-
Andreas Fernandez authored
Action buttons in modals created by the `TYPO3/CMS/Backend/Modal` module may now make use of `ImmediateAction` and `DeferredAction`. As an alternative to the existing `trigger` option, the new option `action` may be used with an instance of the previously mentioned modules. A similar feature has been introduced with #89061 for notifications. This patch also implements the feature in the recycler module. Resolves: #90168 Releases: master Change-Id: I3fde2ced31e6bd2b0779524c0aeead17a2edaa49 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63008 Tested-by:
-
Manuel Selbach authored
This change separates database requirement checks regarding the DBMS platform (e.g. MySQL, PostgreSQL, ...) from drivers as checks for specific drivers may differ (e.g. pdo_mysql requires other PHP extensions being loaded than mysqli). Additionally the encoding for the database is defined in \TYPO3\CMS\Core\Database\Platform\PlatformInformation which will be enforced during the install process of the Install tool. Resolves: #89794 Releases: master Change-Id: I45ff0c57c3af30af0aff349520a0dbea3937eccd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62472 Tested-by:
-
András Ottó authored
Remove an old hotfix entirely because CKEditor seems to work without this settings but this caused an accessibility issue for the backend forms Resolves: #89605 Releases: master, 9.5 Change-Id: Ie288e6971719aa94da2972f2ea46495e4f0cd728 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62827 Tested-by:
Michael Telgkamp <michael.telgkamp@mindscreen.de> Tested-by:
Torben Hansen <derhansen@gmail.com> Tested-by:
-
Benni Mack authored
ContextMenuActions has the field "hidden" hard-coded which does not work in e.g. backend user module, where the field is called "disabled". The RecordProvider now evaluates this and adds this as a separate data attribute which is evaluated in JavaScript now. Resolves: #89939 Releases: master, 9.5 Change-Id: Ife22f229805d9bc06bd57b503f1131a815fb0691 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62953 Tested-by:
-
- Jan 24, 2020
-
-
Markus Klein authored
This patch adds more sanity checks to the SplitButton when rendering its items. Specifically the existence of getters is checked if those are not part of the AbstractButton already. Resolves: #89729 Releases: master, 9.5 Change-Id: I654238e1c9d606596348119374ac283dda1c1713 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62360 Tested-by:
Johannes Kasberger <johannes.kasberger@reelworx.at> Tested-by:
-
Andreas Fernandez authored
Resolves: #90193 Releases: master Change-Id: I6e263dabffc3172ec48d55e2148e7d5b087b6b29 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63023 Reviewed-by:
-
Benni Mack authored
The extension manager now extracts an uploaded file + folder and sets the configured permissions again. Resolves: #90118 Releases: master, 9.5, 8.7 Change-Id: Ic71380cb5227e7cab651877f9033f48f445aca3c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62999 Tested-by:
Frank Nägler <frank.naegler@typo3.org> Tested-by:
-
Dmytro Nozdrin authored
Checkboxes that are placed in sections in BE forms have the same HTML identifiers. As a result it is not possible to check one checkbox in one section without affecting the same checkboxes in other sections. The fix makes identifiers unique. Resolves: #87429 Releases: master, 9.5 Change-Id: Ia5cd88aecb2af12a83f40d39a8b450f5cde09060 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60362 Tested-by:
-
Andreas Fernandez authored
Resolves: #90192 Releases: master Change-Id: I57c0bc9343ca9a203bb8839c823ccf25ee423f25 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63022 Tested-by:
-
Andreas Fernandez authored
This patch makes use of the AJAX API in the slug update revert handling. This also fixes a bug where the notification box disappears directly once a revert action has been clicked. Resolves: #90173 Releases: master Change-Id: I731ad2ac2ea6b649a1a9ab4dfcef2022c6ca7e19 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63015 Reviewed-by:
-
Elias Häußler authored
The TypoScript condition matcher is now able to match pages up in the root line as the old "PIDupinRootline" behavior was. By using the new "tree.rootLineParentIds" expression, one can check if a given page is part of the root line but not currently on the requested page. Example: [30 in tree.rootLineParentIds] ... [end] This is basically the same as: [30 in tree.rootLineIds && page["uid"] != 30] ... [end] Resolves: #88962 Releases: master Change-Id: I15311b39db5d03ad2541377426898c228c86ae53 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61500 Tested-by: -
Markus Klösges authored
When searching cache-identifiers by tag, the Typo3DatabaseBackend now utilizes DBMS functions for de-duplication of identifiers instead of fetching all records and de-duplicate them afterwards in php space. This dramatically reduces memory usage, when many duplicated identifiers are in a cache table for any given tag. Note that there is no noticable impact whenever there are no duplicates at all, as the DBMS handles the de-duplication. Releases: master, 9.5 Resolves: #89997 Change-Id: Ia28deee1e02eec9792dc4b0d4ce41e2177fcadf4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62749 Tested-by:
-
