- Sep 20, 2023
-
-
Oliver Bartsch authored
Instead of manually resolving the path of the processed thumbnail image, use FAL API "getForLocalProcessing". This prevents wrong paths when using storages with "baseUri" set. Resolves: #101968 Related: #82855 Releases: main Change-Id: I08d4b64c115ca7ecdab8233b36de801e22109e9f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81099 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
-
Oliver Bartsch authored
Due to another couple of use cases, the necessary fields to generate the record title, used in the "record saved" notification in FormEngine, are now always fetched, if not already present. Additionally, it's now ensured that the "uid" is always available, since it is necessary for labels with foreign table lookups. Resolves: #101964 Releases: main, 12.4 Change-Id: I933211f582e31c7af9fea909075420316a81a544 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81095 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
Benni Mack authored
This change is a overhaul of the LocalDriver class after 12 years. All comments are updated, types are added, where possible. Resolves: #101468 Releases: main Change-Id: Ie639d352415a67a8f4d499913b5c30f8d6e1b33b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81041 Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Andreas Nedbal authored
A lot of the methods implemented in GraphicalFunctions are only used in GifBuilder, thus it makes sense to move them into that class. This also coincides with most of these methods utilizing GDlib while the remaining methods in GraphicalFunctions now mostly access and work with Image/GraphicsMagick. In addition, some helper methods are in place in order to keep the existing logic in the installer available to verify image generation. In the long term, a new API is introduced to utilize base methods for GDLib and ImageMagick into separate classes by encapsulating the actual commands, whereas GifBuilder will remain the "TypoScript" entrypoint to work with Images from cObjects. Resolves: #101955 Releases: main Change-Id: If22cf3800effc5a3a11a8bf9f224f91ba6225d64 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81089 Reviewed-by:
Andreas Nedbal <andy@pixelde.su> Tested-by:
-
Stefan Froemken authored
Deleting a missing file will not throw exception "InsufficientFileWritePermissionsException" anymore, as a missing file has nothing to do with insufficient file permissions. Preventing that exception allows calling the event "FileDeletionAspect" to remove remaining file related records. Resolves: #101725 Releases: main, 12.4 Change-Id: I272466a47a67358ec4e09cc73d2ffec1339f1b64 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80613 Tested-by:
-
Oliver Hader authored
This change uses the dependency ordering service in the method `\TYPO3\TestingFramework\Core\Testbase::setUpPackageStates` for test scenarios in functional and acceptance tests. Besides that the following changes were applied: * remove invalid dependency in fixture ext:test_configoverride_second * add `PackageStatesTest` to keep track of extension dependencies * add dependency to ext:frontend in ext:form, since it overrides TCA for the tables tt_content and sys_template (which would result in different ext:impexp results due to table field orderings) * recreate IRRE related XML fixtures for ext:impexp since fixture extensions are now ordered alphabetically (and due to #100734) Resolves: #101809 Releases: main, 12.4 Change-Id: I1f91a75ac8aec9db0291b0f5c8bcf7162d5b0082 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81076 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Benjamin Kott authored
Resolves: #101953 Releases: main, 12.4 Change-Id: I1b0d715a96ee914dc8f9787089406457b750df2e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81086 Reviewed-by:
Benjamin Kott <benjamin.kott@outlook.com> Reviewed-by:
-
Anja Leichsenring authored
Tables with TCA columns set to type="group" do not need an ext_tables.sql entry anymore. The core now creates this field automatically. This is one of many patches in this area: The v13 goal is to obsolete ext_tables.sql in most cases by creating default "business" fields of TCA tables automatically. The patch adds the main magic in class DefaultTcaSchema and removes own ext_tables.sql definitions having type=group. Resolves: #101908 Related: #101553 Releases: main Change-Id: I355b1e83c367c08e7c0e6428e563798aa49fe766 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80990 Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
- Sep 19, 2023
-
-
Benni Mack authored
When the crop object is serialized in a wrong manner or does not contain all information. In order to avoid PHP errors, the casting is done so the page still gets rendered. Resolves: #93138 Releases: main, 12.4, 11.5 Change-Id: Ia71dc81363c519a663c9cc91e2f0f200e7570832 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81079 Reviewed-by:
-
Oliver Bartsch authored
A new controller is added, which allows to update Metadata of online media assets. This basically updates the preview image and some basic data like author and the assets dimensions. To trigger the update, a new action is available in the context menu and the secondary dropdown of online media assets. The functionality can be extended in the future to update further information like the asset's title. However, this needs some more considerations, because an editor might already changed the title intentionally. Resolves: #82855 Releases: main Change-Id: Iba82400c582de0d4e7b2d4eab219a86bc4830be6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81083 Reviewed-by:
Jochen Roth <rothjochen@gmail.com> Reviewed-by:
Sebastian Tittel <sebastiantittel@mail.de> Reviewed-by:
-
Stefan Froemken authored
This introduces a new "Edit Metadata" button to the element information view of files, allowing to directly edit the file's Metadata without losing the context. Resolves: #99165 Releases: main Change-Id: Ie32d3bdb31013c195f0efc58cb830c35c6d64a9c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76769 Tested-by:
-
Benni Mack authored
GifBuilder is currently a subclass of GraphicalFunctions. Some places only use logic of GraphicalFunctions, even though GifBuilder is instantiated. This patch adapts these places. Resolves: #101956 Releases: main Change-Id: I437d2836ca8d4ae930e6655bd8da268b0db01ec2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81088 Tested-by:
-
Benni Mack authored
FileProcessingService and its surrounding code within File / FileReference / ResourceStorage and ProcessedFileRepository was hinted to use "FileInterface" which is technically wrong, and - if used - throws a PHP 8 warning because the ProcessedFileRepository checks for the "uid" which is not present in a FileInterface (only for FileReferences, File and ProcessedFile objects). Since it is technically not possible to process a processed file due to the DB relations, this code is now using the correct type hints to avoid PHP errors. In addition, the FileProcessingService is now made DI-aware, so it can injected all necessary services. As this is part of a series to clean up types within FAL in v13, the PHP method signature changes will be documented in a separate commit. Resolves: #101943 Related: #101945 Releases: main Change-Id: I2727cbe12d9f9b507428088ae2c4075af5e90670 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81075 Tested-by:
-
Andreas Nedbal authored
This setting stems from an even older setting called 'im_mask_temp_ext_gif' which was introduced because of issues with PNG file generation with some earlier versions of ImageMagick 5. TYPO3 requires at least ImageMagick 6 or newer in recent versions, where PNG generation issues couldn't be observed using this setting. It's obsolete and removed. Resolves: #101950 Releases: main Change-Id: I4d6fd01591c1f36fe22e4019392ffdab2be908a9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81084 Tested-by:
-
Christian Kuhn authored
Last usage of <INCLUDE_TYPOSCRIPT is the testing framework. To allow switching to @import, we switch to remaining places to "EXT:" syntax which is allowed in @import as well. Resolves: #101952 Releases: main Change-Id: I434b55db1fc95b7648008a2dacea36d7e565ce86 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81085 Tested-by:
-
Benni Mack authored
When FAL was introduced in TYPO3 v6.0, some concepts were introduced which aren't so smart, 11 years later. * Building an AbstractRepository * Using Extbase RepositoryInterface in FAL repositories The shared code between the two implementing classes, FileRepository and AbstractFileRepository isn't justified to use an AbstractRepository which dynamically creates objects through inheritance for its subclass repositories. Instead, the AbstractRepository is now removed and both FileRepository and ProcessedFileRepository are now free, and can also use DI in a way it was meant. For this reason, the whole AbstractRepository class within the "TYPO3\CMS\Core\Resource" namespace is removed along with the dependency to Extbase in this regard. FileRepository and ProcessedFileRepository now only contain the methods they require, and all methods and properties are fully typed. Resolves: #101948 Releases: main Change-Id: I5a1f1fb899e94836cb16c85c2048df264fd59813 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81081 Tested-by:
Göran Bodenschatz <g.bodenschatz@ecentral.de> Tested-by:
-
Christian Kuhn authored
There is no point in having namespace declarations in those config files. Releases: main Resolves: #101944 Change-Id: Iccb97731a1e66a45c12d69c01f85def74073f0cc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81077 Tested-by:
-
Anja Leichsenring authored
Tables with TCA columns set to type="language" do not need an ext_tables.sql entry anymore. The core now creates this field automatically. This is one of many patches in this area: The v13 goal is to obsolete ext_tables.sql in most cases by creating default "business" fields of TCA tables automatically. The patch adds the main magic in class DefaultTcaSchema. Resolves: #101915 Related: #101553 Releases: main Change-Id: I8f23278df9aa1991fc4744c3e63ef9689543fd97 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81017 Tested-by:
-
Oliver Hader authored
This change extracts dynamic stylesheets of web components that are attached to the light DOM to a corresponding static file in the directory `Build/Sources/Sass/element/` (it will be merged to `backend.css` during the build process). This change allows to get rid of the `window.litNonce` helper function that was introduced to allow CSP for dynamic styles. Besides that, the shadow DOM component `typo3-backend-spinner` now uses constructed stylesheets directly. In addition, the missing component names have been added to the global map. Resolves: #101744 Releases: main, 12.4 Change-Id: I7cf3cdc31d0ffe685897e48f000f18e9b5b5aca6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80664 Tested-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
-
Benjamin Kott authored
To support the right to left reading mode for languages like Arabic, we have adjusted the styles in the backend to use logical instead of physical properties. Resolves: #101902 Releases: main, 12.4 Change-Id: I60936682fbeeb35c676f157e63135137b03106e7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80986 Reviewed-by:
-
- Sep 18, 2023
-
-
Oliver Bartsch authored
FileStorageTreeProvider now considers all file mounts, a user (non-admin) has access to, for the file and folder search in the folder tree. Resolves: #98423 Releases: main, 12.4 Change-Id: Id58665392b4351d0c5ecb46335097027f6bf139e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81072 Reviewed-by:
-
Simon Gilli authored
Support for FAL references in FlexForms is added to the FlexFormProcessor. No additional processing is needed anymore to resolve FAL references. Resolves: #94501 Releases: main Change-Id: If3e3355f1dda497be5d7f498b9df85cb56de96d0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69753 Reviewed-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
-
Oliver Bartsch authored
The @internal update() method of MetaDataRepository now checks the data to be updated against the current database row, preventing updating of the records timestamp in case no actual update needs to be done. Additionally, the method now returns the database row. Resolves: #97775 Releases: main, 12.4 Change-Id: I1429605880ec815deb1d6111bc6b1686558b6f5b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81046 Tested-by:
-
Benni Mack authored
TYPO3's powerful image manipulation has some legacy functionality which is outdated nowadays. They aren't considered best practices anymore, and are removed: * $TYPO3_CONF_VARS[GFX][thumbnails_png] * $TYPO3_CONF_VARS[GFX][gif_compress] * TypoScript GIFBUILDER.reduceColors Reducing colors in GIFs or using GIFs instead of PNGs were used back then in the 2000's era of the web to save bandwidth in favor of quality, whereas new websites use optimized images already. Having these options serve only little use and can be removed, as compression can be done on the webserver-level already. The relevant PHP code is also removed. Resolves: #101941 Releases: main Change-Id: Idff1d5adc15b51de25a132d27bba761f5dcb9778 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81073 Reviewed-by:
-
Anja Leichsenring authored
Tables with TCA columns set to type="imageManipulation" do not need an ext_tables.sql entry anymore. The core now creates this field automatically. This is one of many patches in this area: The v13 goal is to obsolete ext_tables.sql in most cases by creating default "business" fields of TCA tables automatically. The patch adds the main magic in class DefaultTcaSchema and removes own ext_tables.sql definitions having type=imageManipulation. Resolves: #101914 Related: #101553 Releases: main Change-Id: I798a6549b1bdc1118cd69c02ccfb90cef0d9b8df Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81016 Reviewed-by:
-
Oliver Klee authored
If the flexforms data is null, there is no point trying to parse that as XML. This avoids type errors when `GeneralUtility` gets native parameter type declarations for `GU::xml2array`, and it should also slightly increase performance. Also fix the corresponding PHPDoc type annotation to reflect that a parameter in reality needs to be nullable. Resolves: #101891 Releases: main, 12.4, 11.5 Change-Id: I39efc1d26300634c0bed74aee1f7ebd444acb8c0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80939 Tested-by:
-
Oliver Bartsch authored
When copy a file corresponding metadata are now also copied, preserving existing properties like "file" or "uid". Resolves: #70934 Releases: main, 12.4 Change-Id: Ifbc15b1ad2f1baaba48edbc5299d3b89e2755a53 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81042 Tested-by:
-
Sybille Peters authored
Improve selection of Linkvalidator linkypes checkboxes form by adding a "Toggle all" checkbox as is already used in FormEngine `selectCheckBox` renderType. This improves the usability of the form and makes multiple clicks unnecessary. Resolves: #101674 Releases: main Change-Id: I8e15cd9765590352804e4b2eacc7f879510cb681 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80542 Tested-by:
-
Torben Hansen authored
The current icon on the password reset button in ext:beuser does not clearly visualize the functionality behind the button. Besides that, the same icon is used in several other places in TYPO3 on buttons, which most likely have either undo or revert functionality. This patch replaces the current icon with the `actions-key` icon, which might raise more awareness to the user, that the functionality behind the button has something to do with the user password. Resolves: #101932 Releases: main Signed-off-by:
Torben Hansen <derhansen@gmail.com> Change-Id: I7a42c1592736825f5ebf541ee9b67a6357cd4d12 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81032 Tested-by:
-
Philipp Kitzberger authored
Resolves: #96537 Releases: main, 12.4, 11.5 Change-Id: I0b2b4dbf47d58f21df8ffb3d91a889c22b092280 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80982 Tested-by:
-
Georg Ringer authored
Resolves: #101925 Releases: main, 12.4, 11.5 Change-Id: Icec9f634ca1e1a9c7ad6b3a55afaf197cfa44acc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81027 Tested-by:
Sybille Peters <sypets@gmx.de> Tested-by:
-
Georg Ringer authored
Resolves: #101730 Releases: main, 12.4, 11.5 Change-Id: I9e400e1c582f84602b6aa8ef3cdd9a85f4e5b93e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80973 Tested-by:
-
Sybille Peters authored
- Add unit tests for function ContentObjectRenderer::listNum() - Improve code by renaming function argument ($char => $delimeter) - Make sure arguments are always passed as strings (and not null) (as declared in PHPDoc) - Improve clarity of description in PHPDoc In the future typehints can be added for function arguments and return type. Resolves: #101934 Releases: main, 12.4 Change-Id: Ic748d74350d5ff629e8a292dc058bb93ed167448 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81034 Tested-by:
-
Oliver Bartsch authored
Resolves: #101940 Releases: main, 12.4 Change-Id: Ib8cc5c5bfc886686c1abfe5ed35724e1e268e800 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81039 Reviewed-by:
-
Oliver Bartsch authored
Resolves: #101939 Releases: main Change-Id: If21ed22673acbf2aced0121908a15decd9560323 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81038 Reviewed-by:
Chris Müller <typo3@krue.ml> Tested-by:
-
Benjamin Kott authored
Resolves: #101860 Releases: main, 12.4 Change-Id: I069355cf87eaf46ff849367e2870cf51fb44c726 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80884 Reviewed-by:
-
Andreas Fernandez authored
With migrating the color picker to alwan in #101646, the usage broke for any case where the color picker was not used in FormEngine, e.g. extension configuration. This patch moves some FormEngine-related code into the `@typo3/backend/form-engine/element/color-element` module. Resolves: #101865 Related: #101646 Releases: main Change-Id: I08ac1b9aad9ad57fc6b2a56c460c88dde1088c7d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80891 Reviewed-by:
-
Daniel Siepmann authored
Resolves: #101938 Releases: main, 12.4 Change-Id: I8def061d7188a4d247a832247c01cdddd745c7dc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81037 Reviewed-by:
-
Benjamin Franzke authored
Make sure that all imports are from the package entry point instead of the path to a module as suggested by upstream: https://ckeditor.com/docs/ckeditor5/latest/updating/guides/update-to-37.html Note: `LinkActionsView` still needs to be imported from `@ckeditor/ckeditor5-link/src/ui/linkactionsview.js` and `LinkUtils` from `@ckeditor/ckeditor5-link/src/utils.js` as they are not exported as named exports on the package entry points. Resolves: #101916 Releases: main, 12.4 Change-Id: I3171fd44c99984dc9a768122fe2297e1b7b6106f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81012 Tested-by:
-
Benjamin Kott authored
The report overview was adjusted to match other already existing entrypoints like the about module. In the form framework the class is simply dropped as it provided no additional benefit. Resolves: #101926 Releases: main, 12.4 Change-Id: I02341658b69ef5a2a24df507d7df2e78658caef6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81028 Reviewed-by:
-
