- Jun 05, 2024
-
-
Jasmina Ließmann authored
In single result view of the "Indexing" backend module, the words found on the page are listed in three tables, each sorted by count, frequency and name. This patch removes the tables "Words by top count" and "Words by frequency" and extends the remaining table to sort by table columns "Word", "Word count" and "Frequency". If no words were found, an info box is now displayed. Resolves: #103727 Releases: main Change-Id: I5b11b9b455452bafc969baa5f246f67101a3a02a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84023 Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
core-ci <typo3@b13.com>
-
Garvin Hicking authored
The TYPO3 Contribution Guide lists DDEV as an easy way to get started with a TYPO3-Core legacy-based installation. The installation itself shows a big warning for the "Trusted Host Pattern" mismatch when utilizing https:// for the installation, which many people might do. While the Contribution Guide mentions this as a sidenote, the actual warning can be improved to better reflect the reason and solution. (Note that the installation can actually continue even with this error, but may hint people at this being an installation show-stopper, so it is now stated clearer, that a working host pattern will be actually set and should be adjusted after installation is complete) Resolves: #103959 Related: #88846 Related: #86356 Releases: main, 12.4 Change-Id: I7988a7dad45b53d5b1c8314e1dfdcbc1d8feb6a5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84450 Tested-by:
Jonas Eberle <flightvision@googlemail.com> Reviewed-by:
Mathias Bolt Lesniak <mathias.bolt.lesniak@typo3.org> Reviewed-by:
Lina Wolf <112@linawolf.de> Tested-by:
-
Marcin Sągol authored
It might not be clear to users how the allowed_languages field works by default when setting permissions for a backend user or group. If no languages are selected from the allowed_languages list, all languages will be available for the given user or group. To make this clearer, a description has been added to explain it straightforwardly. Resolves: #103757 Releases: main, 12.4 Change-Id: If0c0fd9c998f51a0e44617faae3365f2e02bc82e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84078 Tested-by:
Torben Hansen <derhansen@gmail.com> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Guido Schmechel <guido.schmechel@brandung.de> Tested-by:
Thomas Hohn <tho@gyldendal.dk> Tested-by:
-
Christian Kuhn authored
Sometimes - for unknown reasons - a session gets lost in acceptance tests. Tests then hang in BE login waiting for BE load and fail with a timeout. We now catch this timeout and relogin, and also enable cookie debug output to increase chances to fix the real issue. Resolves: #103981 Related: #103086 Releases: main, 12.4, 11.5 Change-Id: I0b10118968933b52523bbee8f8f608db60ad884e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84499 Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
-
Christian Kuhn authored
Frontend TypoScript 'constants' do support conditions. But constants can not be used within conditions, just like constants in general can not be used within constants. The patch adapts the "new TS parser" ReST to clarify. Resolves: #103953 Related: #97816 Releases: main, 12.4 Change-Id: I0e21a320582f2f0edbde432fe36767540ab7993b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84497 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
-
Garvin Hicking authored
We missed a TypoScript feature with the new parser. Function operator modifier values can use constants: foo = 42 foo := addToList({$my.constant}) The solution is two fold: Until now, the value of a function body was a single T_VALUE token. This is turned into a stream of tokens that can consist of multiple T_VALUE and T_CONSTANT tokens. This is handled in the tokenizers. Secondly, the AST builders need to deal with these token streams now, and take care available constants are hand over to ConstantAwareTokenStream before the stream is cast to string and single functions are evaluated. The BE modules *do* reflect constant substitutions in function modifier bodies, but not in an ideal way. An @todo within the responsible CommentAwareAstBuilder outlines ideas how this could be improved. Note TYPO3 v13 supports constant fallbacks here as well, this syntax feature came with #103671. This works, but is NOT supported in v12: foo := addToList({$my.constant ?? $fallback.constant}) Resolves: #102742 Related: #97816 Related: #103671 Releases: main, 12.4 Change-Id: Ib5e0872fe1ea2b78bd0a7e05caccd9874b5668d4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82633 Tested-by:
-
- Jun 04, 2024
-
-
Christian Kuhn authored
There is a subtle difference between a PHP error and a dedicated thrown exception: When an object knows it should return something, but can't, because it has not been set up correctly, then the implementation is responsible of throwing a "i'm incomplete" exception: This is not an error in the class, but a wrong set up usage, and this should throw, and should not error out with a return type mismatch error. The patch changes two getters of TS parser related IdentifierFunctionLine to obey this difference and now throws in case it "has been set up incompletely". In this case, an IdentifierFunctionLine is only "complete" after at least an identifier token stream and a function name token has been set: After being fully set up, these two properties must have a value. The object knows this and the two getters now throw an exception instead of failing with a type error. Resolves: #103977 Related: #97816 Releases: main, 12.4 Change-Id: I772d774fbaae3c2ec7ff4c9abc6ef4964254259d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84495 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Christian Kuhn authored
Add a missing return value in ConstantAwareTokenStream->setFlatConstants(). Resolves: #103976 Related: #97816 Releases: main, 12.4 Change-Id: Ia4d10f846db2bf26f721c5eb03781d3592073a08 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84493 Tested-by:
-
Christian Kuhn authored
The 'original value token stream' is a helper used in BE TypoScript modules to render a possible constant substitution. It is enough if the CommentAwareAstBuilder handles this, which is used in those cases: getOriginalValueTokenStream() is only called by fluid as 'child.originalValueTokenStream' when rendering TS trees in the backend. Those use CommentAwareAstBuilder and not "production" AstBuilder. The patch avoids calling setOriginalValueTokenStream() as a minor micro optimization which may also help the garbage collection to clean up some objects more early in FE. Resolves: #103975 Related: #97816 Releases: main, 12.4 Change-Id: Ifa54b36877d5eb1c1d712433efa2d07fd1ad8bd8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84491 Tested-by:
-
Andreas Kienast authored
This commit updates the markup of the `Cards.html` files to make use of containers in the Install Tool to align its cards horizontally to make better use of the available space. Resolves: #103621 Releases: main Change-Id: Icad70957dc2565bc3830e9101d9fea4ce1798104 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83778 Tested-by:
-
Andreas Kienast authored
The stylesheet loading process in IRRE was kept for several years and moved from version to version. A recent change in #103375 migrated a usage of `delete` to `.splice()`, breaking stylesheet loading as the original iterated object was modified. Since the code was quite dated and had other potental bugs, the whole loading sequence has been transformed to functional programming style to reduce complicated, potentially error-prone, array operations. Resolves: #103971 Related: #103375 Releases: main, 12.4 Change-Id: I18caafc68ceebce53723b7208270043faafc7458 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84487 Tested-by:
rogier Helmer <rogier.helmer@maxserv.com> Tested-by:
-
Anja Leichsenring authored
Additional potential functionality (DI, XClass resolving, etc.) of GU::makeInstance is usually not a wanted behaviour in unit tests. For creation of system under test `new` should be used. Dependencies, if necessary, should be mocks. This patch reduces the obvious cases, more complicated ones will be tackled with follow ups. Resolves: #103902 Releases: main, 12.4 Change-Id: I07cbe6f10fe11e1239cdd5f0fe7496948eed5a44 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84386 Tested-by:
-
Andreas Kienast authored
This commit updates ckeditor to 41.4. See changelog at [1]. Executed commands: # Override ckeditor5 package to avoid pulling in all/too # many available packages. See: # https://github.com/ckeditor/ckeditor5/issues/16360 npm --prefix overrides/ckeditor5 version 41.4.2 npm install --save ./overrides/ckeditor5 npm install --save \ @ckeditor/ckeditor5-alignment@^41.4.2 \ @ckeditor/ckeditor5-autoformat@^41.4.2 \ @ckeditor/ckeditor5-basic-styles@^41.4.2 \ @ckeditor/ckeditor5-block-quote@^41.4.2 \ @ckeditor/ckeditor5-clipboard@^41.4.2 \ @ckeditor/ckeditor5-code-block@^41.4.2 \ @ckeditor/ckeditor5-core@^41.4.2 \ @ckeditor/ckeditor5-editor-classic@^41.4.2 \ @ckeditor/ckeditor5-engine@^41.4.2 \ @ckeditor/ckeditor5-essentials@^41.4.2 \ @ckeditor/ckeditor5-find-and-replace@^41.4.2 \ @ckeditor/ckeditor5-font@^41.4.2 \ @ckeditor/ckeditor5-heading@^41.4.2 \ @ckeditor/ckeditor5-horizontal-line@^41.4.2 \ @ckeditor/ckeditor5-html-support@^41.4.2 \ @ckeditor/ckeditor5-indent@^41.4.2 \ @ckeditor/ckeditor5-link@^41.4.2 \ @ckeditor/ckeditor5-list@^41.4.2 \ @ckeditor/ckeditor5-paragraph@^41.4.2 \ @ckeditor/ckeditor5-paste-from-office@^41.4.2 \ @ckeditor/ckeditor5-remove-format@^41.4.2 \ @ckeditor/ckeditor5-select-all@41.4.2 \ @ckeditor/ckeditor5-show-blocks@^41.4.2 \ @ckeditor/ckeditor5-source-editing@^41.4.2 \ @ckeditor/ckeditor5-special-characters@^41.4.2 \ @ckeditor/ckeditor5-style@^41.4.2 \ @ckeditor/ckeditor5-table@^41.4.2 \ @ckeditor/ckeditor5-theme-lark@^41.4.2 \ @ckeditor/ckeditor5-ui@^41.4.2 \ @ckeditor/ckeditor5-undo@^41.4.2 \ @ckeditor/ckeditor5-upload@^41.4.2 \ @ckeditor/ckeditor5-utils@^41.4.2 \ @ckeditor/ckeditor5-watchdog@^41.4.2 \ @ckeditor/ckeditor5-word-count@^41.4.2 npm install --save-dev \ @ckeditor/ckeditor5-dev-utils@^40.0.0 npm run build [1] https://github.com/ckeditor/ckeditor5/releases/tag/v41.4.2 Resolves: #103840 Releases: main, 12.4 Change-Id: I46dc33ab8e8cfcc75aa13bfe50d8850fb704f75e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84281 Tested-by:Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
-
- Jun 03, 2024
-
-
Stefan Bürk authored
The `symfony/yaml` package provides the `yaml-lint` commandline tool to lint yaml files. This change introduces yaml file linting checks using the symfony tool, differencing `Services.yaml` from other yaml files. Resolves: #103931 Releases: main, 12.4, 11.5 Change-Id: I9442b38c439fb5f2d5507ca0ab70235b2dfd194a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84420 Tested-by:
-
Imko Schumacher authored
The value of the `time` input is sent as an ISO date to the FormEngine, except for the time "00:00", which is just submitted as "0". This has lead to the input field not getting populated by the JavaScript initialization, and the input "00:00" was lost. In cases where such a `time` input is set as a required field, the validation would then fail because of the field getting interpreted as being empty/unset. With this patch, a "0" value is also interpreted as a valid "1970-01-01T00:00:00+00:00" string, that is parseable by FormEngine. Note this only affects display within the FormEngine; the format of the stored data is not changed (converted by DataHandler to proper values and covered by existing tests). IMPORTANT: This only applies to NULLABLE time|timesec inputs. Only for this configuration it is possible to decide, that a stored "0" value in the database is actually "00:00" and not an unset entry. Integrators/developers need to set 'nullable' TCA key to 'true' of the corresponding 'config' array, in case they want to make a time/timesec input picker be able to store and retrieve "00:00" as a valid timestamp. Resolves: #102602 Releases: main, 12.4 Change-Id: Id5dae6564a5da9ab3abd99bdc14b718cc7064464 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82093 Tested-by:
-
Garvin Hicking authored
The current implementation does not properly split UTF-8 formatted strings into multi-lines. This patch now utilizes the corresponding mb_* PHP functions to ensure proper splitting. Tests are added to verify this behaviour. Resolves: #103952 Releases: main, 12.4 Change-Id: I493dac05177ae60942513f93ac2c322b63a7a60b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84444 Tested-by:
-
Torben Hansen authored
With this change, CPP is used in FileDumpController. Resolves: #103963 Releases: main Change-Id: I42ff822a06fd0e138a8d3109163ea4fc76a09ae2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84474 Tested-by:
-
Torben Hansen authored
It is possible to use the namespaced shorthand notation in extbase to add validators for properties or arguments. As an example, `TYPO3.CMS.Extbase:NotEmpty` will be resolved as `TYPO3\CMS\Extbase\Validation\Validator\NotEmptyValidator` or `Vendor.Extension:Custom` will be resolved as `\Vendor\MyExtension\Validation\Validator\CustomValidator`. The namespaced shorthand notation for extbase validators has however never been documented and is rarely used in extensions. This change deprecates the usage of the namespaced shorthand notation for validators in extbase. Resolves: #103965 Releases: main Change-Id: I787401cc3271cc54fed5c875a27cfde545b4e6dc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84477 Tested-by:
-
- Jun 01, 2024
-
-
Nikita Hovratov authored
GitHub repository of justinrainbow/json-schema has been renamed to jsonrainbow/json-schema. As a consequence we update the lock file so that other patches with composer.lock changes are clean. > composer update --lock Resolves: #103964 Releases: main, 12.4 Change-Id: Ie071856eb4b1fd8b7b74be9611757b9e08932c2e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84475 Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
-
Benni Mack authored
This change adapts the newly introduced PageContentFetching data processor, which reduces the number of SQL queries for colPos entries that do not use the "slideMode" feature. This means, that installations which use - multiple colPos on one layout will have 1 instead of "amountOfColPos" DB queries for fetching all content of a page. For colPos with a slide mode, the previous logic still applies. Resolves: #103906 Related: #103894 Releases: main Change-Id: I5172fa427a69f279e88c27f9b97793036d94c533 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84387 Tested-by:
-
Anja Leichsenring authored
Phpstan claims the contract guard condition can never be true (in which case an exception will be thrown) but this is not true. So we keep the condition, but suppress the error. PHPStan gets updated and pinned to lowest version 1.11.3 with composer require --dev phpstan/phpstan:^1.11.3 Resolves: #103962 Related: #99146 Releases: main, 12.4 Change-Id: I8c184ef24ed95c7277e1e6b5ac8b8c9ea3ad0521 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84472 Tested-by:
-
- May 31, 2024
-
-
Benjamin Franzke authored
Allow proxies to cache the TYPO3 content by stripping the nonce from the generated CSP header if the nonce was not actually consumed. Also ensure that the nonce value substitution consumes a nonce to ensure that a (replaced) nonces in cached-content receive a matching CSP header as well. Resolves: #103942 Releases: main, 12.4 Change-Id: I437c83de522ff4a6f4ee0ef2f13881d24bfb990c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84435 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Kai Ole Hartwig <o.hartwig@moselwal.de> Tested-by:
Willi Wehmeier <wwwehmeier@gmail.com> Reviewed-by:
-
Georg Ringer authored
The stdWrap options stripHtml and htmlSpecialChars requires the value to be a string. A typecast forces the string to avoid exceptions. Resolves: #103085 Releases: main, 12.4 Change-Id: Ia936a19e06fdf954ca3aef442cad34c164e9c54e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84446 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
Andreas Kienast authored
With migration away from prophecy during v12 development, the variable `$siteMockRevelation` is not needed anymore as phpunit mocks don't know the concept of revelations. Resolves: #103958 Releases: main, 12.4 Change-Id: I92497737dfbba3ef1cd99e4fbd96751e00057a16 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84449 Tested-by:
Kevin Appelt <kevin.appelt@icloud.com> Reviewed-by:
-
Andreas Kienast authored
This commit updates some colors in the color picker component. The dark background is removed from focussed input fields. Also, the input styling now matches FormEngine styling. Resolves: #103891 Releases: main Change-Id: I9a3a9e10c48be0bf49395d388be55cb8c8535693 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84379 Reviewed-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Tested-by:
-
- May 29, 2024
-
-
Garvin Hicking authored
Using '%env(SOME_VARIABLE)%' within a site configuration YAML did not resolve contents in SOME_VARIABLE that were falsy ('false', '0', 0). This patch now properly converts those falsy values to actual values. Tests are added to verify the new behavior and prevent future regressions. Drive-by fix on Unit tests which did not actually remove env vars after testing, putenv('var') is needed instead of putenv('var='), because the latter will keep the environment var around (with an empty value). Resolves: #91710 Releases: main, 12.4 Change-Id: I99d64f080737ada38fd58a63f4e04e5b0d8c9ef3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84442 Reviewed-by:Markus Klein <markus.klein@typo3.org> Tested-by:
-
Georg Ringer authored
If no icon is provided for submodule, use a fallback to the icon of the parent module instead of directly using the empty-empty icon. Resolves: #103904 Releases: main, 12.4 Change-Id: I4e989483880fd88df904e9028f1d2cf6cd5c29f7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84390 Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Tested-by:
-
- May 28, 2024
-
-
Oliver Bartsch authored
For consistency, the redirect demand's default value for the integrity status is now set to NULL, to show all records by default. This is especially important for existing installations, having redirects which do not yet contain a value for the new `integrity_status` field. Resolves: #103900 Related: #99485 Releases: main Change-Id: Iba8dc0180e22f5e31b51e6c33fb71b47b5486238 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84382 Reviewed-by:
-
Christian Kuhn authored
Detail methods of the two TypoScript tokenizers tend to add mental load since they often update `$this` state. The patch changes `splitLines()` and `parseValueForConstants()` to return updated things instead, for consuming methods to take care of this. This is a pre-patch to simplify #102742. Resolves: #103944 Related: #102742 Releases: main, 12.4 Change-Id: I1a5dbccc1bdfbfc52681e323eb1fe9a2b0bb7dc7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84439 Tested-by:
-
Christian Kuhn authored
<INCLUDE_TYPOSCRIPT: source="DIR:..." condition="[tree.level > 2]"> The TypoScript tokenizers fail here since ">" within the condition is interpreted as "end of INCLUDE_TYPOSCRIPT". Add a couple of tests and fix it. Resolves: #103875 Releases: main, 12.4 Change-Id: I43c59bd61645bee9ce9c175b00ce1d2cba44c023 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84346 Tested-by:
-
- May 27, 2024
-
-
Christian Kuhn authored
There is little point extracting single widget configuration to an own file - we don't split Services.yaml in any other extension. Merge DashboardWidgets.yaml into Services.yaml. Resolves: #103936 Releases: main Change-Id: I00ba601a57942fc543728c87404f0944a307bf0c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84425 Tested-by:
-
Benjamin Franzke authored
Add a filename context to page.tsconfig include nodes (autoloaded from extensions Configuration folder or from site sets) in order to allow relative imports to be resolved. Releases: main, 12.4 Resolves: #79737 Related: #97816 Change-Id: Id6404127b667a61e013d4e5b528048201ad0e6c6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83712 Tested-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is depreacted and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator. [1] In cases, where are implicitly nullable parameter exists before not-nullable parameters in a method or constructor, making it explicitly nullable will emit a Optional parameter <paramname> declared before required parameter <paramname> is implicitly treated as a required parameter since PHP 8.0 [2]. This change adds the `?` nullable operator and removes the null default value for the first parameter, which mitigates both issues. This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated [2] https://php.watch/versions/8.0/deprecate-required-param-after-optional Resolves: #103927 Releases: main, 12.4, 11.5 Change-Id: I0ba574769e5b95852379aa30f03d45715aec2055 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84416 Tested-by:
-
Ayke Halder authored
This enables the already available `phpstan-phpunit` rules: * PHPStan\Rules\PHPUnit\AssertSameBooleanExpectedRule * PHPStan\Rules\PHPUnit\AssertSameNullExpectedRule * PHPStan\Rules\PHPUnit\AssertSameWithCountRule * PHPStan\Rules\PHPUnit\MockMethodCallRule * PHPStan\Rules\PHPUnit\ShouldCallParentMethodsRule `ShouldCallParentMethodsRule` is of great interest: It checks for missing calls to `parent::setUp` and `parent::tearDown`. `AssertSameWithCountRule` replaces `assertSame($expectedCount, count($variable))` with `assertCount($expectedCount, $variable)`. Resolves: #103880 Related: #103929 Releases: main Change-Id: I43a69d0dcf342cc65d34eb03f2d9800b1e70e8a2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84351 Reviewed-by:
-
Stefan Bürk authored
This change modifies the `runTests.sh` helptext to mention the `checkIntegrityPhp` correctly added with #103465. Resolves: #103930 Related: #103465 Releases: main Change-Id: I0ffdb66236bbc0c82f702cf960bf9462dedbdfcf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84419 Tested-by:
-
Christian Kuhn authored
Using PHP attributes to configure DI within classes directly is more easy to understand since developers don't need to constantly look up DI configuration Services.yaml files, but have everything in one place. The patch switches all classes that previously used '@cache.xy' to get a specific cache injected to an `Autowire` attribute. Resolves: #103921 Releases: main Change-Id: I16b064242cdbc2bbcfbed89700c97afac012fdf8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84406 Tested-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is depreacted and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator. [1] In cases, where are implicitly nullable parameter exists before not-nullable parameters in a method or constructor, making it explicitly nullable will emit a Optional parameter <paramname> declared before required parameter <paramname> is implicitly treated as a required parameter since PHP 8.0 [2]. This change removes the `null` default value and adds the `?` nullable operator to the previousException parameter for the `\TYPO3\CMS\Backend\Form\Exception\DatabaseRecordException` constructor. This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated [2] https://php.watch/versions/8.0/deprecate-required-param-after-optional Resolves: #103926 Releases: main, 12.4, 11.5 Change-Id: I4d1506b24b3113a74b37b986fa4f23f24e6219fb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84415 Reviewed-by:
-
Garvin Hicking authored
Using the methods does not improve output, but makes reading harder: A first wantTo() changes the title of a test within the output - that is usually derived from the test method name - to the wantTo() message. This leads to things like different tests having the same name. Our test names are good, use them! Any second or other use of wantTo() does nothing in the output at all. The patch removes wantTo() and wantToTest() (similar behavior), and turns some of them into code comments. This should make the test logs more easy to understand and follow. Resolves: #103916 Releases: main Change-Id: Ie88d8fd937151c1b471cfa3b4743e7639bf2c7fb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84403 Tested-by:
-
Christian Kuhn authored
Resolves: #103933 Releases: main Change-Id: Ic1626081bf0f4ee2159543be1fe6cdfc80b9b4e3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84421 Tested-by:
-
Stefan Bürk authored
`\TYPO3\CMS\Core\Tests\Unit\Database\ConnectionTest` containes code to mock Connection methods conditionally, based on their existance surrounded by a `@todo` comment to remove this, when `doctrine/dbal` has been required with 2.11.0 as minimal version. The version raise has been done already a long time ago, however the removal of this conditional test mock has been missed. This change removes the conditional mocking now. Resolves: #103929 Releases: main, 12.4, 11.5 Change-Id: I4cc2d5942149f69e044c25379c82388f1c4b9f45 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84418 Reviewed-by:
Ayke Halder <mail@ayke-halder.de> Tested-by:
-
