[BUGFIX] Do not set original token value stream in TS AstBuilder
The 'original value token stream' is a helper used in BE TypoScript modules to render a possible constant substitution. It is enough if the CommentAwareAstBuilder handles this, which is used in those cases: getOriginalValueTokenStream() is only called by fluid as 'child.originalValueTokenStream' when rendering TS trees in the backend. Those use CommentAwareAstBuilder and not "production" AstBuilder. The patch avoids calling setOriginalValueTokenStream() as a minor micro optimization which may also help the garbage collection to clean up some objects more early in FE. Resolves: #103975 Related: #97816 Releases: main, 12.4 Change-Id: Ifa54b36877d5eb1c1d712433efa2d07fd1ad8bd8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84491 Tested-by:Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Stefan Bürk <stefan@buerk.tech>
Showing
- typo3/sysext/core/Classes/TypoScript/AST/AstBuilder.php 0 additions, 1 deletiontypo3/sysext/core/Classes/TypoScript/AST/AstBuilder.php
- typo3/sysext/core/Classes/TypoScript/AST/Node/NodeInterface.php 2 additions, 2 deletions...sysext/core/Classes/TypoScript/AST/Node/NodeInterface.php
- typo3/sysext/core/Tests/Unit/TypoScript/AST/AstBuilderInterfaceTest.php 1 addition, 0 deletions...ore/Tests/Unit/TypoScript/AST/AstBuilderInterfaceTest.php
Please register or sign in to comment