- Dec 23, 2021
-
-
Mathias Brodala authored
This only fixes the issue for dedicated record links. Page links with added query arguments can still lead to broken links. Resolves: #87260 Releases: main, 11.5 Change-Id: Ib13aa1925de6463688e2b50612ce7b2820733ce7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59257 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Markus Klein authored
The setup should not contain the same settings twice. Moreover, the default paths are always available, no need to configure them. Additionally, remove default paths from constants, we don't need that either. Resolves: #96384 Releases: main, 11.5 Change-Id: I204cc38a952dd7acd097d188d1637ad1b25324fc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72703 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Torben Hansen <derhansen@gmail.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
-
Alexander Schnitzler authored
Releases: main Resolves: #96046 Change-Id: I86edaa24b08808b70b92687f83a850ff32a74dc7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72007 Tested-by:
-
Benni Mack authored
Resolves: #96344 Releases: main, 11.5 Change-Id: I986945e16e0a2adef827fc0532a431be7ab25e03 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72770 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
Benni Mack authored
Resolves: #96430 Releases: main, 11.5 Change-Id: I8569537d90ee5dc74157db4f3e583366b82a2e27 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72800 Reviewed-by:
Simon Gilli <typo3@gilbertsoft.org> Reviewed-by:
-
Guido Schmechel authored
These additional SMTP options are now supported by TYPO3 and can be set in the Install Tool: - transport_smtp_restart_threshold - transport_smtp_restart_threshold_sleep - transport_smtp_ping_threshold It is also possible to define 'transport_smtp_stream_options' as array with stream options in the AdditionalConfiguration.php. Resolves: #94544 Releases: main Change-Id: I258c5493fa4f7815481636c223b7c5368f79a274 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69907 Tested-by:
-
Benjamin Franzke authored
A human-readable diff of the applied changes can be inspected on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72795/1/Build/Sources/TypeScript/backend/Resources/Public/TypeScript/FormEngineLinkBrowserAdapter.ts No functional change to keep the diff minimal and prepare behaviour as-is. Releases: main Resolves: #88435 Related: #96425 Related: #96323 Change-Id: I512739d5827e2951ac6a63312de380870bdebd8d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72795 Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
-
Benni Mack authored
There is a difference between > typolink.linkAccessRestrictedPages = 1 (only a toggle) and > HMENU.showAccessRestrictedPages = [pageId]|NONE HMENU.showAccessRestrictedPages behaves like the global option "config.typolinkLinkAccessRestrictedPages" Basically, if a page is access restricted, link to a different {pageId}. This change explains the behavior: -- https://review.typo3.org/c/Packages/TYPO3.CMS/+/35908/ "typolink.linkAccessRestrictedPages" in contrast still links to the actual disallowed page, which is also nice in case you have a 403 error page in place. This change fixes the behaviour of HMENU to behave EXACTLY like the global config.typolinkLinkAccessRestrictedPages, previously HMENU did some magic PLUS it set "typolink.linkAccessRestrictedPages" With this change, shortcuts to access restricted pages now get properly transformed and linked for menus. Resolves: #60258 Resolves: #65118 Related: #63804 Releases: main, 11.5 Change-Id: Ifd975243fe4b024b3fcbd4e356430d809cc0f429 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72796 Tested-by: -
Chris Müller authored
Resolves: #96377 Releases: main, 11.5 Change-Id: I98dfe39cf04468d54ee979afa34e7dd3bd40acf6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72793 Tested-by:
-
Chris Müller authored
Resolves: #96418 Releases: main, 11.5 Change-Id: I00b77f478c667f59b751c6f13c975d03799086d7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72792 Tested-by:
-
Torben Hansen authored
Added the following Composer plugins as allowed/trusted * composer/package-versions-deprecated * typo3/class-alias-loader * typo3/cms-composer-installers Resolves: #96428 Releases: main, 11.5, 10.4 Change-Id: Iabb8f00411279f502bca1d1ba79714cc58d82d3f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72797 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Oliver Bartsch authored
This fixes several issues for the case that an editor only has access to translated pages and not to the default language (L=0). Resolves: #95795 Releases: main, 11.5, 10.4 Change-Id: Ied31c7aa5229d3b8686741dd97005f9b5f16ef16 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72616 Tested-by:
-
Sebastian Michaelsen authored
Resolves: #93027 Releases: main, 11.5 Change-Id: I65b4b84a12cf4985d14a62217b075e5c421e0ee6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67072 Tested-by:
-
- Dec 22, 2021
-
-
Christian Kuhn authored
With the removal of ControllerContext a view init call had to be moved out of ControllerContext. It was moved to a wrong place in the view setup chain. This is fixed by the patch. Resolves: #96426 Related: #96183 Releases: main Change-Id: I8a49627040a72649c39aa8ace9da0b0a2e1995c1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72771 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
- Dec 21, 2021
-
-
Christian Kuhn authored
To stick to best practice, the patch adapts all f:uri.resource ViewHelper usages to "EXT:" syntax. Resolves: #96423 Related: #96414 Releases: main Change-Id: Icba87d954f939a42ca59fbe78e7c932f0228f11e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72766 Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
-
Stephan Großberndt authored
This patch changes the behaviour when building the SchemaDiff on a non-default connection to only fetch tables which are mapped to that connection instead of fetching table details of all tables and discarding the information for unmapped tables later on. This improves the performance and avoids errors for data types unknown to doctrine/dbal in details of unmapped tables. Resolves: #92959 Releases: main, 11.5 Change-Id: Ia4a62d861ea0748995eb0dec4f01e9e65eb3ed46 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66949 Tested-by:
-
Chris Müller authored
This avoids the deprecation notice in PHP 8.1: Passing null to parameter #2 ($string) of type string is deprecated in /var/www/html/public/typo3/sysext/recordlist/Classes/Browser/DatabaseBrowser.php line 179 Resolves: #96422 Releases: main, 11.5 Change-Id: I9c811bc0d2d4523a78fc6c72ee02be96efbe1bc3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72764 Tested-by:
-
Chris Müller authored
Resolves: #96420 Releases: main, 11.5 Change-Id: Ida1b27956bfe759062904ee9d0c8246ea73f0667 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72763 Tested-by:
-
Chris Müller authored
When one or more hidden records are referenced in an "Insert records" content element, an "undefined array key" warning was thrown. Resolves: #96419 Releases: main, 11.5 Change-Id: I4f90dc78540bf8c56163cfb8247a13c86869fbe1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72762 Tested-by:
-
Andreas Fernandez authored
If the PageLinkBuilder is invoked with a non-available TSFE as e.g. in the "Redirects" module, generating the URLs to pages with a fragment, e.g. to a referenced content element, works now as we're using the TSFE generated within PageLinkBuilder itself. Resolves: #96101 Releases: main, 11.5 Change-Id: I481b7d8573424dab59df22b0d81a734e03b70575 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72323 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Christian Kuhn authored
f:uri.resource is frequently used to load CSS and JavaScript resources. It is the only ViewHelper that does not understand the general "EXT:" syntax that is usually available when extension resource files are referenced. This is now added to improve consistency and documented as best practice in VH documentation. Change-Id: I504c79eef349b1ea6cc70cc0d7753319e1f356d9 Resolves: #96414 Releases: main, 11.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72759 Tested-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
-
Benjamin Franzke authored
Helps to migrate to ES6 modules as that's just a tsconfig setting then. Releases: main Resolves: #96409 Related: #96323 Change-Id: Ib897c3c2cfdb6d7ff0a88ea70ed9213b33dd2138 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72753 Tested-by:
-
Benjamin Franzke authored
Commands executed: yarn add web-animate yarn build Releases: main Resolves: #96410 Related: #91072 Related: #96323 Change-Id: Id4c06262af9122c638861e798b1f9bfade8ee56f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72754 Tested-by: -
Andreas Fernandez authored
The category starting points introduced with #95037 were designed to allow comma-separated values in its configuration. Due to improper tests, this specific notation was not discovered as being broken right now. If the incoming configuration is a string, GeneralUtility::intExplode() is applied to remove any non-integer value. Afterwards, a new CSV string is generated. Resolves: #96397 Related: #95037 Releases: main, 11.5 Change-Id: I0759d8093bb4665b7709f4e20539307467f246df Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72738 Tested-by:
-
Tom Warwick authored
Releases: main Resolves: #96228 Change-Id: I680bf20c1a3dc63003cf1638ec680ca6ab07447f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72492 Tested-by:
Susanne Moog <look@susi.dev> Tested-by:
-
Simon Schaufelberger authored
According to https://docs.phpdoc.org/latest/guide/guides/types.html#union-types it is only allowed to use "string|null" and not "?string" Resolves: #96407 Releases: main, 11.5 Change-Id: I4e9ec53d05feb5cfffc4eebc29de447d6225ab66 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72749 Tested-by:
-
Benjamin Franzke authored
RecordExportButton.js has been introduced in #94622 by accident (probably a left-over from a previous patchset re-added due to grunt watch). The TypeScript source for Enum/Viewport/TopbarIdentifiers.js has been removed with #78760, it is unused since then and therefore removed. Releases: main, 11.5 Resolves: #96411 Resolves: #96412 Related: #94545 Related: #78760 Related: #96323 Change-Id: I226d51fc87ab8012e917e7d219688fca21eda364 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72755 Tested-by:
-
Simon Gilli authored
The core version service now uses the new entry point of the REST API available via https://get.typo3.org/api. The old entry point is still available but should not be longer used. For more information see `https://get.typo3.org/api/doc <https://get.typo3.org/api/doc>`_ and `https://github.com/TYPO3/get.typo3.org/pull/272 <https://github.com/TYPO3/get.typo3.org/pull/272>`_. Resolves: #92020 Releases: main, 11.5, 10.4 Change-Id: I2c92554e9ba212827b6412d4a88ac5c92e26aa17 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65342 Tested-by:
-
Benni Mack authored
Currently, HMENU generates the direct destination for a shortcut URL, but typolink does not. This is an inconsistency, and since HMENU is actually using typolink now as well (in 4.x this was different), the resolving of shortcuts can now be moved into the typolink/link building functionality. Page Shortcuts are now resolved (recursively!) at a single point for all links, except for RANDOM_SUBPAGE variants, as this is sorted out during runtime when hitting the RANDOM_SUBPAGE shortcut page. Resolves: #80113 Resolves: #95947 Releases: main, 11.5 Change-Id: Ib6204ff1b0ecb699ec87f5154dc18c974676e65c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71402 Tested-by:
-
Stefan Bürk authored
With #96393 forward-compatible prepared statement support has been added to QueryBuilder and also provided several tests to covers this implementation. However one test tests doctrine/dbal behaviour for 'Statement->bindValue()' which behaves differently accross drivers and platforms, emitting different exception types or need an additional execute. This patch removes this test as it is not the job of core testing to test 3rd party code and inconsistent behaviour. Removed test were already removed on backport for #96393. Resolves: #96408 Related: #96393 Releases: main Change-Id: I35d65171dda9fbcc91c906708324997006e21c67 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72752 Tested-by:
-
- Dec 20, 2021
-
-
Andreas Fernandez authored
The function `idn_to_ascii()` will return either `false` or a string, the former one is returned on errors. In #93900, the result was cast to string, making the check for `false` useless. As `idn_to_ascii()` can return both, the string cast is removed to make the check for `false` functional again. Resolves: #96399 Related: #93900 Releases: main, 11.5 Change-Id: Ib5327766fc545a75feb7389d18358aa85b76e5db Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72740 Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
-
Benjamin Franzke authored
In ES6 mode Viewport.Topbar and ModuleMenu.App properties cannot be overwritten (in order to be substituted with a call spy), as they reference other JavaScript modules. The properties of ES6 models are readonly ("frozen") and can therefore not be overwritten in a test setup. Therefore the test is adapted to overwrite the references in Viewport and ModuleMenu instead. Also a timeout is added as await import('TYPO3/CMS/Backend/ModuleMenu') does not guarantee a loading order between modules in ES6, which causes test asserts to be executed too early. Releases: main Resolves: #96396 Related #96323 Change-Id: I5c213b70e43c5e1256e91ffe0d9f12f96dbb6615 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72736 Tested-by: -
Sybille Peters authored
The phpstan configuration documentation recommends to specify the paths relative to the directory of the configuration file. Thus using, currentWorkingDirectory (as current working directory) is unnecessary and removed. Resolves: #96163 Releases: main Change-Id: I2b625f4722e1955b5928a22dbdd2b4aedf6daafe Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72709 Tested-by:
-
Christian Kuhn authored
The patch makes the bulk of ViewHelper classes more strict and applies some general love. Some ViewHelpers have been left, those will see bigger refactorings soon. All affected classes are final, the changes are (hopefully) non-breaking. * declare(strict_types=1) if missing. * Use self:: instead of static:: since all VH's are final, so there is not point in using late static binding. * Return and argument type hints where possible and reduction of methods doc annotations which are covered by PHP method signatures. * Add types to some class properties. * Protect some detail methods that were apparently public by accident. This is not considered breaking. * Avoid extbase LocalizationUtility::translate() in favor of core LanguageService. * Avoid static class state, especially with TSFE. * Minor comment fixes. Change-Id: I4e3b9d01ea92802e47d05a10f4243196120b8510 Resolves: #96400 Related: #96368 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72741 Tested-by:
-
Benjamin Franzke authored
CKEditor is now loaded via a plain <script async> tag in preparation for a transition from requirejs to ES6 modules. CKEditor v4 is not available as ES6 module and can not easily be transformed into a strict-mode compatible module. CKEditor v4 requires `this` to be the global window object in various functions, but `this` is not bound to the global window object in strict-mode (as implied by <script type="module">). Note: CKEditor is not a real AMD module anyway, but is configured to be shimed by requirejs to be loadable as AMD module, therefore it can safely be loaded using good old <script>. Releases: main Resolves: #96394 Related: #96323 Change-Id: Ife0b476ba29b85f85dfd654ea096cdf30c47b6ef Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72733 Tested-by:
-
Christian Kuhn authored
BackendController renders "Main.html" as central backend skeleton, plus "Topbar.html" and "MainModule.html". The patch moved the templates into one folder. Resolves: #96404 Releases: main Change-Id: I485d9ff03e457d78c8454e36ac893fbbc1ffe77c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72746 Tested-by:
-
Christian Kuhn authored
There is no point in having the main template in a sub folder, move it up. Additionally use full EXT: syntax for f:translate arguments and avoid a useless flashMessage VH call that is already done by ModuleTemplate automatically. Resolves: #96405 Releases: main Change-Id: Id2f9e4bd28f9ed7649ff5b3c73348cf7d2307a51 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72747 Tested-by:
-
Christian Kuhn authored
Avoid dash between the two words. Resolves: #96401 Releases: main Change-Id: If3455598e643f1304400aa2271733bb5f69df0aa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72742 Tested-by:
-
Christian Kuhn authored
Resolves: #96403 Releases: main Change-Id: Id4843f31254fe2b4bd46fe3c7c37669c6f3a06f0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72744 Tested-by:
-
Christian Kuhn authored
Resolves: #96402 Releases: main Change-Id: I8266c5859954ea118a4ec92ca3ca9660e9854c8f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72743 Tested-by:
-
