- Apr 04, 2024
-
-
Georg Ringer authored
If a page uses a specific page layout, it must be used in the page module. To be in sync with v12 the change is also merged into v12. Resolves: #103501 Releases: main, 12.4 Change-Id: I91341249fd3f6142a9830bb594a8fe1d2d6ded7a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83624 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
-
Andreas Kienast authored
A new hotkey is introduced in the FormEngine scope that lets editors invoke "Save and Close" via `Ctrl/Cmd+Shift+S`. Resolves: #103529 Releases: main Change-Id: I530a1df54707eb69033c8a03ccf58517facf162a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83642 Tested-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
-
- Apr 03, 2024
-
-
Mathias Brodala authored
Resolves: #103496 Releases: main, 12.4 Change-Id: I688540c91e85d28eec1951305d63028efa27eb82 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83617 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Reviewed-by:
-
- Apr 02, 2024
-
-
Nikita Hovratov authored
While extracting dedicated TCA types from the god type `input`, the `valuePicker` option was forgotten for type `email`. Other types like `number` do have this option. An acceptance test is added to ensure this option will not be dropped by accident in the future. Resolves: #103510 Related: #97013 Releases: main, 12.4 Change-Id: I95c51d858ca9cb3caefa174cd8ce5946c8352aa2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83631 Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
-
- Mar 29, 2024
-
-
Torben Hansen authored
In ext:recycler, there is an open todo to move the function `getUserWhoDeleted` from `RecyclerAjaxController to `RecordHistory`. This change moves the function to `RecordHistory` and additionally renames it to a more appropriate name. Resolves: #103474 Releases: main Change-Id: Id49d2e42c6c2393ef6c0b888bf293cd835cca1ed Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83578 Reviewed-by:
-
Benjamin Franzke authored
The SiteConfiguration service is currently needed during installation phase for writing site configurations. This limits symfony dependency injection usage and basically requires that all services needed by SiteConfiguration need to be defined and manually wired in ServiceProvider php code. The writing part is now split into a separate service that can be used in EXT:install SetupService as before. Resolves: #103450 Releases: main Change-Id: I9cb579ade537c794ce7c1a844b3d7bec7c1b653e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83557 Tested-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
-
- Mar 23, 2024
-
-
Benni Mack authored
This change centralizes Frontend's "PageLayoutResolver", used in TypoScript, and BackendLayoutView logic to find the used page layout, while also modelling more towards an object within PageLayout which can be used at a later stage in FE to retrieve more information. At the same time, some BackendLayoutView code is reduced now. Resolves: #103466 Releases: main Change-Id: I716fe7313894aac92e5519a6b725feefff908270 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83567 Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
-
- Mar 22, 2024
-
-
Benni Mack authored
Various places in smaller extensions were reported in phpstan that had some inconsistencies in their code style, which were unnecessary and are now avoided. Resolves: #103383 Releases: main Change-Id: I1d9653e62e753c87e20bf8f2f9ff299a85c8726e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83449 Tested-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
-
Benni Mack authored
BackendLayoutView is used to build the BackendLayout structure, and does a few things too much: a) it uses ArrayUtility over a simple isset() check for pageTsconfig b) it resolves LLL labels directly, even if MoveContent wizard and Page module handle that as well c) it re-builds logic only used in Move Content which is not needed due to a properly resolved colPos list already All of this internal code can be removed and thus reduced to a minimum, with Page module, FormEngine (pages+tt_content) and Move Content Wizard continue to work, because FormEngine and all other modules already use the proper API for rendering already. Resolves: #103463 Releases: main Change-Id: Ib3878d08936e60a9cbd2f405260f3badcefcf8ae Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83565 Reviewed-by:
-
- Mar 21, 2024
-
-
Andreas Kienast authored
This commit checks whether `eval` and `is_in` are not empty before they are used as "input params" for the JavaScript part of the FormEngine. Also, a plausibility check is added to ensure `eval=is_in` and a non-falsy `is_in` configuration are given. Resolves: #103184 Releases: main, 12.4 Change-Id: I23da4483f1b35b0720ce59d07847fe01ead9a461 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83085 Reviewed-by:
-
Andreas Kienast authored
TYPO3's TCA type field is rendered in the FormEngine along with a `<typo3-formengine-updater>` element that listens on changes on the linked type field. This is a rare case: if FormEngine is programmatically rendered via an own controller and the value of the `type` field is hardcoded via `overrideValues` in the FormEngine compiler, the field itself is not rendered. However, the `<typo3-formengine-updater>` element is still there, leaving an "empty" field group. This patch now checks whether something is available for rendering before rendering the `<typo3-formengine-updater>` element. Resolves: #103449 Releases: main Change-Id: I708b49665dfaa5b836954e40e99cbcb9ed44ec03 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83554 Tested-by:
-
- Mar 20, 2024
-
-
Jasmina Ließmann authored
Resolves: #103429 Releases: main, 12.4 Change-Id: Id8ab8e745a316f8af0abcfe495b7174f0afe1b96 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83530 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Tested-by:
-
- Mar 19, 2024
-
-
Christian Kuhn authored
These two classes are part of the new BE tree, and are documented API for extensions to add additional labels and status to tree nodes. They should not be marked `@internal`. Resolves: #103422 Related: #103186 Related: #103211 Change-Id: I63f466a2726e39058f400599eac70059fb5a6594 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83520 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
- Mar 18, 2024
-
-
Willi Wehmeier authored
The used ll keys used in the javascript code for the inline pagetitle edit feature in the page and recordlist module aren't set correctly in the corresponding templates. This patch solves that mismatch. Resolves: #103419 Releases: main, 12.4 Change-Id: I5dfb242bb596bef73a3d9474e8cd31ded723fea0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83502 Reviewed-by:
-
- Mar 16, 2024
-
-
Oliver Bartsch authored
Resolves: #103391 Releases: main, 12.4 Change-Id: I48d55c7b66669f9836886f257aefba2171b6910e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83455 Tested-by:
Jochen Roth <rothjochen@gmail.com> Tested-by:
-
- Mar 15, 2024
-
-
Willi Wehmeier authored
This change makes the toggle button accessible via keyboard and sets the focus manually, so that the pagetree can be toggled via pressing space or enter on the keyboard. Resolves: #102426 Releases: main, 12.4 Change-Id: I6916cf1f19de288e961ecb0dab85c76241097d33 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81817 Tested-by:
Benjamin Kott <benjamin.kott@outlook.com> Reviewed-by:
-
Willi Wehmeier authored
This patch adds a label to the action-menu used by most of the core extensions. Resolves: #102548 Releases: main, 12.4 Change-Id: I57db0e4d35b439e8841d7f4281bc09b593bb9dc4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82008 Reviewed-by:
-
- Mar 14, 2024
-
-
Willi Wehmeier authored
The thumbnail images in the inline file relations have the properties alt and title set to "id=x" which is only helpful when used to show the record uid in the tooltip. For screenreader users the info in the alt attribute isn't helpful at all. That's why the alt text should be empty so the thumbnail doesn't get read out by screenreaders at all. Resolves: #103397 Releases: main, 12.4 Change-Id: I233a54705c9c81e31b8852a8454165593fa8e061 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83467 Reviewed-by:
-
Andreas Kienast authored
The eslint configuration now takes the rule `@typescript-eslint/prefer-string-starts-ends-with` [1] into account, enforcing the usage of `startsWith()` and `endWith()` over index checking in strings. [1] https://typescript-eslint.io/rules/prefer-string-starts-ends-with Resolves: #103374 Releases: main, 12.4 Change-Id: I88640f71cbe960db2a2e2b162410ff5a79e7c55c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83437 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
- Mar 13, 2024
-
-
Ayke Halder authored
In the backend CEs are elevated by a surrounding box-shadow. This box-shadow was clipped off on top, left and right side. Resolves: #103381 Releases: main, 12.4 Change-Id: I3052ff7ced18e509aefb2f05c6b1bde8725572b5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83445 Reviewed-by:
-
Benjamin Franzke authored
With #103197, a loading indicator was added to the context menus, which rendered a stub context-menu. The position of the context-menu needs to be recalculated once the data has been loaded (the context-menu becomes taller) in order to avoid rendering outside the visible window area. Releases: main, 12.4 Resolves: #103382 Related: #103197 Related: #103294 Change-Id: I75e3659c619d4b98c773faa4dab9bbf184471065 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83450 Tested-by:
Sven Juergens <typo3@blue-side.de> Reviewed-by:
Kevin Appelt <kevin.appelt@icloud.com> Tested-by:
-
Benni Mack authored
This change adapts some places around Backend Layouts, which is a pre-patch in order to centralize previously used code from 2013 to move towards a more generic concept, which needs to go into EXT:core as the structure should also be useful and evaluated in EXT:frontend. This change now cleans up places which are non-breaking but hardens PHP code without changing the underlying logic. Resolves: #103365 Releases: main Change-Id: I77382d93342e5c2e45966f96bf485619c79f25f3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83362 Reviewed-by:
-
Andreas Kienast authored
The eslint configuration now takes the rule `@typescript-eslint/restrict-plus-operands` [1] into account, prohibiting merging of type-incompatible operands. [1] https://typescript-eslint.io/rules/restrict-plus-operands Resolves: #103378 Releases: main, 12.4 Change-Id: I267272e4f384cbcabc245cd85ea493886134b026 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83439 Reviewed-by:
-
- Mar 12, 2024
-
-
Andreas Kienast authored
The eslint configuration now takes the rule `@typescript-eslint/no-array-delete` [1] into account, prohibiting element removal from an array via `delete`. The problem with `delete` is that the element to be removed is in fact replaced with an `empty` slot, effectible keeping the array's size. Using `splice()` [2] is the preferred way to remove elements from an array. [1] https://typescript-eslint.io/rules/no-array-delete/ [2] https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/splice Resolves: #103375 Releases: main, 12.4 Change-Id: Ic742a43d44cbd8c5cc323f629cc82ad606a9858f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83438 Tested-by:
-
Oliver Hader authored
The new methods AbstractUserAuthentication::getUserName() and AbstractUserAuthentication::getUserId() can be used to resolve the corresponding values (instead of using the $user->user array). In addition, the pure system-maintainer checks have been moved into to central BackendUserAuthentication::isSystemMaintainer(). The term "pure" refers to ignoring the development context and not applying any fallbacks in case the setting is empty. Resolves: #103323 Releases: main, 12.4 Change-Id: Ia7db222dac32acc2ef13a34ded4545ba1aedefc3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83306 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
- Mar 11, 2024
-
-
Benjamin Franzke authored
The public URL resolution in lazy loaded TCA forms (e.g. inline records) is aligned to use the same path resolution mechanism as in PageRender. Releases: main, 12.4, 11.5 Resolves: #103296 Change-Id: I981af29b34393302c49dd16216f0baa580d60767 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83230 Tested-by:
-
Torben Hansen authored
With #102761, the new `HashService` has been introduced to ensure that HMAC generation will always use an additional secret. As a follow-up patch, `GeneralUtility::hmac` will be deprecated when all usages in the core have been replaced with the new `HashService`. With this change, usages of `GeneralUtility::hmac` in ext:backend are replaced by the new HashService. Resolves: #103247 Related: #102761 Related: #103245 Releases: main Change-Id: I99abec6d68397bd6c9623a9a3de776b0f6cd4a8a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83253 Reviewed-by:
-
Torben Hansen authored
Currently, the variables `name`, `email`, `language`, `resetLink` and `username` are available in the template of the password recovery email for backend users. It is not possible to add custom user related data from the `be_users` table to the password recovery email. To enable the possibility to add custom user related data, this change adds the new variable `userData` to the FluidEmail object, which contains all userdata of the affected backend user. Additionally, a superfluous `is_array` check has been removed, since it is ensured, that the `$users` variable at this point already is an array. Resolves: #103147 Releases: main Change-Id: I72eb8796a15f5dd9dbb8682555777915f880bc96 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83031 Reviewed-by:
Guido Schmechel <guido.schmechel@brandung.de> Tested-by:
-
- Mar 08, 2024
-
-
Benni Mack authored
All PageTsConfig options are now in DrawingConfiguration and named properly. All plain labels are now moved to Fluid directly via <f:translate> Random id="{uniqueId}" are removed from markup, reducing the usages to the AbstractGridObject, which hopefully will vanish in the near future. RecordRememberer is a singleton and injected as much as possible. The "languageMode" is now resolved into a PageViewMode enum. Resolves: #103345 Releases: main Change-Id: I78f33fed409db2a1c5528e734ed19ad67aeb4e89 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83322 Reviewed-by: -
Andreas Kienast authored
The "Move page" wizard is still based on the dusted `PagePositionMap`. In order to modernize the clunky UI, the wizard is migrated to a modal window that offers a drastically slimmed down interface, offering a page tree to make the selection of the target page easier. It is always possible to paste the to-be-moved page above and below a target page, or inside a page if there are no children, yet. Resolves: #103344 Releases: main Change-Id: I745abb7b34e318275ae95abb689a6024e47b166e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83269 Reviewed-by:
-
Garvin Hicking authored
The Symfony CLI Command `backend:user:create` already offers shortcut options like "-u XXX" instead of "--username=XXX" as an alternative. This was broken, because the ENV/interactive fallback check only performed a check on the full option name. This check is now enhanced to also consider the shortcut. Resolves: #103134 Releases: main, 12.4 Change-Id: I33713dda5f03b96b78c6fc4fb78aa289be064330 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83018 Tested-by:
-
Andreas Nedbal authored
interactjs was introduced in page module drag&drop handling with #98471. It turned out that the library is not necessarily required and is therefore replaced with native drag&drop API. Co-authored-by:
-
Andreas Kienast authored
The CSS classes `.diff-[r|g]` were used in the old `DiffUtility` that was removed in the v7 development cycle, but it was missed to remove the CSS as well. This patch removes the CSS classes and it's remaining reference in a language label. Resolves: #103335 Releases: main Change-Id: Ie1fb7122fc906b160cbda7bd96979bc4c97549a6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83326 Reviewed-by:
-
- Mar 07, 2024
-
-
Benni Mack authored
This change adapts various places where there are cross-dependencies between objects that contain state when rendering the page module. Resolves: #103326 Releases: main Change-Id: I09db90bc4c47f0a15d9890ed40d6cb65b2dff30d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83313 Tested-by:
Frank Nägler <frank.naegler@typo3.com> Tested-by:
-
Andreas Kienast authored
The module `@typo3/backend/tree/page-browser` used to modify a string representing an URL by appending arguments to a query string. The code is now modified to use a proper `URL` object, which is considered more safe for such tasks. Resolves: #103313 Releases: main, 12.4 Change-Id: I39c2c99a348aa338efc7724e96c732e65693343e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83270 Tested-by:
Andreas Nedbal <andy@pixelde.su> Reviewed-by:
-
Andreas Nedbal authored
Resolves: #103275 Releases: main Change-Id: I8fee9a0ecfdecceb50fa18983f2f3b2f2d8c0b0c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83203 Reviewed-by:
-
Oliver Bartsch authored
Page types might contain a static string as label instead of a locallang key. To prevent a RuntimeException, the static string is used as the default now. Resolves: #103315 Releases: main, 12.4 Change-Id: I50858fe6500766e5a66b83e9e72be82c35218ca2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83293 Tested-by:
-
- Mar 06, 2024
-
-
Christian Rath-Ulrich authored
To make the functionality of the button that opens the datepicker clear to screenreaders, an aria-label is added to the button. Resolves: #102470 Releases: main, 12.4 Change-Id: I3c16c887cd148101fe225d65ea95a6f88dd1518b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81879 Tested-by:
Willi Wehmeier <wwwehmeier@gmail.com> Reviewed-by:
Christian Rath-Ulrich <christian@rath-ulrich.de> Reviewed-by:
-
Oliver Bartsch authored
Prevent an undefined array key warning in case the configured `languageField` does not exist in the current database row. Resolves: #103289 Releases: main, 12.4 Change-Id: I3e5747757928efe007b8b6ad73ac5df6c3000619 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83219 Reviewed-by:
-
Andreas Kienast authored
To invoke a deletion on items in FormEngine's Inline Relation container API-wise, a new message identifier `typo3:foreignRelation:delete` has been introduced. Resolves: #102836 Releases: main Change-Id: I6627beb8bfa61be71239ed80e060e66163bc812a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82594 Tested-by:
Daniel Siepmann <coding@daniel-siepmann.de> Tested-by:
-
