- Nov 26, 2021
-
-
Chris Müller authored
The work on this interface was 7 years ago, time to remove the todo. Resolves: #96093 Related: #62928 Releases: master, 11.5 Change-Id: Ieaf08a17eb02c60109f9fcdaf279c608f3a4a146 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72315 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
-
Christian Kuhn authored
Table sys_language is legacy since language setup is bound exclusively to site config in v11. We don't need to import sys_language rows and assert their state in functional tests anymore. In preparation of the soon starting v12 deprecation removals, the patch drops sys_language table row imports and table state asserting in all functional tests that use .csv file based fixtures. Resolves: #96089 Related: #94165 Releases: master, 11.5 Change-Id: Iea752cf03bba690b5a04de7ce5718de274172e43 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72313 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
- Nov 25, 2021
-
-
Christian Kuhn authored
Functional tests that extend AbstractDataHandlerActionTestCase test for correct sys_refindex in tearDown(). This can be avoided by setting assertCleanReferenceIndex to false, which is only a temporary solution until reference updating fully works. The patch changes some import fixtures that come without proper sys_refindex rows to avoid setting this property to false. One last call needs a dedicated bug fix and will have a dedicated patch. Change-Id: I7daa4d961372812312389dda7af13a5ac9fe8cef Resolves: #96074 Releases: master, 11.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72284 Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Christian Kuhn authored
ext:backend Form/Element recently got a trait with #95954 that can be easily avoided by adding the method to AbstractFormElement, which all elements should extend. Resolves: #96071 Related: #95954 Releases: master, 11.5 Change-Id: I8dc73f17b976f8191bf39bae5b51f2609778797c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72281 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Oliver Bartsch authored
Using "readOnly" for a TCA field with renderType "selectCheckBox" previously led to the fact, that nothing was rendered at all. This can be seen with `tx_styleguide_elements_select.select_checkbox_4`. This is now fixed, while the whole element got a light code cleanup. This will increase performance a bit, since unneeded JavaScript is no longer loaded. Additionally, this also fixes the "expandAll" option, which was broken due to the bootstrap 5 upgrade. Resolves: #96058 Resolves: #96068 Releases: master, 11.5 Change-Id: I762d328c9f4c83558dd8fd98683f8ccfe6c4b3f0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72279 Tested-by:
-
- Nov 24, 2021
-
-
Oliver Bartsch authored
With #94222, the TSconfig preview of a TCA field with renderType= belayoutwizard was adjusted to use the CodeMirror plugin - in case EXT:t3editor is installed. With this change, also the default "preview" was changed form a <code> element to a <textarea>. This therefore led to the field being editable. However, any manual change will always be overwritten on adjusting the grid via the editor or on saving the record. To avoid confusion for the user and to be in line with the CodeMirror variant, the previous behaviour is restored by adding the readonly attribute to the <textarea> element. Resolves: #96064 Related: #94222 Releases: master, 11.5 Change-Id: Iaa41df59cbfd0420962c2239a42d329c249adb6c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72278 Tested-by:
-
Oliver Bartsch authored
TCA renderType=belayoutwizard did previously not work for custom fields, as can be seen in styleguide `tx_styleguide_elements_basic.text_20`. BackendLayoutWizardElement used the hardcoded field name "config", which however is only used for the "backend_layout" table. Additionally, using the raw database value instead of the processed "itemFormElValue" led to further issues, e.g. when the field is defined with "l10n_display=defaultAsReadonly". This is now fixed by using the "itemFormElValue", since this is the correct value, which is also added to the corresponding input field and would also contain the "default" for new records. Additionally, the given parsed itemFormElValue is now checked to start with the correct root level key "backend_layout.". This prevents undefined array key warnings, triggered when a malformed default value is used for the field. Resolves: #96060 Releases: master, 11.5 Change-Id: I2d7c40bf3b33d6d2528c7575febe67d105ab5e12 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72276 Tested-by:
-
Oliver Bartsch authored
In case a TCA field with renderType=belayoutwizard is configured to be not in the initially visible tab, the CodeMirror editor remains empty, when switching to the tab, containing the editor. The reason is, CodeMirror needs to be refreshed, after becoming visible. Therefore, the GridEditor, holding the configuration, is now observed, if not initially visible. As soon as it becomes visible, the CodeMirror instance - if any - is refreshed. Can be tested with `tx_styleguide_elements_basic.text_20`. Resolves: #96062 Releases: master, 11.5 Change-Id: Ic03c315e8f12bc2f3623fdb11a1782d5c1081a23 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72277 Tested-by:
-
- Nov 23, 2021
-
-
Oliver Hader authored
BackendUtility::getUpdateSignalCode() returned plain inline JavaScript code which got replaced by new BackendUtility::getUpdateSignalDetails(). The new function is capable of handling inline JavaScript code (for backward compatibility reasons) and HTML markup using corresponding `<typo3-immediate-action>` custom element. OpendocsToolbarItem::updateNumberOfOpenDocsHook has been adjusted as well to use the script-less implementation. Resolves: #96002 Resolves: #96012 Releases: master, 11.5 Change-Id: I248db207600ae5c7452471a093f84f3802050c59 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72206 Tested-by:
-
Nikita Hovratov authored
By setting the display property of buttons inside of input-groups to "flex", the height of the element inside the button can be easier controlled. Resolves: #95451 Releases: master, 11.5 Change-Id: Ia41d6bf4421d8ad078509893c8b0177708767e5c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71459 Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
-
- Nov 22, 2021
-
-
Jochen Roth authored
Currently when a language in site configuration is removed the modal cancel button does not remove/cancel the modal. This has been fixed by adding a trigger to close the modal when the cancel button was clicked. Resolves: #96016 Releases: master, 11.5 Change-Id: I100d84a7fa5f6a84d1045fec0a63d7c20789b42d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72219 Tested-by:
-
- Nov 19, 2021
-
-
Oliver Bartsch authored
The RequestUpdate component, handling the TCA "onChange" functionality, adds an event listener to the main HTML field. In case of TCA type "input", this field never dispatches such event, because the user always changes the "human readable" field in the GUI. The main field is only updated manually by FormEngine after validating the new value. Therefore, the "onChange" property never had any effect for TCA type "input" fields. This is now fixed by dispatching a "change" event for the main field after its value has been updated. Resolves: #93613 Releases: master, 11.5 Change-Id: I9facf3548619b3733975fb5c8f28622d03002e7b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72205 Tested-by:
-
Jochen Roth authored
Given you have a user which has no access to the current page or no page at all, a "access array offset on value of type" is thrown in PHP8. This has been fixed by adding a fallback in case the array key does not exist which then throws the expected exception. Resolves: #96026 Releases: master, 11.5 Change-Id: I335a74fb6c2566d7a3e65632977dbc2740249414 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72228 Tested-by:
-
Benjamin Franzke authored
This applies to rendering of database mounts (from groups or from workspaces): They are now shown as children of the virtual root page (uid=0) as it used to be in TYPO3 v8. This is to allow workspace users to get an overview of all changes of all mounts by navigating to the virtual page uid=0. Releases: master, 11.5, 10.4 Resolves: #95854 Related: #95972 Related: #91145 Change-Id: I7f6370f327711396193cf56b63f15876350c2559 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72028 Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
-
- Nov 18, 2021
-
-
Oliver Hader authored
Closing a popup window does not use inline JavaScript code anymore. Resolves: #96019 Releases: master, 11.5 Change-Id: Iea2354e30d51ddcd24d9288fe5fa87b924259c13 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72222 Tested-by:
Torben Hansen <derhansen@gmail.com> Tested-by:
-
Oliver Hader authored
When resolving inline JavaScript invocations in issue #95954 it looked like AJAX-aware elements in FormEngine would share a common abstract implementation in the client-side handling. Actually AJAX response handling is independent for each of those elements... This change now applies changes, that previously have been made to `TYPO3/CMS/Backend/FormEngine/InlineRelation/AjaxDispatcher`, to `TYPO3/CMS/Backend/FormEngine/Container/FlexFormSectionContainer`. Resolves: #96027 Releases: master, 11.5 Change-Id: Icf507a32399f72182597e9c8d650fb2d9a35e480 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72231 Tested-by:
Jörg Bösche <typo3@joergboesche.de> Tested-by:
-
Oliver Hader authored
Resolves: #96022 Releases: master Change-Id: I6d9be94a4013d1380f75ef6f6f8f7f330d15f9f5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72224 Tested-by:
-
- Nov 17, 2021
-
-
Oliver Hader authored
Due to a bug, inline form fields were initialized twice, causing internal application state issues in FormEngine and Modal handling. Resolves: #96009 Releases: master Change-Id: I07f75ae90826eec77515ec84e69f4154828295a1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72214 Tested-by:
Chris Müller <typo3@krue.ml> Tested-by:
-
- Nov 16, 2021
-
-
Oliver Bartsch authored
In #94688, the table layout of form fields had been replaced by a grid layout. However, some places did not receive the new classes, leading to display error. This is fixed by adding the corresponding classes to those places. Resolves: #95994 Relates: #94688 Releases: master Change-Id: Iba3ea2d3f665d055864edd9c8329dac939aa2642 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72191 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Oliver Hader authored
Change-Id: I5796168cca0ddfd134da596d016a784bb9ab55b9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72188 Tested-by:
-
Oliver Hader authored
Change-Id: I963971774750267bde8c1f4816ec9f07f2dad9f1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72187 Tested-by:
-
- Nov 15, 2021
-
-
Oliver Hader authored
Reduces amount of `requireJsModules` and `scriptCall` invocations in AJAX response handling and migrates to new `scriptItems` which is forwarded to JavaScriptHandler.js. Resolves: #95954 Releases: master Change-Id: I258da49fef46ccc36c602e0fd7c9a14ddb3cec1d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72154 Tested-by:
-
Nikita Hovratov authored
Resolves: #95987 Releases: master Change-Id: Icd868d64e0414fa295f1d03c7cbe102b388ff978 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72182 Tested-by:
-
Nicole Cordes authored
The ConditionMatcher tries to resolve the current page id from global variables. One of this possibilities uses the cmdMap that is sent to the DataHandler. This patch ensures that the correct target uid is used to resolve the page id. Resolves: #95967 Releases: master, 10.4 Change-Id: I0fb7968c3118f2ab78c1cbb1dda3643e9f2f450e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72163 Tested-by:
Kevin Appelt <kevin.appelt@icloud.com> Tested-by:
-
Benni Mack authored
Bootstrap 5 ships with "text-end" which is semantically more correct than "text-right". This change adapts the needed places in TYPO3 Core to use "text-end". Resolves: #95974 Releases: master Change-Id: I9c72b5004594ef46faba79e0ea78fe24025a93a1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72172 Tested-by:
-
Christian Eßl authored
Previously, when creating a translated content element of type `shortcut`, the preview in the page module would always show the title of the reference from the original language. In case the referenced record has been translated as well, the preview now shows the translated title instead. Resolves: #92523 Releases: master Change-Id: I5dd5de3a63db916311ede94a07bb7fb3209795f2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66090 Tested-by:
-
Benjamin Franzke authored
empty() returns true if a record contains 0 as value. Therefore isset() needs to be used instead. The corresponding fix that was introduced with #91145 to workaround this flaw is removed again. Resolves: #95972 Related: #91145 Releases: master, 10.4 Change-Id: Idfea91b84d8391d680900966f57b406c28a616ce Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72170 Tested-by:
-
Benni Mack authored
Used commands: > yarn add "bootstrap@^5.1.3" > yarn add "@popperjs/core" > grunt build Resolves: #95975 Releases: master Change-Id: Icacbf8d51c4e3345b9c549433c5ae28ba88848d9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72173 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Anja Leichsenring authored
For easier testing, ext:irre_tutorial "csv" setup is extracted to a dedicated extension. Tests concerning these tables can now load the smaller test extension, which reduces system load and simplifies maintenance. Resolves: #95951 Releases: master Change-Id: Ib2040107929d795dd5b2606bff170a23435e541a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72165 Tested-by:
-
Christian Eßl authored
There were several problems with tooltips in the page tree: - htmlspecialchars was applied twice to the tooltip string. Once in BackendUtility::titleAttribForPages, once in TreeController. - When applying double or single quotes to a page title, the tooltips in the page tree would show these as html entities. Double and single quotes are now allowed, while any potential html tags in the title will be stripped from the tooltip. Any of those characters (", ', <, >) left in the tooltip are later escaped to unicode in the json view. Resolves: #91424 Releases: master Change-Id: I53b2ad6bbd4e4131535eb573422a8cbd5d002858 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64511 Tested-by:
-
- Nov 11, 2021
-
-
Gabe Troyan authored
Currently, the value of `USdateFormat` is disregarded because the corresponding property, `FormEngineValidation.USmode`, is set to zero regardless in `FormEngineValidation.initialize()`. This change will ensure that `USmode` will remain 1 without conflicting with core functionality that relies on `USmode` being set *before* `initialize()` is called. Resolves: #86679 Releases: master, 10.4 Related-to: #91105 Change-Id: I5584ca7fe92742e28147f9883fedf53e0556f1b1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72034 Tested-by:
-
- Nov 10, 2021
-
-
Oliver Bartsch authored
TableController was removed in #95036. The corresponding service registration is now removed, too. Resolves: #95955 Related: #95036 Releases: master Change-Id: I9e55be091fd911f8f4d3d99f72fd4a30af505390 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72156 Tested-by:
-
Imko Schumacher authored
Native time fields (dbtype) in the record list are now displayed independent from the server timezone. Resolves: #92962 Releases: master, 10.4 Change-Id: Ie9075378e67d0c302b126db78751992789fae29c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66953 Tested-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
-
Tomas Norre Mikkelsen authored
FlexForm Section can be added before content element is saved. This is done by ensuring that processedTca have a value for list_type. Earlier the pi_flexform was ignored as the default values on create before save was empty. Resolves: #81684 Releases: master, 10.4 Change-Id: I62e03cbbd93e8785f58c24dad1e573e8b5e0202b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68152 Tested-by:
-
Oliver Bartsch authored
The contents of the toolbar dropdown menus for bookmarks and open documents are dynamic. Having e.g. a lot bookmarks previously lead to the most recent bookmarks might be cut of at the bottom of the screen. This is now fixed by using a maximum height and allowing vertical scroll. Resolves: #94641 Releases: master Change-Id: I50b799c628e51fbcb8b59ad5eb64d369647c27fe Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72140 Tested-by:
-
Nikita Hovratov authored
TCA shares same keys across different types, and so does "items" with type check, radio and select. The value is usually set for the array key "1". But type check is special in that regard: the value is stored as a bitset. This means, the value is completely unused and shall not be provided for checkboxes. 1. All occurrences of "items => ['1' => '']" removed. 2. When checkboxes only have 1 item and no configuration whatsoever, "items" can be omitted. These constructs are gone now: 'items' => [ [ 0 => '', 1 => '', ], ] Resolves: #95876 Releases: master Change-Id: I3deb96498e3afb8823cd6397e57e268c68774276 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72056 Tested-by: -
Stefan Bürk authored
InputTextElement::render() calls htmlspecialchars() to output the itemValue. $itemValue can be null null instead of a string at this place and feeding null to htmlspecialchars() emits a E_DEPRECATED PHP 8.1 error. Sanitize call. Resolves: #95929 Releases: master Change-Id: I96eeb6fb0b19e5f751b68e835a59726c7a4657b6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72106 Tested-by:
-
Oliver Hader authored
To decrease the amount of inline JavaScript that has been generated by some PHP process assignments and invocations are declared in a more strict way. This would allow to make use of strict content security policy denying invocation of unsafe-inline scripts. Resolves: #91786 Releases: master Change-Id: I89384d661ebd35a5fda10f9587a7f41db4f587aa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64123 Tested-by:
-
Stefan Bürk authored
TextElement::render() calls strlen() to determine length of form elemet item value. It may be that item value is null instead of a string at this place and feed null to strlen() emits a E_DEPRECATED PHP 8.1 error. Sanitize call. Resolves: #95930 Releases: master Change-Id: Ib7f073d59e4bbc39fb070d86bbfe3a5b69d3bef8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72107 Tested-by:
-
Stefan Bürk authored
TextElement::render() calls htmlspecialchars() to output the item value. It may be that $itemValue is null instead of a string at this place and feed null to htmlspecialchars() emits a E_DEPRECATED PHP 8.1 error. Sanitize call. Resolves: #95931 Releases: master Change-Id: I0b2066e7161b2e12e3a4b39d3f9669938a04c9bb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72108 Tested-by:
-
