- May 02, 2023
-
-
Helmut Hummel authored
When defining a default value in column overrides e.g. for tt_content TCA field sys_language_uid this value from TCA will override the value that will be set via the page module when adding a content element for a different language, because the change introduced in #86876 does not respect default values that are set via defVals (which are passed to form engine as defaultValues) A check if such values are set is now added, so that the fix for #86876 will still work, but default values set via editing forms are also respected Resolves: #99381 Releases: main, 11.5 Change-Id: Ib4270665b396bbe520afb21a7f145d0d549305ac Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78893 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
Oliver Bartsch authored
Properly check for the given value being an object before passing it to corresponding method, which is type-hinted since #100068. Resolves: #100774 Related: #100068 Releases: main, 11.5 Change-Id: I704ef93ebbbfd1f161bf56dd7ef0058bd2b4875d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78918 Tested-by:
-
Oliver Klee authored
This helps static analysis of projects using this class. Resolves: #100778 Releases: main, 11.5 Change-Id: I41cbf38477fb6743e5039dd9905ed38be81e96fc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78915 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
- Apr 27, 2023
-
-
Oliver Bartsch authored
Resolves: #100770 Releases: main, 11.5 Change-Id: I549371e78de399195d6810858d337528f39ce0ad Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78892 Tested-by:
-
Andreas Fernandez authored
The list of ids generated by `getSearchableWebmounts()` may contain duplicated values being passed into an `IN()` criteria, causing additional load to the database server. The values are now de-duplicated by applying `array_unique()` onto the list before passing the list around. Resolves: #100750 Releases: main, 11.5 Change-Id: Ib49bf1a5903cca2fbaa12ea240050caa7908f69c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78874 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de>
-
- Apr 25, 2023
-
-
Daniel Siepmann authored
Resolves: #100742 Releases: main, 11.5 Change-Id: Ibff1f2da48192a23d3fe6e5404c95f3b7e6c8ae8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78852 Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
- Apr 24, 2023
-
-
Benni Mack authored
With #100720 the AbstractExceptionHandlers const IGNORED_EXCEPTION_CODES was set from private to public in order to allow to use it in subclasses. However, public is making this a full public API, which should be within the ExceptionHandler logic in general. For this reason, the constant is now changed from public to protected. Resolves: #100736 Relates: #100720 Releases: main, 11.5 Change-Id: I58427977c2217792ae854738f59527bdb2e8339e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78736 Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
-
Markus Klein authored
Body content generation may be triggered by calling some getter or indirectly when the mail is sent (via `ensureValidity`). This changes ensures that multiple tries to generate the body are only executed if the state of the view has actually changed. This enables extensions to manipulate the content of an e-mail via events without getting their changes overridden again when the mail is sent. Resolves: #99944 Releases: main, 11.5 Change-Id: I5eced5710feeb66e6f1e32f10f710d388bc43a62 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78251 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
Thomas Hohn authored
The variable $row['url_response']['errorParams'] should always contain a value. Either the actual error message array or an empty array to avoid a PHP 8 warning. The corresponding getErrorMessage methods now have a guard clause to check if the array is empty to avoid further propagated warnings. In TYPO3 v13 that signature of the getErrorMessage should be changed to be array. The array $errorParams is always initialized to an empty array instead of null. IN TYPO3 v13 the default value of $errorParams should be [] instead of null. Resolves: #99988 Releases: main, 11.5 Change-Id: I0f7e10f45e0f5ec7e80b79d705b38fda9a3f1410 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78812 Tested-by:
-
Christoph Lehmann authored
This makes AbstractExceptionHandler::IGNORED_EXCEPTION_CODES public accessible in order to re-use it in custom error handlers. Resolves: #100720 Releases: main, 11.5 Change-Id: Id9217d3bbf3b66982adceb485918e52bb5cddd56 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78735 Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Christoph Lehmann authored
Illegal requests should not fill log files. The Exception is thrown in \TYPO3\CMS\Core\Http\Request::validateMethod() Resolves: #100718 Releases: main, 11.5 Change-Id: I202fba9e76ac00ab11e02dc401633b383b0048b6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78734 Reviewed-by:
-
Torben Hansen authored
The redirect evaluation is currently always processed no matter if a `redirectMode` based on the referer is configured or not. Also, given referers are checked for validity using `RedirectUrlValidator`, which logs a message in the TYPO3 log with the log level `warning` if the given URL is considered as invalid. This patch adds a check to the referer evaluation, so it is only processed, if a redirect mode supporting the referer is active. Additionally, the log level for invalid redirect URLs in `RedirectUrlValidator` is changed to `debug`, since a warning is not appropriate for invalid redirect URLs. Resolves: #100197 Releases: main, 11.5 Signed-off-by:
Torben Hansen <derhansen@gmail.com> Change-Id: I10d1723de131e0387f7dd2103c8a1ca21ed015e5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78733 Reviewed-by:
-
- Apr 22, 2023
-
-
Oliver Hader authored
Prior to #93240 URL routes were reverse sorted using the corresponding site identifier (which did not contain any URL information). For the scenario of matching undefined URLs (e.g. base URL is "/website/", but request was like "https://example.org/"), the first item of a reverse sorted list was used. Resolves: #99149 Related: #93240 Releases: main, 11.5 Change-Id: Ia242591cebfba7d8221494a5d214f6dca75a00fc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78794 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
- Apr 21, 2023
-
-
Markus Klein authored
Remove any modification done to Context by the RedirectHandler/RedirectService in order to have a proper rendering of FE in case no valid redirect is found (circular). Resolves: #100654 Releases: main, 11.5 Change-Id: I7fb0c1ac9619d7599151e57cbcacc916deee41c5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78722 Tested-by:
-
Markus Klein authored
Whenever a scheduler task fails during execution via CLI `scheduler:run`, the error message is now always written to stderr. This gives the task executor (e.g. cron) a chance to identify any failures, if even stdout is redirected to /dev/null. The task-loop is adapted to avoid (ab)using exceptions for control-flow (for loop-abortion). It instead now uses nullables to signal that not finding a next-task is expected behavior, not an exception. Also the exit code of the command is adapted to switch to 1 in case at least one error occured. (This is important in case the cronjob is executed as systemd-timer) Resolves: #87806 Releases: main, 11.5 Change-Id: I0b55bab7fcd916209114d9e3e07f54c7243ce9a5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78220 Tested-by:
Benjamin Franzke <benjaminfranzke@gmail.com> Reviewed-by:
-
- Apr 20, 2023
-
-
Andreas Fernandez authored
The dimensions available in `CropperEvent` are fractions in some cases, that probably happens when an image gets upscaled. This causes issues as those dimensions are apparently adjusted downward in the cropper library, resulting in dimension reduced by 1px. To solve this issue, `Math.ceil()` is applied to round up incoming dimensions. Resolves: #96722 Releases: main, 11.5 Change-Id: I537bccd32a634805a37957bea59ec51e5e856272 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78769 Reviewed-by:
-
- Apr 18, 2023
-
-
Oliver Bartsch authored
In case an export is created based on e.g. an invalid preset, no PHP TypeError should occur. This is now fixed by properly typecasting the input data. Additionally, two possible undefined array key access warnings are fixed. Resolves: #97403 Releases: main, 11.5 Change-Id: I994391909b44247879099ce92d61911c56ca7e39 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78732 Reviewed-by:
-
Markus Klein authored
Extbase does not ask the database anymore for relations, where the uid in the database field is zero. This prevents SQL queries with where-parts like `uid IN (0)`. Since this is done when reconstituting models from the database, depending on the amount of relations of a model, the number of saved queries is huge. Resolves: #99505 Releases: main, 11.5 Change-Id: If3b6c2756674eeb43a66b59a13e44011c9845cd5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77582 Tested-by:
Stephan Großberndt <stephan.grossberndt@typo3.org> Tested-by:
-
- Apr 17, 2023
-
-
Oliver Bartsch authored
Used command(s): > Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #100565 Releases: 11.5 Change-Id: I11d1680ec707e7c93d8dcbfcf558d840094a1a65 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78692 Reviewed-by:
Sybille Peters <sypets@gmx.de> Tested-by:
-
Chris Müller authored
Additionally, remove outdated manuals from list in Settings.cfg. Resolves: #100641 Releases: main, 11.5 Change-Id: Idc09d4da5a0131ae9d4554790d6f782a87d8da5a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78577 Tested-by:
-
Albrecht Köhnlein authored
Set the variable `$linkParts['tableName']` even if the currently linked record could not be found. The variable is required in later step to show information, which also should be present for deleted records. Resolves: #100611 Releases: main, 11.5 Change-Id: I3f5d1e53d8c6889c8907af5ff56c76eb74efa5fc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78680 Tested-by:
Albrecht Köhnlein <ak@koehnlein.eu> Reviewed-by:
Jörg Bösche <typo3@joergboesche.de> Tested-by:
-
Benni Mack authored
Resolves: #98985 Releases: main, 11.5 Change-Id: Id886584f8fa57b30f54257d79a6eca4465906a86 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78576 Reviewed-by:
-
- Apr 16, 2023
-
-
Albrecht Koehnlein authored
The HTML parser failed to correctly detect single tags with closing `/` and without white space, e.g. `<br/>`. The old tag name detection only splitted the tag content by white spaces, which is not enough to correctly find these valid tags. So the new way is to also remove trailing slashes from the tag name. Resolves: #96347 Related: #96307 Releases: main, 11.5 Change-Id: I3acefcbf046600bf118764b873f15b2a1678932d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78575 Tested-by:
-
Albrecht Köhnlein authored
Set the array index `$linkDetails['typoLinkParameter']` in `\TYPO3\CMS\Redirects\Service\RedirectService` to pass it through. That information is needed for the LinkBuilder. For example, `DatabaseRecordLinkBuilder` would trigger an array key access error, in case the linked record cannot be found and no link can be generated. This array value is use there for the thrown exception message. The team play between `LinkService->resolve()` and the `LinkBuilder->build()` should be reviewed in a dedicated change. It may be useful, that the resolver directly adds this information to the result, making the manual adding at several placed through out the core obsolete. Comments are added to document this. Resolves: #100612 Releases: main, 11.5 Change-Id: I74cbf5cbb1b91e0045207873554aec4477986c4b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78672 Tested-by:
-
Stefan Bürk authored
The docker container image hub is slowly becoming more and more problematic for open source organisations, it's time to move to another container registry for core-testing images. Images are now build and published to both Docker HUB and GitHub Container Registry (`ghcr.io`). To test the ghcr.io images, the patch changes runTests.sh to use them them for local (non CI) execution already. We can not fully switch to ghcr.io yet, since CI uses the docker registry container as mirror for images to heavily reduce network load and increase performance. The registry container however can only mirror hub.docker.io images, so we need a different solution for CI first. When this is done, we'll stop uploading images to docker hub later. Resolves: #100617 Releases: main, 11.5, 10.4 Change-Id: Ia309826618696dc25b15527b73fa704235285479 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78668 Tested-by:
-
- Apr 15, 2023
-
-
Stefan Bürk authored
External "enshrined/svg-sanitize" package uses `libxml_use_internal_errors()`, but fails to clear errors using libxml_clear_errors(). This can lead to side effects with subsequest libxml usages. An upstream patch to fix this is pending, but it needs to be merged and released. In the meantime, we mitigate the issue in our wrapper class. See: https://github.com/darylldoyle/svg-sanitizer/pull/90 Resolves: #100607 Releases: main, 11.5 Change-Id: I911119b498a4dda8312c5ca940b5fdf6410a1a87 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78648 Tested-by:
-
- Apr 14, 2023
-
-
Oliver Klee authored
Simplify `initialize` using a guard clause. Resolves: #100598 Releases: main, 11.5 Change-Id: Ic53d190a139bc4c74517fc680adf43a8daadb6d9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78574 Tested-by:
-
Oliver Bartsch authored
Since it's valid to use a digit-only subject or title, those options are now properly cast to a string, preventing TypeError exceptions when passing them to type-hinted functions. This happened due to PHP converting digit-only strings to integers. Resolves: #100582 Releases: main, 11.5 Change-Id: I30c543b64f41b91ed64edabdb4bd2d9720f24e51 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78628 Tested-by:
-
André Buchmann authored
Resolves: #100580 Releases: main, 11.5 Change-Id: I10e4b21908a1b4649d7ab4b02c467af381017b2b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78627 Tested-by:
-
- Apr 13, 2023
-
-
Andreas Fernandez authored
This patch pre-defines `cropBox` with an empty jQuery object to avoid errors when starting the image cropper. A similar fix was already done in #99953, that's why the issue doesn't pop up in v12. Resolves: #100576 Releases: 11.5 Change-Id: I5d4fc7022a7521816ffc7762dde146256a6171ff Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78615 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Benni Mack authored
When using a formField with a property name that only consists of a number (e.g. a UID), Fluid will now allow this. Resolves: #100281 Releases: main, 11.5 Change-Id: Ief95b87af1025f65ac0db1ed0c64b6fcf9c40bbe Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78573 Tested-by:
-
Christian Kuhn authored
A new patch level forces us to regenerate baseline. > composer req --dev phpstan/phpstan:^1.10.13 > Build/Scripts/runTests.sh -s phpstanGenerateBaseline Change-Id: I7e616c60e448332ed10183665b772d892670480f Resolves: #100573 Releases: main, 11.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78612 Tested-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Reviewed-by:
-
- Apr 12, 2023
-
-
Christian Eßl authored
The changes introduced in #93706 broke the preview button functionality in multidomain setups. When first previewing the page in one page tree and then clicking the preview link in the page tree of a different domain, a DOMException due to a cross origin error would be triggered in JavaScript, because it is not allowed to access the constructor of a window object from a different context. The thrown DOMException is now properly caught. Resolves: #99286 Related: #93706 Releases: main, 11.5 Change-Id: I709f06ef89e248d7b88d500281e708f56557a176 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78571 Tested-by:
-
Ayke Halder authored
Improve the privacy of users by using the no-cookie setting by default as fallback and set the do not track parameter to 1. This fix recreates the behaviour already implemented for YouTube embedded media to also apply for Vimeo embedded media: If the setting 'no-cookie' is not set at all then use the 'no-cookie' url anyway. Resolves: #100466 Releases: main, 11.5 Change-Id: I37e23f6220696591c2eb7d58dd8932d9b766a491 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78572 Tested-by:
-
- Apr 11, 2023
-
-
Benni Mack authored
Change-Id: Ifb6baec06e9a7be3e891b6e3e7b314d52886b87c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78568 Reviewed-by:
-
Benni Mack authored
Change-Id: Iedc984e71a0cd1d82d1f7f0f28ddf8c9712b9575 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78567 Reviewed-by:
-
Oliver Bartsch authored
This fixes the YAML configuration of the "Number" form element, making the gird selection available. Resolves: #98930 Resolves: #100412 Releases: main, 11.5 Change-Id: I1586adfc41c00070e00db10a1b71d614f34f3466 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78561 Tested-by:
-
jakotadesigngroup authored
This file was removed in v12 and only the version in TYPO3\CMS\Lowlevel\Database\QueryGenerator was updated with fixes. This patch backports all the checks to the v11 TYPO3\CMS\Core\Database\QueryGenerator Resolves: #98536 Releases: 11.5 Change-Id: I7aabc6e5b31529c15fd50b390c346b1ec7caf71d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78139 Reviewed-by:
Ralph Brugger <typo3bugs@public.linkpool.de> Reviewed-by:
-
Stefan Bürk authored
Ensure that invalid array key accesses are properly guarded. Resolves: #99863 Releases: main, 11.5 Change-Id: I1900eb96f4c77d11accc465aa5847af3e642afcc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77778 Tested-by:
-
Alexander Grein authored
The recursive function pagesToFlatArray make use of the page tree repository on two places, which always instantiates the same object. To improve the performance this patch instantiates the page tree only once and stores it in a protected property. Moreover, it adds another protected property editPageAndDefaultLanguageAccess, which holds the general allowance of a backend user to modify pages and access to the default language. This information is needed in the pagesToFlatArray as well and was requested over and over again. Finally, the array_merge construction inside fetchDataAction and filterDataAction was changed to a more performant solution, by merging it after the loop. Overall, this reduces the request time of a page tree ajax call (data and filter) by around 10%. Resolves: #99852 Releases: main, 11.5 Change-Id: I75e8fca96c3eebec72a00e328c634338191d31c1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78304 Tested-by:
-
