- Jun 07, 2018
-
-
Christian Kuhn authored
The ext:impexp related functional export tests compare with different target .xml file exports depending on the used db engine. This is ugly and pain to maintain. The patch aligns last differences between the generated exports by fixing sorting bugs in fixture db rows and adding an explicit order by at test preparation stage. Additionally, a column type bug in irre_tutorial fixture extension got resolved. The different .xml export file comparison fixtures per db engine are then merged into one and the split logic within tests removed. Change-Id: I429d5127e09c3e3714edae938cb0bf796b3274fd Resolves: #85178 Releases: master Reviewed-on: https://review.typo3.org/57141 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
-
Christian Kuhn authored
Method BackendUtility::getRecord() returns strings or integer values for number columns like int / bigint. This detail depends on the underlying driver, for instance mysqli returns integers for those fields, while native pdo_mysql and our pdo_pgsql setup return strings for everything. This leads to different xml files when exporting records depending on driver, since GeneralUtility::array2xml() may add type="integer". That's especially nasty for the functional export tests and is one reason we have to maintain dedicated xml fixture files per db driver. During import, the type value does not matter, it needs to be able to cope with both variants anyway. The patch now just forces strings for all to-be-exported row values. Resolves: #85175 Releases: master Change-Id: Ic132d8abd906b34c59279ce025c0bdd65e954672 Reviewed-on: https://review.typo3.org/57140 Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Christian Kuhn authored
Adds a class that auto creates TYPO3 "management" related database columns and indexes based on TCA 'ctrl' information without having them specified in ext_tables.sql. The feature .rst file outlines field details. Goals: * Save extension developers time. * Less copy+paste issues and different general fields definitions. * Reduce number of boilerplate fields in ext_tables.sql. * Bring schema of management fields under core control. Non goals: * No full substitution of ext_tables.sql by TCA: "Business" fields from 'columns' are NOT created automatically. This would require further thoughts and code disentangling. * No new extension API. * No "migration" approach or similar. Notable patch details: * The patch is a revamped version of issue #81234 that has been abandoned. As requested in the review of #81234, the code now hooks in after ext_tables.sql has been parsed into the doctrine schema. * Field defintions of ext_tables.sql take precedence, auto fields are only added if ext_tables.sql does not define a column or index. This makes the patch fully backwards compatible. * No deprecation for obsolete field definitions in ext_tables.sql is logged. * Many core fields are aligned to a central definition and slightly change. For instance "uid" is now always an unsigned int. * Reduce all core's ext_tables.sql files as well as the functional testing related ext_tables.sql files down to the business fields * A relatively huge series of test adaptions: Especially the ext:impexp related functionals now create dumps with differently sorted fields - This is no problem during import. * Field t3_origuid of sys_file_reference has never been registered in TCA as ['ctrl']['origUid'], is thus unused and removed as obsolete. * The extension manager no longer applies possible destructive changes, it only adds missing columns and tables when loading / updating extensions. It however considers *all* ext_tables.sql files, not only the one the extension in question provides. See the important .rst file for details. Change-Id: I640a7c7da3b63bac21a71102f253aa2d1bef4391 Resolves: #85160 Related: #81234 Releases: master Reviewed-on: https://review.typo3.org/57121 Tested-by:
-
Kevin Ditscheid authored
Fix the link browser to not drop the additional link params if editing a link with additional link params set. Resolves: #85040 Releases: master, 8.7 Change-Id: I4c016f701b38e048aa999c4e96365019eae4a237 Reviewed-on: https://review.typo3.org/57009 Tested-by:
Andreas Wolf <andreas.wolf@typo3.org> Tested-by:
Frank Naegler <frank.naegler@typo3.org> Tested-by:
-
Christian Kuhn authored
composer updade typo3/testing-framework The update brings a couple of cleanups and bug fixes and an improved functional test case splitter script now used in bamboo. Resolves: #85171 Releases: master Change-Id: I79e30fd4e93e4a1635a74e225d4801dfb1768ad4 Reviewed-on: https://review.typo3.org/57134 Tested-by:
-
Christian Kuhn authored
The various "AbstractActionTestCase" classes of the functional data handling tests only prepare the scenario, while the extending Test classes of ext:core and ext:workspaces then call parent and add assertions. The abstract test preparations thus must not have @test annotations, they would be executed as casual tests without asserting anything useful. The patch removes those obsolete @test annotations and fixes another test case that had wrong wrong naming and was not executed for a while. Resolves: #85170 Releases: master Change-Id: Ibf6f9ef99f7eaeaeba1374962112d4a342c36567 Reviewed-on: https://review.typo3.org/57133 Tested-by:
-
- Jun 06, 2018
-
-
Christian Kuhn authored
phpunit tends to execute test case files even if the file comes with a broken namespace and can't be autoloaded. The patch hopefully fixes all test case files that are positioned in a wrong folder, has an otherwise broken namespace or is not yet registered as psr-4 require-dev. Resolves: #85169 Releases: master Change-Id: Id8da485b14ab65a883dd90e1a11cfd8e74d85780 Reviewed-on: https://review.typo3.org/57132 Tested-by:
-
- Jun 05, 2018
-
-
Nicole Cordes authored
Currently only the DriverInterface cares about applied filters. The ResourceStorage received a new API function to validate a file or folder object against applied filters as well. This ensures proper validation for objects fetched without driver calls. Resolves: #84908 Releases: master, 8.7 Change-Id: I5e8d35215c99aacfb330fe0eb8cfd9259b9a4199 Reviewed-on: https://review.typo3.org/56844 Reviewed-by:
Mathias Schreiber <mathias.schreiber@typo3.com> Tested-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Tested-by:
-
Richard Haeser authored
The SEO meta tags that can be set in the page properties, will be rendered in frontend. Resolves: #85147 Releases: master Change-Id: I75e6d8e50b7c8616497ee7075fddcb182551bea4 Reviewed-on: https://review.typo3.org/57117 Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Reviewed-by:
Joerg Boesche <typo3@joergboesche.de> Reviewed-by:
Tobi Kretschmann <tobi@tobishome.de> Tested-by:
Riny van Tiggelen <info@online-gamer.nl> Reviewed-by:
Steffen Frese <steffenf14@gmail.com> Reviewed-by:
-
Andreas Fernandez authored
Resolves: #85155 Related: #85065 Releases: master Change-Id: I0a3d89678dc23318db3cc3a3845c9c7fb3931959 Reviewed-on: https://review.typo3.org/57126 Reviewed-by:
-
- Jun 04, 2018
-
-
Benni Mack authored
The scheduler object cleans up execution arrays on instantiation. Due to the PSR-3 refactoring, the logger is instantiated after the constructor is called - resulting in a fatal error ("Call to member function info() on null") when cleaning up the execution array. The patch manually instantiates a logger if there isn't one already. Resolves: #85148 Releases: master Change-Id: I5ff3a06a2b9d7e511d5d243df545359a48bf84b1 Reviewed-on: https://review.typo3.org/57118 Tested-by:Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Daniel Gorges <daniel.gorges@b13.de> Tested-by:
-
Christian Kuhn authored
A minor CGL error slipped through with a patch that has been merged based on a +1 from bamboo before the 'declare_equal_normalize' php-cs-fixer rule has been established. The change should make the bamboo nightly builds green again. Resolves: #85152 Related: #84720 Releases: master Change-Id: Iaaf08d429780a12bf38a2865a5ae696a73cfcffb Reviewed-on: https://review.typo3.org/57123 Tested-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
-
Christian Kuhn authored
Fix a series of core unit test classes to correct namespace. Resolves: #85151 Releases: master Change-Id: Ibfffae113ba3114acf616e65d48d8b508eee9353 Reviewed-on: https://review.typo3.org/57122 Reviewed-by:
Jan Helke <typo3@helke.de> Tested-by:
-
- Jun 03, 2018
-
-
Georg Ringer authored
If a page record is fetched from the database, the PageRepository needs to care about the l18n_cfg setting for this page. Resolves: #85063 Releases: master, 8.7 Change-Id: Ib0338a4725a3b569b91f27baa3a59cabee6fe2fb Reviewed-on: https://review.typo3.org/57038 Reviewed-by:
Mona Muzaffar <mona.muzaffar@gmx.de> Reviewed-by:
-
- Jun 02, 2018
-
-
Richard Haeser authored
The properties within the allowedSubProperties have to be arrays because the AbstractMetaTagManager checks if the property as a key exists in the allowSubProperties. Resolves: #85126 Releases: master Change-Id: Ie57a77f8d4100e0861958de73faa56d80709daad Reviewed-on: https://review.typo3.org/57099 Tested-by:
-
Frederik Holz authored
Menues provided by MenuProcessor will display restricted pages, if the configuration value is set to true. This is the same behavior as known from pure TypoScript provided menues. Resolves: #82755 Releases: master, 8.7 Change-Id: Idf600f3ce151e2accba828c69dc601e26771686c Reviewed-on: https://review.typo3.org/56834 Reviewed-by:
-
Georg Ringer authored
Use the LanguageService for help texts of select items. This can be tested with the element 'select_checkbox_3' of the styleguide extension. Resolves: #78984 Releases: master, 8.7 Change-Id: Idb6e63547ac480b18fcb1ca997d5d07e4bcb4e81 Reviewed-on: https://review.typo3.org/56689 Reviewed-by:
-
- Jun 01, 2018
-
-
Andreas Fernandez authored
To improve the overall performance of the recycler, these things are done: - Improve how permissions are checked for each record Instead of running multiple SQL requests per record, the check now instantly stops if the user is either an admin, or has no permission to modify a certain table. - Drop sorting of records by page tree structure The records get sorted by the page tree structure, to mime the tree in a flat view. However, this feature is rather useless and also considered buggy in a huge record set. Resolves: #84711 Releases: master, 8.7 Change-Id: I0c5177546489ce2a0ba84435fed3879267a5a871 Reviewed-on: https://review.typo3.org/56102 Reviewed-by:
-
Tom Warwick authored
This commit is intented to improve the language used in the Install Tool and each of its modules. [+] Review title,subtitle and description for each action available and update/amend where required. Resolves: #84891 Releases: master Change-Id: I7f71f85ae86c37786870b2c30511673fe28da7c2 Reviewed-on: https://review.typo3.org/56825 Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
Mathias Brodala authored
Code which uses enumerations expects a known set of values, adding more values by extending these classes leads to undefined behavior. Since it is now impossible to create a mock of an enumeration also drop a few Enumeration tests and stick to testing of the public API. Resolves: #85025 Releases: master Change-Id: I3d0238c85ae916052dc1aa503f7f8e39c1765ac6 Reviewed-on: https://review.typo3.org/56976 Tested-by:
-
Ralf Zimmermann authored
Only list valid forms within the form manger and the form plugin. Valid forms have an "identifier" and a "type" and the type must be "Form". Resolves: #85132 Releases: master, 8.7 Change-Id: I2f473925b3edf839d5f965136b6b02030671350a Reviewed-on: https://review.typo3.org/57108 Reviewed-by:
-
Benni Mack authored
The method `getPageShortcut()` which is marked as private is moved to PageRepository, as it only requires logic and methods from PageRepository. Resolves: #85130 Releases: master Change-Id: I4c7296e085953377e0937b8d1efad0b97d1fb021 Reviewed-on: https://review.typo3.org/57106 Reviewed-by:
-
Mathias Brodala authored
Resolves: #85139 Releases: master Change-Id: Iadcfdb2bcc5dd0ebf3eeb535171a43c3a54afe47 Reviewed-on: https://review.typo3.org/57110 Tested-by:
-
Susanne Moog authored
Sqlite limits the maximum number of variables allowed in a query. When importing the extension list the chunks are too big (> 999 variables). This has been chunked to enable import on sqlite. Resolves: #85129 Releases: master Change-Id: If65476707946f4078a1b1e55128239aed07f6ed8 Reviewed-on: https://review.typo3.org/57103 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
Benni Mack authored
Since TYPO3 v9.0, all routing in backend is handled unified, thus, the old methods from historical reasons can be deprecated. - BackendUtility::getModuleUrl() - UriBuilder->buildUriFromModule() Instead of guessing the name to a module route, an "id" for the route (like the path) can be explictly given. Resolves: #85113 Releases: master Change-Id: I8cf2b9dc3a938dd7227dcc972e0782619ede4213 Reviewed-on: https://review.typo3.org/57048 Tested-by:
-
Tymoteusz Motylewski authored
Replaces hardcoded RTE configuration in BrowseLinksController with one resolved by Formengine when rendering a field. This takes into account e.g. column overrides. The RTE configuration preset name is now kept by Formengine in ['processedTca']['columns'][$fieldName]['config']['richtextConfigurationName'] Then it's being passed as parameter P[richtextConfigurationName] from RTE field to the BrowseinksController Resolves: #84943 Releases: master, 8.7 Change-Id: Id4f1c350f6eb6dfad4d49ec759a23939bbc45eda Reviewed-on: https://review.typo3.org/56881 Tested-by:
Jan Stockfisch <jan.stockfisch@googlemail.com> Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
-
Susanne Moog authored
For SQLite inSet was implemented with a "like" substitution which had various bugs. That implementation has now been substituted with an "instr" implementation. Resolves: #85131 Releases: master Change-Id: Id4e8f7132800c991e49d4033d2b01f474b6aae3b Reviewed-on: https://review.typo3.org/57107 Reviewed-by:
-
- May 31, 2018
-
-
Nicole Cordes authored
Fetching a parent folder may throws an error if the user hasn't access to the parent. This exception needs to be caught and the search for an existing recycler folder needs to be stopped immediately. Furthermore the patch removes the comparison with the root level folder but checks the parent folder doesn't equal the folder itself. Another loop is fixed by calling moveFile on the correct ResourceStorge and not the current one. Resolves: #85079 Related: #81836 Releases: master, 8.7 Change-Id: I51f5e20d7fa7da9b350ac0ca60cab05866a4d337 Reviewed-on: https://review.typo3.org/57052 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Frans Saris <franssaris@gmail.com> Tested-by:
-
Susanne Moog authored
Concerning the usage of Statement::rowCount() the Doctrine DBAL documentation states the following: Returns the number of rows affected by the last DELETE, INSERT, or UPDATE statement executed by the corresponding object. For default configurations using MySQL as platform, rowCount() is returning the expected value for SELECT statements as well. However, on other DBMS this value will be zero as mentioned in the documentation - for instance SQLite is a candidate for that. For retrieving the row count for given criteria, the count() expression has to be used explicitly. Resolves: #78129 Releases: master Change-Id: Id28d72a1a21e8615ec45b63d4aecc100d03a39a3 Reviewed-on: https://review.typo3.org/50083 Reviewed-by:
-
Tymoteusz Motylewski authored
The concept for custom UrlHandlers, introduced in TYPO3 v7 for extracting JumpURL into a TER extension has been deprecated in favor of PSR-15. These could be registered via $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['urlProcessing']['urlHandlers'] The methods related to that functionality have been deprecated. - $TSFE->initializeRedirectUrlHandlers() - $TSFE->redirectToExternalUrl() However, the core-internal calls have been marked with a property to ensure that no deprecation warning is triggered, but the functionality can be kept. Resolves: #85124 Releases: master Change-Id: Ie49d7200618d2b8ffdd5394ea9c649c123719b07 Reviewed-on: https://review.typo3.org/57096 Tested-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
-
Jan Helke authored
Releases: master Resolves: #84720 Change-Id: If13dfe85fcb41ce3a361fbb184d95c5ddffaf958 Reviewed-on: https://review.typo3.org/56654 Tested-by:
Thomas Maroschik <tmaroschik@dfau.de> Tested-by:
Kay Strobach <typo3@kay-strobach.de> Tested-by:
-
Benni Mack authored
CharsetConverter is still instantiated in some places and not needed at all times. The following places have CharsetConverter completely removed (as internal property): - PageRenderer - SearchController - Indexer The AbstractHierarchicalFilesystemDriver's shorthand method getCharsetConversion() has been deprecated, as drivers should instantiate the CharsetConversion themself. Indexed Search's Lexer has a public property "csObj" which has been switched to protected, where a deprecation message will be thrown. Resolves: #85125 Releases: master Change-Id: I48fd110ecd25bb6a4225a3d2141edc5fc3b92673 Reviewed-on: https://review.typo3.org/57097 Reviewed-by:
-
- May 30, 2018
-
-
Simon Gilli authored
Allow the usage of a value for --action argument of the CLI command cleanup:versions as mentioned in the documentation and the implementation. Resolves: #85085 Related: #79109 Related: #82653 Releases: master, 8.7 Change-Id: I6c07303728bcb527b44a6c5bf811870f25398a21 Reviewed-on: https://review.typo3.org/57055 Tested-by:
-
Tymoteusz Motylewski authored
It was decided to use .typoscript and .tsconfig The patch renames the files and adds little BC layer which allows you to include TypoScript files using old (.txt) file extension. Resolves: #81686 Releases: master Change-Id: Id6784e4f573e2e0b060f37d241c07216ac5678e1 Reviewed-on: https://review.typo3.org/57083 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Benni Mack authored
PageRepository has two public properties regarding fetching records for versioned records: - versioningPreview (bool) - versioningWorkspaceId (int) In order to allow previews of versions, a workspace ID has to be set - otherwise it fetches live records. Basically things like: $versioningPreview=false, $versioningWorkspaceId=3 will make things more confusing. Instead, versioningPreview is not in use anymore, and PageRepository solely relies on the parameter of the workspaceId set. Resolves: #85078 Releases: master Change-Id: I70f028854ebc1a83d6d5af18de507284ae89b2ac Reviewed-on: https://review.typo3.org/57047 Reviewed-by:
-
Harry Glatz authored
Releases: master, 8.7 Resolves: #85117 Related: #32030 Change-Id: I6af62c8337865e8a76c2dd8593f5afa38e0c2d26 Reviewed-on: https://review.typo3.org/57089 Reviewed-by:
-
Tymoteusz Motylewski authored
Currently selected page is remembered in the fsMod js object. The JS code responsible for handling click on the node text and node background is refactored. Now both uses node.checked property. Resolves: #85100 Resolves: #85106 Releases: master Change-Id: I08768e82a62e942c247d968df707bf64426e1dab Reviewed-on: https://review.typo3.org/57076 Tested-by:
-
Benni Mack authored
The following constants related to the Services in TYPO3 have been moved into AbstractService as class constants, effectively moving them in the right context. - T3_ERR_SV_GENERAL - T3_ERR_SV_NOT_AVAIL - T3_ERR_SV_WRONG_SUBTYPE - T3_ERR_SV_NO_INPUT - T3_ERR_SV_FILE_NOT_FOUND - T3_ERR_SV_FILE_READ - T3_ERR_SV_FILE_WRITE - T3_ERR_SV_PROG_NOT_FOUND - T3_ERR_SV_PROG_FAILED The Extension scanner will detect usages of these constants. The constants will be removed in TYPO3 v10. Resolves: #85123 Releases: master Change-Id: I9df12e51deda77903aff83769d4f2a532b2676fb Reviewed-on: https://review.typo3.org/57095 Reviewed-by:
-
Benni Mack authored
Due to native support and a polyfill for mb_string(), lot of functionality of CharsetConverter was simplified throughout TYPO3 in the last release to ensure faster charset conversion. Many methods and properties within CharsetConverter can be deprecated now: - CharsetConverter->synonyms - CharsetConverter->parse_charset() - Fourth parameter of CharsetConverter->conv() - CharsetConverter->convArray() - CharsetConverter->utf8_to_entities() - CharsetConverter->entities_to_utf8() - CharsetConverter->crop() - CharsetConverter->convCaseFirst() - CharsetConverter->utf8_char2byte_pos() Additionally the following public properties have been changed to have a "protected" visibility, as this only reflects internal state: - CharsetConverter->noCharByteVal - CharsetConverter->parsedCharsets - CharsetConverter->toASCII - CharsetConverter->twoByteSets - CharsetConverter->eucBasedSets Resolves: #85122 Releases: master Change-Id: Ic67dd1cffa36cd625c844ae82fdca8447a317efe Reviewed-on: https://review.typo3.org/57094 Tested-by:
-
Simon Gilli authored
Add the Site Configuration to the ConfigurationController to simplify debugging and enable its inspection at the backend. Resolves: #84709 Releases: master Change-Id: Ib0720f372a2d27873fda9931c8753c7ed6a98750 Reviewed-on: https://review.typo3.org/56644 Reviewed-by:
-
