[!!!][TASK] Make all enumerations final
Code which uses enumerations expects a known set of values, adding more values by extending these classes leads to undefined behavior. Since it is now impossible to create a mock of an enumeration also drop a few Enumeration tests and stick to testing of the public API. Resolves: #85025 Releases: master Change-Id: I3d0238c85ae916052dc1aa503f7f8e39c1765ac6 Reviewed-on: https://review.typo3.org/56976 Tested-by:TYPO3com <no-reply@typo3.com> Reviewed-by:
Joerg Boesche <typo3@joergboesche.de> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Mona Muzaffar <mona.muzaffar@gmx.de> Tested-by:
Mona Muzaffar <mona.muzaffar@gmx.de> Tested-by:
Jan Helke <typo3@helke.de> Reviewed-by:
Jan Helke <typo3@helke.de> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
Showing
- typo3/sysext/backend/Classes/Toolbar/Enumeration/InformationStatus.php 3 additions, 1 deletion...backend/Classes/Toolbar/Enumeration/InformationStatus.php
- typo3/sysext/core/Classes/DataHandling/TableColumnSubType.php 3 additions, 1 deletion...3/sysext/core/Classes/DataHandling/TableColumnSubType.php
- typo3/sysext/core/Classes/DataHandling/TableColumnType.php 3 additions, 1 deletiontypo3/sysext/core/Classes/DataHandling/TableColumnType.php
- typo3/sysext/core/Classes/Resource/DuplicationBehavior.php 3 additions, 1 deletiontypo3/sysext/core/Classes/Resource/DuplicationBehavior.php
- typo3/sysext/core/Classes/Type/Bitmask/JsConfirmation.php 1 addition, 1 deletiontypo3/sysext/core/Classes/Type/Bitmask/JsConfirmation.php
- typo3/sysext/core/Classes/Type/Bitmask/Permission.php 3 additions, 1 deletiontypo3/sysext/core/Classes/Type/Bitmask/Permission.php
- typo3/sysext/core/Classes/Type/Icon/IconState.php 3 additions, 1 deletiontypo3/sysext/core/Classes/Type/Icon/IconState.php
- typo3/sysext/core/Classes/Versioning/VersionState.php 3 additions, 1 deletiontypo3/sysext/core/Classes/Versioning/VersionState.php
- typo3/sysext/core/Documentation/Changelog/master/Breaking-85025-EnumerationsAreNowFinal.rst 36 additions, 0 deletions...angelog/master/Breaking-85025-EnumerationsAreNowFinal.rst
- typo3/sysext/core/Tests/Unit/Type/EnumerationTest.php 41 additions, 133 deletionstypo3/sysext/core/Tests/Unit/Type/EnumerationTest.php
- typo3/sysext/core/Tests/Unit/Type/Fixture/Enumeration/CompleteEnumeration.php 4 additions, 1 deletion...sts/Unit/Type/Fixture/Enumeration/CompleteEnumeration.php
- typo3/sysext/core/Tests/Unit/Type/Fixture/Enumeration/DuplicateConstantValueEnumeration.php 3 additions, 1 deletion...Fixture/Enumeration/DuplicateConstantValueEnumeration.php
- typo3/sysext/core/Tests/Unit/Type/Fixture/Enumeration/InvalidConstantEnumeration.php 3 additions, 1 deletion...t/Type/Fixture/Enumeration/InvalidConstantEnumeration.php
- typo3/sysext/core/Tests/Unit/Type/Fixture/Enumeration/MissingConstantsEnumeration.php 3 additions, 1 deletion.../Type/Fixture/Enumeration/MissingConstantsEnumeration.php
- typo3/sysext/core/Tests/Unit/Type/Fixture/Enumeration/MissingDefaultEnumeration.php 3 additions, 1 deletion...it/Type/Fixture/Enumeration/MissingDefaultEnumeration.php
- typo3/sysext/indexed_search/Classes/Utility/LikeWildcard.php 2 additions, 1 deletiontypo3/sysext/indexed_search/Classes/Utility/LikeWildcard.php
Please register or sign in to comment