- Apr 16, 2020
-
-
Oliver Hader authored
This change aims to reduce the amount of inline JavaScript by removing `onchange` events. * extracts inline JavaScript from templates * introduces `TYPO3/CMS/Backend/GlobalEventHandler` module * adjusts PHP type-hints to their correct & actual values Resolves: #91052 Releases: master Change-Id: If92391bd48f89df57fbb0ed6f8b0936da0e1a49d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64191 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Andreas Fernandez authored
Resolves: #91057 Related: #91008 Releases: master Change-Id: I448a7b2364996f55c98dfe92c3c566acdf3df3e8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64196 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
- Apr 15, 2020
-
-
Oliver Hader authored
This change aims to reduce the amount of inline JavaScript by removing `onchange` or `onclick` events and dynamically created JavaScript code/settings. There are still a couple of aspects that need to be solved in a general way - e.g. assigning global language labels (`TYPO3.lang`) or settings (`TYPO3.settings`). * allows `Modal` confirmation to emit `ModalResponseEvent` * extracts inline JavaScript from controllers & templates * introduces `BroadcastChannel` in `nav_frame` (folder tree) * uses plain links (`<a href="..."`) where applicable * updates folder tree when navigating in browser history Resolves: #91016 Releases: master Change-Id: Ied6a626e09df07bd1a240b9b6b4250cd6fff4c8a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64154 Tested-by:
-
Benni Mack authored
Due to the deprecation of "switchable controller actions", list_type items can now be grouped in FormEngine - as well as all other "select" fields defined in TCA. A new TCA option in TCA type=select is added, called "itemGroups". In addition, all "items" now have four parts (fourth being optional) 0 => label 1 => value 2 => icon 3 => groupID where the group belongs to an item group (defined explicitly) or taken from a --div-- element, which then turns into an optgroup. In order then to avoid the "itemProcFunc" of tt_content.list_type which is used to sort items, a "sortOrders" option is added to sort items (within a group, if grouping is enabled) by label or value. When registering a new plugin, the groupId can be added as well as an additional parameter, which falls back to the "default" group. A new method ExtensionManagementUtility::addTcaSelectItemGroup() allows to add item groups via API. When registering extbase Plugins or pibase plugins, it is possible to add a registered "group ID" to make use of this feature. Resolves: #91008 Resolves: #82352 Releases: master Change-Id: I8ad215b5cbc16f332e7c129d762fc020ade5ceeb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63889 Tested-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Tested-by:
-
Benni Mack authored
TYPO3's PHP-CS-Fixer configuration is adapted to move towards the PSR-12 standard by unifying the new statement and adding proper braces argument methods and arguments. Resolves: #91026 Releases: master Change-Id: If5eb945e18fb4a2330e3c9eeaf90134126638079 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64163 Tested-by:
-
Andreas Fernandez authored
Resolves: #90941 Releases: master Change-Id: If205ab5308c0f1bb7e935a53bebee41e7b9e2fd2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64061 Tested-by:
Frank Nägler <frank.naegler@typo3.org> Tested-by:
-
Alexander Schnitzler authored
With this patch, the header comment of php files is automatically added by the php-cs-fixer, which guarantees that its format and place of occurrence remain the same in all files. Files that are copied over from other projects are excluded. Furthermore, files that are kind of inspired by other projects also get the same header comment but may have a second, additional comment explaining its origin. Used command: bin/php-cs-fixer fix --config=Build/php-cs-fixer/header-comment.php Releases: master Resolves: #91024 Change-Id: I5a040517e0fbde6e5a27d589bf2f222078326dc8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64159 Tested-by:
-
- Apr 14, 2020
-
-
Andreas Fernandez authored
The start up option "First module in menu" is a misleading in some ways. The select box e.g. has "dashboard" as first selectable option, but in such cases the "help_AboutAbout" module is loaded instead, for example. This is due the fact the first module is determined via querying the DOM for the first element matching the selector `.t3js-modulemenu-action[data-link]`. The behavior is now changed to load the first module as listed in the previously mentioned select box. Resolves: #91028 Releases: master Change-Id: I669a9b146f76f2513c51ff5f48128a1ea8b0c0a7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64164 Tested-by:
Richard Haeser <richard@maxserv.com> Tested-by:
-
Andreas Fernandez authored
To improve the user experience, the search filter in the "New Content Element" wizard is automatically focussed when the modal appears. Resolves: #91014 Releases: master Change-Id: I3e0f18bd454955af63cd797138de7b2118d9d2ac Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64129 Tested-by:
Josef Glatz <josefglatz@gmail.com> Tested-by:
-
Benni Mack authored
This change adds two changes 'blank_line_after_opening_tag' => true, 'single_trait_insert_per_statement' => true, to our PHP-CS Fixer configuration, adopting more rules related to PSR-12. Resolves: #91020 Releases: master Change-Id: I180b2cbceb077911bddeb42d9f131e5b32244ed2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64158 Tested-by:Oliver Bartsch <bo@cedev.de> Tested-by:
-
Benni Mack authored
DataHandler does not set "-1" for versioned records in workspaces anymore, thus making it a lot easier to find the real PID for a versioned record without always having to fetch the live version for it. This is ground-breaking, as this opens the door for a lot of improvements when accessing versions via overlays. An upgrade wizard will migrate all pid=-1 records to their equivalent pids, and discard all already published / archived versions. Resolves: #89555 Releases: master Change-Id: I31c32451827c1f94764bb0ba22ad8207c8b3d4fd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61699 Tested-by:
Manuel Selbach <manuel_selbach@yahoo.de> Tested-by:
-
- Apr 13, 2020
-
-
Benni Mack authored
Due to wrong prefixes of TCA type=slug fields for custom records e.g. in ext:news, a new configuration `prefix` is introduced. A `userFunc` can be assigned to the new field which then allows to provide a custom base url based on e.g. the correct detail page. The default behaviour, which is used for pages, is still applied, when no custom base url is given. Resolves: #89573 Releases: master Change-Id: I529ff26ddeba200b56f0c23aca55daa187c3f40d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62270 Tested-by:
-
Alexander Schnitzler authored
As a preparation to be compatible with PSR-12, all spaces in strict type declerations are removed. Releases: master Resolves: #91009 Change-Id: I2b7c2fda42b44168b5c4c6b21711eede2eadaf2e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62104 Tested-by:
-
Georg Ringer authored
Make sure that the key in ArrayBrowser::getSearchKeys() is always cast to string. Resolves: #91007 Releases: master Change-Id: I28aa780a92f9425df486cb0dadee3930b4a54f14 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64124 Tested-by:
Christian Eßl <indy.essl@gmail.com> Tested-by:
Jonas Eberle <flightvision@googlemail.com> Tested-by:
-
- Apr 11, 2020
-
-
Tobi Kretschmann authored
Using mm tables, the value that is stored in the database does not represent the uid of the selected item. Much rather it is the amount of selected items. If three items are selected the value within the database field is "3". Whereas using multiple select without mm table, it is stored as a comma-separated list of uids. Releases: master, 9.5 Resolves: #90925 Change-Id: I110cbf0fd19fab1135958c445a846a1af9c24510 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64062 Tested-by:
Jörg Bösche <typo3@joergboesche.de> Tested-by:
Sebastian Hofer <sebastian.hofer@marit.ag> Tested-by:
-
- Apr 10, 2020
-
-
Georg Ringer authored
Improve rendering of the password forgotten link if additional login providers are registered. Resolves: #90978 Releases: master Change-Id: I0e064b7bfa7836ac2341d4d96ccc61c056c03269 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64104 Tested-by:
Florian Wessels <f.wessels@bitmotion.de> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
-
- Apr 09, 2020
-
-
Tymoteusz Motylewski authored
Add test for TreeController, so we're safe when refactoring or doing performance optimizations. Besides that moved pages in a workspace were not considered when calculating permissions on the rootline due to missing workspace overlays. Resolves: #90831 Releases: 9.5, master Change-Id: Ic3ab08d2502e8c9a3f08e737552c2e1d2a56a66c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63848 Tested-by:
-
- Apr 08, 2020
-
-
Alexander Schnitzler authored
Releases: master Resolves: #90913 Change-Id: If38a526547518e93b3002ffa01accebf4a12e5b3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64032 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Christian Eßl authored
Resolves: #90976 Releases: master, 9.5 Change-Id: I3827e0796f7dc016b3095b5e8917905b85523712 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64096 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
-
Christian Eßl authored
Resolves: #90960 Releases: master Change-Id: I71933b194a4c366914c9d462b91cf605ed454a76 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64103 Tested-by:
-
Daniel Siepmann authored
These changes in the SuggestWizardController allow users to override allowed tables in group fields with columnsOverrides. Typical usecases for this is to use the records field for tt_content elements. Resolves: #76661 Releases: master Change-Id: Ic566c793f8d953802f5f6ff670fde485c19ed9db Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59444 Tested-by:
-
- Apr 07, 2020
-
-
Patrick Broens authored
When a logged in backend user is entering the history/undo functionality for a certain page, which contains a deleted one, the backend user authentication will throw an error. This is due to the fact the pid field is not taken into account when fetching the pages to check if they are deleted. This pid field will be used to calculate the page access, but is now done with the value null. This patch will add the pid field when fetching the subpages which will be checked if they are deleted. Resolves: #90963 Releases: master, 9.5 Change-Id: I1b78d4a71fea35b5d55a1d8989e586f01e7d9280 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64088 Tested-by:
-
- Apr 06, 2020
-
-
Alexander Schnitzler authored
Releases: master Resolves: #90893 Change-Id: Icc339442cded9a268fb66fe932b0f13de292e3b7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64018 Reviewed-by:
-
Josef Glatz authored
Add related links for each upgrade documentation file at the end: - link to forge issue - link to rendered rST document This makes it possible to - read the documentation as rendered html with on click - easily share an upgrade document with others - open the related forge issue Resolves: #90923 Releases: master, 9.5 Change-Id: Iedf874e31b7026a55275d6073d645e875dab1b6c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64044 Tested-by:
Daniel Siepmann <coding@daniel-siepmann.de> Tested-by:
-
Markus Klein authored
TCEMAIN.linkHandler.page.configuration.pageIdSelector.enabled = 1 This configuration is adhered again and the pageIdSelector shows up. Resolves: #83056 Releases: master, 9.5 Change-Id: I1e03bfa180601a46c85e3c3b92ba9c7e980a4b8b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64065 Tested-by:
-
- Apr 05, 2020
-
-
Claus Due authored
Creates a dedicated partial template which only contains the preview output, allowing global overrides of preview output without overriding the entire Record.html template. Releases: master Resolves: #90946 Change-Id: Ic3d9f9801476725bd37472f0266dfe0b69e8d653 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64072 Tested-by:
-
Anja Leichsenring authored
During refactoring of the class a method was removed, that was still mentioned in a mock creation. This raised a warning in unit test runs. Removing the mentioning (and the mock alongside with it) returns the tests to green. Resolves: #90943 Related: #90348 Related: #90839 Releases: master Change-Id: I558d0bcd31942aac6241c819c8bf011dba23fe2c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64067 Reviewed-by:
Claus Due <claus@phpmind.net> Reviewed-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
-
- Apr 04, 2020
-
-
Georg Ringer authored
Integrators are now able to compare individual backend usergroups. Backend usergroups are used to split permissions into smaller parts which can be later assigned to a backend user. This feature makes it possible to compare the defined permissions including the ones inherited from sub groups. Resolves: #90826 Releases: master Change-Id: Ic2306be7091c0001c293bcc8622c4d6ea16776ea Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63890 Tested-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
-
Benni Mack authored
The hook to determine if child records are used is re-implemented. This makes the fluid based page module behave like the legacy PageLayoutView when determining if a record was used, allowing third party extensions to override the core's "is used?" decision. Resolves: #90927 Releases: master Change-Id: Ia72cf7479e04ee9c5ae688cf9c37bed697ac4d3e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64049 Reviewed-by:
Kevin Appelt <kevin.appelt@icloud.com> Reviewed-by:
-
Benni Mack authored
In order to reduce the amount of data fetched, the PageTree loaded for editors will only fetch pages that the editor actually sees, reducing the actual amount of pages to fetch. If a pagetree has 80.000 pages, but the editor can only see 50, the tree only loads these 50 pages. Resolves: #90880 Releases: master, 9.5 Change-Id: I57985484ace07fbfb919573351c210b291697ae3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63570 Tested-by:
Susanne Moog <look@susi.dev> Reviewed-by:
-
- Apr 03, 2020
-
-
Christian Eßl authored
The $key in ArrayBrowser can sometimes be numeric. Cast the $key to string before handing it to htmlspecialchars() to prevent type errors. Resolves: #90883 Releases: master Change-Id: If5303800a0b8ef25521a8eb028ac0f11f8c5f648 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64005 Tested-by:
Georg Tiefenbrunn <georg.tiefenbrunn@gmail.com> Tested-by:
-
Georg Ringer authored
Use buttons instead of span tags to make the module more accessible. Resolves: #90872 Releases: master Change-Id: Id183fa8de13ec3bea992cb9cdbe851127b1bc15c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64000 Tested-by:
-
- Apr 02, 2020
-
-
Benni Mack authored
Instead of using "callUserFunction" which hands in an instance of the current object for BackendLayoutView, which is never needed, this change uses the method calls directly. Resolves: #90896 Releases: master Change-Id: I2746b7b6d3ce856379bcbad4e94eec14b5521ccc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64019 Tested-by:
-
Alexander Schnitzler authored
Several issues have been ignored because of checks on runtime constants which vary from context to context. Since we can only simulate one context, phpstan is unable to properly detect several paths. Releases: master Resolves: #90909 Change-Id: Ie3213112a299559687f27317821453137cd5322a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64030 Reviewed-by:
-
Andreas Fernandez authored
To improve the UX of null placeholder checkboxes (e.g. used in sys_file_reference) its assigned text field is now automatically focused if such checkbox gets disabled. Resolves: #90879 Releases: master Change-Id: I5228f49d58276d3c6fc1d19275ca9e92cbdb2f91 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64001 Tested-by:
-
- Apr 01, 2020
-
-
Benni Mack authored
The code that executes the drawItem hook must be called before the fluid-preview is rendered, in order to allow rendering of custom variables within the Fluid preview. This way, it behaves the same way as in the non-Fluidbased page module. Resolves: #90906 Releases: master Change-Id: Id7998446b211763da3d3b7be89a4d7016f2fb54f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64020 Tested-by:
Achim Fritz <af@achimfritz.de> Tested-by:
-
- Mar 31, 2020
-
-
Oliver Bartsch authored
By expanding an inline record the AJAX request calls the `detailAction` in `FormInlineAjaxController`. The parent data array created in this function does not contain the parent record's uid nor its database row. In order to ensure that the uid is not NULL, in any FormDataProvider, the uid is now added to the parent data array. This value is then used as fallback in case there is no database row given in the `compileChild` function which calls the FormDataProviders. Resolves: #90734 Releases: master, 9.5 Change-Id: I66a4a20980d6c62a3e87496b6261b25f5e22aea6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63686 Tested-by:
-
- Mar 30, 2020
-
-
Andreas Fernandez authored
This patch replaces DataTables with the lightweight alternative tablesort and adjusts all usages of DataTables. Since using DataTables with TYPO3 is neither documented nor propagated, removing this library isn't considered as breaking change. Resolves: #86343 Releases: master Change-Id: Ied7a3a8d471d508f00cc568a15fb930eec4f274b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63958 Tested-by:
-
Benni Mack authored
Resolves: #90888 Releases: master Change-Id: Id5448d8536c9078b9cb37c952f33bb1deab272ca Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64010 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Benni Mack authored
This code is either protected or marked as internal, and not in use and can be removed. Resolves: #90889 Releases: master Change-Id: I45636e9117d00c05e7880275919b5ba30c12d6d6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64013 Reviewed-by:
-
