- Apr 16, 2020
-
-
Oliver Hader authored
This change aims to reduce the amount of inline JavaScript by removing `onchange` events. * extracts inline JavaScript from templates * introduces `TYPO3/CMS/Backend/GlobalEventHandler` module * adjusts PHP type-hints to their correct & actual values Resolves: #91052 Releases: master Change-Id: If92391bd48f89df57fbb0ed6f8b0936da0e1a49d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64191 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Alexander Schnitzler authored
This patch has been created with rector and php-cs-fixer bin/rector process --set=php53 typo3/sysext/frontend/Classes bin/rector process --set=php53 typo3/sysext/frontend/Tests Releases: master Resolves: #91063 Change-Id: Ia6a547ec40c1da2c80cabb8a3e0581d628f51c92 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64200 Tested-by:Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Alexander Schnitzler authored
Releases: master Resolves: #90910 Change-Id: If03889ee330e96c5ca82b31ae0604fb1d1d0afc8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64031 Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Chris Müller authored
In the dependency injection examples for defining a console command a colon is missing after the class name. Resolves: #91068 Related: #89139 Releases: master Change-Id: Ieea67cfb3f906037a4fad7da49d3d91613a12855 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64202 Tested-by:
Jonas Eberle <flightvision@googlemail.com> Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Josef Glatz <josefglatz@gmail.com> Tested-by:
-
Benni Mack authored
This patch has been created with rector and php-cs-fixer bin/rector process --set=php53 typo3/sysext/core/Classes bin/rector process --set=php53 typo3/sysext/core/Tests Resolves: #91054 Releases: master Change-Id: Ie27503980812581103a5d12581a80a7e8fe474f1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64192 Tested-by:Alexander Schnitzler <git@alexanderschnitzler.de> Tested-by:
Susanne Moog <look@susi.dev> Reviewed-by:
-
Patrick Broens authored
When having a multisite setup using the same slugs pointing to the same or other different mounted pages, the PageSlugCandidateProvider will always fetch the information of the first page found in the database which complies with the slug. In some cases this will be the right page, but in other cases will be a page which is not part of the requested website. In the last case this will result in a 404. This patch fixes this by checking if the slug is from the site being called. Resolves: #90469 Releases: master, 9.5 Change-Id: I333bfdfeb37ffa13b86697c4597cbda6e315b590 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63349 Tested-by:
Patrick Broens <patrick@patrickbroens.nl> Tested-by:
Dirk Koritnik <koritnik@werkraum-media.de> Tested-by:
-
Benni Mack authored
ExtensionService (internal API) is a random place for some methods used only in one specific parts of Extbase. Some parts in Extbase internal code regarding request building and determining if an action is cacheable is moved to the places where it is needed. The EnvironmentService class has a method to determine a HTTP-relevant request, which is only relevent for the RequestBuilder where it is now moved to, and uses PSR-7 handling if available. Resolves: #91019 Releases: master Change-Id: Ie6ca0c751bc7453de1d123665b7fe6ce51b37c62 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64157 Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
-
Oliver Bartsch authored
Adds the missing footer section, including the button definition, which can be set in the configuration, to the widget template. Resolves: #91056 Releases: master Change-Id: I2ec3c954e0ac8fec0814848fdb0d4bea897b48d3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64195 Tested-by:
Richard Haeser <richard@maxserv.com> Tested-by:
-
Benni Mack authored
Resolves: #91053 Releases: master Change-Id: I96108a509c7e9d95e9bd88b9c6b53dbfc37acd5b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64193 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Benjamin Franzke authored
rectors `auto_import_names` causes relative class names to be transformed into `use` statements. This reduces the readability of the grouped getFactories array as used in ServiceProviders, we rather used to define all external dependencies in use statements and to include local dependencies using relative class names. Also revert the change in TYPO3\CMS\Extbase\ServiceProvider which has already been applied in #91047 using: git checkout 682873dd^ -- \ typo3/sysext/extbase/Classes/ServiceProvider.php Releases: master Resolves: #91059 Related: #91047 Change-Id: I16c4b0d264b2acc5149da375967d862c879f2958 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64198 Tested-by:
-
Anja Leichsenring authored
command: composer require --dev php-webdriver/webdriver:^1.8 This version of webdriver contains the newly recommended UnknownErrorException, that replaces the deprecated UnknownServerExecption we used before. command: composer require --dev codeception/module-webdriver:^1.0.1 The webdriver package underwent a namechange from "facebook/webdriver" to "php-webdriver/webdriver". Only "codeception/module-webdriver" requires this package, so in order to get rid of the old one, also this dependency needs a raise. Resolves: #91011 Resolves: #91010 Releases: master Change-Id: Ia7283105a8307887073b77a697a3f244ac1ba4c1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64127 Tested-by:
-
Andreas Fernandez authored
Resolves: #91057 Related: #91008 Releases: master Change-Id: I448a7b2364996f55c98dfe92c3c566acdf3df3e8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64196 Tested-by:
-
Oliver Bartsch authored
This adds the closing html tag to some widget templates which missed it. Resolves: #91055 Releases: master Change-Id: I1905cc601b942c52061eed3d0dc8f0519eba4057 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64194 Tested-by:
-
- Apr 15, 2020
-
-
Oliver Bartsch authored
Removed duplicated code fragments by using the ButtonUtility consistently also for ListWidget and RssWidget. Resolves: #91051 Releases: master Change-Id: Id7b323d16d74e07ff1b68fce73a52110dbdc03d9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64189 Tested-by:
Christian Eßl <indy.essl@gmail.com> Reviewed-by:
-
Alexander Schnitzler authored
This patch has been created with rector and php-cs-fixer bin/rector process --set=php53 typo3/sysext/extbase/Classes bin/rector process --set=php53 typo3/sysext/extbase/Tests Releases: master Resolves: #91047 Change-Id: Idcd1e10e5bf6dd5fa504873e450e31a980fab9db Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64180 Tested-by: -
Oliver Hader authored
See https://review.typo3.org/c/Packages/TYPO3.CMS/+/43870/ + typo3/sysext/beuser/Resources/Private/Layouts/Default.html + module import was accidentally removed in #70360 Resolves: #91046 Releases: master, 9.5 Change-Id: I04e0be82c4f16b84b951a157c5618722cdf7577f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64184 Tested-by:
-
Alexander Schnitzler authored
GeneralUtility is a class with only static methods and a class comment stated for years not to instantiate it. Since there is a possibility to prevent instantiations of classes with private constructors, one has added to this class and on top is has been marked final. Releases: master Resolves: #91043 Change-Id: I15e2dfa98b2a30149f9f0efed31281d5d01d4efa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64181 Reviewed-by:
-
Alexander Schnitzler authored
composer remove rector/rector Package operations: 0 installs, 8 updates, 4 removals - Removing tracy/tracy (v2.7.2) - Removing rector/rector (v0.7.0) - Removing phpstan/phpstan-phpunit (0.12.6) - Removing ondram/ci-detector (3.1.1) - Updating composer/xdebug-handler (1.4.0 => 1.4.1) - Updating nette/robot-loader (v3.2.1 => v3.2.3) - Updating symplify/package-builder (v7.2.2 => v7.2.12) - Updating symplify/auto-bind-parameter (v7.2.2 => v7.2.12) - Updating nette/http (v3.0.3 => v3.0.4) - Updating symplify/autowire-array-parameter (v7.2.2 => v7.2.12) - Updating symplify/smart-file-system (v7.2.2 => v7.2.12) - Updating symplify/set-config-resolver (v7.2.2 => v7.2.12) composer require rector/rector:"^0.7.14" --dev Package operations: 5 installs, 0 updates, 0 removals - Installing tracy/tracy (v2.7.4) - Installing phpstan/phpstan-phpunit (0.12.7) - Installing ondram/ci-detector (3.3.0) - Installing jetbrains/phpstorm-stubs (v2019.3) - Installing rector/rector (v0.7.14) Releases: master Resolves: #91048 Change-Id: I45be2ba76b2bd909a28bd391fd2d9d774cbbe0e1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64186 Reviewed-by:
-
Oliver Hader authored
This change aims to reduce the amount of inline JavaScript by removing `onchange` or `onclick` events and dynamically created JavaScript code/settings. There are still a couple of aspects that need to be solved in a general way - e.g. assigning global language labels (`TYPO3.lang`) or settings (`TYPO3.settings`). * allows `Modal` confirmation to emit `ModalResponseEvent` * extracts inline JavaScript from controllers & templates * introduces `BroadcastChannel` in `nav_frame` (folder tree) * uses plain links (`<a href="..."`) where applicable * updates folder tree when navigating in browser history Resolves: #91016 Releases: master Change-Id: Ied6a626e09df07bd1a240b9b6b4250cd6fff4c8a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64154 Tested-by:
-
Benni Mack authored
Due to the deprecation of "switchable controller actions", list_type items can now be grouped in FormEngine - as well as all other "select" fields defined in TCA. A new TCA option in TCA type=select is added, called "itemGroups". In addition, all "items" now have four parts (fourth being optional) 0 => label 1 => value 2 => icon 3 => groupID where the group belongs to an item group (defined explicitly) or taken from a --div-- element, which then turns into an optgroup. In order then to avoid the "itemProcFunc" of tt_content.list_type which is used to sort items, a "sortOrders" option is added to sort items (within a group, if grouping is enabled) by label or value. When registering a new plugin, the groupId can be added as well as an additional parameter, which falls back to the "default" group. A new method ExtensionManagementUtility::addTcaSelectItemGroup() allows to add item groups via API. When registering extbase Plugins or pibase plugins, it is possible to add a registered "group ID" to make use of this feature. Resolves: #91008 Resolves: #82352 Releases: master Change-Id: I8ad215b5cbc16f332e7c129d762fc020ade5ceeb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63889 Tested-by:
-
Markus Klein authored
Fix the condition whether a page is linkable in the requested language or not. Resolves: #90850 Releases: master, 9.5, 8.7 Change-Id: I720c09cc1f938b5000980bcba20786a5cf41f98d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63946 Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
-
Oliver Hader authored
Files that just have been deleted in filelist module need to be removed from current clipboard state - otherwise the rendering process will throw ResourceDoesNotExistException due to obviously missing files. Resolves: #91039 Releases: master, 9.5 Change-Id: Ic03cd8775ee4db40996e1152f4f0b1660323780f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64177 Tested-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
-
Benni Mack authored
TYPO3's PHP-CS-Fixer configuration is adapted to move towards the PSR-12 standard by unifying the new statement and adding proper braces argument methods and arguments. Resolves: #91026 Releases: master Change-Id: If5eb945e18fb4a2330e3c9eeaf90134126638079 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64163 Tested-by:
-
Michael Schams authored
This patch updates the Changelog documentation and suggests to use one of the keywords "small", "medium", or "large" (instead of numeric values) when registering dashboard widgets. Resolves: #91041 Releases: master Change-Id: I9b1ac49d8586ab058cd7278eadaba42df4fc05fe Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64179 Tested-by:
-
Benni Mack authored
This change adds proper "language" attributes to ViewHelpers just as the typolink property now allows an additional "language" parameter, in order to allow a language menu with TypoLink. See https://docs.typo3.org/m/typo3/reference-typoscript/master/en-us/Functions/Typolink.html#language Resolves: #90613 Relate: #89686 Releases: master Change-Id: I63492b6ee99e72ca747e3d74b7991db7be52e48e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63827 Reviewed-by:
Achim Fritz <af@achimfritz.de> Reviewed-by:
-
Josef Glatz authored
The icon path of an extension is only returned if the icon can be found. This prevents the JavaScript from rendering a broken extension icon. Resolves: #91038 Releases: master, 9.5 Change-Id: Ic0a4fb874215408c1781b3acb29e9ec4769150fd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64176 Tested-by:
-
Alexander Schnitzler authored
With https://review.typo3.org/c/Packages/TYPO3.CMS/+/59514/ all possibilities have been taken to define which view class to use based on the current plugin environment parameters like controller name, action name and format. Since this is used a lot in user land code, this functionality has been re-enabled for version 10. But still, the main flaw of the original code, i.e. checking for possibly defined classes, is avoided. Instead, users can implement a deterministic view resolver which ensures view objects that implement the ViewInterface. Releases: master Resolves: #90892 Change-Id: Ide2919a6d86b2904087d3d7aa8dfece1abee4658 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64017 Tested-by:
-
Manuel Selbach authored
With this change the method DataHandler::getAutoVersionId will return null or a proper integer value to reduce the complexity at other places to bring it in the right format. Resolves: #91022 Releases: master Change-Id: I3e05e7f31314bebcac5c5d47e88c381f85a399d3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64160 Tested-by:
-
Andreas Fernandez authored
Resolves: #90941 Releases: master Change-Id: If205ab5308c0f1bb7e935a53bebee41e7b9e2fd2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64061 Tested-by:
Frank Nägler <frank.naegler@typo3.org> Tested-by:
-
Alexander Schnitzler authored
With this patch, the header comment of php files is automatically added by the php-cs-fixer, which guarantees that its format and place of occurrence remain the same in all files. Files that are copied over from other projects are excluded. Furthermore, files that are kind of inspired by other projects also get the same header comment but may have a second, additional comment explaining its origin. Used command: bin/php-cs-fixer fix --config=Build/php-cs-fixer/header-comment.php Releases: master Resolves: #91024 Change-Id: I5a040517e0fbde6e5a27d589bf2f222078326dc8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64159 Tested-by:
-
- Apr 14, 2020
-
-
Richard Haeser authored
The Type of Users dashboard widget doesn't have to be that high. Resized to height medium. Resolves: #91035 Releases: master Change-Id: Ic99545d298f9db44486579058f322c5ab388f834 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64172 Tested-by:
-
Richard Haeser authored
As the title TYPO3 for a widget as well as a widget group is not giving a lot of information about the purpose of the widget and the group, both the widget and the widget group are renamed. The widget is called About TYPO3 now. The group is called TYPO3 community now. Additionally a group called News is added and both the TYPO3 News and TYPO3 security advisories are moved to that group. The TYPO3 Community group will remain to make sure no installations will break by removing a widget group. The group won't show up when no widgets are in this group though. Resolves: #90865 Releases: master Change-Id: I468692edfafc74597d3f21b1ecb4d90cf26ad41a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64171 Tested-by:
-
Daniel Siepmann authored
Sort rss entries before reducing to shown limit. Resolves: #90770 Releases: master Change-Id: Ia95d36a06408d115fb92786c361c21227f06c792 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63756 Tested-by:
-
Jonas Eberle authored
This covers files from commits that were run against the earlier version and would not pass the nightly. Resolves: #91033 Related: #91020 Releases: master Change-Id: Ie155b53bb195510a89cb943743f8d87ab8fc4106 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64169 Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
-
Oliver Klee authored
For images that cannot be loaded (e.g., when the extension is outside the document root), the extension name will be printed twice, which looks ugly and also breaks the layout. As the extension icon is purely decorative, the alt attribute should be an empty string. Resolves: #91031 Releases: master, 9.5 Change-Id: I71be7978cc3245f127d864586dd5d54c1a6aae10 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64167 Tested-by:
-
Benni Mack authored
The option to register packages during runtime was a work-around to dynamically modify the "extList". Using this feature has certain limitations: * Runtime-activated Extensions cannot add their DI configuration * Runtime-activated Extensions make every (!) single TYPO3 request much slower just like back in 6.2.0 times The usecases from people using this functionality was to enable e.g. extensions such as "devlog", "mask"/"mask_export" or "extensionbuilder" only on development systems. Nowadays, it is recommended - if this functionality is needed - to use TYPO3 Console and Composer Mode (with require-dev) to achieve a similar behaviour. This also ensures a clear state of available extensions, and to build a proper class map / autoloading mechansims of extensions in use. Runtime-activated extensions also prohibit to continue to work on a smoother integration between composer-mode and non-composer mode in the future. Resolves: #91030 Releases: master Change-Id: If4344cd081e8f60f30c9a0fb4d0cb9c308bbfb66 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64166 Tested-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
-
Alexander Schnitzler authored
This patch enriches the deprecation messages with important information such as extension, plugin and vendor name to be able to distinguish deprecation messages from each other and to ease the location of affected code. Releases: master Resolves: #90914 Change-Id: Ia6bdd7ffa7539214de41f1b55ebe83bb66190b5f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64035 Tested-by:
-
Jonas Eberle authored
AssetRenderer gets events for manipulating AssetCollector assets. This enables asset post-processing extensions like EXT:min or EXT:ws_scss to fully support AssetCollector assets. The AssetCollector::add*() methods get an optional parameter that allows filtering for (non-)priority assets. It became apararent during testing that any listener would otherwise have to implement that itself in order to avoid double-processing assets (as there are two rendering passes, priority and non-priority). Resolves: #90899 Releases: master Change-Id: I2526328d3ee4ab269fa654347abd6156ee516a84 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64021 Tested-by:
-
Benni Mack authored
Use PHP's native \SessionHandlerInterface to allow further separation of concerns and allow other packages to use a different implementation (e.g. via redis). Resolves: #90938 Releases: master Change-Id: Ibc16efd0edd35df3f6673e3150929947ede5b500 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64034 Tested-by:
-
Christian Eßl authored
The changes made in #18079 lifted the restrictions for using doktypes with a number higher than 200 in several parts of the frontend. These restrictions were still present in the SlugHelper upon resolving a parent page record (which automatically fetches the slugs of parent pages for a child page upon creating its slug). This hard restriction made it impossible to automatically resolve the slug of a parent page with a doktype higher than 200. The check is now adjusted to solely exclude the following doktypes: * DOKTYPE_SPACER (199) * DOKTYPE_SYSFOLDER (254) * DOKTYPE_RECYCLER (255) Resolves: #90947 Related: #18079 Releases: master Change-Id: Ia71ad2251969a73875124c80ea7521212e459150 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64073 Tested-by:
-
