[BUGFIX] Don't render broken extension icons in language packs updater

The icon path of an extension is only returned if the icon can be found.
This prevents the JavaScript from rendering a broken extension icon.

Resolves: #91038
Releases: master, 9.5
Change-Id: Ic0a4fb874215408c1781b3acb29e9ec4769150fd
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64176


Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>

Build/Sources/TypeScript/install/Resources/Public/TypeScript/Module/Maintenance/LanguagePacks.ts

@@ -442,7 +442,7 @@ class LanguagePacks extends AbstractInteractableModule {
     const $tbody = $('<tbody>');
     data.extensions.forEach((extension: any): void => {
       rowCount++;
-      if (extension.icon !== '') {
+      if (typeof extension.icon !== 'undefined') {
         extensionTitle = $('<span>').append(
           $('<img>', {
             'style': 'max-height: 16px; max-width: 16px;',

typo3/sysext/install/Classes/Service/LanguagePackService.php

@@ -173,8 +173,10 @@ class LanguagePackService implements LoggerAwareInterface
             $extension = [
                 'key' => $key,
                 'title' => $title,
-                'icon' => PathUtility::stripPathSitePrefix(ExtensionManagementUtility::getExtensionIcon($path, true)),
             ];
+            if (!empty(ExtensionManagementUtility::getExtensionIcon($path, false))) {
+                $extension['icon'] = PathUtility::stripPathSitePrefix(ExtensionManagementUtility::getExtensionIcon($path, true));
+            }
             $extension['packs'] = [];
             foreach ($activeLanguages as $iso) {
                 $isLanguagePackDownloaded = is_dir(Environment::getLabelsPath() . '/' . $iso . '/' . $key . '/');