- Jun 21, 2024
-
-
Benjamin Kott authored
Using the forced primary link colors in dark mode on dark backgrounds generates insufficient contrast. In addition, we let the general module link handler handle the switch to the module. Resolves: #104175 Related: #104129 Releases: main Change-Id: I4ead28801d66ffee2ffcb13766be115c25601b36 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84821 Tested-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Reviewed-by:
Benjamin Kott <benjamin.kott@outlook.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Christian Kuhn authored
Not globally setting backupGlobals=true speeds up unit tests quite significantly. We can do this with deprecated unit tests without further issues already. Resolves: #104177 Releases: main Change-Id: I4566b5113400563254041a35819ab34efa642313 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84831 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de>
-
Jasmina Ließmann authored
The two submodules "Check Links" and "Report" of backend module "Check Links" have been merged into one view. Language keys that are no longer used have been deleted in the process. If no page has been selected in the page tree, a corresponding info box now appears. Further improvements to this backend module will be made in further patches. Resolves: #104145 Releases: main Change-Id: Ic9331b6e58bf5986bc0e84416276faaec149e575 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84702 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Tested-by:
core-ci <typo3@b13.com>
-
Jasmina Ließmann authored
The redirects overview table has been revised to improve the UX. Previously, the table fields took up as much space as their content allowed. Redirects with a long source and/or destination path stretched the table rows, which caused unwanted horizontal scrolling. The patch now fixes this and sets a maximum width for these fields. Furthermore, the "Status Code" and "Protected" fields are now also managed as separate table columns. The record icon is now placed first after the multi-record selection checkbox, as with other tables used in the system. Further actions, such as viewing the redirect and resetting the hit counter, have been moved to a separate button group. Resolves: #104166 Related: #93912 Releases: main Change-Id: I5844e1e95ea9f3b1e9a2b06ca91dce9db3cf495e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84805 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Oliver Bartsch authored
Using the multi record selection, it's possible to change the state of checkboxes via multiple ways, e.g. by clicking on the table row. The central functionality for changing the connected checkbox state now also considers the disabled attribute and therefore only changes the checked state in case the checkbox is not disabled. Additionally, next to the custom event, which is triggered on checkbox state changes, the multi record selection now also dispatches the standard "change" event. FormEngine validation for example is listening on this event to mark the field as changed. The JS component is also migrated to a proper custom element (web component). Resolves: #104142 Releases: main, 12.4 Change-Id: I9854709ee624d88821757fff3baf38c892e5f11d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84749 Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Ayke Halder <mail@ayke-halder.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Ayke Halder <mail@ayke-halder.de>
-
Christian Rath-Ulrich authored
This commit fixes a minor issue where the header tag in PaletteAndSingleContainer was incorrectly set as h4. The tag has been changed to h3 for better readability and semantics. Simultaneously, visually hidden headers were also added to tabs to improve accessibility. Resolves: #104021 Releases: main, 12.4 Change-Id: Ic2301eabb23d1d17169056ec8e9ec40a5824c52c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84545 Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benjamin Kott <benjamin.kott@outlook.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com>
-
Leon Dietsch authored
When switching between cropVariants with multiple coverAreas, all of the previous coverAreas are properly removed, only showing those that belong to a specific cropVariant. See details and screenshots in the related ticket. (A new styleguide TCA element crop_9 is also added to showcase multiple coverAreas in multiple cropVariants) Resolves: #103389 Releases: main, 12.4 Change-Id: I7649aa0fe5bc01939326119b24dbdafd5f09a708 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84489 Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Andreas Nedbal <andy@pixelde.su> Tested-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Andreas Nedbal <andy@pixelde.su> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Chris Müller <typo3@brotkrueml.dev> Reviewed-by:
Chris Müller <typo3@brotkrueml.dev> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com>
-
Garvin Hicking authored
When filtering the page tree with characters that have special meaning for a regular expression (for example, ")" or "(" or "?" and some others), the filtering would return a "Page Tree error". JavaScript does not have something like "preg_quote", so this uses the escape string provided by the MDN with fixed special characters. Resolves: #104092 Releases: main, 12.4, 11.5 Change-Id: I4a29c62eaca8b7643c8ef78dda1d8337b3e1e53a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84785 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- Jun 20, 2024
-
-
Andreas Kienast authored
Resolves: #104080 Releases: main Change-Id: I83b5f8dfabb32b584300066ea52a97b5917ca6c4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84677 Tested-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Tested-by:
core-ci <typo3@b13.com>
-
- Jun 19, 2024
-
-
Andreas Kienast authored
The method `Utility.updateQueryStringParameter()` from the module `@typo3/backend/utility.js` was introduced in TYPO3 v8 as a bugfix for highlighting in the old ExtJS-based page tree. With removal of ExtJS in TYPO3 v9, the method became unused since then. Since a safe removal of the method cannot be guaranteed as this point, it is therefore deprecated. Resolves: #104154 Related: #74180 Releases: main Change-Id: I90f0ff4c997ab31d690ff6f518f38ffb186058dd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84786 Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com>
-
- Jun 18, 2024
-
-
Jochen Roth authored
Currently, the notification/alert container does not allow scrolling when multiple notifications exceed the viewport height and it is not possible to clear all displayed notifications. This has been changed to allow scrolling within the container. On top of this, it is now also possible to focus the container using tab and scroll up and down using the arrow keys and clear all notifications with a single click. Resolves: #104069 Releases: main Change-Id: I6f4c27bff84942a3f161310da85a04957648218d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84659 Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Garvin Hicking <gh@faktor-e.de>
-
Benjamin Franzke authored
Improve document-service responsiveness by relying on `DOMContentLoaded` and `document.readyState` >= `interactive`. 1) Handle non-loading state as "ready" to avoid waiting for `complete`. `document.readyState` has three states: * `loading` The document is still loading. * `interactive` The document has finished loading and the document has been parsed but sub-resources such as scripts, images, stylesheets and frames are still loading. The state indicates that the DOMContentLoaded event is about to fire. * `complete` The document and all sub-resources have finished loading. The state indicates that the load event is about to fire. If DocumentService.ready was called in "interactive" state we have been skipping this state as we only considered `complete` to be the "ready" state in this case. This is wrong as we actually wait for the DOMContentLoaded if we are launched in the initial readyState (`loading`), that means an initial `interactive` must be understood as: `DOMContentLoaded` has already been fired as state is `interactive` We should actually avoid waiting for `complete` entirely, as document readyState `interactive` means "ready" in terms of document parsing. We're not interested in images or async scripts that are still loading and want event listeners to be registered as early as possible. With this improvement applied we can also drop the (now) unneeded `load` event-listener, as we are no longer skipping interactive state (this made the `load`-listener necessary previously). Note that the `load` workaround was previously needed for IE<=10 as those versions set `document.readyState` to `interactive` prior to the `DOMContentLoaded` event. This applied workaround becomes a race condition once `load` never happens and that is the case with a recent google chrome regression which causes iframe documents to never "complete": https://issues.chromium.org/issues/347724924 2) Drop the timeout logic. It is no longer needed now that we only need to wait for `DOMContentLoaded` – which will always fire (or already fired) – instead of the `load` event. 3) Avoid creation of new promises for every invocation of the ready-method. A promise can be reused without side effects by multiple consumers. This avoids creating a lot of event listeners (and previously timers). 4) Remove unneeded document and window references. Releases: main, 12.4, 11.5 Resolves: #104135 Related: #104139 Change-Id: I42c86961405f8a5c346c17ea429a288a85d58f8a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84742 Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de>
-
Christian Kuhn authored
Argument passing using `--` works well. It's time to remove the previous `-e` solution. Resolves: #104137 Related: #104131 Related: #102769 Releases: main, 12.4, 11.5 Change-Id: I99577a24dda77c4c96813f8ca14c2a27bdf7f2de Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84745 Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Garvin Hicking <gh@faktor-e.de>
-
Georg Ringer authored
The backend layout wizard now uses a working example by using an existing icon. Resolves: #91910 Releases: main, 12.4 Change-Id: If6df3bd73d1ff6dc1a7a3e71cadf2e89b1a18bd5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84529 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Georg Ringer <georg.ringer@gmail.com>
-
Christian Kuhn authored
Inline the 'random seed' option for -s unitRandom, replay a specific seed using: > runTests.sh -s unitRandom -- --random-order-seed=<number> Resolves: #104131 Releases: main, 12.4, 11.5 Change-Id: I84e1cc0a0c57a5132a592a140d1b58ceb6d3b059 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84735 Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com>
-
- Jun 15, 2024
-
-
Andreas Nedbal authored
Backend users can now search for the backend modules they have access to in the LiveSearch. Resolves: #92009 Releases: main Change-Id: I28d9593655989f064b7a7fac0ab80415eee4c6fe Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84654 Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de>
-
- Jun 14, 2024
-
-
Oliver Bartsch authored
A new multi record selection option is added to the filelist, which allows to edit the metadata of multiple records while respecting the currently defined columns list. Resolves: #104095 Releases: main Change-Id: Ib679628f280116de47e6f59ec5e3cec0e4f9535a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84695 Tested-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Jochen Roth <rothjochen@gmail.com> Reviewed-by:
Jochen Roth <rothjochen@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Oliver Bartsch authored
A new multi record selection option is added to the recordlist, which allows to edit multiple records while respecting the currently defined columns list. Resolves: #104085 Releases: main Change-Id: I740a8b31381bbc03c178e4b2048c760f5d31afd6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84682 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Jochen Roth <rothjochen@gmail.com> Tested-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Jochen Roth <rothjochen@gmail.com>
-
Oliver Bartsch authored
Defining columnsOnly, which is used by the EditDocumentController to instruct the FormEngine to only render a subset of available fields for records is now table aware. This allows to render records from different tables in the same request, while respecting the fields to be rendered on a per-table basis. The "columnsOnly" parameter therefore now requires the fields as array under the corresponding table name: &columnsOnly[pages][0]=title A backwards-compatibility layer is in place, migrating the previous syntax to the new one by adding the configured fields for the tables from the edit configuration. Resolves: #104108 Releases: main, 12.4 Change-Id: I46500100eb369ad117a2cf5c61a9811c6fd5c7a3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84711 Tested-by:
Jochen Roth <rothjochen@gmail.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Jochen Roth <rothjochen@gmail.com>
-
Christian Rath-Ulrich authored
Resolves: #104065 Releases: main, 12.4 Change-Id: I48c121620bf84a9444ff3c9d79d1adfd1fa631f3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84655 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Andreas Nedbal <andy@pixelde.su> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Michael Telgkamp <michael.telgkamp@mindscreen.de> Reviewed-by:
Andreas Nedbal <andy@pixelde.su> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Michael Telgkamp <michael.telgkamp@mindscreen.de>
-
- Jun 13, 2024
-
-
Andreas Kienast authored
With the upgrade to Bootstrap 5, the panels have no explicit position anymore, breaking the progress bars in the Extension Scanner found in the Install Tool. This commit adds a relative positioning to the panels. Resolves: #104073 Releases: main, 12.4 Change-Id: Ie67989dbcfa859ebc3020dabaa27913de7ae4b64 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84663 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Georg Ringer <georg.ringer@gmail.com>
-
Christian Kuhn authored
Resolves: #104094 Releases: main Change-Id: I0d732915975135e2eb04c6c854b6b01257c3aec9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84694 Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
core-ci <typo3@b13.com>
-
Oliver Bartsch authored
The toggle button to open the selection options of the multi record selection component does now provide an aria-label to make it accessible for screen readers. Resolves: #104089 Releases: main, 12.4 Change-Id: I89af5e4f5a0f8dd87be5d532bdd894bd2636502e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84686 Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Michael Telgkamp <michael.telgkamp@mindscreen.de> Tested-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Tested-by:
Andreas Nedbal <andy@pixelde.su> Reviewed-by:
Andreas Nedbal <andy@pixelde.su> Reviewed-by:
Michael Telgkamp <michael.telgkamp@mindscreen.de> Tested-by:
core-ci <typo3@b13.com>
-
Jasmina Ließmann authored
* Align display of "References" table column with usual system display * Increase size of "Location" table column * Adjust action buttons displayed in table rows * Use "Info" color for form duplication and references modals * Update table, buttons and modal header in references modal * Use "Danger" color for form deletion modal and update used wording Resolves: #104043 Related: #102978 Releases: main Change-Id: I3672dd45605cc4e2ed483168cf86db7529fc2788 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84088 Tested-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Reviewed-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Jochen Roth <rothjochen@gmail.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Jochen Roth <rothjochen@gmail.com>
-
Andreas Nedbal authored
Before it was not really clear if/where a select check box header was collapsible. This patch unifies the layout with the one of the recordlist tables, adding a button specifically responsible to collapse/expand the group. Resolves: #98683 Releases: main, 12.4 Change-Id: I6b47cdc9cd2673a85aaa0bfb85dd70534e4ffc33 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79703 Tested-by:
Michael Telgkamp <michael.telgkamp@mindscreen.de> Tested-by:
Andreas Nedbal <andy@pixelde.su> Reviewed-by:
Andreas Nedbal <andy@pixelde.su> Reviewed-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Reviewed-by:
Michael Telgkamp <michael.telgkamp@mindscreen.de>
-
- Jun 12, 2024
-
-
Christian Rath-Ulrich authored
To improve accessibility, an aria-label is added to all context menu buttons to allow assistive technologies to announce them correctly. Resolves: #102490 Releases: main, 12.4 Change-Id: Ia397ab17a8fcbfe3a1ea75e86733a6a5a778653e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81943 Tested-by:
Michael Telgkamp <michael.telgkamp@mindscreen.de> Reviewed-by:
Michael Telgkamp <michael.telgkamp@mindscreen.de> Reviewed-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Tested-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Oliver Bartsch authored
The form listing in the form backend module is now sortable. Resolves: #104067 Releases: main Change-Id: Ib950e17b6b8a350b07e3340ce948969da7fed69d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84656 Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Andreas Nedbal <andy@pixelde.su> Tested-by:
Andreas Nedbal <andy@pixelde.su> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
Oliver Bartsch <bo@cedev.de>
-
Oliver Bartsch authored
To unify and streamline record selection in the backend, the SelectCheckBoxElement now also utilizes the MultiRecordSelection component. This allows to get rid of the custom JS implementation. Resolves: #104012 Releases: main Change-Id: I2ed675e9c04530d822036c7573ab62301486b2d4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84602 Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
Andreas Nedbal <andy@pixelde.su> Reviewed-by:
Andreas Nedbal <andy@pixelde.su> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de>
-
Michael Telgkamp authored
The Treeview widget is only allowed to have one tabstop. Focus handling within the widget is done using arrow keys. When scrolling away from the focused node, and then focusing the widget again, the focus is restored. Resolves: #104061 Releases: main Change-Id: If99bd5c5de506cbc649430fb8678736bdb7efdf6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84626 Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
Benjamin Kott <benjamin.kott@outlook.com>
-
- Jun 11, 2024
-
-
Andreas Kienast authored
This commit introduces a new component to render progress bars in a streamlined fashion, addressing common accessibility issues by providing proper aria attributes. The component supports a `max` value and a relative `value` attribute. If `value` is omitted, the progress bar is rendered in an indeterminate state. If `value` is present, an optional `severity` attribute can get passed to visually describe the state of the progress bar. Please note that only successful, warning and error states are supported. Additionally, an optional `label` can get passed, describing the progress bar and its current state. Important note: this component is rather experimental by now and may change in a few details. Until further notice, this component is strictly for internal use only. Resolves: #103767 Releases: main Change-Id: I2a99c10e589482a2972935f49af87119ea899f34 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84038 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Andreas Nedbal <andy@pixelde.su> Tested-by:
Andreas Nedbal <andy@pixelde.su> Reviewed-by:
Benjamin Franzke <ben@bnf.dev>
-
- Jun 10, 2024
-
-
Jasmina Ließmann authored
The "About" backend module provides overviews of the modules available in the system, installed external libraries, authors of installed extensions, as well as general information about TYPO3 and its community. This patch standardizes the appearance of the cards in this module with those from the "Admin Tools" area. In addition, the heading structure has been updated and some headings have been added. In addition, links are now colored blue, similar to those in the "System Information" toolbar element, and email links in the extension authors list were removed because they violated the Content Security Policy. Resolves: #104009 Releases: main Change-Id: Ia3a0811e973edea579e8d66d2f0d7f01e9ded0c2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84400 Reviewed-by:
Andreas Nedbal <andy@pixelde.su> Tested-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Andreas Nedbal <andy@pixelde.su> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Reviewed-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com>
-
Willi Wehmeier authored
The aspect ratio buttons in the image cropping tool have a visible focus state now to make them usable when navigating with the keyboard tab key. Additionally the button can now be pressed with the space and return key. Resolves: #103760 Releases: main, 12.4 Change-Id: Id221daddeee9d5b61497cb74604dbf151d25e3ee Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84079 Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Michael Telgkamp <michael.telgkamp@mindscreen.de> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
Michael Telgkamp <michael.telgkamp@mindscreen.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com>
-
Oliver Bartsch authored
When inserting a record via the element browser, the value argument needs either to be formatted manually or left empty, allowing the element browser to format the identifier automatically. By omitting the value in the `PageBrowser` module, the value is now correctly formatted by the element browser to "pages_<uid>". This makes the "node-action" usable for TCA group fields, which allow more than one record type. The same logic is also used by the `BrowseDatabase` module, which also omits the value argument. Resolves: #103700 Releases: main, 12.4 Change-Id: I80e2cc696d85b5ec83432c35a263b19f9752b0ef Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84018 Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Stefan Bürk authored
PHPUnit changed the way how double creation is handled internally and now emits an exception if a manually defined `mock class name` should be registered. In some places within the unit tests, manual mock class names have been used, because the names are needed for cross referencing at a later point. For this, different approaches have been used, for example hardcoded MD5 hashes as strings or creating hashes of static values like `md5('1')`, and also reused hashes in different places or in tests using data providers. This now leads to an exception: PHPUnit\Framework\MockObject\Generator\NameAlreadyInUseException The name "b70551b2b2db62b6b15a9bbfcbd50614" is already in use This change mitigates the issue by using `StringUtility::getUniqueId('somePrefix')` as is already done in other places. As a sideeffect, four phpstan baseline entries can be removed. Used command(s): Build/Scripts/runTests.sh -s phpstanGenerateBaseline [1] https://github.com/sebastianbergmann/phpunit/pull/5804 Resolves: #104005 Releases: main, 12.4 Change-Id: Icc558844275c9ae9f67a0e7c20daa318f5ad6b41 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84530 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Andreas Wolf <andreas.wolf@typo3.org> Reviewed-by:
Andreas Wolf <andreas.wolf@typo3.org>
-
- Jun 07, 2024
-
-
Andreas Kienast authored
With the upgrade of alwan to 2.x, CSS was completely overhauled. This snuck in some issue regarding the color previews, where always either a dark or light background was rendered, depending on user configuration. This commit fixes the CSS to use the internal `--color` custom property, which reflects the actual color value. Resolves: #103995 Related: #102735 Releases: main Change-Id: I326498995d2ddea5569f5e9a5c35b3e620f8872a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84522 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Georg Ringer <georg.ringer@gmail.com>
-
- Jun 06, 2024
-
-
Garvin Hicking authored
The directory to reference removing Documentation-GENERATED-temp breaks out of the current working directory scope and could possibly delete files in a completely unrelated directory. Also, it does not remove the actual temporary files. Resolves: #103989 Releases: main, 12.4, 11.5 Change-Id: I685a398aa0d5abee3177ab3def4e271d493d59ab Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84513 Reviewed-by:
Jochen Roth <rothjochen@gmail.com> Reviewed-by:
Patrick Schriner <patrick.schriner@diemedialen.de> Tested-by:
Patrick Schriner <patrick.schriner@diemedialen.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Jochen Roth <rothjochen@gmail.com> Tested-by:
Stefan Bürk <stefan@buerk.tech>
-
Garvin Hicking authored
The use of the backtick operator inside the help output leads to an error message: Build/Scripts/runTests.sh: line 175: --: command not found on macOS (probably others, too). This patch replaces the backticks with normal quotes. Resolves: #103988 Releases: main, 12.4, 11.5 Change-Id: Ib6809dc6943a98e4d45d04f4ec02601e830518cd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84512 Reviewed-by:
Jochen Roth <rothjochen@gmail.com> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Patrick Schriner <patrick.schriner@diemedialen.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Patrick Schriner <patrick.schriner@diemedialen.de> Tested-by:
Jochen Roth <rothjochen@gmail.com>
-
- Jun 05, 2024
-
-
Jasmina Ließmann authored
In single result view of the "Indexing" backend module, the words found on the page are listed in three tables, each sorted by count, frequency and name. This patch removes the tables "Words by top count" and "Words by frequency" and extends the remaining table to sort by table columns "Word", "Word count" and "Frequency". If no words were found, an info box is now displayed. Resolves: #103727 Releases: main Change-Id: I5b11b9b455452bafc969baa5f246f67101a3a02a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84023 Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
core-ci <typo3@b13.com>
-
- Jun 04, 2024
-
-
Andreas Kienast authored
The stylesheet loading process in IRRE was kept for several years and moved from version to version. A recent change in #103375 migrated a usage of `delete` to `.splice()`, breaking stylesheet loading as the original iterated object was modified. Since the code was quite dated and had other potental bugs, the whole loading sequence has been transformed to functional programming style to reduce complicated, potentially error-prone, array operations. Resolves: #103971 Related: #103375 Releases: main, 12.4 Change-Id: I18caafc68ceebce53723b7208270043faafc7458 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84487 Tested-by:
rogier Helmer <rogier.helmer@maxserv.com> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
rogier Helmer <rogier.helmer@maxserv.com> Tested-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Benjamin Franzke <ben@bnf.dev>
-
Andreas Kienast authored
This commit updates ckeditor to 41.4. See changelog at [1]. Executed commands: # Override ckeditor5 package to avoid pulling in all/too # many available packages. See: # https://github.com/ckeditor/ckeditor5/issues/16360 npm --prefix overrides/ckeditor5 version 41.4.2 npm install --save ./overrides/ckeditor5 npm install --save \ @ckeditor/ckeditor5-alignment@^41.4.2 \ @ckeditor/ckeditor5-autoformat@^41.4.2 \ @ckeditor/ckeditor5-basic-styles@^41.4.2 \ @ckeditor/ckeditor5-block-quote@^41.4.2 \ @ckeditor/ckeditor5-clipboard@^41.4.2 \ @ckeditor/ckeditor5-code-block@^41.4.2 \ @ckeditor/ckeditor5-core@^41.4.2 \ @ckeditor/ckeditor5-editor-classic@^41.4.2 \ @ckeditor/ckeditor5-engine@^41.4.2 \ @ckeditor/ckeditor5-essentials@^41.4.2 \ @ckeditor/ckeditor5-find-and-replace@^41.4.2 \ @ckeditor/ckeditor5-font@^41.4.2 \ @ckeditor/ckeditor5-heading@^41.4.2 \ @ckeditor/ckeditor5-horizontal-line@^41.4.2 \ @ckeditor/ckeditor5-html-support@^41.4.2 \ @ckeditor/ckeditor5-indent@^41.4.2 \ @ckeditor/ckeditor5-link@^41.4.2 \ @ckeditor/ckeditor5-list@^41.4.2 \ @ckeditor/ckeditor5-paragraph@^41.4.2 \ @ckeditor/ckeditor5-paste-from-office@^41.4.2 \ @ckeditor/ckeditor5-remove-format@^41.4.2 \ @ckeditor/ckeditor5-select-all@41.4.2 \ @ckeditor/ckeditor5-show-blocks@^41.4.2 \ @ckeditor/ckeditor5-source-editing@^41.4.2 \ @ckeditor/ckeditor5-special-characters@^41.4.2 \ @ckeditor/ckeditor5-style@^41.4.2 \ @ckeditor/ckeditor5-table@^41.4.2 \ @ckeditor/ckeditor5-theme-lark@^41.4.2 \ @ckeditor/ckeditor5-ui@^41.4.2 \ @ckeditor/ckeditor5-undo@^41.4.2 \ @ckeditor/ckeditor5-upload@^41.4.2 \ @ckeditor/ckeditor5-utils@^41.4.2 \ @ckeditor/ckeditor5-watchdog@^41.4.2 \ @ckeditor/ckeditor5-word-count@^41.4.2 npm install --save-dev \ @ckeditor/ckeditor5-dev-utils@^40.0.0 npm run build [1] https://github.com/ckeditor/ckeditor5/releases/tag/v41.4.2 Resolves: #103840 Releases: main, 12.4 Change-Id: I46dc33ab8e8cfcc75aa13bfe50d8850fb704f75e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84281 Tested-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
Benjamin Franzke <ben@bnf.dev>
-