- Oct 12, 2020
-
-
Benni Mack authored
Both Domain\Model\Extension and Domain\Model\Dependency now have factory methods to avoid using the ExtensionModelUtility to build objects in an atomic state. This marks the ExtensionModelUtility class obsolete, which resolved dependencies and built Dependency objects. The Dependency object is now not an AbstractEntity anymore, but more of a type ValueObject. However, since the Dependency object knows about the min/max version constraints, this logic is now shifted into this class, making the DependencyUtility much smaller in logic. Resolves: #92547 Releases: master Change-Id: I7116d0d2c4f0d08b4a503f48b75ab50bfc675d21 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66100 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
Benni Mack authored
With the new possibility to add more pages.doktype variants since TYPO3 v10, the DB field "pagetypes_select" is not large enough for let's say 50 custom page types. The DB field should be extended to allow any kind of custom doktypes to be selected. Resolves: #92548 Releases: master, 10.4 Change-Id: I2a13df7f1095a48187cdfa4acee04c623e3a088b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66103 Tested-by:
David Steeb <david.steeb@b13.com> Tested-by:
Matthias Stegmann <matthias.stegmann@b13.de> Tested-by:
Desiree Lochner <desiree.lochner@b13.com> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
-
Tymoteusz Motylewski authored
Add index on the felogin_forgotHash field of the fe_login table to speed up db queries send when user requests password reminder. Resolves: #92485 Releases: master, 10.4 Change-Id: I100557a82fe352eb6c078df65c6f8b81a1e92802 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66055 Tested-by:
Simon Gilli <typo3@gilbertsoft.org> Tested-by:
-
Daniel Goerz authored
Resolves: #92536 Related: #92532 Releases: master Change-Id: Ib11897a1427cea1d60d82961294cfad743471487 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66101 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Benni Mack authored
A feature which was built for the introduction package back then, which allowed to ship a modified / custom extension as dependency, where one could put another extension in EXT:my_ext/Initialisation/Extensions/another_ext is removed, as this special case is a) not needed anymore b) not following any rules of being conformant for "dependency hell" c) specific for dependency handling of TYPO3 (non-composer) Resolves: #92532 Releases: master Change-Id: I7e7d8681a81e184835122ae221971e5eab435778 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66097 Tested-by:
-
Oliver Bartsch authored
In #92457 a new field `remote` was introduced to `tx_extensionmanager_domain_model_extension`. As it was not added to the corresponding TCA, accessing the value through the extbase model throws an exception when installing an extension in Extension Manager. It's therefore now added to the TCA, enabling the automatic extbase mapping. Resolves: #92533 Relates: #92457 Releases: master Change-Id: I685ce04d18f7c623372ac809cc5a339fc64e31c6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66099 Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
- Oct 10, 2020
-
-
Benni Mack authored
isLoggedIn() is referring to the user, as Frontend sometimes needs "isUserOrGroupSet()" functionality for working with Admin Panel Previews or the infamous pages.fe_login_mode where the user log in is hidden but the group is still valid. Resolves: #90989 Releases: master, 10.4 Change-Id: Ib19dfbea6c355abe51507430fb03e247eb5c27bf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64441 Tested-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Reviewed-by:
-
Andreas Fernandez authored
This patch removes jQuery from a major part of FormEngine components, including elements, field wizards, enhancers and IRRE. Additionally, the argument `optionEl` of the method `FormEngine.setSelectOptionFromExternalSource()` accepts objects of type `HTMLOptionElement` which renders jQuery objects obsolete, which has been deprecated. Resolves: #91911 Releases: master Change-Id: I5b7d2f4c7b9b5993a5bbe8cec016aa74cabbbecd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65009 Tested-by:
Stefan Froemken <froemken@gmail.com> Tested-by:
Richard Haeser <richard@richardhaeser.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
Chris Müller authored
Resolves: #92530 Releases: master, 10.4 Change-Id: If593ae69ec7862f45eeea7d0c15cebf98462139b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66096 Tested-by:
-
- Oct 09, 2020
-
-
Benni Mack authored
This change is cleaning up a lot of Extension-Manager-code under-the-hood in order to solve some important topics related to t3x files, and how to fetch extensions from TER / Repositories. First of all, instead of having *one* API on how to retrieve extensions, an ExtensionDownloaderRemoteInterface is added which allows for downloading a single extension from a remote endpoint. In conjunction ListableRemoteInterface is used to fetch all available extensions from a remote (known as extensions.xml.gz currently). For both functionalities, the existing functionality from TER API is kept: * Downloading an extensions.xml.gz * Downloading an extension as a t3x file from a remote However, this is now placed into the TerExtensionRemote class. Custom remote configuration can be added in Services.yaml. This makes the previous "Repository" and its connected "Mirrors" functionality completely obsolete. Additional bugfixes: * Since TER does not have mirrors anymore, ...
-
Claus Due authored
This patch: * Removes dead code which deals with setting an extension configuration option by path (which is not supported!) * Removes an unused parameter to pass the path. * Adjusts tests and usages of the class to no longer pass an empty string as $path argument. Releases: master Resolves: #89957 Change-Id: Ia74a9d9994056599006e375ec63c32dcd8e4c403 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62650 Tested-by:
-
Christian Eßl authored
If the configuration `['BE']['debug']` is enabled and the current user is an administrator, the name of a DB table or DB field is appended to the select options in the "Full Search" module of ext:lowlevel. Resolves: #92522 Releases: master Change-Id: I1da79ac49f7d9b7c4890d3ebc0141f48b89ff00d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66089 Tested-by:
Josef Glatz <josefglatz@gmail.com> Tested-by:
-
- Oct 08, 2020
-
-
Georg Ringer authored
Having empty array like `routes: { }` make it hard to lint the site configuration yaml files. To have a cleaner state, those empty arrays are removed before they are persisted. Resolves: #92524 Releases: master, 10.4 Change-Id: Id4f9cae7deb5903bf735cc1076731a5105b494ec Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66091 Tested-by:Markus Klein <markus.klein@typo3.org> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Benni Mack authored
Due to legacy reasons before PSR-15 middlewares were introduced, there was a hook to re-evaluate the Page ID via TSFE->determineId() which was popular with RealURL. $TSFE->determineId() was called twice when logged-in backend users were accessing a page they did not have access to, with a clean state, however TSFE->determineId() does the same check already as well, so it is not needed to call determineId() twice anymore, because the hook was removed in TYPO3 v10. Resolves: #92500 Releases: master Change-Id: Ib2f24fe193eae1dd974d6bebcc1a8803dce194f4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66067 Tested-by:
-
Helmut Hummel authored
* use singular for array command options * clarify option description * remove same purpose configuration class and extend demand instead * remove proxy method in service class * use demand as argument instead of property * filter order field against allow list * use dependency injection * cleanup superfluous annotations Releases: master Resolves: #92426 Change-Id: I1aa9078fcffbfb601aeac82b982e1fffd3159dc2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65916 Tested-by:
-
Helmut Hummel authored
The code in the test suite is based on PHPUnit 8 therefore using it with PHPUnit 9 will produce a lot of warnings caused by deprecations. The testing framework however allows installing PHPUnit 9, which is fine, when the test suite itself can cope with that. This is why we pin our tests to PHPUnit 8, until we adapt them to properly work with PHPUnit 9 composer req --dev phpunit/phpunit ^8.5.2 Resolves: #92511 Releases: master, 10.4 Change-Id: I9270dd6d7e8c0b8b6a8794a54abc2195c8aad896 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66077 Tested-by:
-
Sybille Peters authored
Releases: master, 10.4 Resolves: #92506 Change-Id: I292d0220335884f9185a468bdbd50bae41a6ca5b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66072 Tested-by:
-
Alexander Schnitzler authored
Classes Argument and Arguments are prototypes (stateful) which have been created by the object manager to have dependencies injected. This however is problematic for various reasons: 1) ObjectManager shouldn't be injected into classes as it's used to fetch objects (with DI support) directly from the container. 2) In those classes, prototypes had been injected which are now created directly via makeInstance. To be able to achieve this, the property mapper had been pulled out of the Argument class and does not longer manipulate the internal value on a setValue call. The proper value is now set from outside the Argument instances in the ActionController. Releases: master Resolves: #92236 Change-Id: Ic0ca6b84c003c6d15c9fde4fa64cb3bbb71f7880 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65640 Tested-by:
-
Daniel Goerz authored
With #92264 the behavior of the public function LocalDriver->isFolderEmpty() has been changed for invalid input. As this was an unintended change, the former behavior is restored with this patch. Resovles: #92498 Relates: #92264 Releases: master, 10.4 Change-Id: I4ab6d79b3ecacc575612391711ab039d62b64a90 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66065 Tested-by:
-
Georg Ringer authored
If a rich text field contains a link to a file or folder the current user doesn't have access to, the thrown exception must be handled and ignored. Resolves: #91400 Releases: master, 10.4 Change-Id: I255d6793785d1a074870aafc7b0f07bd9e82af94 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66021 Tested-by:
-
Georg Ringer authored
If the site config is saved through the site module the following fields are saved as integer instead of a string: - `languageId` of a language item - `errorCode of an errorHandling item This change makes it easier to lint the yaml configuration. Resolves: #92510 Releases: master, 10.4 Change-Id: I3086a6c71a191ac1cbc0c14deadce3fa7fab5f5d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66076 Tested-by:
-
- Oct 07, 2020
-
-
Georg Ringer authored
With #90803 the ObjectManager::get has been deprecated. Remove its usages from the ViewHelpers of EXT:belog. Resolves: #92484 Releases: master Change-Id: I1970d38a7ff0b9d777656e9af83ecc6012333e5b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66017 Reviewed-by:
-
Georg Ringer authored
tt_content The field control "addRecord" allows editors to create a file collection within the content element of type uploads. Resolves: #92486 Releases: master Change-Id: Ie2873049e313de0d28827628a7305c68774f45ee Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66018 Reviewed-by:
-
Benni Mack authored
AdminPanel's feature to include hidden records, also included fe_groups, which allowed to preview fe_groups which are marked as "hidden". This feature has been removed as frontend groups need to be visible in order to be previewed. Resolves: #92499 Releases: master Change-Id: Ic48b34a07b008e99d985569f2932979cdb08540a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66069 Tested-by:
-
Anja Leichsenring authored
The test fails in recent runs due to a type error. It expects an integer, but gets served a string and therefore fails. Adjusting the expected value to be a string solves the test failure. Resolves: #92496 Releases: master, 10.4 Change-Id: I6289502e7f44c3ec826138b32bdfa8e775565fb1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66063 Tested-by:
-
Christian Kuhn authored
The fix for #92388 also solved the issue that a test fails on postgres and mssql. Activate the functional on those platforms now. Resolves: #92480 Related: #92388 Releases: master, 10.4 Change-Id: I4a098a9403d632c1b1ae714366836903d0278963 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66010 Tested-by:
-
Georg Ringer authored
Add a new condition using the PageLayoutResolver to let integrators check for the used backend layout of a page. Resolves: #88276 Releases: master Change-Id: Ifac0e020a72994c9c8499af0afd48179472cb202 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66012 Tested-by:
Daniel Siepmann <coding@daniel-siepmann.de> Tested-by:
-
Chris Müller authored
Translating extended sys_file_metadata with an RTE field throwed an exception because the iso code of a language id > 0 cannot be determined. A null value was returned which violates the method's return type. As a solution, English is returned. Resolves: #92248 Releases: master, 10.4 Change-Id: I47ff6e3452ab7e31c1d9cd9e58a00d62fbffae0d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65654 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
- Oct 06, 2020
-
-
Anja Leichsenring authored
The typo3/testing-framework 6.4.4 included a backport of the prophecy trait that is required for phpunit v10 and causes lots of deprecation messages in phpunit v9. This backport causes problems with phpunit v8, though. So the inclusion is reverted. Used command: composer require --dev typo3/testing-framework:^6.4.5 Resolves: #92495 Related: #92477 Releases: master, 10.4 Change-Id: Iecaa42ee1fbbab4fceacefb96979da240c7d7872 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66061 Tested-by:
-
Alexander Schnitzler authored
This patch fixes incompatible type usage in function arguments and is preparatory work for introducing native type hints and strict mode in all core files. Releases: master, 10.4 Resolves: #92264 Change-Id: I7722c8abfe6599b2ca2a6e7ea1217708e13144f2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65673 Tested-by:
-
Daniel Goerz authored
With #92263 the type hint for ServiceProviderRegistry->create() has been changed from Package to PackageInterface which is wrong, because a method is called that is not part of the interface. Resolves: #92491 Relates: #92263 Releases: master, 10.4 Change-Id: I0ad0a9c21534bfb1e0dde8768c630d82218cdf55 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66057 Tested-by:
-
Alexander Schnitzler authored
This patch fixes incompatible type usage in function arguments and is preparatory work for introducing native type hints and strict mode in all core files. Releases: master, 10.4 Resolves: #92279 Change-Id: I469892a56334a13ab19df17aeaa39a68226b7510 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65679 Tested-by:
-
Alexander Schnitzler authored
This patch fixes incompatible type usage in function arguments and is preparatory work for introducing native type hints and strict mode in all core files. Releases: master, 10.4 Resolves: #92277 Change-Id: I56783a73d0bd0932ee26ce208e64fabbdc113699 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65666 Reviewed-by:
-
Alexander Schnitzler authored
This patch fixes incompatible type usage in function arguments and is preparatory work for introducing native type hints and strict mode in all core files. Releases: master, 10.4 Resolves: #92262 Change-Id: I980c449d2b962d79952e6f0e6ecc84ecbda60cdb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65684 Tested-by:
-
Alexander Schnitzler authored
This patch fixes incompatible type usage in function arguments and is preparatory work for introducing native type hints and strict mode in all core files. Releases: master, 10.4 Resolves: #92282 Change-Id: I7eac7f91fe1461a73f2f3dc5cf6988fb91274de1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65665 Tested-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
-
Alexander Schnitzler authored
This patch fixes incompatible type usage in function arguments and is preparatory work for introducing native type hints and strict mode in all core files. Resolves: #92171 Releases: master, 10.4 Change-Id: I814aa008b102121359146c2d32da967965f96b30 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65907 Reviewed-by:
-
Helmut Hummel authored
LocalDriver evaluates a configuration option baseUri, to use this URI instead of a derived one from the absolute base path of files. However there are currently limitations that need to be fixed to allow more complex setups: 1. baseUri is not defined in flexform, thus cannot be set from UI 2. baseUri isn't evaluated, when the absolute file path is within TYPO3's public path 3. baseUri is currently required to be a fully qualified URI (with scheme and host) This change addresses all three of them to cover the following use cases: 1. Provide a different hostname to serve the files from, even when they are located on the same machine. 2. Allow base URI without host name, for files that are on the same host, but in a folder not within TYPO3's root directory (e.g. due to special web server configuration) Resolves: #91232 Releases: master, 10.4 Change-Id: I7694661f9892c612489c68ef271f965df65744b6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64345 Reviewed-by:
-
Markus Klein authored
Running the PopulatePageSlugs upgrade uses the SlugService to generate the slugs. SlugService itself uses BackendUtility::getRecordLocalization() which does a DB query using a WorkspaceRestriction. This restriction uses the workspace of the current BE user. But within the Install Tool upgrade there is no such user of course. Add the necessary condition to avoid a PHP type error. Resolves: #92464 Related: #92209 Releases: master, 10.4 Change-Id: I75b6021b4ef1543740ae83bc951b2c2c5374c8d1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65994 Tested-by:
Johannes Kasberger <johannes.kasberger@reelworx.at> Tested-by:
Torben Hansen <derhansen@gmail.com> Reviewed-by:
Philipp Parzer <p.parzer@siwa.at> Reviewed-by:
-
Georg Ringer authored
Resolves: #92362 Releases: master, 10.4, 9.5 Change-Id: I9db655907b321bce70285e3201e8ea6a3bd205f3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66019 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
-
- Oct 05, 2020
-
-
Oliver Bartsch authored
In #90315 the PageLayoutView was refactored. Mainly `getTable_tt_content` was spitted in smaller functions. Therefore a new function `generateLanguageView` was introduced but missed `defLangBinding` in the parameter signature. The parameter is now registered and correctly passed to the function. Resolves: #90617 Relates: #90315 Releases: master, 10.4 Change-Id: Ic7d4817cfc1799f2f95aec628fabeba7240b511c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66014 Tested-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
-
