[TASK] Decouple Dependency logic and domain models in EM
Both Domain\Model\Extension and Domain\Model\Dependency now have factory methods to avoid using the ExtensionModelUtility to build objects in an atomic state. This marks the ExtensionModelUtility class obsolete, which resolved dependencies and built Dependency objects. The Dependency object is now not an AbstractEntity anymore, but more of a type ValueObject. However, since the Dependency object knows about the min/max version constraints, this logic is now shifted into this class, making the DependencyUtility much smaller in logic. Resolves: #92547 Releases: master Change-Id: I7116d0d2c4f0d08b4a503f48b75ab50bfc675d21 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66100 Tested-by:Oliver Bartsch <bo@cedev.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
Showing
- typo3/sysext/extensionmanager/Classes/Controller/ActionController.php 2 additions, 15 deletions.../extensionmanager/Classes/Controller/ActionController.php
- typo3/sysext/extensionmanager/Classes/Controller/ListController.php 4 additions, 8 deletions...xt/extensionmanager/Classes/Controller/ListController.php
- typo3/sysext/extensionmanager/Classes/Domain/Model/Dependency.php 68 additions, 41 deletions...sext/extensionmanager/Classes/Domain/Model/Dependency.php
- typo3/sysext/extensionmanager/Classes/Domain/Model/Extension.php 64 additions, 3 deletions...ysext/extensionmanager/Classes/Domain/Model/Extension.php
- typo3/sysext/extensionmanager/Classes/Domain/Repository/ExtensionRepository.php 57 additions, 6 deletions...manager/Classes/Domain/Repository/ExtensionRepository.php
- typo3/sysext/extensionmanager/Classes/Service/ExtensionManagementService.php 1 addition, 15 deletions...ionmanager/Classes/Service/ExtensionManagementService.php
- typo3/sysext/extensionmanager/Classes/Utility/DependencyUtility.php 47 additions, 159 deletions...xt/extensionmanager/Classes/Utility/DependencyUtility.php
- typo3/sysext/extensionmanager/Classes/Utility/ExtensionModelUtility.php 0 additions, 89 deletions...xtensionmanager/Classes/Utility/ExtensionModelUtility.php
- typo3/sysext/extensionmanager/Classes/Utility/InstallUtility.php 17 additions, 67 deletions...ysext/extensionmanager/Classes/Utility/InstallUtility.php
- typo3/sysext/extensionmanager/Classes/Utility/ListUtility.php 43 additions, 15 deletions...3/sysext/extensionmanager/Classes/Utility/ListUtility.php
- typo3/sysext/extensionmanager/Classes/ViewHelpers/Typo3DependencyViewHelper.php 17 additions, 38 deletions...manager/Classes/ViewHelpers/Typo3DependencyViewHelper.php
- typo3/sysext/extensionmanager/Tests/Unit/Domain/Model/DependencyTest.php 45 additions, 0 deletions...tensionmanager/Tests/Unit/Domain/Model/DependencyTest.php
- typo3/sysext/extensionmanager/Tests/Unit/Domain/Model/ExtensionTest.php 118 additions, 0 deletions...xtensionmanager/Tests/Unit/Domain/Model/ExtensionTest.php
- typo3/sysext/extensionmanager/Tests/Unit/Domain/Repository/ExtensionRepositoryTest.php 110 additions, 0 deletions.../Tests/Unit/Domain/Repository/ExtensionRepositoryTest.php
- typo3/sysext/extensionmanager/Tests/Unit/Service/ExtensionManagementServiceTest.php 8 additions, 8 deletions...ger/Tests/Unit/Service/ExtensionManagementServiceTest.php
- typo3/sysext/extensionmanager/Tests/Unit/Utility/DependencyUtilityTest.php 27 additions, 206 deletions...nsionmanager/Tests/Unit/Utility/DependencyUtilityTest.php
- typo3/sysext/extensionmanager/Tests/Unit/Utility/ExtensionModelUtilityTest.php 0 additions, 147 deletions...nmanager/Tests/Unit/Utility/ExtensionModelUtilityTest.php
- typo3/sysext/extensionmanager/Tests/Unit/Utility/InstallUtilityTest.php 0 additions, 9 deletions...xtensionmanager/Tests/Unit/Utility/InstallUtilityTest.php
Please register or sign in to comment