- Dec 16, 2021
-
-
Christian Kuhn authored
ext:extensionmanager has a couple of view helpers that extend ActionViewHelper for no apparent reason. Change those to extend AbstractTagBasedViewHelper instead. Resolves: #96361 Releases: main, 11.5 Change-Id: Iedab908a30df0418a7c86d073d97a47548a87ab4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72665 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
Christian Kuhn authored
To prepare making all view helpers final as anticipated with #95298, ext:backend ThumbnailViewhelper must no longer extend ext:fluid ImageViewHelper. The patch is a simple transition, we may later have a look at the ThumbnailViewHelper again, since probably some of the possible arguments are not needed for thumbnails. Resolves: #96362 Related: #95298 Releases: main Change-Id: Ibf0f3ac108ab1849454769a947061a4604eb9fbf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72666 Tested-by:
-
- Dec 15, 2021
-
-
Christian Kuhn authored
The "max" drop down in the ext:belog filter html is the only one that uses belog:form.translateLabelSelect view helper. By refactoring slightly, we can drop this view helper and simplify the code a bit. Resolves: #96360 Related: main Change-Id: Ib952dd3475d952354f8a07c31917f88751b93704 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72664 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Marc Bastian Heinrichs authored
Resolves: #96308 Releases: main, 11.5, 10.4 Change-Id: Ibcbda7fd97a338d721cf00b38026727e941c72ac Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72598 Tested-by:
-
Georg Ringer authored
If EXT:workspaces is not installed, the workspace information should also be skipped in the logging module. This makes it easier to read and less bloated. Resolves: #96314 Releases: main, 11.5 Change-Id: I22277ca681cc877d57686e02f36fe54e630d2f9a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72607 Tested-by:
-
Christian Kuhn authored
$command being either 'new' or 'edit' is tested in a previous if() a couple of lines above already. Resolves: #96357 Releases: main Change-Id: I8088d50df6c854127ebecb8038a648fdad9af172 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72662 Tested-by:
-
Stefan Bürk authored
Add support for sqlite acceptance testing to 'Build/Scripts/runTests.sh'. Run acceptance/sqlite testing with PHP 8.1 in nightly as a first execution implementation, which could be reshuffled when minimum PHP requirements have been decided. Furthermore two acceptance tests are marked as skipped when executed with sqlite, which should be fixed in dedicated patches: * MaintenanceCest.php->analyzeDatabaseStructureWorks() Skipped, as database compare is never clean and ends in endless loop with sqlite, when ext:indexed_search is installed. This is a general issue, existing at least since v10.4. Needs investigation and a dedicated patch. * UpgradeCest.php->seeUpgradeWizard() Skipped, as utf-8 charset upgrade wizard is not visible for sqlite dbms backend, thus rendering this test obsolete with sqlite. Needs another update wizard test and possibly a dedicated patch. Resolves: #96340 Releases: main Change-Id: I74c8f1156d98a5419309e110ed761e3de21fa37a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72446 Tested-by:
-
Benni Mack authored
Resolves: #94308 Releases: main, 11.5 Change-Id: I84836ba46e3b8e3fa8d4ac915efb5a6a7afbdca7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72657 Tested-by:
-
Christian Kuhn authored
Resolves: #96305 Related: #94115 Releases: main Change-Id: Id048e7f8b8679fd0dc2ab4e7f2120410e053a4df Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72595 Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
-
Chris Müller authored
The following deprecation occurred in PHP 8.1: PHP Runtime Deprecation Notice: trim(): Passing null to parameter #1 ($string) of type string is deprecated. This happens in various places: * Using stdWrap_field() or in stdWrap() places * BackendUtility (e.g. new IRRE elements) * ExtensionManager Resolves: #96354 Releases: main, 11.5 Change-Id: Ie5c721784b51ed5493c8d9e1d557b08611263f6b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72659 Tested-by:
-
Florian Rival authored
Resolves: #96350 Releases: main, 11.5 Change-Id: I67e9fd68de038b84c83f7f12a465e6e37f918568 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72654 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Chris Müller <typo3@krue.ml> Reviewed-by:
-
Simon Gilli authored
The routes added via ExtensionManagementUtility::addModule() are missing when the UriBuilder/Router is used prior to ext_localconf loading. Also for this particular case, multiple instances of the Router class were created, as UriBuilder is loaded from the failsafe installtool container instead of using an instance from the symfony container (as created by LateBootService n loadExtLocalconfDatabaseAndExtTables). This resulted in multiple routers being loaded with different sets of routes. This patch ensures that the routes are loaded from a UriBuilder/Router instance that is fully populated with information from ext_localconf. Therefore GeneralUtility::makeInstance() is avoided and UriBuilder is fetched from the late booted container instead. Resolves: #95806 Releases: main, 11.5 Change-Id: Id57bf09fb7798eac26dbdbc6ed89228c54fbafb9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72463 Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
-
Guido Schmechel authored
If a language in the SiteConfig is set to the fallbackType free and there is no translated page for this language, then there is now no generated hreflang. Previously, a link was always generated with default language slug, which lead to 404 page not found. Resolves: #94270 Releases: main, 11.5, 10.4 Change-Id: Ifb261cf388fccbaabbf2bcae9ac805b143c9b42f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69919 Tested-by:
-
- Dec 14, 2021
-
-
linawolf authored
Releases: main, 11.5 Resolves: #96346 Change-Id: Ie64e82e84c63142f86b4e0f3e5072514b516aa33 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72653 Tested-by:
Lina Wolf <112@linawolf.de> Reviewed-by:
-
Benni Mack authored
The method TemplateService->updateRootlineData() can be removed. Until TYPO3 v11 TemplateService resolved the TypoScript for a specific page, then found out the actual used language (config.sys_language_uid via TSFE->settingLanguage()) and then fetched the (translated) rootline based on the resolved language information. This is not needed anymore, as settingLanguage() does not call this method anymore, and is called much earlier now, see https://review.typo3.org/c/Packages/TYPO3.CMS/+/65044. TypoScript is now always loaded after a translated page rootline has been fetched. This method is now completely unneeded, and is remoevd without replacement as the concept has now been streamlined. Resolves: #96351 Related: #23736 Releases: main Change-Id: If959a36333fcf5c91bee84ee497fddd2bfcec89b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72605 Tested-by:
-
Benjamin Franzke authored
jquery-ui/sortable has been patched as minified file in #83593 with a patch taken from https://github.com/jquery/jquery-ui/pull/1093 That pull request never got merged, but in the meantime the chrome bug seems to be fixed (the original report is no longer reproducable), therefore we now remove the patch. Note: Our binary patch (#83593) implicitly reverted jquery-ui/sortable to a 2013er version. Thus, this change implicitly updated our copy back to version 1.11.4 (from 2015) as defined in our package.json Resolves: #96335 Related: #83593 Related: #96323 Releases: main Change-Id: I71360f2808c655a0af00259552dcf8507742b729 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72628 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Benjamin Franzke authored
Add a patch file for jquery.autocomplete that contains the custom TYPO3 patches added in #79938 and #70988. Enable the grunt copy action to ensure that mass package-upgrades like #92419 do not miss to update our local fork. A non-applying patch will produce an error during upgrade, while a local fork is silently ignored. Also, pin devbridge-autocomplete to the version that is actually used (updated last time in #70988): yarn add devbridge-autocomplete@~1.3.0 The patch file has been generated via: cp typo3/sysext/core/Resources/Public/JavaScript/Contrib/jquery.autocomplete.js \ Build/node_modules/devbridge-autocomplete/dist/jquery.autocomplete.js patch-package devbridge-autocomplete Note: The version line change is removed and the indentation (tabs vs spaces) is fixed, as it rather limits updatability, therefore the resulting javascript file format is slightly changed. No functional change. Resolves: #96334 Related: #92419 Related: #79938 Related: #70988 Related: #96323 Releases: main Change-Id: Ib8f9a79c3df1875e8a1606122f30e7d15bce06a9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72626 Tested-by: -
linawolf authored
Includes changed links, missing images, wrong path's in includes etc. Excluded EXT:form as resolving the warnings is a large TASK there. Releases: main, 11.5 Resolves: #96345 Change-Id: I05d73d7fa211bbf9308a3c7a2161b1b5184d7b31 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72640 Tested-by:
-
Oliver Bartsch authored
The SelectTree and the CategoryTree use a placeholder form element with all the information like current value and then calls the FormSelectTreeAjaxController to actually build the tree. When using default / override values for such field, the information was previously only available on building the placeholder. Therefore the value was correctly filled and stored, but not displayed in corresponding tree. This is now fixed by passing those values to the Ajax endpoint, which then adds them to the form compiler input. This allows the data providers to properly select the values in the tree. Resolves: #91607 Releases: main, 11.5 Change-Id: I8743bc3c28977b8d8758096b573a0be332d825e8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72645 Tested-by:
-
Benjamin Franzke authored
Some modules are missing jquery imports. This currently works as jquery is exposed in the global object (window.$ and window.jQuery) and likely loaded by some other module. Still, loading may fail when jquery hasn't been loaded by another module, therefore these occurences are fixed and the type declarations are patched to avoid marking jquery available as global object (therefore typescript will complain when using jQuery or $ without importing it). Releases: main Resolves: #96349 Related: #96323 Change-Id: I7f57137a1f23416aa90579de8a1860a42a7a6d46 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72646 Tested-by:
-
- Dec 13, 2021
-
-
Oliver Bartsch authored
Resolves: #96333 Releases: main Change-Id: Ia35da7c93c5fa2aa1bf3d9e3b405d83225b3729c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72647 Tested-by:
-
Oliver Bartsch authored
ContextMenu item providers are now automatically tagged and registered, based on the implemented `ProviderInterface`, using the auto configuration feature from the DI container. The registration via `$GLOBALS['TYPO3_CONF_VARS']['BE']['ContextMenu']['ItemProviders']` has been removed. To enable the auto configuration, the context information (table, record identifier, context) is no longer passed as constructor argument, but instead using the new `setContext()` method. This is done in the `ContextMenu` class, prior to any other action, e.g. `canHandle()`. In case extensions with custom item providers extend the AbstractProvider, while not overwriting the constructor, nothing has to be changed. Only the registration via global TYPO3 configuration should be removed. Resolves: #96333 Releases: main Change-Id: I7e65102163d5cb6129ed2e8bd13c10660871811c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72627 Tested-by:
-
Oliver Hader authored
Deprecates BackendUtility::getUpdateSignalCode as well as using custom singal callbacks providing `JScode` containing inline JavaScript. Resolves: #96136 Releases: main Change-Id: I1462625ac3aee2a71da3956f79a6ffde6d620be5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72373 Tested-by:
-
Florian Rival authored
This fix a warning when you click on "SMTP Settings" in "Configuration preset". Resolves: #96348 Releases: main, 11.5 Change-Id: Ic6ec6b7efd9dde2f7c365fa391e6c358192dc23b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72644 Reviewed-by:
-
Robert Kärner authored
$this->firstEl is checked for !== null several times in EditDocumentController, but it most certainly isn't, because reset() returns false instead of null, if the array is empty. This patch resolves this problem by setting $this->firstEl to null, if reset($this->elementsData) returned false. Resolves: #96342 Releases: main, 11.5 Change-Id: I45b7aff02d7b601e16fd05862542a9e3955de908 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72638 Reviewed-by:
physikbuddha <r.kaerner@oranto.de> Reviewed-by:
-
Robert Kärner authored
Access to array key $this->pageRow['editlock'] must be protected with the neccessary fallback to false. Resolves: #96343 Releases: main, 11.5 Change-Id: Ic181911709ba053e9c1f8b77d8b35684ba6c41c8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72639 Tested-by:
-
Oliver Bartsch authored
Since #96154, the shortcut button is invalid in case no `$displayName` is provided. For such case, the ButtonBar throws an unhandled exception. The EditDocumentController previously failed to ensure that the corresponding value is always properly set, which therefore led to mentioned exception in some cases. To fix this, it's now ensured that `getShortcutTitle()` does always return a valid title. In case something is wrong, e.g. no valid query arguments are provided, a default title is used. Previously, the `$recordId` in `getShortcutTitle()` was always directly casted to an int. However, since it is also possible to edit multiple records, the $recordId` might be a comma separated list of uids. This case is now also properly handled. Note: The `getShortcutTitle()` is since #94182 also used for the module title. This might be a misuse and will therefore be further evaluated in another patch. Resolves: #96337 Related: #96154 Releases: main Change-Id: I2ec6a5d2ab8d5263315e8fa7194bc887b084ae79 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72632 Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Tested-by:
-
Benjamin Franzke authored
ECMAScript 2020 (ES11) introduced dynamic imports. TypeScript offers automatic type checking and resolution for the dynamic import syntax (when using static strings) and is able to transpile to require() calls in AMD output mode. Therefore all occurences where a require() is used directly, are migrated to the import syntax. Notes: * This change has a slight drawback: the generated code is slighter in order to add runtime detections for ES6 vs AMD style default. Although, this only applies in TypeScript AMD mode and will be compensated once switching to native ES6 modules. * top.require() calls are left as-is for now, as this cases can't be changed to top.import(): Property 'import' does not exist on type 'Window' Also something isn't available in native ES11 imports: TypeError: top.import is not a function We'll rather need a messaging api between the frames that allows to load top-level modules via import() in future. Resolves: #96326 Related: #96323 Releases: main Change-Id: Ia389da64255fb1fee76a4fbb0d2abdfc277921e1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72619 Tested-by:Jochen <rothjochen@gmail.com> Tested-by:
-
Benjamin Franzke authored
Instead of disabling the grunt copy, because of a hardcoded sourcemap reference in the minified build, we simply use the non standard build instead and minify the file ourselves. This results in 25 bytes increased file size, but that's fine as it allows to auto-update this library. While at it, the filename is changed to reflect the npm module name. Resolves: #96324 Related: #88999 Related: #96323 Releases: main Change-Id: I06c359b3600a16732568877831d1b719f21ffa9a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72613 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Oliver Bartsch authored
Actions to site configurations, in the site configuration module, are now properly logged with the new logging type "site". Resolves: #91744 Releases: main, 11.5 Change-Id: I43156f0ac4eaa538e1f10442d4e54d141073e6da Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72624 Tested-by:
-
Oliver Bartsch authored
With #95258 `ConditionMatcher->getPageIdByRecord()` got type hinted. Therefore, the $uid has to be casted to int before passing it to the method. Additionally, a left over type cast in the method itself is removed. Resolves: #96336 Related: #95258 Releases: main, 11.5 Change-Id: I3d154e99464bf30ec00124780f949e1b3dac33c6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72631 Tested-by:
-
Nikita Hovratov authored
This adds missing tests for the TCA "filter" option for group, select and inline. Resolves: #96339 Related: #36810 Releases: main, 11.5 Change-Id: I402edf4774f35c3b15aa53eb630d9d098f847e87 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72636 Tested-by:
-
- Dec 11, 2021
-
-
Nikita Hovratov authored
Since the removal of the container entry, the factory method TypoScriptFrontendController->getGlobalInstance() is obsolete. Resolves: #96338 Related: #96273 Releases: main Change-Id: Ib8c973acb240cac0c7f18c10fbc801585b7c70b7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72635 Tested-by:
-
- Dec 10, 2021
-
-
Florian Rival authored
This fix a warning when you click on a Rollback (preview) button in history for pages or content elements. Resolves: #96325 Releases: main, 11.5 Change-Id: Iec42cd04289a4c567840651686808b9ef43e1656 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72615 Tested-by:
-
Benjamin Franzke authored
Adapt testing changed in #96244. Resolves: #92859 Resolves: #92750 Related: #96244 Releases: main Change-Id: I0f0a4d5423eb22f674342ead62d56ef7d720f397 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72630 Tested-by:
-
Benjamin Franzke authored
This file has been introduced in #94622 by accident (probably a left-over from a previous patchset). It is unused and no sources are present, therefore this file is removed. Releases: main, 11.5 Resolves: #96331 Related: #94622 Change-Id: I39d79fe560b9b1b5b8b640addba3a3bb26868a75 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72625 Tested-by:
-
Benjamin Franzke authored
The .done() Promise polyfill has been removed in #96263, therefore .then() needs to be used on promised. Also adapt the return type declaration in the global type declarations file. Resolves: #96328 Related: #96263 Releases: main Change-Id: Iba53393076285db1709ac3980eeb434862ee2952 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72618 Tested-by:
-
Benni Mack authored
TYPO3 has had a long history of linking to other pages in other pagetrees. Most of the issues were solved with the TYPO3 v9 Routing and Site Handling. Through this feature, it is now possible to easily create a page of type shortcut and link to a page in a different page tree. This was previously not possible because TYPO3 Core by default generated URLs like "/index.php?id=123" where people could simply add ?id=355 (where page 355 resides on a different page tree). Since this change has been resolved, links to other pages can be allowed and are automatically redirected. If we ever get rid of allowing to call pages with an `?id=123` query parameter, the $pageNotFound=3 case can be removed completely. Resolves: #92859 Resolves: #92750 Releases: main, 11.5 Change-Id: I16ccc3e5b0ccb1419ccd2a8d78443616e7627a33 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70432 Tested-by:
-
Benni Mack authored
The TypoScript option "page.pageHeaderFooterTemplate" is removed. It was introduced in TYPO3 4.5, but never documented, and is actually overridden by the option "config.pageRendererTemplateFile" which IS documented, which was also introduced during TYPO3 4.x times. Both options behave the exact same way. Resolves: #96322 Releases: main Change-Id: Ifeec8faec7f28121f3135838bcaa82cac461cb60 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72612 Tested-by:
-
Oliver Bartsch authored
In #96318 the call to `$backendUser->start()` was removed in OpenDocumentService. This then led to an exception, in case a not fully initialized backend user object is used to call `getModuleData()`. This is fixed by no longer using an own backend user instance, but instead accessing the already initialized global object. Resolves: #96330 Related: #96318 Releases: main Change-Id: Ic887df324b2cea4eb79c48f4a50e2be28d8f0774 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72623 Tested-by:
-
