- Jul 13, 2022
-
-
Christian Kuhn authored
This avoids using importDataSet() in functional tests using .xml fixture files from the testing framework. Usages are converted to importCSVDataSet(), fixture files are added as .csv to the according extension. XML handling in functional tests is now down to setUpBackendUserFromFixture() which will be prepared in testing-framework and adapted in core with another patch. Change-Id: Ifc3cc30d4b824775dc6ccc7e1d982d9d122f39d9 Resolves: #97924 Related: #96856 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75165 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
linawolf authored
Releases: main Resolves: #97915 Change-Id: I5dd0812847d1984b312e1d452ff38232b20f100a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75159 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Lina Wolf <112@linawolf.de> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Christian Kuhn authored
The acceptance test base class in testing-framework now allows to load .csv instead of .xml files to prime the database with records. These files are easier to read and maintain and we avoid a fixture dependency to the testing-framework this way. $ composer req --dev typo3/testing-framework:dev-main Change-Id: I7055215a2006d985af1b19929157bdef2190854d Resolves: #97921 Related: #96856 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75156 Tested-by:
-
Stefan Bürk authored
Docblock annotations with more then one space between a wildcard character `*` and the annotation start character `@` was not found. Additionally, annotation identifiers did not regonize hyphens as valid identifier character, thus cutting of e.g. phpstan annoations. This patch now properly finds annotions with multi-space separations and annotation identifiers containing hyphens. Additionally, two phpstan specific annotations are allowed. > https://phpstan.org/writing-php-code/phpdoc-types#local-type-aliases Summarized contained tasks: > find multi-space separated annotations e.g. `* @<AnnotationIdentifier>` > properly extract full annotation identifier containing hyphens e.g. `* @annoation-identifier-with-hyphen` > add `@phpstan-type` and `@phpstan-import-type` as allowed annotation, but only on class level, and not on class-property or class-method level Resolves: #97917 Resolves: #97918 Resolves: #97919 Releases: main, 11.5, 10.4 Change-Id: Iab69ffd87d407088f1237168e19b67a8dc846c8f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75160 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
Andreas Fernandez authored
The NoopPasswordHash fixture is currently used in MFA provider tests only. To declutter the Tests/ directory, the fixture directory is now moved to core/Tests/Unit/Authentication/Mfa/Provider/. Resolves: #97920 Releases: main, 11.5 Change-Id: I86544bf897a26a2565278e2432831adde7154be8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75161 Tested-by:
-
- Jul 12, 2022
-
-
Andreas Fernandez authored
Since Symfony 5.x, the Command class offers constants for possible return values to be used in a commands `execute()` method. All commands are adjusted. Resolves: #97912 Releases: main Change-Id: I14f7e13ceb1b10cb21528bb420a6f8c1a20f8ab3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75154 Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
-
Larry Garfield authored
PHPStan identified these code paths as impossible. On code inspection that's true, so they have been removed as dead code. That allowed for the properties of the class to be typed. Small related cleanup is included to make verifying that the code paths were indeed dead easier. Resolves: #97621 Releases: main Change-Id: Icc5e53ef72fedb9fc5de659b22229d61c8502f1e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74636 Tested-by:
-
Andreas Fernandez authored
With the removal of datatables in #86343 the search terms used to filter tables were not stored anymore, leading to unfiltered tables after requesting pages with such again. This is found to be annoying in the extension manager when many extensions with the same prefix need to get managed. The search terms are now stored in the browser session and the local extension list is filtered again when visiting the extension manager. Resolves: #93628 Related: #86343 Releases: main, 11.5 Change-Id: Ib99e1fbf0ad420826164f8fed019c5235f8c43d5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75153 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Christian Kuhn authored
The 'installer' acceptance test related environment setup files have been part of typo3/testing-framework, but they should be part of ext:core since they're core monorepo specific and not a concern of the general testing-framework. The patch moves the codeception environment setup files from TF to core and raises TF which removed them already. Resolves: #97910 Releases: main Change-Id: Id95e1872afd3a6edeb6c3facdcbaab11522bec7a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75152 Tested-by:
-
Shehfinaz Kadavil authored
The existing condition checks if opcache_invalidate and opcache_reset are disabled, the new condition also checks if the function opcache_invalidate exists. Resolves: #97826 Releases: main, 11.5 Change-Id: Ibb201946b358a592f3c5b264646d100867e5e385 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75126 Tested-by:
-
Oliver Bartsch authored
When using a <button> in a bootsrap dropdown menu, additional button classes, such as ".btn" are not necessary, but might lead to display errors. Those classes are therefore now removed. Resolves: #97909 Releases: main Change-Id: I1c3ef81dce52e31d15a3d93c1e215f033b22a4a1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75130 Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
-
Benni Mack authored
With this change, Extbase consistently returns objects with a "uid" of the default language, and not the localized ID, depending on the query settings. This way, side effects related to the Persistence Storage are removed, as the persistence session is storing the UID + the localized UID as identifier. Resolves: #59992 Releases: main Change-Id: I42c0643ec2eb666c69446aef698fb180152bee08 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75099 Tested-by:
-
Daniel authored
Like the surrounding $conf['max'], this array index access should also be secured. Releases: main, 11.5 Resolves: #97908 Change-Id: I36ad5cf3d9eac5655e8721c8913bed43ab26377f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75129 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Christian Kuhn authored
Migrate some further usages of XML fixture imports to CSV in functional tests. This resolves all missing cases that don't use the "PACKAGE:" prefix. Resolves: #97907 Related: #96856 Releases: main Change-Id: I95057abf900bf9c24badc3a58ef7b4f96239292f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75128 Tested-by:
-
Christian Kuhn authored
iconfile target should be Extension.svg instead of Extension.gif Resolves: #97906 Releases: main Change-Id: Icf0bc949982d635644c1a59c5c278d726c165825 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75124 Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
-
Andreas Fernandez authored
flatpickr always defaults to 12:00 if no other value is given, being quite inconvenient. The options `defaultHour` and `defaultMinute` are now provided to set the current time when opening flatpickr on an empty input field. Resolves: #97798 Releases: main, 11.5 Change-Id: Ic222c2ff0e3bf111c498c16dd27ecdc703909342 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75086 Tested-by:
-
Jochen Roth authored
The list and page view currently do not show details about the record to be deleted. The content of the delete modal has been enhanced with record title and relations (if one does exist) and the buttons and modal title now use the same labels. Resolves: #92670 Related: #94780 Releases: main Change-Id: I4e3a48f4d37a46ad825eef95a7c8bc610301c419 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72001 Tested-by:
-
Nikita Hovratov authored
This patch reverts #91148 and #97897. This change had some side effects in FlexForm value displaying outside the intended diff-view. Resolves: #97904 Related: #91148 Related: #97897 Releases: main, 11.5 Change-Id: I6d5af76dea80b457de5a690e3065ccb700b2a507 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75115 Tested-by:
-
Benni Mack authored
This is a precursor for several language-related Extbase bugfixes, allowing to hand over a custom LanguageAspect into PageRepository->getRecordOverlay() instead of the legacy naming conventions. Resolves: #97903 Releases: main, 11.5 Change-Id: I06f6e889bc0e9f052a79fc8f719b090bface0f77 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75100 Tested-by:
-
Andreas Fernandez authored
Executed commands: cd Build nvm use yarn add @typo3/icons@^3.2.0 grunt build Resolves: #97902 Releases: main Change-Id: I8bbc547dd7e6cd266a155daed6ddf2796b08ec0d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75112 Tested-by: -
Frank Naegler authored
Since TYPO3 version 10.4, the custom page type is not restricted to any range of numbers. This limitation no longer exists, and any number is allowed. The ElementBrowserPageTreeView just now also respect this and allows to link to other any doktype beside: - PageRepository::DOKTYPE_RECYCLER - PageRepository::DOKTYPE_SYSFOLDER Resolves: #97626 Releases: main, 11.5, 10.4 Change-Id: Iffc3f705f74cc7516464fdb00adb456141657948 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75105 Tested-by:
-
Oliver Bartsch authored
The rollback link for a single field change is now displayed again in the rollback view of the history module by using the correct variable in the template. Additionally, an unintended change in #91148 is resolved, which would also display the rollback link in the normal history list view. Resolves: #97901 Releases: main, 11.5 Change-Id: I2606d0585a5f1d196adab5f83340ff3033dced1c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75111 Tested-by:
-
- Jul 11, 2022
-
-
Sybille Peters authored
Add the following information to impexp documentation: - export functionality is restricted to admin users and users for which the new User TSconfig option options.impexp.enableExportForNonAdminUser has been set - export functionality poses security risk as explained in patch https://review.typo3.org/c/Packages/TYPO3.CMS/+/74902 - the same restrictions apply to the import functionality (which is not new but has not been documented) Resolves: #97899 Releases: main, 11.5, 10.4 Change-Id: Icb16dc97505a3bbe671357555bb786705121cb67 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75110 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
-
Sybille Peters authored
The vendor namespace TYPO3.CMS.Form is no longer used in the form configuration. This patch removes the namespace from snippets within the documentation. Resolves: #97896 Related: #97517 Releases: main Change-Id: I52c9c0533d2934781de963209f21d23f1fe9aa2d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75106 Tested-by:
-
Oliver Bartsch authored
Since #91148, EXT:backend and EXT:workspaces depend on the "lolli42/finediff" package, which is a fork of the archived "cogpowered/finediff" package. This dependency is now declared in the corresponding composer manifests. Resolves: #97897 Related: #91148 Releases: main, 11.5 Change-Id: Ia6c53bcee4173a1f7598581c30825ee162126c9d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75104 Tested-by:
-
Oliver Bartsch authored
A couple of debug information, e.g. the field- and tablenames in FormEngine, are displayed depending on the user status and the debug settings. To simplify the codebase, this condition is now centralized in BackendUserAuthentication. Resolves: #97894 Releases: main, 11.5 Change-Id: I5173c48180fbf96f7408c008eeb3c71c25686d0d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75102 Tested-by:
-
Oliver Bartsch authored
Usage of button specific classes was mostly removed in bootstrap 5. However, core still supports some of those classes, e.g. "btn-block". Using those classes however often leads to misbehavior updating other components, which rely on newer layout technologies. To circumvent this, usage of the "btn-block" class is migrated at all places, while the class definition is still kept for backwards compatibility. Resolves: #97891 Related: #97809 Related: #93119 Releases: main Change-Id: I0308207e4e34d52512141658797046ac470514f1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75098 Tested-by:
-
Nikita Hovratov authored
With the refactoring in #96998 the validator options are now passed with the `setOptions` method instead of passing them as constructor argument. Resolves: #97871 Related: #96998 Releases: main Change-Id: I9a52560debc5227e0d3049f13d8b897f56baf2d5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75048 Tested-by:
-
Nikita Hovratov authored
In the introduction of the StatusRegistry it was forgotten to adapt one method in the Status class. The adaption renders the property `statusProviders` now obsolete, and it is therefore removed. In addition, a variable name in the `getSystemStatus` method is adjusted and the null coalescing assignment is used. Resolves: #97883 Related: #97320 Releases: main Change-Id: Ie71dc7fad56f2a0545f1446de1f420c6f031cf2d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75087 Tested-by:
-
Francois Suter authored
The LogManager tries to access $GLOBALS['TYPO3_CONF_VARS']['LOG'] without considering that it could be undefined Releases: main, 11.5 Resolves: #97888 Change-Id: I7ac2435e548e2d241fe223686595a42927ae1a60 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75092 Tested-by:
-
Oliver Bartsch authored
Resolves: #97889 Related: #97887 Releases: main Change-Id: I4f2754858dc9bb483a5f77d9f08397f97b300850 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75094 Tested-by:
-
Andreas Fernandez authored
Since #97578, `GeneralUtility` is declared strict, potentially breaking calls to `fixed_lgd_cs()` in at least the "List" module. The argument `$chars` must be of type int, but sometimes it's a string which breaks the call of `abs()`. All calls to this method are adjusted, where required, and the value is explicitly cast to int. Resolves: #97887 Related: #97578 Releases: main Change-Id: I7feed1ae8dbe7cdbc906d73cfbc49f7d9dbeb6fe Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75091 Tested-by:
-
- Jul 10, 2022
-
-
Oliver Klee authored
This is the first step before we can start adding native types to the GU methods in multiple separate changes. Resolves: #97578 Releases: main Change-Id: I42e9da54b072f3c6d204ec5b8b32b797ab7996ec Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74572 Tested-by:
-
Oliver Klee authored
This helps avoid breakage when GeneralUtility will switch to strict mode. This change also prevents a bunch of possible invalid array access warnings. Resolves: #97584 Related: #97578 Releases: main Change-Id: Iaf23147d2ffdbca3a5c8205b2c32926c46084021 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75079 Tested-by:
-
linawolf authored
The outdated links in EXT:install are improved in https://forge.typo3.org/issues/97885 Releases: main, 11.5 Resolves: #97886 Change-Id: I25979df8f9f322461ffc6d03ab9030240c2e0e8a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75090 Tested-by:
-
linawolf authored
Releases: main, 11.5, 10.4 Resolves: #97885 Change-Id: Ib274d3d85f1311f100afe8e12167ebc6eaab21db Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75089 Tested-by:
-
linawolf authored
- mention the methods of the removed hook to make it easier for developers to search for them. - add missing description of the ModifyAllowedItemsEvent Releases: main Resolves: #97881 Related: #97454 Change-Id: I3667514d8d6b6ef1865e161d77ce18ec2999cca8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75081 Tested-by:
-
- Jul 09, 2022
-
-
Andreas Fernandez authored
The ReST helper tool at https://forger.typo3.com/utilities/rst produced faulty ReST files for quite some time where the trailing colon was missing from labels. Changelog files affected by this issue are hereby fixed with this commit. Resolves: #97882 Releases: main Change-Id: I96b361b0128680d4bc6434c8ddf1aefc0d280df0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75084 Tested-by:
-
Torben Hansen authored
With this change constructor property promotion is used in ext:felogin where possible. Also 2 superfluous overrides of EventDispatcherInterface have been removed, since the property is already inherited through ActionController. Resolves: #97805 Releases: main Change-Id: I48ac97fe86dc068db023e247039ab38669c868e2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74974 Reviewed-by:
-
Oliver Klee authored
This helps avoid breakage when GeneralUtility will switch to strict mode. This change also prevents a bunch of possible invalid array access warnings. Resolves: #97580 Related: #97578 Releases: main Change-Id: Iba6eae561cf8e3607474287683d606a63d14f041 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75080 Tested-by:
-
