- Mar 03, 2024
-
-
Simon Schaufelberger authored
For some fluid templates, the namespace has been migrated from the "{namespace}" notation to the html tag notation. Additionally, some formatting was applied. Resolves: #103240 Releases: main, 12.4 Change-Id: Ia6873fa0707df0b0c95b6933f7e9bac26442cae8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83174 Tested-by:core-ci <typo3@b13.com> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Simon Praetorius <simon@praetorius.me> Reviewed-by:
-
Christian Kuhn authored
DataHandler related class SlugEnricher is a scary sounding class name for a simple operation that sets incoming TCA type=slug fields to empty string if not provided, to trigger slug calculation later. The patch inlines that operation into DataHandler, avoiding the class with three methods, a property, and a set of array_* function calls, substituting it with three foreach(), two if() and a helper method that can be re-used. Change-Id: I4452d9c50b43832db3cd4b7f538395054a3d67ab Resolves: #103244 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83176 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
- Mar 02, 2024
-
-
Andreas Kienast authored
The `RotatingFileWriterTest` previously used a timestamp-based calculation to mock file names. This approach conflicts with the `DateInterval`-based calculation and might lead to false-negative test results. This commit updates the test cases by using the interval-based calculation now. Resolves: #103243 Releases: main Change-Id: I9b08b797377eb504af7707acf520fae896b6cbb1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83177 Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
- Mar 01, 2024
-
-
linawolf authored
* Introduce a guides.xml, the presence of this file triggers the new rendering. * Replace sphinx-only syntax * remove superfluous genindex, it is not supported anymore * Remove old Settings.cfg, was only used for Sphinx Attention: Backports need manual changes to the guides.xml. Resolves: #103238 Releases: main, 12.4, 11.5 Change-Id: I5d9239a9217d8d6c2faa08cef58436971ee83113 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83171 Reviewed-by:
Chris Müller <typo3@krue.ml> Reviewed-by:
Lina Wolf <112@linawolf.de> Tested-by:
-
Oliver Bartsch authored
Resolves: #102451 Releases: main, 12.4 Change-Id: I50944fe4eb4aa1557c6289f9ae8eefe67717fb75 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83175 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
-
Willi Wehmeier authored
To deliver a meaningful tooltip text for screenreaders the title of the page is added to the tooltip message in the pagetree view. Resolves: #102451 Releases: main, 12.4 Change-Id: I8af2e3652d38abb6b2a090c2f8bd0e4427ab255a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81854 Reviewed-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
-
Torben Hansen authored
jQuery autocomplete has been removed with #98455 and jQuery UI has been removed with #100966. In ext:core, there are however leftover JavaScript module registration to both libraries. This change removes the JavaScript module registration for `jquery/autocomplete.js` and `jquery-ui` Resolves: #103236 Releases: main Change-Id: Ib0b96399d1da5794bef183286c5d58ec5c21fd16 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83166 Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
-
Benjamin Kott authored
If you are managing backend users, it is now also possible to view the assigned groups directly. The hardcoded edit labels are now also replaced with the respecting translatable variants. Resolves: #103231 Releases: main Change-Id: Icbf16f420689b288d5f334c94872b71112ac83f0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83162 Reviewed-by:
Frank Nägler <frank.naegler@typo3.com> Tested-by:
-
Benjamin Kott authored
We've upgraded the backend tree component by extending tree nodes to incorporate labels, offering enhanced functionality and additional information. Before the implementation of labels, developers and integrators relied on `pageTree.backgroundColor.<pageid>` for visual cues. However, these background colors lacked accessibility and meaningful context, catering only to users with perfect eyesight and excluding those dependent on screen readers or contrast modes. With labels, we now cater to all editors. These labels not only offer customizable color markings for tree nodes but also require an associated label for improved accessibility. Each node can support multiple labels, sorted by priority, with the highest priority label taking precedence over others. Users can assign a label to a node via tsconfig, noting that only one label can be set through this method. ``` options.pageTree.label.<pageid> { label = Campaign A color = #ff8700 } ``` The labels can also be added by using the event `\TYPO3\CMS\Backend\Controller\Event\AfterPageTreeItemsPreparedEvent`. ``` $items = $event->getItems(); foreach ($items as &$item) { $item['labels'][] = new Label( label: 'Campaign B', color: #00658f, priority: 1, ); } ``` Please note that only the marker for the label with the highest priority is rendered. All additional labels will only be added to the title of the node. Resolves: #103211 Releases: main Change-Id: I5daaa1efe6e11c506bd5f5f86770bf9895bb6789 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83143 Tested-by:Benjamin Franzke <ben@bnf.dev> Reviewed-by:
-
Andreas Kienast authored
The TYPO3 backend module `@typo3/backend/wizard.js` that offers simple wizards has been marked as deprecated in favor of the richer `@typo3/backend/multi-step-wizard.js` module. Resolves: #103230 Releases: main Change-Id: I653f8c746f8f7f2b48899a0a78ea759fd5eb95da Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83161 Tested-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
-
- Feb 29, 2024
-
-
Christian Kuhn authored
When a record localization is changed in workspaces, `transOrigPointerField` ("l10n_parent") can point to either the default language -live-, OR default language -workspace- record, depending on workspace action chains as detailed below. FormEngine did not deal with that properly when `showPossibleLocalizationRecords` for inline (or file) children is enabled, and did tend to show a possible localization child even though a record has been localized already ("shown twice"). This issue exists for a long time already, but became more obvious with #94623, which enabled `showPossibleLocalizationRecords` for tt_content image. The main fix of the patch is to make FormEngine aware of this scenario and suppress listing a localized workspace record as "can be synchronized" when its l10n_parent field points to live. As drive-by, the patch fixes a missing reference index update call in DH when "synchronizing" a relation in workspaces. The patch also adds some `@todo`s to point out situations where the "parent count" fields are incorrect. The added tests show scenarios where a localized workspace record points to either its live, or its workspace default language "parent" in the "l10n_parent" field. We're adding the tests for FAL, but the situation is similar with parent (here: tt_content), with inline csv and inline foreign field: a) modifyContentLocalizeAddDefaultLangRelationSynchronize() Having a content element and a localization in live. Add an image in workspace default language and synchronize into workspace localized record: l10n_parent of new localized sys_file_reference points to the workspace sys_file_reference record. This is quite obvious, since there is no live record to point to. b) localizeLiveModifyWsLocalizationAddLiveWsSync() Having a content element and a localization in live. Modify the localization in workspaces, by for instance changing the title of the content element. This creates a workspace overlay of that localized element in workspaces. Then add an image to the default language live content element, and synchronize this in the localized workspace element. Now, l10n_parent of the new localized sys_file_reference points to the live sys_file_reference record. This is because an overlay of the default language record does not exist. c) localizeLiveModifyWsDefaultLang() Having a content element with image and a localization in live. Modify the default content element in workspaces, by for instance changing the title of the content element. This creates workspace overlays of the default language record, *and* overlays of the localized content elements. It also creates overlays of the attached images in both the default language record and its localizations. l10n_parent of the sys_file_reference localized records now point to the live version. This scenario is debatable since overlays of the default language record exist. We decided to keep this behavior, since we'd otherwise have to deal with updating these pointers when publishing localizations. Change-Id: Iaab27586ff19cdc5f491324ca6dbc2cceff73373 Resolves: #97548 Resolves: #89858 Related: #94623 Releases: main, 12.4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82996 Tested-by: -
Andreas Kienast authored
The Lit element `typo3-backend-spinner` uses a hard-coded SVG string, which has to be the same as the `spinner-circle` asset file. However, the SVG string was outdated as it neither respected the `currentColor`, nor respected the configured icon size. Both issues are fixed in this commit. Since `currentColor` is now taken into account, the variant styling has been removed. Resolves: #103198 Releases: main, 12.4 Change-Id: I24eababb8716076eb4db55a6bcd3eb43e98ea1fd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83128 Reviewed-by:
Jörg Bösche <typo3@joergboesche.de> Tested-by:
-
- Feb 28, 2024
-
-
Benjamin Kott authored
Correctly extend and show the children of the parentnode when a node is added. Clean up the parent node status when a node is removed and no longer contains child nodes. Resolves: #103226 Releases: main Change-Id: I269380c322cad06902e87406732d8f708c8f9614 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83158 Tested-by:
-
Christian Kuhn authored
With all phpunit 11 deprecations being fixed, we can raise from phpunit 10 to current major. > composer req --dev phpunit/phpunit:^11.0.3 -w Change-Id: Idc9774c9d5b0f0b170c870e04d8eb09df61363f0 Resolves: #103229 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83144 Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
-
Oliver Bartsch authored
Since #102970, it's no longer possible to use DB relations in nested types for flex forms. A forgotten TCA configuration in `tx_styleguide_elements_folder` is removed accordingly. Resolves: #103227 Related: #102970 Releases: main Change-Id: I06c6a5953fa9dca1e8a90b677c3c890580da8b6b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83159 Reviewed-by:
-
Till Hörner authored
Resolves: #103221 Releases: main, 12.4 Change-Id: I4089a733f9ce2c888c05a4f1e4f7834a00ad1bfc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83154 Reviewed-by:
Till Hörner <thoerner@3pc.de> Tested-by:
-
Christian Kuhn authored
Deprecated with phpunit 11. Adapt to fixture classes to test details of abstracts. Resolves: #103228 Releases: main Change-Id: Ic0cd4541856beb45775d50d22b95be687888373a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83160 Reviewed-by:
-
Markus Klein authored
In relation mode "manyToMany" it is okay to have a limit of one. Code-wise the FlexForm code is slightly simplified as there is no support for the "manytoMany" case. Resolves: #103188 Releases: main, 12.4, 11.5 Change-Id: Ib2bbafadefc39f603a9ec4fda20aebcee85cdd7a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83090 Tested-by:
Josef Glatz <typo3@josefglatz.at> Tested-by:
-
Christian Kuhn authored
Deprecated in phpunit 11. Used once. We remove that test entirely since it is a direct call to GU::formatSize() which has its own tests already. Resolves: #103225 Releases: main Change-Id: If895a9edd41b3e427ec4eb5751b713cf9da7f017 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83157 Tested-by:
-
Christian Kuhn authored
Deprecated with phpunit 11: Use `$double->willReturn()` instead of `$double->will($this->returnValue())`. Resolves: #103223 Releases: main Change-Id: I0f90a168e6649dcacc2c56628e51117893d7e645 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83156 Reviewed-by:
-
Christian Kuhn authored
Phpunit 11 is a bit more picky with data providers: If single data sets "name" their arguments, they must match to the consuming test argument names, or a PHP warning is raised. The patch adapts data providers or test method arguments to deal with this. Change-Id: Ic09a1621a5921239f2abdb9de58f7135af6240d9 Resolves: #103222 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83155 Tested-by:
-
Andreas Kienast authored
In order to deprecate the inferior Wizard component introduced back in TYPO3 v7, the Localization wizard is migrated to the MultiStepWizard component. In the same run, the opportunity to cleanup the code a bit is taken: * replace `.then()` callback hell with async/await * use setting "API" of MSW instead of local properties * steps that don't allow interaction are skipped from composition Also, some minor quirks in MSW are fixed without doing major refactorings: * `forceSelection` is checked and enforced before running callbacks that may unlock any buttons, otherwise leading to a unresolvable situation * the "previous" button is now automatically (un)locked, depending on whether there are previous steps * the content of the slide that is slid to is reset as it may have been altered in a slide callback Resolves: #103155 Releases: main Change-Id: I35d5d4a14b7635c0df3f5248491f0cc45074c430 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83040 Tested-by:
Andreas Nedbal <andy@pixelde.su> Tested-by:
-
- Feb 27, 2024
-
-
Christian Kuhn authored
Substitute with a PHP attribute. Resolves: #103219 Releases: main Change-Id: Ie589404f797a880fc8e27480a2dd95c3f0420427 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83152 Tested-by:
-
Christian Kuhn authored
phpunit 11 deprecates addMethods() on mocks. There are various solutions: * Use onlyMethods([]) instead of addMethods(['dummy']) to "mock nothing" * Remove a couple of calls that were bogus in the first place * Turn calls into mocks of interfaces * Turn calls into mocks of fixture classes * Instantiate a subject with new() Also have the one or the other minor cleanup as drive-by. Change-Id: I5dad1cc65c14ed50b3941beaa7132040bc415a11 Resolves: #103218 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83150 Tested-by:
-
Christoph Lehmann authored
In production environments the address is always wrong. By removing it the fallback MAIL/defaultMailFromAddress is used. With this it's possibly one step less to setup the Linkvalidator. Releases: main Resolves: #103209 Change-Id: I03705a26de2dad6181b0a4f202900634f787a965 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83149 Tested-by:
-
Christian Kuhn authored
The methods are no longer static in phpunit 11 and should not be used in data providers. We split a data provider to deal with this. The final switch to not call these statically will be done when phpunit is raised, since it otherwise collides with cgl checks and current phpunit 10. Resolves: #103216 Releases: main Change-Id: I90c787d1c8b68e0bf02be0e4f056ef6ebb8ca9ef Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83148 Reviewed-by:
-
Christian Kuhn authored
* Less mocking * Don't test AbstractFrontend but implementations * Turn test-internal loops into data providers * General cleanup * Avoid phpunit 11 deprecations Resolves: #103214 Releases: main Change-Id: I87851d7ba6332161dc387bc6a5aea9661703428b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83147 Tested-by:
-
Christian Kuhn authored
Check $dataMap and $commandMap structure in start(), type hint them to array. This is considered b/w compatible since DH would have failed already when the incoming array shape was funny, and the annotations clearly stated an array must be given for a long time already. Minor adaptions throughout DH class to happify phpstan a bit more. Change-Id: Idfc4b0c5c8db1b096f9477ce9b2bbfc0c5755a03 Resolves: #103213 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83073 Tested-by:
-
Christian Kuhn authored
phpunit 11 deprecation: Use `$double->willReturn()` instead of `$double->will($this->onConsecutiveCalls())`. Resolves: #103210 Releases: main Change-Id: I72f4db5814a1c488e8b1883d6ce79cbdb91a2a33 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83145 Tested-by:
-
- Feb 26, 2024
-
-
Christian Kuhn authored
Unblock phpunit 11. > composer req --dev codeception/codeception:^5.1.1 codeception/module-webdriver:^4.0.1 > composer u codeception/lib-web codeception/stub > composer req --dev php-webdriver/webdriver:^1.15.1 Change-Id: Ib9f153e879510a3188c59ebd039033af2fcd6226 Resolves: #103208 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83142 Reviewed-by:
-
Christian Kuhn authored
Unblocks phpunit 11. > composer u typo3/testing-framework Resolves: #103207 Releases: main Change-Id: Iff3b1c026960d004b6576795c0fddee79168f01b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83141 Tested-by:
-
Christian Kuhn authored
Major version upgrade from v4. Unblocks phpunit 11. Adapt various Build/ scripts and the extension scanner. > composer req nikic/php-parser:^5.0.1 > composer req nikic/php-parser:^5.0.1 -d typo3/sysext/install --no-update Change-Id: I6fb3f874a4d8af951a74a8287afe798e29bbe3a2 Resolves: #103206 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83139 Reviewed-by:
-
Christian Kuhn authored
Use the attribute in favor of `@dataProvider` annotation. Adapt the acceptance test splitter to deal with it. Clean up annotationChecker to no longer allow `@dataProvider` and disallow a series of further not used annotations along the way. Resolves: #103204 Related: #103180 Releases: main, 12.4 Change-Id: If8e4d5a87d07d574065d596acb4c44a48f265ffa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83136 Reviewed-by:
-
Mathias Brodala authored
Resolves: #103202 Releases: main, 12.4 Related: #40096 Change-Id: If64a5d16da9d500180d070b8d5f6a7fd96609010 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83135 Tested-by:
-
Christian Kuhn authored
Unblocks phpunit 11, backport to v12 to keep php-cs-fixer in sync. > composer req --dev friendsofphp/php-cs-fixer:^3.50 Resolves: #103200 Releases: main, 12.4 Change-Id: I1ab390c816caf3eabba00e8404d00fe2c9009fd8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83133 Tested-by:
-
- Feb 25, 2024
-
-
Christian Kuhn authored
phpunit 11 deprecates annotations like `@test` and `@dataProvider` in favor of their attribute counterparts. We'll adapt core main & v12 to keep v12 backports simple. The patch takes care of Tests/Functional and Tests/FunctionalDeprecated. Script `Build/Scripts/splitFunctionalTests.php` is adapted to deal with annotations for CI to continue splitting functional tests into chunks. This also fixes detection in two test cases that had unexpected `@test` annotation combinations which were not properly detected before. > composer req --dev rector/rector > wget https://forge.typo3.org/attachments/download/38273/rector.php > find typo3/ -name \*Test.php | grep Tests/Functional | xargs bin/rector process > rm rector.php > composer rem --dev rector/rector Minor manual adaption in a few files plus cgl fixes. Also deny `@test` annotion in annotationChecker.php now to not introduce new occurences with other patches anymore. The script will receive another cleanup to look at further obsolete annotations. `@dataProvider` is currently still used in acceptance tests. Change-Id: I42705b57193a32db6fe17276d53476ecddcae835 Resolves: #103195 Related: #103180 Releases: main, 12.4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83115 Reviewed-by:
-
Oliver Bartsch authored
Resolves: #103192 Releases: main, 12.4 Change-Id: I81c0c655b75332790243c05be14f24593c5b9d6a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83118 Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
-
- Feb 24, 2024
-
-
Oliver Klee authored
Due to a typo, #103193 downgraded the minimum required phpstan/phpstan-phpunit version. Executed command: composer require --dev \ phpstan/phpstan-phpunit:^1.3.16 Resolves: #103194 Related: #103193 Releases: main, 12.4 Change-Id: Ied12668b57b500a42bdb9f901952094cd48bd1b0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83122 Tested-by: -
Oliver Klee authored
The new version changes the format of a warning. Executed commands: composer require --dev \ phpstan/phpstan:^1.10.59 \ phpstan/phpdoc-parser:^1.26.0 \ phpstan/phpstan-phpunit:^1.2.16 ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #103193 Releases: main, 12.4 Change-Id: I36a6b4f98e03b73dbf076d84ce1ea900c26fcfb2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83120 Tested-by:
-
- Feb 23, 2024
-
-
Oliver Bartsch authored
A couple of places (mostly paginations) are using the action ViewHelpers without providing the `action` argument. Those links will therefore fall back to the default action, which might be wrong e.g. in the backend user group listing. To preserve the current action on paginating, the corresponding action is now always set. Resolves: #103189 Related: #101729 Releases: main, 12.4 Change-Id: I1db9a637a4b320f90aae3a93fe903c939384ea3a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83114 Reviewed-by:
-
