Skip to content
Snippets Groups Projects
Commit c51afbf4 authored by Christian Kuhn's avatar Christian Kuhn
Browse files

[TASK] Use phpunit attributes in functional tests

phpunit 11 deprecates annotations like `@test` and
`@dataProvider` in favor of their attribute counterparts.

We'll adapt core main & v12 to keep v12 backports
simple. The patch takes care of Tests/Functional and
Tests/FunctionalDeprecated.

Script `Build/Scripts/splitFunctionalTests.php` is
adapted to deal with annotations for CI to continue
splitting functional tests into chunks. This also
fixes detection in two test cases that had unexpected
`@test` annotation combinations which were not properly
detected before.

> composer req --dev rector/rector
> wget https://forge.typo3.org/attachments/download/38273/rector.php
> find typo3/ -name \*Test.php | grep Tests/Functional | xargs bin/rector process
> rm rector.php
> composer rem --dev rector/rector

Minor manual adaption in a few files plus cgl fixes.

Also deny `@test` annotion in annotationChecker.php now
to not introduce new occurences with other patches anymore.
The script will receive another cleanup to look at further
obsolete annotations. `@dataProvider` is currently still
used in acceptance tests.

Change-Id: I42705b57193a32db6fe17276d53476ecddcae835
Resolves: #103195
Related: #103180
Releases: main, 12.4
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83115


Reviewed-by: default avatarAnja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: default avatarcore-ci <typo3@b13.com>
Tested-by: default avatarStefan Bürk <stefan@buerk.tech>
Tested-by: default avatarAnja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: default avatarChristian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: default avatarStefan Bürk <stefan@buerk.tech>
Reviewed-by: default avatarChristian Kuhn <lolli@schwarzbu.ch>
parent 4ad2e75a
Branches
Tags
No related merge requests found
Showing
with 153 additions and 324 deletions
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment