- Feb 16, 2020
-
-
Georg Ringer authored
Use mb_strlen & mb_substr to cut off TypoScript to avoid exceptions if the 20th character is a multibyte value. Resolves: #90372 Releases: master, 9.5 Change-Id: I8f90aa54a4cb6ede95d4fa50d557aeec4d8cd031 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63255 Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
-
- Feb 15, 2020
-
-
Christian Eßl authored
A regression introduced with #87879 removed the _REF_ label in the header table row of the filelist module. This commit fixes this bug. Resolves: #90387 Relates: #87879 Releases: master Change-Id: I7c7289352d81b09576fce6b266fb6c7a11daeeb1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63265 Reviewed-by:
Claus Due <claus@phpmind.net> Reviewed-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
Björn Jacob <bjoern.jacob@tritum.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Georg Ringer authored
Show all collected information of a user in the beuser module instead of just the information directly added to the user record. The UI will be improved with later patches This patch also switched to constructor injection in BackendUserController. Resolves: #90298 Releases: master Change-Id: I8cc19a475ae43404e29402b99852286bf6991b70 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63149 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Christian Eßl authored
The "Environment Overview" card in the admin tool will now show the application context the TYPO3 instance is running with. Resolves: #90136 Releases: master Change-Id: Ia9583ac093cdeba341e8cd079bbac341098a3b76 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63259 Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
-
Alexander Schnitzler authored
Used commands: composer remove rector/rector --dev composer require rector/rector:"~0.7" --dev Since updating phpstan to version 0.12.10, rector failed to run properly. Also, the updated version of rector brings a couple of bugfixes and new features. Releases: master Resolves: #90383 Change-Id: I29d66c5e34db594fbcf24949c61e6db85cecae1b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63260 Tested-by: -
Alexander Schnitzler authored
This patch only pleases phpstan. The refactoring of the indexer which includes the removal of the direct dependency to 3rd-party classes is taken care of in the following issue. https://forge.typo3.org/issues/83603 Releases: master Resolves: #90384 Change-Id: Ia1ee984f692dce7f8293077cbea3359d6843cb46 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63261 Tested-by:
-
Alexander Schnitzler authored
Releases: master, 9.5 Resolves: #90381 Change-Id: Ib7d3700ab928addec9c585e031fa9c0ba1bb50d3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63257 Tested-by:
-
Alexander Schnitzler authored
Releases: master Resolves: #90382 Change-Id: I26fe0116e48c64362c2b124e9daeec73182cccc2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63258 Tested-by:
-
Alexander Schnitzler authored
Both the \TYPO3\CMS\Core\Http\Client\RequestException and \TYPO3\CMS\Core\Http\Client\NetworkException declare a method getRequest which must return a RequestInterface object which they did not. Releases: master Resolves: #90379 Change-Id: I4cdee1cdf95efc1ebcabaacec7be2cd290f31989 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63254 Tested-by:
-
Alexander Schnitzler authored
Upgrade phpstan/phpstan to at least 0.12.10 and enable bleeding edge configuration to be able to run the phpstan analysis with all available cpu cores. Releases: master Resolves: #90378 Change-Id: I4c76a8f44c570b126844d1bde96998cf9d3790fa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63253 Tested-by:
-
Andreas Fernandez authored
Use the correct target (clicked button) to be able to access the button name. Resolves: #90036 Releases: master Change-Id: I3a2face0c10aa41dea13bc49d3f8f3e9f47b3fcc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63251 Tested-by:
-
Nikita Hovratov authored
Since the querybuilder is used to fetch notes the default restrictions of both apply sys_note and be_users. This patch removes the default restrictions and adds them manually only for sys_note. The names of hidden or deleted authors are replaced with "unknown author" instead. Fixes: #90216 Releases: master, 9.5 Change-Id: I7613909dad078256747e8b719bf68d64729fb56d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63246 Tested-by:
Stefan Froemken <froemken@gmail.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Guido Schmechel authored
IP anonymization now takes the correct pattern when querying the database. Depending on the mask to be shortened. Resolves: #89788 Releases: master, 9.5 Change-Id: Ic09d2385b33434cc2d7553087c2014b190f9c339 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62992 Tested-by:
-
Mario Lubenka authored
Resolves: #90042 Releases: master Change-Id: I9ca7dbc59495372033659d7d4c82142c92ed5e1b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62813 Tested-by:
-
Claus Due authored
Adds two new methods, evaluate() and onClose() which makes Widgets compatible with Fluid 3.0 but which are never called on Fluid 2.x. Releases: master, 9.5, 8.7 Resolves: #90286 Change-Id: I36a99c30e7c3bb5baae065cfc6368a2bf493cc40 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63133 Tested-by:
-
Stefan Froemken authored
In case of extbase many FlexForm fields are called settings.*. As "settings" is part of the field it should not be removed as extra identifier. Resolves: #80295 Releases: master,9.5 Change-Id: I206f28cfc360cb526f488b2fb016139246c2cad8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63003 Tested-by:
-
ℳichiel ℛoos authored
Allow inline parent UID to have a "NEW..." placeholder value. Resolves: #82931 Releases: master, 9.5, 8.7 Change-Id: I1714160d14d226a02663568947ed9525ad07d347 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/54598 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Steffen Frese <steffenf14@gmail.com> Tested-by:
Sascha Rademacher <sascha.rademacher+typo3@gmail.com> Tested-by:
-
Elias Häußler authored
Both "clear" and "add" buttons for the backend user avatar selection are currently not accessible via keyboard. In order to solve this accessibility issue, both buttons have been converted from links to html buttons to trigger the onclick handler when using the keyboard. Resolves: #90293 Releases: master, 9.5 Change-Id: I263a282a4bee33abdb88f9850d230a453365b7ab Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63148 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Torben Hansen <derhansen@gmail.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Michael Telgkamp <michael.telgkamp@mindscreen.de> Tested-by:
-
Georg Ringer authored
If a record should be restored, the label in the modal must be set to "Restore record" instead of "Delete". Resolves: #89599 Releases: master, 9.5 Change-Id: I201473cb86be207cda9c87b43c5420f6cb5c6898 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63244 Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Tested-by:
-
Daniel Siepmann authored
Allows direct checks whether an expected bit is part of a bit set, e.g. in a stored checkbox or radio of a record. Resolves: #90213 Releases: master Change-Id: I2ff188c74b207376f5f44307f0a8a2e9514ea6d8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63046 Tested-by:
-
- Feb 14, 2020
-
-
Oliver Bartsch authored
transOrigPointerFields can not longer be excluded as this leads to inconsistent data stored in the database if a non-admin user created a localization by not having the permission to edit the transOrigPointerField. Resolves: #89550 Resolves: #89672 Releases: master Change-Id: Id718323783d37e6044781183052e3428ded9c89c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62632 Tested-by:
-
Claus Due authored
Changes access of $this->viewHelperVariableContainer to $this->renderingContext->getViewHelperVariableContainer since the former is deprecated in AbstractViewHelper. Releases: master, 9.5, 8.7 Resolves: #90276 Change-Id: I157948834a6a6e654b2e851057922745e9921920 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63101 Tested-by:
-
Alexander Schnitzler authored
Unfortunately phpstan looses the correct type of $this as soon as $this is passed into a hooked as a hook method parameter without a specific type. This leads to phpstan losing the information about available methods and properties of $this. Releases: master Resolves: #90204 Change-Id: I6fdb4f07dd970a1602a7afbbf662b29f2a927a15 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63036 Reviewed-by:
-
Benni Mack authored
Use code cache properly instead of storing strings into it, because it is proper usage of our API, removes the need for stripping PHP code strings and improves performance when OPCache is in use (which is recommended on production systems). Additionally all calls to ->has are removed, except one place where boolean values are stored in a runtime cache and in tests, because the API guarantees returning "false" when using ->get or ->require Doing so reduces the amount of lookups on the backend storage (file_exists for file backend, SQL queries for DB backend) and makes up more straightforward code in most places (reduces cyclomatic complexity by removing obsolete "else" branching). Releases: master Resolves: #89895 Change-Id: I401512ad4ddffb622ce2f4a9d88274deb4b4e849 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62558 Tested-by:
Achim Fritz <af@achimfritz.de> Tested-by:
-
Benjamin Franzke authored
Transform CommandRegistry into a symfony CommandLoader which allows console commands to be created on demand. That means commands are lazy loaded in order to avoid creating all commands with all their dependencies in every console invocation. Command will now be loaded when they are either executed or when command metadata is required (e.g. for the command listing) The `site:list` command is adapted to make use of dependency injection. Releases: master Resolves: #89139 Change-Id: I64256bf2dc21f0f3fe434aa5dff6176f0fe22233 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61630 Tested-by:
-
Nikita Hovratov authored
This fixes the wrong comparison with the key instead of the value in the foreach loop. Fixes: #89694 Releases: master, 9.5, 8.7 Change-Id: I6d1d4b9d89a9ac0db1215245b39edb23b3a888f8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63237 Tested-by:
-
Andreas Fernandez authored
This patch reworks the queueing system for AJAX requests sent by the extension scanner. This implementation now really only sends the allowed amount of concurrent requests and queues the remaining requests. When the extension scanner gets closed, the queue gets flushed and the remaining running requests get aborted. Since aborting a request triggers a DOMException, the rather useless "Oops" notification gets removed. The extension scanner now also queues requests where it actually makes sense. Resolves: #90279 Releases: master, 9.5 Change-Id: Ia5a64a2074fd99b8447063e2135126b7cf46e393 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63107 Tested-by:
Richard Haeser <richard@maxserv.com> Tested-by:
-
Michael Telgkamp authored
To allow persons with color blindness to recognize the status of the toggle checkboxes more easy the contrast is adjusted. Resolves: #84881 Releases: master Change-Id: I30aff505cdaafc3272303712d7a4eb70b53c2371 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63179 Tested-by:
Riny van Tiggelen <info@online-gamer.nl> Reviewed-by:
-
Georg Ringer authored
module If an editor has got access to only a subset of languages, only those must be visible within the list module for page translations. Resolves: #90367 Releases: master, 9.5 Change-Id: I6deae42f2428e23d0dfb7656905db7c453119000 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63232 Reviewed-by:
-
Georg Ringer authored
Move the info message text to a xlf file and differ between the slug of pages and records. Resolves: #89574 Releases: master, 9.5 Change-Id: I1d68e5b9dcca9cd2559c5e0bdbefc81c79e6b669 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62199 Tested-by:
-
Susanne Moog authored
To promote the new PSR-14 Events and to make it easier for people to see which kinds of events may be used, the admin panel now displays all events that are dispatched in the current request with their parameters. Resolves: #90265 Releases: master Change-Id: I3c73ab19168954e66ca3bb73762a26a3cb9628a2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63041 Tested-by:
-
Benni Mack authored
SystemEnvironmentBuilder calls error_reporting(E_ALL & ~(E_STRICT | E_NOTICE | E_DEPRECATED)); which in turn is called on every test to setup the environment. This basically enforces this exact error reporting and does not allow to configure the error reporting in phpunit.xml AT ALL. Until TYPO3 v9, this was covered in each BaseTestCase in setUpBeforeClass() to re-add E_NOTICE to make all tests run without notice. The functionality in SystemEnvironmentBuilder was added in TYPO3 v6.0 while refactoring TYPO3's Bootstrap to ensure that no notices in ext_localconf.php or ext_tables.php were breaking the output. However, nowadays, TYPO3's error reporting is set up directly after LocalConfiguration.php inclusion, making this logic obsolete. The functionality is therefore moved to the Bootstrap at a later point, which is called for Functional and Acceptance Tests. Resolves: #90125 Releases: master Change-Id: I8d6348ffbf6622c03abecedc1cb0ce286ba1044c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62926 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
- Feb 13, 2020
-
-
Sebastian Fischer authored
With adding progressbar support while updating the reference index, it is now possible to see which table is updated and how much progress has already been achieved. To be able to implement the progressbar in the frontend in a different way, a progress listener interface is introduced which can be added separately. At the same time, the FlashMessage logic is now put in the TYPO3 Backend controller and the $cli_echo is now used to inject the progress listener interface Resolves: #82062 Releases: master Change-Id: Id11ba8a9f3e033eaea9f3aff5a7f5eb0602cfa02 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/53748 Tested-by:
Sebastian Fischer <typo3@evoweb.de> Reviewed-by:
-
Benni Mack authored
This change introduces a new security option for setting the SameSite option to all cookies sent by TYPO3 Core. Namely: - Frontend User Sessions ("lax" by default) - Backend User Sessions ("strict" by default) - Install Tool Sessions ("strict", none-configurable) - Last Login Provider in Backend ("strict", non-configurable) This means that these can only be accessed by scripts and requests by the same site, and not by any third-party scripts. Since we're talking about actual cookies for a user, and not ads-related or third-party login-dependant cookies, the default options fit just perfectly. All modern browsers except Internet Explorer respect this option to be set. Please note that Firefox and Chrome will have "SameSite=lax" set in Q1/2020 by default if NO SameSite option is set at all. This change allows to configure this. Backend and Frontend User Cookies can be configured to "strict", "lax" or "none" (= same as before), whereas "none" only works for secure connections (= HTTPS). If "strict" is in place, security via CSRF is not needed anymore, and can be dropped in the future. Resolves: #90351 Releases: master, 9.5, 8.7 Change-Id: I8095e2a552faa9d1fd4fa7855297302a9ec6a75f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63183 Tested-by: -
Benni Mack authored
There are a few places where unused options can be simplified, and the dependency on the PagePositionMap class can be placed in one dedicated method. Several guard clauses are useless due to method parameter types, and are cleaned up. This is a pre-patch to bring more functionality into New Content Element Wizard. Resolves: #90366 Releases: master Change-Id: I912efbe25f6ff79670f404d7f44dbad0993295db Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63211 Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
-
- Feb 12, 2020
-
-
Benni Mack authored
TYPO3 uses "phpdocumentor/reflection-docblock" (added in Jan 2019) but also added "webmozart/assert" which is not needed directly (as it is a subdependency). Thus, TYPO3 Core should only require what is directly used, therefore the dependency is removed. Used composer command: composer remove webmozart/assert Resolves: #90364 Releases: master Change-Id: Ief2787cb98c0080517f73e321ab34568b0addafb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63209 Tested-by:
-
Andreas Fernandez authored
This patch fixes some code issues with unit tests and HTML formatting that were not noticed due to missing builds during the infrastructure outage. Resolves: #90363 Releases: master Change-Id: Iab2e9965e711d0ca655c1105b16ec9a5434d3d87 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63208 Tested-by:
-
Andreas Fernandez authored
Resolves: #90362 Releases: master, 9.5, 8.7 Change-Id: I5716164f88e1fcead60bf64cd76bbb7d31cfd6b6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63205 Tested-by:
-
Anja Leichsenring authored
Added the missing keyword abstract to the class definition to prevent phpunit from issuing a warning about the class not containing any tests. Resolves: #90357 Releases: master, 9.5 Change-Id: I4b2d5c8111d63e73039658efffe73888b0c84179 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63204 Reviewed-by:
-
- Feb 11, 2020
-
-
Georg Ringer authored
TYPO3 supports now translations from Macedonian which uses `mk` as locale. Resolves: #90328 Releases: master, 9.5 Change-Id: I25bec5840e48a74e23fe9d1b0d565f2cdd036f22 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63178 Tested-by:
-
