- Aug 24, 2021
-
-
Benni Mack authored
This change favors native <a> tags for internal TYPO3 links in TYPO3 Backend where a ViewHelper is not needed. Resolves: #94975 Releases: master Change-Id: Ib068aee4bb54e45b158bf79d6e5f0c0d8a597341 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70736 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Oliver Bartsch authored
The workspace review features the collapse/expand functionality for record relations. An example is tt_content which may contain several sys_file_reference relations. They are included in the listing as well but collapsed by default. Since at least v10 those relations are always processed together. This means, in case an editor checks a parent record and executes an action, e.g. publish, the same action is also executed for the relations. However, the UX was previously not really helpful as this was not visible to the editor. Therefore, and to improve the UX in workspace review, those relations are now always "bound together". This means, when selecting the parent record all relations are selected, too. The same goes the other way round. When selecting a relation, all corresponding relations as well as the parent record are selected. As mentioned, this does not change any functionality as this process was already done "under the hood". This process is now just visualized for the editor. Resolves: #94404 Releases: master, 10.4 Change-Id: I28d2c9e67747dde5ffdfb36d24f8cc7f36c246a8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70712 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
-
Oliver Bartsch authored
The multi record selection, introduced in #94906, is extended for keyboard shortcuts. They can be used to achieve similar results as by using the actions in the multi record selection dropdown. * `shift` key: check / uncheck the range between the last checked checkbox and the current one * `option` (Mac) or `ctrl` (Windows/Linux) key: Toggle the current selection Resolves: #94944 Related: #94906 Releases: master Change-Id: Ia5f6625e6b380d908bddfbf5849f2ea6233fe420 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70688 Tested-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
-
Oliver Bartsch authored
The TcaText data provider transforms a given database field value with the RteHtmlParser as soon as `enableRichtext` is set for the field in TCA. This means, the data provider did previously not checked, whether RTE is disabled for the user in general or for this specific field by configuration (e.g. page TSconfig). This therefore led, among others, to "normal" text being falsely wrapped with `<p>` tags. This is now fixed by checking all relevant settings before actually transforming the database field value. Resolves: #94915 Releases: master, 10.4 Change-Id: I5af4e9997c28269be959ea9e63e12cfee5e991af Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70674 Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Tested-by:
-
Andrzej Kołbuc authored
Labels are rendered by CshViewHelper which do htmlspecialchars on it. Next step todo is change whole additional fields layout and prepare translations. Resolves: #93888 Releases: master, 10.4 Change-Id: I19d12951a030977384ee3a923823990fe97e9211 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70536 Tested-by:
kharaf <k.haraf@macopedia.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Rudy Gnodde <rudy@famouswolf.com> Reviewed-by:
-
Wouter Wolters authored
The following core extensions are handled: EXT:reports EXT:redirects EXT:recycler EXT:recordlist EXT:opendocs EXT:linkvalidator Resolves: #94855 Releases: master Change-Id: Ifb6b2ca2f6c25dae2c3dab3d2d4ca6571312c9f4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70512 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
- Aug 23, 2021
-
-
Oliver Bartsch authored
The extbase ObjectConverter - typically used when mapping request arguments to target domain models - needs more fine grained handling to drop ObjectManager usages. We missed some details with #94451. The patch takes care of this and adds an explanation together with possible future options to the codebase. This fixes deprecation log entries triggered by the belog module. Resolves: #94807 Related: #94451 Releases: master Change-Id: Ia1f1c15c1814d53b42d83213778029908332ede0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70445 Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Alexander Nitsche authored
This is a regression introduced with #94057 that causes resetting excluded records to throw an exception in the export view, since the incoming parameter "exclude" could be of type array (= add excluded records) or integer (= include all records again), but was only checked for null or not null, which was ambiguous in the second case. For clear separation the reset of excluded records is now done via a new parameter "resetExclude". Resolves: #94949 Releases: master Change-Id: Iddb8d21e0f75cc24ef18dd2f851a479cb7dafb3b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70690 Tested-by:
Alexander Nitsche <typo3@alexandernitsche.com> Tested-by:
-
Oliver Hader authored
Avoids round trip through Fluid template, but instead assigns stylesheets and inline scripts directly via `PageRenderer`. Resolves: #94969 Releases: master Change-Id: Ic16c853fc8fcb26204c91b6347616513787fcd78 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70731 Tested-by:
-
Alexander Nitsche authored
This is a regression introduced with #94772 that causes all actions related to export presets to fail because the controller checks $_GET instead of $_POST for incoming preset action parameters. Reduced redundancy in EXT:impexp acceptance tests by introducing AbstractCest::selectInContextMenu() for basic context menu handling and moving waitForAjaxRequestToFinish() to the central AbstractCest. In addition, the declarations of local variables have been bundled. Resolves: #94938 Releases: master Change-Id: I13f506d9c32b09b13034388908d710c284885f56 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70684 Tested-by:
-
Benni Mack authored
This reverts commit e2e59fb3 due to certain incompatibilities with direct "index.php" calls in certain server setups. Change-Id: I980feb08f3a507d51ad059763748ee64752aa9a3 Resolves: #94968 Reverts: #94537 Releases: master, 10.4, 9.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70694 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
-
Alexander Nitsche authored
Adapting the "impexp:export" and "impexp:import" commands to the TYPO3 Core and replacing all lowerCamelCase options with lowercase options. The lowerCamelCase options will be removed in TYPO3 v12. Perform explicit instead of implicit command argument testing to tackle the increased complexity introduced by the handling of deprecated and future-proof arguments. Align naming of command options "pid" and "pageId" Align some command option descriptions. Resolves: #94902 Releases: master Change-Id: Ibd30a89e6ba81f27753979da944bde4d104aeb95 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70599 Tested-by:
-
Christian Kuhn authored
The frontend editing extension ext:feedit has been extracted from core monorepo with #87498 in v10. This rendered stdWrap.editPanel, stdWrap.editIcons and EDITPANEL content object unused as core functionality. The patch deprecates these parts: Extensions that rely on it - typically ext:feedit and ext:frontend_editing should integrate stdWrap using hooks and registering an own EDITPANEL cObj if needed. Releases: master Resolves: #94953 Related: #87498 Change-Id: I489b4fb2d3e09d8b2fcad91b5ae3bccf28244151 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70714 Tested-by:
-
Andreas Fernandez authored
The context menu skeleton is partially visible for a very short time, before its items are rendered and event listeners are attached. This is revealed by some flaky acceptance tests and was previously workarounded by an additional ->wait() call in the tests. The context menu stays hidden now until everything is set up and the workaround in the AC tests is removed again. The context menu gets hidden after 500ms once the user moved the mouse out of its boundaries. However, that timeout was never reset which closed another context menu that might have opened within that 500ms time span. To circument this issue, such timeouts are now monitored and cleared again once a new context menu is requested. Resolves: #94891 Releases: master, 10.4 Change-Id: Ia0551d8c0b41edeca27cd0b15e4285a89ad2c171 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70592 Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
-
Christian Kuhn authored
TypoScriptFrontendController has a property to count nesting of content objects. This is used in ContentObjectRenderer to prevent recursion scenarios. If that kicks in, the rendering is silently stopped. This is ugly for various reasons: First, creating a recursion via TypoScript is rather unlikely. Second, the property creates a dependency between ContentObjectRenderer and TypoScriptFrontendController. And most importantly: If a TypoScript setup somehow manages to create a recursion, this should create an error, not a silent suppression. The patch drops handling of property cObjectDepthCounter. If a recursion appears now, PHP will error out as soon as max nesting level is reached. This obsoletes the property and its handling. Resolves: #94957 Releases: master Change-Id: I4d25472c6c0680a96cc223b7e81bbcbc813b2f52 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70719 Tested-by:
-
Anja Leichsenring authored
The information is available in the request and should be used from there. Resolves: #94632 Releases: master Change-Id: I8730e8a96bed7272d6c6239b7d55ea56a03bd2de Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70065 Reviewed-by:
-
Wouter Wolters authored
The extesion "about" is moved to EXT:backend and can safely be removed in composer.json. Resolves: #94967 Related: #91888 Releases: master Change-Id: I61e00b78ea12c1226fe35244778612e1d82fd054 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70604 Tested-by:
-
Stefan Bürk authored
If the dropzone was not visible, remove it without animation. Resolves: #94892 Releases: master Change-Id: Icfb0090b9383321cd1d24c0aba7026affdbb58d9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70594 Tested-by:
-
Wouter Wolters authored
Resolves: #94895 Releases: master Change-Id: Ic8a69d570627e3017c53b2ad2959ade0f657fb5f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70603 Tested-by:
-
Oliver Bartsch authored
Have you ever wondered why "unrelated" records got processed in workspaces review when using one of the mass actions? Simply because the workspace JavaScript component is using an internal array, holding all selected records. This internal array however was only reset on leaving the module. Therefore, all records which had been selected since the module was accessed were taken into account when a mass action was executed. This did not only affect records which were unchecked prior to mass action execution, but also records which were no longer visible at this time, e.g. due to an applied filter. In the worst case, that led to completely unrelated records got published to a live workspace. This is now fixed by resetting the mass action state whenever the listing gets updated. This way, only the selected records in the current view are taken into account when executing a mass action. Resolves: #94405 Releases: master, 10.4 Change-Id: I40cabe66fd7a4eb310a8113f69d49f234cc110a8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70691 Tested-by:
-
Achim Fritz authored
fetching all references from sys_references to formPersistenceIdentifier should have the same constraints as counting the references Resolves: #94960 Releases: master, 10.4 Change-Id: Ic6237c2e1742c48fdeab327eb28e22b21b1454d4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70722 Tested-by:
-
Christian Kuhn authored
ContentObjectRenderer has a couple of non-critical and mostly unused public properties. Those can be deprecated without much impact. Resolves: #94958 Releases: master Change-Id: I8b79660944f2fd9f2a5df1b3a73a0d6894f88127 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70720 Tested-by:
-
Christian Kuhn authored
Handing around ContentObjectRenderer in the frontend is tricky and intransparent. Especially class instances created via ContentObjectRenderer->callUserFunction() get an instance of it set through public property $cObj in the consuming class. This is typically the case for USER and USER_INT type frontend plugins. The patch deprecates using this public property and calls the method setContentObjectRenderer() instead. This explicit method call is much easier to see, break point and follow. The state handling of ContentObjectRenderer is far from obvious, the change helps debugging and refactoring this further. Change-Id: Ib6ca11e7d6660dae0e82ad08ad1f9b39095e99da Resolves: #94956 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70717 Tested-by:
-
Alexander Nitsche authored
Since patch #94316, when downloading a file in the TYPO3 backend, a PSR-7 response object should be created instead of using header() and die(). Resolves: #94916 Releases: master Change-Id: Ie99950636084358aa8b07e8a1595f5041a3808ff Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70673 Tested-by:
-
Wouter Wolters authored
The methods are now called statically but are not statically defined. Use $this instead. Resolves: #94894 Releases: master Change-Id: I2b1d5efc21af49ce447368440cbcbe5fabc94ffe Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70601 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Alexander Nitsche authored
This change introduces a new CLI command "impexp:export" which allows to export the TYPO3 page tree based on a fine-grained configuration. Both CLI commands "impexp:export" and "impexp:import" no longer offer option shortcuts to improve the clarity of the command when the user does a quick search. Resolves: #84718 Releases: master Change-Id: I00d87f94544d1abfa0d547639b67afb8a8eea112 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70393 Tested-by:
-
Alexander Nitsche authored
Running the functional EXT:impexp tests causes the EXT:impexp/Tests/Functional/Fixtures/Folders/fileadmin/user_upload folder to grow larger. This is due to export files being created that have not been cleaned up after the tests have run. In addition, completely delete the default import/export folder in ImportExport::removeDefaultImportExportFolder(). This method is currently only used in tests. Resolves: #94937 Releases: master Change-Id: I55d821ec18689172a73e0f290f1e155fae64d3cb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70683 Tested-by:
-
Oliver Bartsch authored
AbstractTreeView defines the current "scriptUrl", to build links in the backend. Since this class may also be called via CLI, e.g. by EXT:impexp, missing `instanceof` checks are added to prevent a null pointer exception. Resolves: #94947 Related: #93158 Releases: master Change-Id: I795effd17d42944ae0ab32b1ab10cd632ca7c31e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70689 Tested-by:
-
Oliver Bartsch authored
The workspace JavaScript component tries to fetch the workspace listing on accessing the backend module. Since #94819 this results in a JavaScript TypeError since the provided selector for the progress bar component, used as indicator for the ajax request, might not exist. This is now fixed by checking if the the workspace is actually accessible prior to initiating the ajax call. Resolves: #94946 Related: #94819 Releases: master Change-Id: I0c77564acc197a57e2999f4439daf28ba3fd333c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70724 Tested-by:
-
Oliver Bartsch authored
FormEngine allows to edit multiple records at once. This view can e.g. be accessed using the recordlists' "Edit marked" button. Since the "language switcher" only affects the first displayed record, it is now not longer rendered, when in "edit multiple" view. To improve readability of the code, all those places now use the same "speaking" method. Resolves: #94900 Releases: master Change-Id: Iae0ccd69616324fed915dbc0bb781c4edc95971b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70618 Tested-by:
-
Oliver Bartsch authored
The multi record selection component is now also used in the recycler module. This increases consistency, as custom checkbox logic could be removed. Also the recyclers' JavaScript implementation of the selection actions is simplified. To interact with the multi record selection component, some events are used. This also means, the functionality stays the same, while most of it is now handled by the Multi record selection component. Resolves: #94926 Releases: master Change-Id: I57d91d070bfa75c01d4cb87dfd0c5576d111dcfa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70678 Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
-
Oliver Bartsch authored
Components, using the multi record selection, introduced in #94906, usually do not have to change any checkbox state manually. The multi record selection component is taking care of it. However, there might be cases when a consuming component needs to change checkbox state on its own. An example is the workspaces module, which may changes checkbox state of child records when their parent record got changed. See: #94404. To prevent the components from overriding each other, the multi record selection now respects a special data attribute `manually-changed`. If set on a checkbox element, the multi record selection component will not touch this checkbox, while executing its (mass) actions. Resolves: #94948 Releases: master Change-Id: I35b07ca45cab4b96d3eea93ff45426702a1532d7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70713 Tested-by:
-
Oliver Bartsch authored
Resolves: #94942 Releases: master, 10.4 Change-Id: I59685f499f9a86e266b6b012a88e80bdef4d3c3b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70685 Tested-by:
-
- Aug 20, 2021
-
-
Oliver Bartsch authored
The multi record selection component is now also used in the workspaces module. This increases consistency, as custom checkbox logic could be removed. Furthermore are the actions now shown above and below the listing, similar to the recycler module. Thanks to additional labels, it's now also clear what each action is for and which records are affected. Resolves: #94935 Releases: master Change-Id: I65d275f79390deaf30b9468f40b34856b7aee8d4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70682 Tested-by:
-
Henrik Elsner authored
Add a missing semicolon and a comment to a code example. Resolves: #94933 Releases: master, 10.4 Change-Id: I0c028b72e111591cdd8ac33e76d7aaff18543363 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70686 Tested-by:
Henrik Elsner <helsner@dfau.de> Tested-by:
-
- Aug 19, 2021
-
-
Oliver Bartsch authored
This does a few follow up changes to increase consistency and allow further use cases. * Introduce a wrapper class to prevent jumping of the multi record selection actions and to unify the space between the actions and the record listing * Introduce new event listener for the actions, allowing JavaScript modules to influence the display based on their custom logic * Allow defining the actions multiple times on the same page (e.g. above and below the records listing) * Move "Selection:" label to EXT:core, while using it in both, filelist and file selector now Resolves: #94928 Related: #94906 Releases: master Change-Id: Ia1c972e8d5005d895476ad7e7322e39b37036669 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70679 Tested-by:
-
- Aug 18, 2021
-
-
11nd11 authored
The label of the select field 'allowedFileMounts' in the form wizard has been optimized. Now, the label is more readable and less technical. Resolves: #91627 Releases: master Change-Id: Iee18a47901a6d1c63184c68d5c4a888c3d4f0e15 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70540 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
Andreas Steiger <typo3@andreassteiger.de> Tested-by:
waldhacker <hello@waldhacker.dev> Reviewed-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
-
Ralf Zimmermann authored
Adds the forgotten breaking rst for the ticket https://review.typo3.org/c/Packages/TYPO3.CMS/+/70528/ Resolves: #94911 Releases: master Change-Id: I1a0e9c1b074b377febd655cc96a1a1033b56fc35 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70652 Tested-by:
-
Nikita Hovratov authored
In case the URL is at the very end of a string and there are no space characters that follow, the preg_split has failed with a backtracking error. By declaring the last capturing group as optional, this error is fixed. Resolves: #94920 Releases: master Change-Id: Id846840d910f38612d9b9185b4ed307a62422d4b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70676 Reviewed-by:
Frank Nägler <frank.naegler@typo3.com> Reviewed-by:
-
Jochen Roth authored
With #94778 the backend logo has been scaled down to fit into the topbar. This worked but also led to issues with smaller, such as the default TYPO3 logo, as those were now stretched. This is now fixed by removing the "height: auto" property. Resolves: #94914 Releases: master Change-Id: Id3321bf739d0b064b7113ff6a152a088860f44f6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70672 Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
-
