Skip to content
Snippets Groups Projects
Commit 53649c82 authored by Christian Kuhn's avatar Christian Kuhn Committed by Andreas Fernandez
Browse files

[TASK] Deprecate TypoScriptFrontendController->cObjectDepthCounter

TypoScriptFrontendController has a property to count nesting
of content objects. This is used in ContentObjectRenderer
to prevent recursion scenarios. If that kicks in, the rendering
is silently stopped.

This is ugly for various reasons: First, creating a recursion
via TypoScript is rather unlikely. Second, the property creates
a dependency between ContentObjectRenderer and
TypoScriptFrontendController. And most importantly: If a
TypoScript setup somehow manages to create a recursion, this
should create an error, not a silent suppression.

The patch drops handling of property cObjectDepthCounter. If
a recursion appears now, PHP will error out as soon as max
nesting level is reached. This obsoletes the property and its
handling.

Resolves: #94957
Releases: master
Change-Id: I4d25472c6c0680a96cc223b7e81bbcbc813b2f52
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70719


Tested-by: default avatarWouter Wolters <typo3@wouterwolters.nl>
Tested-by: default avatarAnja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: default avatarBenni Mack <benni@typo3.org>
Tested-by: default avatarcore-ci <typo3@b13.com>
Tested-by: default avatarAndreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: default avatarWouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: default avatarAnja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: default avatarBenni Mack <benni@typo3.org>
Reviewed-by: default avatarAndreas Fernandez <a.fernandez@scripting-base.de>
parent b893e2df
Branches
Tags
No related merge requests found
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment