[TASK] Deprecate TypoScriptFrontendController->cObjectDepthCounter
TypoScriptFrontendController has a property to count nesting of content objects. This is used in ContentObjectRenderer to prevent recursion scenarios. If that kicks in, the rendering is silently stopped. This is ugly for various reasons: First, creating a recursion via TypoScript is rather unlikely. Second, the property creates a dependency between ContentObjectRenderer and TypoScriptFrontendController. And most importantly: If a TypoScript setup somehow manages to create a recursion, this should create an error, not a silent suppression. The patch drops handling of property cObjectDepthCounter. If a recursion appears now, PHP will error out as soon as max nesting level is reached. This obsoletes the property and its handling. Resolves: #94957 Releases: master Change-Id: I4d25472c6c0680a96cc223b7e81bbcbc813b2f52 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70719 Tested-by:Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
Showing
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-94957-TypoScriptFrontendController-cObjectDepthCounter.rst 42 additions, 0 deletions...4957-TypoScriptFrontendController-cObjectDepthCounter.rst
- typo3/sysext/extbase/Classes/Utility/FrontendSimulatorUtility.php 1 addition, 3 deletions...sext/extbase/Classes/Utility/FrontendSimulatorUtility.php
- typo3/sysext/fluid/Classes/ViewHelpers/CObjectViewHelper.php 1 addition, 3 deletionstypo3/sysext/fluid/Classes/ViewHelpers/CObjectViewHelper.php
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php 24 additions, 30 deletions.../frontend/Classes/ContentObject/ContentObjectRenderer.php
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php 1 addition, 0 deletions...ntend/Classes/Controller/TypoScriptFrontendController.php
- typo3/sysext/frontend/Tests/Unit/Plugin/AbstractPluginTest.php 0 additions, 1 deletion.../sysext/frontend/Tests/Unit/Plugin/AbstractPluginTest.php
- typo3/sysext/install/Configuration/ExtensionScanner/Php/PropertyPublicMatcher.php 5 additions, 0 deletions...figuration/ExtensionScanner/Php/PropertyPublicMatcher.php
Please register or sign in to comment