[TASK] Explicitly set ContentObjectRenderer in USER cObj
Handing around ContentObjectRenderer in the frontend is tricky and intransparent. Especially class instances created via ContentObjectRenderer->callUserFunction() get an instance of it set through public property $cObj in the consuming class. This is typically the case for USER and USER_INT type frontend plugins. The patch deprecates using this public property and calls the method setContentObjectRenderer() instead. This explicit method call is much easier to see, break point and follow. The state handling of ContentObjectRenderer is far from obvious, the change helps debugging and refactoring this further. Change-Id: Ib6ca11e7d6660dae0e82ad08ad1f9b39095e99da Resolves: #94956 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70717 Tested-by:Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Benni Mack <benni@typo3.org>
Showing
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-94956-PublicCObj.rst 77 additions, 0 deletions...ntation/Changelog/master/Deprecation-94956-PublicCObj.rst
- typo3/sysext/extbase/Classes/Core/Bootstrap.php 13 additions, 4 deletionstypo3/sysext/extbase/Classes/Core/Bootstrap.php
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php 15 additions, 1 deletion.../frontend/Classes/ContentObject/ContentObjectRenderer.php
- typo3/sysext/frontend/Classes/DataProcessing/LanguageMenuProcessor.php 12 additions, 1 deletion...frontend/Classes/DataProcessing/LanguageMenuProcessor.php
- typo3/sysext/frontend/Classes/DataProcessing/MenuProcessor.php 12 additions, 1 deletion.../sysext/frontend/Classes/DataProcessing/MenuProcessor.php
- typo3/sysext/frontend/Classes/Imaging/GifBuilder.php 2 additions, 0 deletionstypo3/sysext/frontend/Classes/Imaging/GifBuilder.php
- typo3/sysext/frontend/Classes/Plugin/AbstractPlugin.php 13 additions, 0 deletionstypo3/sysext/frontend/Classes/Plugin/AbstractPlugin.php
- typo3/sysext/frontend/Tests/Functional/SiteHandling/Fixtures/LinkHandlingController.php 12 additions, 2 deletions...nctional/SiteHandling/Fixtures/LinkHandlingController.php
- typo3/sysext/seo/Classes/HrefLang/HrefLangGenerator.php 1 addition, 1 deletiontypo3/sysext/seo/Classes/HrefLang/HrefLangGenerator.php
Please register or sign in to comment