- Nov 19, 2022
-
-
Oliver Klee authored
Resolves: #99136 Releases: main, 11.5 Change-Id: I7851afb5f6417bb538895768fe4ae35d8b75d0b9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76700 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
-
- Nov 18, 2022
-
-
Oliver Klee authored
The FAL-related Extbase models are documented in the "TYPO3 Explained" documentation, and they are the recommended way to use FAL in an Extbase context. So the following classes are not marked as `@internal` anymore in order to not send mixed signals to extension developers: - TYPO3\CMS\Extbase\Domain\Model\File - TYPO3\CMS\Extbase\Domain\Model\FileReference - TYPO3\CMS\Extbase\Domain\Model\Folder There is no point in forcing extension authors to re-implement those classes (and duplicating the code from the Core) when the Core implementation is stable now and has proven to work fine. Some history for what has happened: Those classes started out marked as experimental (when they were indeed still experimental). Then, in a cleanup bulk change in 3888dae8f3f71c3f5e1db1c00bcbfe7d0d8fed2e5966e6533c9353b6d7485f32, the classes were converted to use the `@internal` annotation, even though at least the three FAL Extbase models should have been made public API instead by that time. This is where the usage of the FAL models is documented in "TYPO3 Explained": https://docs.typo3.org/m/typo3/reference-coreapi/main/en-us/ApiOverview/Fal/UsingFal/Frontend.html Resolves: #99126 Releases: main, 11.5 Change-Id: I2935fdb989569c7fc4088975af0ba1e5206df6d2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76670 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Lina Wolf <112@linawolf.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
- Nov 17, 2022
-
-
Oliver Klee authored
Passing no action name is a perfectly fine use case as this allows to conveniently redirect from a controller action to any page. Making this explicit in the type annotations allows extension authors to use this pattern without type checkers like PHPStan creating a warnings about this. Resolves: #99110 Releases: main, 11.5 Change-Id: I12cded81cbe20f7f2f626cf71ab92532d9037ee9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76654 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
Oliver Klee authored
Extbase controllers that call a never-returning method do not need a return statement after that call in order to avoid calling the rest of the action method. The new annotations ensure that PHPStan becomes aware of this control flow. Resolves: #99109 Releases: main, 11.5 Change-Id: I9b9d308440966c71051fe993abd31f23b13c82e0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76652 Tested-by:
-
- Nov 15, 2022
-
-
Christian Kuhn authored
We will soon have additional TypoScript TreeBuilder classes, for instance one related to TsConfig. Rename the Frontend TypoScript related TreeBuilder to SysTemplateTreeBuilder to improve namings. Resolves: #99096 Related: #97816 Releases: main Change-Id: I32dbd8aae87614d0a2a7d6aaa21e0f71059242a2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76611 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
-
- Nov 14, 2022
-
-
Christian Kuhn authored
TSconfig plays an important role in the Backend: It configures rendering and behavior details in the Backend and can be set on pages, be_users and be_groups field, leading to UserTsConfig and PageTsConfig. Frontend users and Frontend groups have this as well on database level, together with an API in class FrontendUserAuthentication. This was probably added in the old days to allow a similar thing as Backend TSconfig for Frontend users as well. It is however unused by the core and there seems to be only a very limited number of extensions that ever used this. Developers think of "TSconfig" as Backend specific things, and that's how it should be. To reduce confusion, the patch deprecates the TSconfig database fields in fe_groups and fe_users table along with the PHP API. Resolves: #99075 Releases: main Change-Id: I599670bf5e87eee4aa5e1ba353da1e7dc9351702 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76578 Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
-
- Nov 09, 2022
-
-
Benni Mack authored
When using a TCA table without deleted, or any other enablefields except "endtime", then the SQL query is built in a wrong fashion both in PageRepository and BackendUtility. Thee source of this disaster is inproper encapsulation in parenthesis when comparisons are build. Instead of simply adding a manual "()" around the or() comparisons, this change adjusts CompositionExpresion to properly add corresponding parenthesis, which ensure this in every case and avoid missing usages. A couple of tests are adjusted to properly reflect this change. Resolves: #89616 Releases: main Change-Id: I4aed140cbca5b4b40dfacd459a4c3aa30549b582 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76481 Tested-by:
Susanne Moog <look@susi.dev> Tested-by:
-
- Nov 08, 2022
-
-
Christian Kuhn authored
There is little point in not clearing all caches when extensions are loaded / unloaded using the extension manager. It's easier for extension developers to rely on all caches being cleared, it's one thing less to think about. The patch deprecates the clearCacheOnLoad and clearcacheonload array key in ext_emconf.php and removes the handling in extension manager. Resolves: #99019 Releases: main Change-Id: Id6ff3db02e2ff82813534e1d2a40cbfac0013b8c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76474 Reviewed-by:
-
Alexander Schnitzler authored
Due to the dependency of those objects to the DataMapper and its own dependency chain, serialization of those objects lead to error: Serialization of \Closure not allowed. To ommit this issue and to reduce the footprint of the serialization data in general, the data mapper should be omitted and reinitialized via __serialize() and __unserialize() Releases: main, 11.5 Resolves: #97190 Resolves: #92148 Change-Id: If8b78a93308eb14d40080c9cceee95754b785ba8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73975 Tested-by:
-
- Nov 07, 2022
-
-
Christian Kuhn authored
Switch the Extbase BackendConfigurationManager to use the new TypoScript parser. The implementation is quicker for Extbase Backend modules. Change-Id: Icb821fbe8804f219806abc5094ace3d404b96a73 Resolves: #99017 Related: #97816 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76447 Tested-by:
-
- Nov 03, 2022
-
-
Georg Ringer authored
To avoid exceptions if arguments are given but empty, an additional check is added in extbase LocalizationUtility, plus the default in f:translate is changed back to the same 'null' value as in v11. Resolves: #98924 Related: #96473 Releases: main, 11.5 Change-Id: Idd08f7b948eb504999a80a215a7ded64f3c648a0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76269 Tested-by:
-
- Oct 31, 2022
-
-
Benni Mack authored
This change modifies all places in TYPO3 Core to avoid using FormProtectionFactory::get() and use proper DI. A new method FormProtectionFactory->createForType(string $type) is added. In addition, FormProtectionFactory::set is removed as all affected tests are moved towards injection. The next step in this series is to deprecate the ::get() method and make a singleton out of the Factory to avoid purgeInstances() calls. Resolves: #98696 Releases: main Change-Id: I77cec532009ea4171f382bb5d9f207c0fcb7221c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76130 Tested-by:
-
- Oct 29, 2022
-
-
Nikita Hovratov authored
These comments don't add any value as the class under test can be easily determined from the filename. Executed commands: > grep -Rn -E "^\s\*\sTest case(\sfor.*|\.)?$" --include="*Test\.php" \ typo3/sysext/ | awk -F':' '{print "sed -i \047" $2-1 "," $2+1 "d\047 " $1}' | sh Some files with more comments needed manual adaption. Resolves: #98956 Releases: main Change-Id: Ia2fe96edda6ac26203bdfe8537a4d6e9d3e768c0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76332 Tested-by:Chris Müller <typo3@krue.ml> Tested-by:
-
- Oct 28, 2022
-
-
Torben Hansen authored
Resolves: #98899 Resolves: #98901 Releases: main Change-Id: Ifb188334c1445e3e8847bca476b6c5182bce829c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76323 Tested-by:
-
- Oct 27, 2022
-
-
Torben Hansen authored
Resolves: #98900 Releases: main Change-Id: Ie6f7d98ee293dcc2153a6af191892a7e12c1ea9e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76317 Reviewed-by:
-
Torben Hansen authored
Resolves: #98893 Releases: main Change-Id: Idcf53113f2f4acafe11cd953d9d9dd89f3b3dccb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76316 Reviewed-by:
-
Torben Hansen authored
Resolves: #98890 Releases: main Change-Id: If64893018e062ffb1fe83d3b8f68de3d5f2b2289 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76315 Tested-by:
-
Torben Hansen authored
Resolves: #98888 Releases: main Change-Id: I54c4cb0bb406f9d6a0a6b8d56a330f89630c9ca4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76311 Reviewed-by:
-
Torben Hansen authored
Resolves: #98898 Releases: main Change-Id: I62c2915adb19bc8cc124cab51e4f99782053b4d9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76304 Tested-by:
-
Torben Hansen authored
Resolves: #98894 Releases: main Change-Id: I7c1d7cf3622f64666adcabbb3ebf30d7c6189d1b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76306 Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Torben Hansen authored
Resolves: #98896 Releases: main Change-Id: I3c452a229b8a690d3954cfadfa439c9b3b7be30e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76307 Tested-by:
-
Torben Hansen authored
Resolves: #98895 Releases: main Change-Id: Ib1898a11fcb156d08d0f3fd9cfb738038d3d90ca Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76305 Tested-by:
-
- Oct 25, 2022
-
-
Christian Kuhn authored
The patch introduces the new request attribute TypoScriptRequestAttribute as 'frontend.typoscript'. It is set up in the Frontend middleware chain, extensions and content objects can use this attribute to retrieve TypoScript settings and setup. This obsoletes usages of TSFE->tmpl, the patch switches usages to the request attribute. Note we're also establishing a better wording: The old TypoScript 'constants' are now called 'settings'. This matches much better, should avoid confusion for newcomers and is in line with further renaming of a vaguely anticipated new 'constants editor' towards 'settings editing' or similar. Further patches in this naming area will follow. Change-Id: Ib6ffb91db9bf0976f39759b12983d78418d64efa Resolves: #98914 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76239 Tested-by:
-
- Oct 24, 2022
-
-
Christian Kuhn authored
The "is backend" check will never kick in since this is dispatched in ConfigurationManager already. Resolves: #98721 Related: #98578 Releases: main Change-Id: I9afca12237a618903d47757a6960500058106c21 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76244 Tested-by:
-
- Oct 21, 2022
-
-
Michael Vöhringer authored
PHP8.1 throws an TypeError if we sending null to createStream Resolves: #98417 Releases: main, 11.5 Change-Id: I327751c2cb13991122c84f4333a4976b9d0a0dae Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76197 Reviewed-by:
-
- Oct 19, 2022
-
-
Elias Häußler authored
This patch removes an outdated deprecation notice that was left when the ViewResolverInterface was changed in #96174. Resolves: #98655 Releases: main Change-Id: I4038e7a891b0fc5df6b737d41d53034aaa272c5e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76163 Tested-by:
-
- Oct 18, 2022
-
-
Benni Mack authored
This change modifies most of the userland code to use a) Connection::PARAM_* constants instead of \PDO::PARAM_* constants This is due to also another change from Doctrine DBAL 3 https://github.com/doctrine/dbal/blob/3.4.x/UPGRADE.md#bc-break-the-pdo-symbols-are-no-longer-part-of-the-dbal-api which can easily be changed in TYPO3's Source Code to ensure easy upgrade paths and showing best practices for extension authors looking into TYPO3 Source Code b) Avoid using constants from \Doctrine\DBAL\Connection but use our own constants. Even though Doctrine DBAL 3.x introduces "ParameterType" objects, we use our own connection implementation for the time being as we also seek to backport such changes in TYPO3 v11. c) Avoid using the Connection::PARAM_STR for ->createNamedParameter as second argument, as this is the default value. All of these changes will make the upgrade path towards Doctrine DBAL 4.x easier. The initial change was made with Rector - thanks to @schreiberten $rectorConfig->ruleWithConfiguration( \Rector\Renaming\Rector\ClassConstFetch\RenameClassConstFetchRector::class, [ new \Rector\Renaming\ValueObject\RenameClassAndConstFetch( \PDO::class, 'PARAM_INT', \TYPO3\CMS\Core\Database\Connection::class, 'PARAM_INT' ), .... PDO constants are now solely used within our own Database adapter code. Resolves: #98649 Releases: main, 11.5 Change-Id: Ife2569ddeda31e37d4c575d96beb4d41e9affff7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76156 Tested-by:
-
- Oct 12, 2022
-
-
Benni Mack authored
This change adapts our coding guidelines and rules with PHP-CS-Fixer, allowing for * PER (a.k.a. PSR-12) * no_useless_nullsafe_operator (only use nullsafe if allowed) * only single-spaces in arrays This effectively adapts our code base * use "public const" instead of "const" where visibility is not defined * one whitespace between "declare()" and "namespace" declarations * Use (float) instead of (double) casting * Additional space in annonymous classes (PER) * grouped "use" statements (classes, function, constants) * only one space between items in array lists * Use (bool) instead of (boolean) Resolves: #98585 Releases: main, 11.5 Change-Id: Idb83729d0e4f9dc3c41e4dc5346dab77e6fbce84 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76097 Tested-by:
-
- Oct 11, 2022
-
-
Christian Kuhn authored
A first code clean up of this class streamlines the properties and removes some rather obvious stuff. The unit tests receive an overhaul. Resolves: #98581 Related: #98578 Releases: main Change-Id: I9a6db5015c976986fde24f721e5c2fd8cc1d3f04 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76090 Tested-by:
-
Chris Müller authored
Resolves: #98580 Releases: main, 11.5 Change-Id: Ib3ee06cb2849efd8e4cf18fc2497f3c0fed0f752 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76091 Tested-by:
-
Christian Kuhn authored
The extbase ConfigurationManager is a complex beast full of anti patterns. We need to refactor here to unblock other things. AbstractConfigurationManager is the base of the 'concrete' classes BackendConfigurationManager and FrontendConfigurationManager. These are @internal with ConfigurationManager being the outer API. To reduce complexity and to allow looking at Frontend and Backend scenarios without triggering side effects on the other one, this divide and conquer patch simply copies all code from AbstractConfigurationManager into the inheriting classes, making them standalone. Existing unit tests of AbstractConfigurationManager are also copied to the two consuming classes. No further other refactorings are done with this patch to keep it simple. Resolves: #98578 Releases: main Change-Id: Ie7d663cc94c40363f46f41a09ee689113835133e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76089 Tested-by:
-
- Oct 10, 2022
-
-
Mario Lubenka authored
DebuggerUtility::var_dump() is commonly used to debug PHP classes. We recommend hardening PHP classes by using typed properties in PHP classes. Previously uninitialized properties resulted in a PHP exception when passing the class instance into DebuggerUtility::var_dump. Uninitialized properties will not be processed by DebuggerUtility::var_dump anymore. Instead a label "uninitialized" indicates that it has not been initialized at the time of debugging. Resolves: #98519 Releases: main, 11.5 Change-Id: Ifbb9fd4d0de2e6214ab4b876b04302b2adaf6d2a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75981 Tested-by:
-
- Oct 04, 2022
-
-
Christian Kuhn authored
This avoids abandoned php-cs-fixer/diff. The raise brings a series of CGL changes. > composer req --dev friendsofphp/php-cs-fixer:^3.11.0 > Build/Scripts/runTests.sh -s cgl -p 8.1 Change-Id: I84704208cc891916e5354c0900dc4bac4e771380 Resolves: #98522 Releases: main, 11.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75979 Tested-by:
Simon Gilli <typo3@gilbertsoft.org> Tested-by:
Kevin Appelt <kevin.appelt@icloud.com> Tested-by:
-
Oliver Hader authored
Change-Id: I1feb236aeae9b3b7da1c50d5f65daf4fca4727bc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75974 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Oliver Hader authored
Change-Id: I90d3ef8740698afac0327dff0591e4597b51e3e6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75973 Tested-by:
-
- Oct 02, 2022
-
-
Oliver Bartsch authored
In the process of using dedicated TCA types, the new TCA type "file" is introduced and replaces TCA type "inline" with "foreign_table" set to "sys_file_reference". The new type allows to remove a lot of cross dependencies and special cases for type "inline", in case the field is used in FAL context. Also DataHandler and friends benefit from this change, since dedicated functionality can be used now. It therefore effectively allows to improve FAL independently in the future. Due to the nature of "inline" a lot of code had to be copied for the new type, while changing the internal naming was not always easily possible. This will be done step by step with further patches. Besides the new TCA type also three new PSR-14 Events are introduced: - CustomFileControlsEvent - ModifyFileReferenceControlsEvent - ModifyFileReferenceEnabledControlsEvent While the ModifyFileReferenceControlsEvent and ModifyFileReferenceEnabledControlsEvent are equal to their inline counterparts does the CustomFileControlsEvent replace the "customControls" hook option, which is therefore only available for type "inline". Further notable changed: - Superfluous field "table_local" is removed from "sys_file_reference" - ExtensionManagementUtility::getFileFieldTCAConfig() is deprecated - Placeholders are introduced for common image/media/file types - File extension filtering is now done automatically in FormEngine and DataHandler Executed commands: composer u typo3/cms-styleguide Resolves: #98479 Releases: main Change-Id: Ie7a14e8cef444816d3c1844df43e6c0c93706d5d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75916 Tested-by:
-
- Oct 01, 2022
-
-
Markus Klein authored
Due to the improved strictness of the API the query methods logicalAnd and logicalOr required at least two parameters. This is very inconvenient for developers and force the same boilerplate code to be present in almost all extensions using array decomposition like: ->logicalAnd(...$constraints) Prevent this situation by adding dummy-conditions inside the methods to fulfill the interface's contracts. As it is impossible to add straight conditions like "1=1" directly from within the Query object, the solution is to use conditions based on the "uid" field. Resolves: #98415 Related: #96044 Releases: main Change-Id: I824ef076b3e0dfbeb6701965f71d3c7df9c70cd8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75836 Tested-by:
-
- Sep 29, 2022
-
-
Benni Mack authored
This change uses the core UriBuilder and LinkFactory (FE) for creating links in f:link.page and f:uri.page to avoid booting up Extbase when using f:link.page in non-Extbase Fluid context. Resolves: #98474 Releases: main Change-Id: Iec0e09af01dae0bb11bf62cee5f03be50e25352d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75808 Tested-by:
-
- Sep 26, 2022
-
-
Larry Garfield authored
Sets return types for most classes that implement PHP SPL classes. Only "mixed" return types are not set: That would be hard breaking for extensions that support both core v11 and v12, since it is not PHP 7.4 compatible. Those places are marked with an @todo to switch to mixed in v13. Resolves: #98035 Releases: main Change-Id: Icd62a69270a6718c8356108e55a0729779609c53 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75310 Tested-by:
-
- Sep 21, 2022
-
-
Benni Mack authored
Due to cleanups some, usages of Extbase's Request and UriBuilder can be removed. Resolves: #98398 Releases: main Change-Id: Ifac91344c404d5e1d3beee2ec882da2de309d61e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75806 Tested-by:
-
