Skip to content
Snippets Groups Projects
Commit 7fad0349 authored by Benni Mack's avatar Benni Mack Committed by Stefan Bürk
Browse files

[BUGFIX] Ensure proper encapsulation of comparisons with QueryBuilder

When using a TCA table without deleted, or any other enablefields
except "endtime", then the SQL query is built in a wrong fashion
both in PageRepository and BackendUtility. Thee source of this disaster
is inproper encapsulation in parenthesis when comparisons are build.

Instead of simply adding a manual "()" around the or() comparisons,
this change adjusts CompositionExpresion to properly add corresponding
parenthesis, which ensure this in every case and avoid missing usages.

A couple of tests are adjusted to properly reflect this change.

Resolves: #89616
Releases: main
Change-Id: I4aed140cbca5b4b40dfacd459a4c3aa30549b582
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76481


Tested-by: default avatarcore-ci <typo3@b13.com>
Tested-by: default avatarBenni Mack <benni@typo3.org>
Tested-by: default avatarSusanne Moog <look@susi.dev>
Tested-by: default avatarStefan Bürk <stefan@buerk.tech>
Reviewed-by: default avatarBenni Mack <benni@typo3.org>
Reviewed-by: default avatarSusanne Moog <look@susi.dev>
Reviewed-by: default avatarStefan Bürk <stefan@buerk.tech>
parent 29f3d83f
Branches
Tags
No related merge requests found
Showing
with 225 additions and 66 deletions
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment