- Jul 11, 2024
-
-
Benni Mack authored
This change adds a new fixture extension with a content element with a relation to an inline table. Resolves: #104369 Releases: main Change-Id: I777d5dbdebaad4f278bab2dc2b87ebd92f331515 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85227 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
-
Simon Schaufelberger authored
Add test coverage for GeneralUtility::getFilesInDir with sorting by mtime. Resolves: #103817 Releases: main Change-Id: I298f63fef0369cf2fefd0876628ca55a152947c9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84190 Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Benjamin Kott authored
We replace the default bootstrap `text-<color>` utility CSS classes with an own color-scheme aware implementation. In contrast to the original bootstrap color utilities we ensure that the new set is accessible and optimize the color contrast for all values. This results in darker colors for light-mode and lighter colors for dark-mode. Resolves: #104362 Releases: main Change-Id: I8e36394435aa523069aad784f54b632bff489eb8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85223 Reviewed-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
-
Jasmina Ließmann authored
Over time, EXT:stylguide has expanded its range of functions. To clarify the separation between styles and components, as well as the functionality of creating example page trees, the contents of the backend module "Styleguide" are divided into submodules. Resolves: #104358 Releases: main Change-Id: I9548567265633b66da3fadd4f0f5b07f39f79ae8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85186 Reviewed-by:
-
Benjamin Kott authored
The callout component is now using the unified surface colors. The new callout styling is now context aware and adapts to light and dark color schemes. Resolves: #104359 Releases: main Change-Id: I8299aa0fde12aa41acae58a53eea3d00f3ed13ec Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85222 Tested-by:
-
Andreas Nedbal authored
This patch removes the Bootstrap "card" component as the cards present in the Backend are implemented using the classes and styling of TYPO3. The conflict comes from a time in which Bootstrap (3.x) only had panel-* classes and for the new card component the classes were modelled after Bootstraps naming scheme. This did not end up matching what Bootstrap implemented finally, causing confusion within some developers when using cards in the backend. Resolves: #99233 Related: #94529 Releases: main Change-Id: Ia1bf1f453310cc452059ec9396c2f54be87c2150 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76870 Tested-by:
-
Benjamin Kott authored
We are dropping the Bootstrap CSS definitions for badges to have more control about the styling of the badges. From now on we are shipping custom css adapted to our needs. The new badge styling is context aware and adapts to light and dark color schemes. Resolves: #104356 Releases: main Change-Id: I4a449feb4a4dc0bc32664d99fabd453fa969ddd4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85219 Reviewed-by:
-
- Jul 10, 2024
-
-
Andreas Kienast authored
The class `TypoScriptReferenceController` used by our code editor get some minor updates: * Removed unneded `$xmlDoc` property * Added missing type declarations * Resolved open @todo Resolves: #104352 Releases: main Change-Id: Iee855f7cf1f2f3fac80ba4f9482473d08420257c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85216 Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Reviewed-by:
-
Benjamin Kott authored
We are dropping the Bootstrap CSS definitions for buttons to have more control about the styling of the buttons. From now on we are shipping custom css adapted to our needs. The new button styling is context aware and adapts to light and dark color schemes. Resolves: #104350 Releases: main Change-Id: Id6a08557d6414f08cb213420db2a60e70ff4be08 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85150 Reviewed-by:
-
Oliver Bartsch authored
Toggling the visibility of the new alert element, introduced with #103699, does actually lead to changing the `opacity` property. Therefore, the corresponding space of the alert element will stay, leaving empty spaces in the backend. This is now resolved by additionally toggling the `hidden` class, which works with the `display` property. Note: The `show` class has to stay due to the underlying functionality from the used bootstrap component. Resolves: #104346 Related: #103699 Releases: main Change-Id: Id85da0972be02b43ef78f79fd1118d74e8ff1662 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85213 Tested-by:
Marcin Sągol <marcin@soee.pl> Reviewed-by:
-
Daniel Siepmann authored
PHP will cast array keys to int if they are valid integers. The code applies htmlspecialchars() on the keys. The function expects a string as first argument, which wouldn't be the case if the actual value would be an int. Therefore the key is casted to a string within the function call to prevent TypeError. Resolves: #104341 Releases: main, 12.4 Change-Id: Ic9aef0fd37f2e883a2a8fa626cfda2e813e3b289 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85190 Tested-by:
-
Garvin Hicking authored
With the introduction of the new filelist functionality, the list view of folders no longer showed their last modification timestamps. Without this information, the list view could no longer sort the whole item list by date. With this patch, the information is now fetched not only for files, but also for folders. Folders and files are sorted on their own, so no file will be sorted in between a list of folders (and vice versa). (Note that for filesystem folders there is only one timestamp, so "last modified" and "created at" will use the same timestamps. Remote folders with their distinct drivers may provide distinguishable information.) Resolves: #100520 Releases: main, 12.4 Change-Id: I4e9ceb597946cc7532b76ec2ee4bec3d52d17fdc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85158 Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Tested-by:
-
Marcin Sągol authored
A new web component called `<typo3-backend-alert>`, which is based on the Bootstrap alert component, is introduced. It will be used to streamline the use of this component through backend code. The web component can therefore be used in any JavaScript module or directly in HTML markup. This is the first step towards unifying the alert, notification, and callout components in the backend. These components share a lot of common logic and should therefore have a common ancestor. Note: The new component might receive further changes in the future and is therefore introduced as internal for now. Resolves: #103699 Releases: main Change-Id: Ie31ef032ad1d3bb28553f518eff0a7673b53257d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84535 Reviewed-by:
-
Andreas Kienast authored
The flatpickr integration in TYPO3 is configured to use luxon for date time formatting operations, which consumes different format tokens. This leads to the situation that aria labels generated by flatpickr are now broken. This commit changes the option `ariaDateFormat` to luxon's `DDDD` token, which renders a "localized date with full month and weekday", according to [1]. [1] https://moment.github.io/luxon/#/formatting?id=table-of-tokens Resolves: #104342 Releases: main, 12.4 Change-Id: I7902d39209ad59e0c3196db7f906b93533d7b7cf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85191 Tested-by:
-
- Jul 09, 2024
-
-
Christian Kuhn authored
The patch level release brings PHP 8.4 compat. Core v12 and v11 will have dedicated patches. > composer req lolli42/finediff:^1.1.1 > composer req --no-update -d typo3/sysext/core lolli42/finediff:^1.1.1 Resolves: #104339 Releases: main Change-Id: I6521f8d8fddce1d10d97350d4c6128de026df120 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85183 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
-
Christian Kuhn authored
* Inject service dependencies * Clean up doc headers * generate() can return string|int over string only to create better typed DB values up front * Various further minor type improvements * readonly classes where possible Resolves: #104336 Releases: main Change-Id: I2cda858d30b70d527f4024bce8c3e95b6176679e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85146 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Mogens Fiebrandt <mogens.fiebrandt@googlemail.com> Tested-by:
-
Andreas Kienast authored
The date time picker module `@typo3/backend/date-time-picker` uses flatpickr, but wasn't aware of it due loose `any` usages. The code is modified to make use of the typings shipped with flatpickr. To solve this long-standing issue, the module identifier is changed from `flatpickr/flatpickr.min` to `flatpickr`, which requires an additional entry in the `JavaScriptModules.php` configuration, but allows to remove a module declaration. Resolves: #104338 Releases: main, 12.4 Change-Id: I3feed53627c639e21e4812855fd4ce2defe91c14 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85182 Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
-
Benni Mack authored
This change adds native PHP types to RelationHandler. The reasoning for the changes: - Even though some properties are public and not typed, setting an array property to null will fatal if Relation Handler already expects an array access - Some methods do not get full types, as some options can be string/int etc, whereas $tableName must be a string in any case, where a type is applied. This is a pre-patch as part of a bigger change in order to bring TcaSchema API and Record API into RelationHandler. Resolves: #104334 Releases: main Change-Id: I66c6ae10858d6a2bb37ee03792e191b755bd1968 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85105 Reviewed-by:
-
Stefan Bürk authored
This change adds PHP8.4 as allowed version to the `Build/Scripts/runTests.sh` script as preparation to validate and check the Core and 3rd party libs with PHP8.4 locally. Note that unit tests already revealing deprecation and errors for 3rd party extension which can now be reported and for checked upstream updates. Resolves: #104337 Releases: main, 12.4, 11.5 Change-Id: I76d3e37b393c347173fcdbe874d6a0737fb76d33 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85178 Tested-by:
-
Anja Leichsenring authored
Port the duplicate exception code integrity check into the PhpParser based integrity suite. This allows for improvements compared with the older regex based search, that missed quite some occurences. We can now detect non-standard parameter position, named arguments and also missing exception codes. Resolves: #104275 Related: #103465 Releases: main Change-Id: Ifcb1176b6803108a2c1668f090039fb0627d7d4e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85033 Reviewed-by:
-
Daniel Siepmann authored
The menu generation must not reuse the page record from the current page but must use the data from the linked page. This got already fixed for #101883. But that fix didn't take into account that ->createLink() might throw an exception. This is now considered and the state is properly re- initialized also on exceptions. Resolves: #104335 Related: #103582 Related: #101883 Releases: main, 12.4 Change-Id: Ib4c1f1fba68a83dca32a9ffd7ee14c31cf60bab5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85175 Tested-by:
-
Christian Kuhn authored
DiffUtility has the unfortunate property `$stripTags`, making this tiny service stateful. This service should not `strip_tags()` on its own, consumers should, if needed. The patch adds a new method `diff()`, that does not strip tags anymore and deprecates the property and method `makeDiffDisplay()`. Resolves: #104325 Releases: main Change-Id: Ib6705816bf1547bc2a54eb5bb364fdcde4c10ea9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85141 Reviewed-by:
-
Andreas Kienast authored
This commit fixes the event binding on the "Close" and "Save" actions to trigger the correct actions when e.g. the icons within the buttons are clicked. Resolves: #104333 Releases: main, 12.4 Change-Id: I448c0b68de376a1b0e8517cc58c5bf2d2576b662 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85152 Tested-by:
-
- Jul 08, 2024
-
-
Loek Hilgersom authored
Fixes exception in impexp when an extension does not have a value for TCA[tableName][ctrl][rootLevel] Resolves: #104308 Releases: main, 12.4, 11.5 Change-Id: Ia2b8095c35ba6b07827525a65e0dcbb6fa1d060e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85104 Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Tested-by:
-
Benjamin Franzke authored
Version 7.15 officially supports TypeScript 5.5, which we use since #104189 and therefore eliminates a build-time warning. Also update TypeScript from 5.5.2 to 5.5.3, while at it. Executed commands: npm install --save-dev \ @typescript-eslint/eslint-plugin@^7.15 \ @typescript-eslint/parser@^7.15 \ @typescript-eslint/typescript-estree@^7.15 \ typescript@^5.5.3 npm run build-js Resolves: #104317 Related: #104189 Releases: main, 12.4 Change-Id: Ibe242b42ecf9c5e986217a85283174220ae18bc3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85135 Reviewed-by: -
Benjamin Kott authored
With this patch, we are introducing color tokens for use across the system. These tokens are provided as CSS variables. We generate the tokens by starting from a base value and modifying the luminance, rather than shading or tinting the current color. This approach ensures a consistent color scheme. Additionally, we are providing new surface variants for the general states used in the backend, such as primary, secondary, danger, and success. These will be used in components and will back utility classes like `.bg-<color>` and `.text-bg-<color>`. Resolves: #104315 Releases: main Change-Id: If39719eb23e1adf5ddb67c37380f47ed6627b968 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85132 Reviewed-by:
-
- Jul 07, 2024
-
-
Christian Kuhn authored
With TCA changes from #104311, l10n_source in styleguide is now configured as type=passthrough just like everywhere else. This needs a bit attention in styleguide data generator to create "int'ish" values, or postgres stumbles during insert. Resolves: #104327 Related: #104311 Releases: main Change-Id: I1a95f64d5f0db06c2f72c063128fe607134f3429 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85145 Tested-by:
-
Christian Kuhn authored
TcaSchemaFactory can avoid more class state: RelationMap is only used during building and can be hand around instead of parking it on $this. Resolves: #104326 Related: #104002 Related: #104322 Releases: main Change-Id: I2ccf2b816506276a7676a6a9dc0435e8a01eb078 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85143 Reviewed-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Reviewed-by:
-
Garvin Hicking authored
Similar to #104228 there was another place where the 'actiontype' array key of a history record was checked for 'BE' context, instead of the proper 'usertype'. There should now be no more remaining instances of core usage for 'actiontype' with a 'BE' check. Resolves: #104314 Related: #104228 Related: #98024 Releases: main, 12.4 Change-Id: I1833929d16ecef937ba260fe498e9abdee94b9c9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85133 Tested-by:
-
Jasmina Ließmann authored
Skip the "edit" pen icon in workspace BE module when the record is a "delete placeholder" (marked for deletion in workspaces). Such a record can not be edited and leads to an error view. Resolves: #104324 Releases: main Change-Id: I12f89e8deaee8aad8b0cbc4017d34bf17823cea1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85142 Tested-by:
-
- Jul 06, 2024
-
-
Christian Kuhn authored
TcaSchemaFactory can avoid more class state: TCA is only used during building and can be hand around instead of parking it on $this. This avoids this rather huge array being attached during entire runtime. Resolves: #104322 Related: #104002 Releases: main Change-Id: Ifcf3feb99475ef4a834654362feabb74aaf01265 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85140 Tested-by:
-
Christian Kuhn authored
This patch adds a layer to the "load and create final TCA" process. When "base" TCA files in 'Configuration/TCA' define 'ctrl' capabilities like 'languageField=sys_language_uid', these fields need according 'columns' definitions. The core now adds default definitions of such columns if they do not exist after loading 'Configuration/TCA' files, and before loading 'Configuration/TCA/Overrides' files. Developers no longer need to define such columns and can rely on core adding them, if a capability is enabled in 'ctrl'. There are two advantages: First, it adds a level of control for these columns away from extensions to the core, which is good for future development in this area. Secondly, extension developers no longer need to take care of nasty configuration details of these columns and can remove lots of boilerplace TCA definitions that had to be maintained manually before. The patch shows this: About 6000 lines of TCA definitions can be removed. These colummn are now handled automatically: * ['ctrl']['enablecolumns']['disabled'] - typically set to "disabled" or "hidden" * ['ctrl']['enablecolumns']['starttime'] - typically set to "starttime" * ['ctrl']['enablecolumns']['endtime'] - typically set to "endtime" * ['ctrl']['enablecolumns']['fe_group'] - typically set to "fe_group" * ['ctrl']['editlock'] - used less often, typically set to "editlock" * ['ctrl']['descriptionColumn'] - typically set to "description" * ['ctrl']['languageField'] - typically set to "sys_language_uid" * ['ctrl']['transOrigPointerField'] - typically set to "l10n_parent" * ['ctrl']['transOrigDiffSourceField'] - typically set to "l10n_diffsource" * ['ctrl']['translationSource'] - typically set to "l10n_source" In the backend, this patch streamlines a couple of details, by for instance using the same / default label in all situations. There are a couple of specific overrides to deviate from defaults now defined by core. For example, new "pages" should be disabled=1, but the default "disabled" columns definition does not set disabled=1. "pages" thus overrides the core default in a Configuration/TCA/Overrides file. A couple of tests have a dependency to the order of columns in TCA, and need minor as well. Some code in TcaPreparation is now obsolete, together with a functional test. Resolves: #104311 Related: #104288 Related: #88057 Releases: main Change-Id: I155a96163d75cf6692ae23ea96656285895d1c36 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85095 Tested-by:
-
Marcin Sągol authored
The `tables_select` and `tables_modify` lists have the same items listed, so instead of managing them through separate views, the merges them into a single view. The new (merged) table renders the three options "No Access", "Read" and "Read & Write" for each table. Those options are accompanied by the multi record selection options to "Check All", "Uncheck All" and to "Toggle Selection". To render this new table view and handle its behavior, a dedicated form renderType `tablePermission` is introduced, which is now set for the `tables_modify` column. The `tables_select` column has been changed to TCA type `passthrough`. The new form element is defined through: `\TYPO3\CMS\Backend\Form\Element\TablePermissionElement`. It uses a dedicated data provider defined in: `\TYPO3\CMS\Backend\Form\FormDataProvider\TcaTablePermission`. The JavaScript code is handled by a new web component: `@typo3/backend/form-engine/element/table-permission-element.js`. When the TcaTablePermission data provider handles the configuration, it reads table lists from both the `tables_select` and `tables_modify` columns and combines them into a single array with unique table names. Resolves: #103521 Releases: main Change-Id: Iae468d9209d346ef09fd34053cdcd2d1a8ef1f2c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83743 Reviewed-by:
-
Anja Leichsenring authored
This reverts commit 4b4586e1. Reason for revert: see post -1, we are going to resolve the issues rather than trying to fix the situation. Change-Id: Icc7d79443d1e4b348c6416ae24d5aef500a711d6 Resolves: #104313 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85114 Tested-by:
-
- Jul 05, 2024
-
-
Andreas Nedbal authored
Resolves: #104313 Releases: main Change-Id: I17bb0ab444ef180434847a03561aac0414c7af27 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85111 Reviewed-by:
-
Benni Mack authored
This change reduces BackendUtility calls in DataHandlerHook of EXT:workspaces towards complete TcaSchema usage. Resolves: #104307 Related: #104002 Releases: main Change-Id: I161325bc62d91e91fef6d75618628cb85fabf983 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85099 Tested-by:
-
Oliver Bartsch authored
The debug information of each element in FormEngine now displays the correct field names for FlexForm fields in a container. Additionally, do the container elements itself display the correct (field) name now. Resolves: #104303 Releases: main, 12.4 Change-Id: Ic2a92bc0deea4b3165f4aa77103c56050cb3dc63 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85096 Tested-by:
-
- Jul 04, 2024
-
-
Benjamin Franzke authored
The cache.assets container entry was pregenerated in Bootstrap for historic reasons: it used to be statically injected into the IconRegistry and PageRenderer from Bootstrap::init(). This has been refactored with #93475 and #97030, therefore assets cache generation can now be delayed until it is actually needed. Note: It is needed in uncached installtool context, therefore it is provided in ServiceProvider.php instead of Services.yaml Resolves: #104305 Related: #93475 Related: #97030 Releases: main Change-Id: I3a0f1a5b6f01ed19da79d2547b418029d68bf0f1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85102 Tested-by:
-
Guido Schmechel authored
An example for the addition of multiple CSS classes to editor.config.style will be added to the existing RST files. Resolves: #104310 Releases: main, 12.4 Change-Id: I8a77aae8c402608857b3b7ea690da23f4f8134c6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85107 Tested-by:
Torben Hansen <derhansen@gmail.com> Reviewed-by:
-
Benni Mack authored
The method getTcaFieldConfiguration is the first to fall in BackendUtility as we now have a new API for accessing information from TCA. The last pieces have been migrated. Historical fun fact: This method was introduced with TYPO3 4.x to add support for IRRE in Workspaces in 2010 by ohader: "Add feature #16374: Implement Inline Relational Record Editing (IRRE) in Workspaces" Kudos for this tremendous effort. Resolves: #104304 Related: #104002 Related: #16374 Releases: main Change-Id: I5c38592777ca4ee64e5a9155e338e17322ae452c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85100 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
