- Sep 15, 2021
-
-
Stefan Froemken authored
DebugUtility threw warnings of the type "Undefined array key" which results in error for uncached content in frontend. This warning is fixed in this patch. Resolves: #95211 Releases: master Change-Id: I692f88e1cf123003bfdbef4f8303c41fab855f01 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71079 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Oliver Bartsch authored
The edit permissions for linked live search suggestions, shown in the the dropdown layer, were previously not properly evaluated. This is now fixed. In case a user does have insufficient edit permissions for a live search suggestion, it won't be linked anymore. Resolves: #95052 Releases: master, 10.4 Change-Id: I84f7beeae8be62d275236779b993bbbf380fb835 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71050 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
-
Christian Kuhn authored
The BackendTemplateView is a - usually Extbase backend module related - Fluid view that adds a default backend ModuleTemplate to render backend module content. That implementation has a couple of drawbacks: * Using BackendTemplateView hides a dependency to the request object by triggering a fallback in ModuleTemplate accessing $GLOBALS['TYPO3_REQUEST']. * Using $this->view->getModuleTemplate() is pretty ugly, controllers should work with the ModuleTemplateFactory instead and retrieve an instance of ModuleTemplate using create($request). * The level of indirection by having ModuleTemplate within the view class magically created makes controller actions harder to follow and understand. With extbase Request nowadays implementing ServerRequestInterface we can get rid of this indirection: Controllers should get an instance of ModuleTemplateFactory injected, receive the ModuleTemplate using ->create($request), and add further title and doc header related details using that instance. The patch changes ext:indexed_search, ext:extensionmanager and ext:form to do that, and deprecates BackendTemplateView. Change-Id: I613a560c8fc3c35343e31f397479f0c008a4a314 Resolves: #95164 Related: #92513 Related: #94428 Related: #94209 Related: #93885 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70973 Tested-by:
-
Andreas Fernandez authored
To give extension authors the possibility to react on drag&drop events happening in the page module, AjaxDataHandler now emits the `typo3:datahandler:process` event. Resolves: #95069 Releases: master, 10.4 Change-Id: I07956357afa301e77b1bed033113bd8b9dca662d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70859 Tested-by:
Stefan Froemken <froemken@gmail.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Sybille Peters authored
Previously, the pagination controls were sometimes shown on the bottom of the page and sometimes on the top and the bottom (e.g. EXT:form, EXT:redirect). The pagination controls are now only shown on the bottom. This adds more consistency to the user interface. Resolves: #95192 Releases: master Change-Id: Id724a26b4fcb978182160036694b764adc275bc1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71077 Tested-by:
Rachel Foucard <rfoucard@w-seils.com> Tested-by:
Jonas Eberle <flightvision@googlemail.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
- Sep 14, 2021
-
-
Simon Schaufelberger authored
Remove identical like in hasProtocolAndSchemeDataProvider Resolves: #95215 Releases: master Change-Id: I5341667f5984b1044c375ee42a076fea50aea6ea Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71085 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
Oliver Klee authored
This change helps static code analyzers like PHPStan or Psalm. Resolves: #95104 Releases: master, 10.4 Change-Id: I3c5900e57116c3e4e2ba8542a6c0471a372504f8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70886 Tested-by:
crell <larry@garfieldtech.com> Tested-by:
Rick Septer <rick.septer@maxserv.com> Reviewed-by:
-
Oliver Hader authored
In issue #75657 `onFocus` has been purged from `FormEngine` - purging from JavaScript class `SelectSingleElement` has been forgotten. Resolves: #95214 Related: #75657 Releases: master Change-Id: I2e2be48a924bf2e9babd7f561e2ffbbe1eead3d9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71080 Reviewed-by:
-
- Sep 13, 2021
-
-
Christian Weiske authored
Releases: master Resolves: #95208 Change-Id: I852fbdc1d34afb819798cb93b2bb2f2b05e7a082 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71051 Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Reviewed-by:
-
Tina Westner authored
isSubmenu() produces different results depending on the includeNotInMenu setting, Therefore we need to use separate cache entries. Resolves: #95043 Releases: master, 10.4 Change-Id: I34bdeb1a25606998e07ce2dc8aa366045dc3eefa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70828 Tested-by:
Tina Westner <tina.westner@bgm-gmbh.de> Tested-by:
Peter Kraume <peter.kraume@gmx.de> Tested-by:
-
Helmut Hummel authored
Drop usage of getenv('TYPO3_PATH_COMPOSER_ROOT') and use Composer provided runtime API to determine the path of the root package. This mitigates thread unsafety at least for packages, which is more prevalent than other getenv usages, that exist in TYPO3 already. These should be tackled in subsequent changes. Resolves: #95171 Related: #94996 Releases: master Change-Id: I7e45aaf72d24ac3575488b708220ba754cc131e6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71075 Tested-by:Benjamin Franzke <bfr@qbus.de> Tested-by:
-
Anja Leichsenring authored
The files grow ever larger when repeatedly executing splitAcceptanceTests.php. Deleting them before they are written for the current run resolves the problem. Resolves: #95196 Releases: master, 10.4 Change-Id: I175e486af001307bc99f5879dbc59f9a11c3d69b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71038 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
-
Helmut Hummel authored
Similar to #95027 FAL public URLs are now automatically prefixed with absRefPrefix, making it much easier for developers to deal with FAL URLs, as these URLs are always "complete" / path absolute, after retrieving it from getPublicUrl() With that, TYPO3 code can be simplified as well and separate appending of absRefPrefix for FAL resources is now removed. Releases: master Resolves: #95027 Related: #95027 Change-Id: I614f0ad8ecb9c168d3006a812dbfe9fba6b7de51 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70839 Tested-by:
Helmut Hummel <typo3@helhum.io> Reviewed-by:
-
Torben Hansen authored
Resolves: #95205 Releases: master, 10.4 Change-Id: Ibee44bc384105955248ef7dff04b1c1ec96b8d2b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71049 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
-
Anja Leichsenring authored
Testing for visibility of 'Admin Tools' requires the TYPO3 instance to be set to Development context, or the user to be system maintainer. Both requirements are not in the scope of the Acceptance Test in question, so the better choice of test is something in its context. A backend user having set the admin flag (which is part of the be_users DB table and therefor within the setup responsibility of the test in question) sees the 'System' section in BE modules, while an editor user does not. Resolves: #95193 Releases: master, 10.4 Change-Id: I93ccac0673e95723df378079a2465fddb4327571 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71036 Tested-by:
-
Oliver Bartsch authored
In case a paginated listing does only contain records for one page, the pagination controls do not make any sense and will at worst just confuse editors. This patch therefore adds consistency to the backend modules by only showing pagination controls if the number of paginated pages is greater than one. Resolves: #95092 Releases: master Change-Id: I3cf45ffa194d5a925df26be4f6e144dbe8f4df04 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71016 Tested-by:
Sybille Peters <sypets@gmx.de> Tested-by:
-
Alexander Nitsche authored
Some EXT:impexp functional tests threw warnings of the type "Undefined array key" which did not abort the test but were written unnoticed to the TYPO3 logs. These warnings are fixed in this patch. Resolves: #94972 Releases: master Change-Id: I0e4f3558cd12ef49ae6dc071edd67cd2621dbc2f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70741 Tested-by:
-
Jonas Eberle authored
git stores files either 0664 or 0775. Script checkFilePermissions.sh is improved to deal with that. Resolves: #95203 Releases: master Change-Id: I49ede03ac7e1180621c497081e463d8c617250b3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71046 Tested-by:
-
Helmut Hummel authored
The root package is now always considered as TYPO3 package. The "ignore-as-root" flag and the exclusion of root packages in general was only introduced to allow integration testing setups of extensions with public resources. For such a scenario to work properly, the testing framework introduced \TYPO3\TestingFramework\Composer\ExtensionTestEnvironment to be included as composer autoload hook, which symlinks the root path inside the typo3conf/ext folder. This exact behaviour is now introduced in TYPO3 directly, making it possible to always consider the root package for TYPO3, and obsoleting the double negative "ignore-as-root" flag. Releases: master Relates: #94996 Change-Id: Ib033b7634736f5f201b55ad374943cb10dafa0a6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71029 Tested-by:
-
Oliver Bartsch authored
With #90548 the filelist module has been extended for the possibility to download files and folders. Since file download might not be enabled for all users, or should at least be limited to a set of file extensions, this patch adds the necessary configuration options. It's therefore now possible to either specify allowed / disallowed file extensions or to completely disable the file download. In case the download can not be prepared due to no valid files were found, the user receives a notification. Resolves: #95113 Related: #90548 Releases: master Change-Id: Ifc4b4a5cd4ac8cb49b14e8eb6239ece37596e7e4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71013 Tested-by:
-
Benni Mack authored
This change uses the existing session information (moduleData[browse_links.php][expandFolder]) to read and write the last opened folder not just for the File Browser (as currently used) but also the file link handler. Resolves: #73195 Releases: master Change-Id: I7957325599407333486898d5538247d452c7af18 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70959 Tested-by:
Susanne Moog <look@susi.dev> Reviewed-by:
-
- Sep 12, 2021
-
-
Wouter Wolters authored
composer req --dev codeception/module-webdriver:^1.4.0 composer req --dev composer/package-versions-deprecated:^1.11.99.3 composer req --dev friendsofphp/php-cs-fixer:^3.1 composer u phpunit/phpunit phpspec/prophecy Resolves: #95195 Releases: master Change-Id: I66ef7d9ebf32b79fe7640e91e8fc791a079de193 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71037 Tested-by:
-
Christian Kuhn authored
Since moving to gitlab, script checkFilePermissions.sh was inactive due to a gitlab detail that leads to funny permissions of cloned files. This can be suppressed with a gitlab feature toggle. The patch activates that toggle, activates the test script and fixes a couple of files that slipped in with broken permissions meanwhile. Change-Id: I2b0fdca282dbc39fe230b33910a690118a21b74e Resolves: #95194 Releases: master, 10.4, 9.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71033 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
- Sep 11, 2021
-
-
Christian Kuhn authored
We're delivering a "test distribution" composer.json in Build/composer since #94996. The patch adds "runTests.sh -s composerTestDistribution" that "composer update" this project and adds it to pre-merge and nightly integrity suite. This verifies core dependencies are fine at all times. Main difference to the monorepo: This composer setup has no dev dependencies that influence version decisions. Resolves: #95188 Related: #94996 Releases: master Change-Id: I04084a2a44a69903d523b5c4740d62d7dc46c1f1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71030 Tested-by:
-
Richard Haeser authored
Check if the right status code is added to the header of a redirect. Furhtermore check if the current available status codes can be selected when creating a new redirect in the backend. Releases: master, 10.4 Resolves: #95154 Change-Id: I48bb678ce7ef4de098d545e5cf72cfe2704d4714 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70971 Tested-by:
-
Wouter Wolters authored
composer req --dev phpstan/phpstan:^0.12.98 Resolves: #94839 Releases: master Change-Id: I8ca57073436b695e340aae0e1fd5846e3fdc1271 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70439 Tested-by:
-
Oliver Bartsch authored
The paste buttons in the page layout module are added via a JavaScript component. Since its introduction in #13749, a lot has changed. For example, the Paste component always tried to remove a duplicate declaration of `t3js-page-ce`. However this duplicate class does no longer exist since #85911. Therefore, this code is now removed. Initially the Paste component also checked for an element with class `.icon-actions-document-new`. This was then later changed to check for the class `.t3js-toggle-new-content-element-wizard`. This then resulted in the paste buttons were no longer added as soon as the "New content element wizard" had been turned off. It has to be assumed that this check was initially introduced as a kind of permission check. "No content button > user does not have permissions". On one hand this doesn't look sufficient, on the other hand, this is superfluous since the wrapper class `.t3-page-ce-wrapper-new-ce`, on which the component iterates, is only present if the user has the required edit permissions (at least in fluid based page module). For the PageLayoutView, this would also fail, since `top.pasteAfterLinkTemplate` and `top.this.pasteIntoLinkTemplate` are not available in case of insufficient permissions. In the end, this check is removed, making pasting possible again, in case "New content element wizard" is disabled. Resolves: #95117 Releases: master Change-Id: I48fa4b990a6367d8700b3b7d3c292eb49ad89ab4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71012 Tested-by:
-
Torben Hansen authored
Since #94057, ['offlineMode' => false] is added to the settings array in ActionController by default. This has most likely been added by mistake, since it is not used in extbase but in ext:extensionmanager. This patch removes the default 'offlineMode' setting in extbase and ensures, it is always defined in ext:extensionmanager. Resolves: #95187 Related: #94057 Releases: master Change-Id: Id43ea5b4ea598f374193e9119aad1397e9e4aef8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71028 Tested-by:
-
Wouter Wolters authored
Resolves: #94986 Related: #94280 Releases: master Change-Id: Ia03641edf7d0174f68b539cb2d2c6ec502d5da45 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70748 Tested-by:
-
Christian Kuhn authored
Minor refactoring of ExportCest to prevent some not needed page tree operations in exportRecord() may stablize that test further. Resolves: #95182 Releases: master Change-Id: I1d07669e47f01c191b25cc2e06f7814c254d98a8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71022 Tested-by:
-
Wouter Wolters authored
Resolves: #94790 Releases: master Change-Id: Ic68f3db121d07013d7d46f143f55694fcba91cde Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70407 Tested-by:
-
Roman Büchler authored
Strictifies the following extensions: - EXT:dashboard - EXT:extbase Resolves: #94897 Releases: master Change-Id: I1cb8c2ebdc4c0c73a26754163e99f5bffd0520a3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70632 Tested-by:
-
Roman Büchler authored
Resolves: #94867 Releases: master Change-Id: Ibb0f7aefcdcf7b2fffd5b181287befaf8ee20074 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70543 Tested-by:
-
Wouter Wolters authored
The following core extensions are handled: EXT:frontend Resolves: #94908 Releases: master Change-Id: I6d2191f7f649756ecc12bd4bf2e1faa8837ba971 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70642 Tested-by:
-
Roman Büchler authored
Resolves: #94879 Releases: master Change-Id: I4b96ad0ed03f6089c391fb3bd3e967878aaa1ea2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70593 Tested-by:
-
Wouter Wolters authored
The following dependencies are missing from main composer.json Add them. * doctrine/event-manager * psr/http-server-handler * guzzlehttp/promises composer req doctrine/event-manager:^1.0.0 --no-update composer req psr/http-server-handler:^1.0 --no-update composer req guzzlehttp/promises:^1.4.0 --no-update composer req doctrine/event-manager:^1.0.0 -d typo3/sysext/core/ --no-update composer req psr/http-server-handler:^1.0 -d typo3/sysext/core/ --no-update composer req guzzlehttp/promises:^1.4.0 -d typo3/sysext/install/ --no-update composer u --lock Resolves: #95142 Releases: master Change-Id: Ibb17d9bb6d752ad1921b4bae36f774a92ea5932d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70793 Tested-by:
-
Nikita Hovratov authored
$rowsByLang[0] is not set, if editing a content element without a language source. A check for existence is added to prevent warnings in PHP 8. Resolves: #95059 Releases: master Change-Id: I200175d4127d8925973022c6b3eed86ce1f575b9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70846 Tested-by:
-
Christian Kuhn authored
Brings preparations for PHP 8.1 and some further minor goodies. composer req --dev typo3/testing-framework:^6.11.0 Change-Id: I4e8d4b31a66c7775801d7abb6243e98c00d2833b Resolves: #95185 Releases: master, 10.4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71018 Tested-by:
-
Chris Müller authored
Resolves: #95184 Releases: master Change-Id: I28f194f06890085a9d9297356d83e4027ab80113 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71025 Tested-by:
-
Oliver Klee authored
Also polish the language of the related ReST file a bit. Relates: #94996 Releases: master Change-Id: Id5cc50bcb518db37323bb15602fb56b9ae699861 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71024 Tested-by:
-
