- Apr 22, 2020
-
-
Oliver Hader authored
This change aims to reduce the amount of inline JavaScript by removing `onchange` or `onclick` events and dynamically created JavaScript code/settings. * adjusts invocations of top.TYPO3.InfoWindow.showItem * adjusts low-level inline `onchange` and `onclick` events Both JavaScript modules `TYPO3/CMS/Backend/GlobalEventHandler` and `TYPO3/CMS/Backend/ActionDispatcher` are required to actually handle these new triggers and correpsonding events - that's why they are loaded in `ModuleTemplate` and deprecated `DocumentTemplate`. Resolves: #91117 Releases: master Change-Id: Ie7012445d09c3aee253548cb3057c8e9e4b86809 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64242 Tested-by:
Josef Glatz <josefglatz@gmail.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.o...>
-
Oliver Hader authored
Resolves: #91166 Releases: master Change-Id: Ief1dfff09aba275a11306693cf39ebc71992f5f9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64301 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
Use newer formating, e.g.: * Definition lists for better readability. * Content directive to automatically update local TOC. To not update by hand. * Use short :: for yaml examples. To shorten rst code and make it more readable. * Use option directive to highlight options. * Update intersphinx urls to not trigger redirects. Always use YAML instead of yaml or Yaml. Use inline Fluid example, instead of adding it with another tip. Update Includes.txt to match current state and provide expected css classes and text roles. Resolves: #91137 Releases: master Change-Id: I185c17a80e69b723b292b9c99eddfe4412362f20 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64299 Tested-by:
Daniel Siepmann <coding@daniel-siepmann.de> Reviewed-by:
-
Josef Glatz authored
Resolves: #91164 Releases: master, 9.5 Change-Id: Ida1267d13ad2330945c0efafb00cf8ac1656bc61 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64300 Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
-
- Apr 21, 2020
-
-
Daniel Siepmann authored
Resolves: #91155 Releases: master Change-Id: I8e26f7d9bb0c22dcb00cadc704cf8c61ffaf8c0a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64293 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
-
Daniel Siepmann authored
Resolves: #91163 Releases: master Change-Id: I52c4323f2ef812e87015a203f0e2dbaa5a38a581 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64298 Tested-by:
Christian Eßl <indy.essl@gmail.com> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
-
Christian Eßl authored
The fluidbased page layout refactoring done in #90882 missed two spots, where the no longer existing function getBackendLayout() is called on a GridObject. Resolves: #91162 Related: #90882 Releases: master Change-Id: I7d381fe35a02c4f1464f9c4bb9fc31b27ef02b1d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64297 Tested-by:
-
David Steeb authored
Releases: master Resolves: #91158 Change-Id: I71de97b4b62985e0630d2475523a96d4d7f206ba Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64294 Reviewed-by:
-
Christian Eßl authored
The code block using $scheme is never reached, because there is already an elseif condition further above, that is true for all urls containing ":". The last else block even states in the comment: "special handling without a scheme" Therefore the variable is removed to remove a bit of complexity from the function. Resolves: #90951 Releases: master, 9.5 Change-Id: I2bc9fe0c546cb946fc32789ee384c3c60ac7c1fa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64077 Tested-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Benni Mack authored
Change-Id: Ia7d214d29ca5fd958fd9c8169b2d76578cbeb511 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64292 Reviewed-by:
-
Benni Mack authored
Change-Id: I8f9c86cfb5a9785e6884ebd643127cac91bbbd67 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64271 Tested-by:
-
Thomas Pronold authored
The 'else' part would never be returned in this cases. Used [a-zA-Z0-9]{3,}\)[^(]?\$.*\?\? to find the cases. Care, this brings up false positives as well. Resolves: #91154 Releases: master, 9.5 Change-Id: Ifdb0f75995543c3cc8abeb81aba52e935e9bf9a1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64270 Tested-by:Susanne Moog <look@susi.dev> Reviewed-by:
-
Claus Due authored
Skip creation of the PageLayoutContext in PageLayoutController if the user has no access to the page, or if the ID parameter was malformed. Releases: master Resolves: #91147 Change-Id: Idd73aa7ba5e6b3a2b41429b1887ad8f9d1db45ad Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64259 Tested-by:
-
Benni Mack authored
ZipService->extract was introduced for a security patch set but the permissions are not set correctly, as fixPermissions receives a directory with a slash at the end, resulting in "//" for recursive checks. This patch fixes the issue. Resolves: #90417 Relates: #90118 Releases: master, 9.5 Change-Id: Ie56ef6a3781b12c9ac2cf9a859ec226f48691d7f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64267 Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
Danilo Caccialanza <supercaccia@bluewin.ch> Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
-
Andreas Fernandez authored
This commit updates ckeditor to version 4.14.0. This release contains a bugfix for self-XSS'ing the editor: https://ckeditor.com/blog/CKEditor-4.14-with-Paste-from-LibreOffice-released/#security-issues-fixed Command executed: yarn add ckeditor4:^4.14.0 Resolves: #91149 Releases: master, 9.5 Change-Id: I46e2b95773ed0b4fd623a1843ab690a0b596728d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64262 Tested-by:
-
Andreas Fernandez authored
Pasted records use a negative integer to determine their location which is passed as "pid". The DataHandler now resolves the real pid of the records before executing any checks. Resolves: #91144 Related: #89555 Releases: master Change-Id: I10f74542bee5a8a15113731b975580f540748cdb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64257 Tested-by:
-
Anja Leichsenring authored
The changelog files for the version 10.4 must leave the master folder now and move to their final home in 10.4. Resolves: #91106 Releases: master Change-Id: If4b7d5e737b0759592600c06578e6aac3a78f6d9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64269 Tested-by:
-
Benni Mack authored
In order to stabilize this API, all APIs are marked as internal in order to allow changes once Fluid-based page module is stable enough to remove the info in further patch-level releases. Resolves: #91153 Releases: master Change-Id: I26737e5ab89947fdcd7a0bf99c30310fce3b0a3a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64268 Tested-by:
-
- Apr 20, 2020
-
-
Oliver Bartsch authored
The check if a user is allowed to paste content from the clipboard now evaluates the content modify and content edit permissions instead of the page edit permission. This is done in both PageLayoutView and the fluid based page module. Resolves: #90961 Releases: master, 9.5 Change-Id: I65a29a9a6cf4ae4e73af28d1319d0b730fd5f5bd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64105 Reviewed-by:
-
Benni Mack authored
Due to the fact that backend user objects have not been initialized properly in PSR-15 middlewares defining the current in-memory state for workspaces falls back to the users' default workspace. Basically `BackendUserAuthentication::groupData['workspace_perms']` was not initialized which results in the mentioned behavior for non-admin users. `fetchGroupData` was split up into public `initializeGroupData` to be used internally only and protected `enrichGroupData`. Resolves: #90954 Releases: master, 9.5 Change-Id: I75ad15ac600ca489b9951199482e97bcb54d1778 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64264 Tested-by:
Tobi Kretschmann <tobi@tobishome.de> Reviewed-by:
-
Benni Mack authored
Due to the replacment of DocumentTemplate with ModuleTemplate the rendering is now different. In order to overcome this, a new flag enableDocHeader is added. see https://review.typo3.org/c/Packages/TYPO3.CMS/+/63290 Resolves: #90834 Releases: master Change-Id: Ifb278f7dff1c9b1e18b09f7587dbe33caff13732 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64261 Reviewed-by:
-
Oliver Bartsch authored
Remove wrong fourth parameter from the items array as this broke the whole column. Resolves: #91152 Releases: master Change-Id: I07f5a1d3fd3d25fadba88b54581ccbfc52184fb6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64266 Tested-by:
Richard Haeser <richard@maxserv.com> Reviewed-by:
-
Georg Ringer authored
This reverts commit 47e63fc3 because of regressions. Resolves: #89989 Reverts: #88344 Releases: master, 9.5 Change-Id: I1f43d0f343484366e81581435bdb418cfebf317a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62832 Tested-by:
-
Claus Due authored
Provide the correct UID for the "edit record" link which edits the default language page record when page module is in "Languages" mode and the edit icon in top of default language's column is clicked. Releases: master Resolves: #91146 Change-Id: I17c415efdcbf80737d05982ec90a4ac62ce5abea Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64258 Tested-by:
-
Benni Mack authored
This patch prevents throwing and spamming the logs with 500 server errors. Resolves: #91145 Releases: master, 9.5 Change-Id: I9385a9c0a2a665cedb1340cc8397740b0bd6255e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64084 Tested-by:
Frank Nägler <frank.naegler@typo3.org> Tested-by:
-
Claus Due authored
Implements a PSR-14 event dispatched after LocalizationController has built the manifest of columns and column numbers, allowing third parties to change this manifest without XCLASS'ing LocalizationController. Releases: master Resolves: #90945 Change-Id: I5a7929512c498329841c51ceceba7b0d4c156594 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64071 Tested-by:
-
Jonas Eberle authored
This fixes some functional and visual problems in the ChangeLog: * The use of code backticks in a headline was removed as it was also output as <blockquote> on the overview page. * All warnings regarding intersphinx cross-referencing have been fixed. * The unsupported text role :mysql: has been replaced by :sql:. The rest of the warnings seem to come from the build command or will automatically be fixed after the master branching is done: WARNING: unsupported theme option 'show_sphinx' given WARNING: unsupported theme option u'show_legalinfo' given WARNING: unsupported theme option 'use_opensearch' given WARNING: unsupported theme option 'show_revision' given /Documentation/Master.rst:11: WARNING: toctree contains reference to nonexisting document u'Changelog/master/Index' Releases: master Resolves: #91118 Change-Id: I290bf8879bbee66f030a32de45ea765fd40a1b92 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64237 Tested-by:
-
Josef Glatz authored
The option includeNotMenu is set to 1 if the CType menu_section is used to render a section menu for the current page even if the page is hidden in menus (pages.nav_hide). This patch adds also the necessary stdWrap functionality to the abstract class for hierarchical menus. Releases: master, 9.5 Resolves: #91044 Change-Id: I563390b4af36fb26e6a02df237563bdc48293048 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64183 Tested-by:
-
Gerrit Mohrmann authored
When resursive is set, the selected page is now added to the storagePids. Resolves: #91004 Releases: master Change-Id: Idb786c2495dd7ce6e740bc5e198e7bf05a962b5d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64119 Tested-by:
-
Oliver Hader authored
This change aims to reduce the amount of inline JavaScript by moving these parts to dedicated static JavaScript modules or using native HTML functionality instead of location.href. * unused properties in QueryView have been removed * onclick event on a submit button does not have any effect since the onsubmit event is handled first - corresponding code has been removed as well Resolves: #91111 Releases: master Change-Id: I51263b5cd71109d9a28d4edf3cb0b95097aab6b6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64230 Tested-by:
-
Alexander Schnitzler authored
This patch adds an @deprecated annotation to the get method of the ObjectManager class of Extbase. Both the core and users use the object manager directly to create instances of dependencies, often like this: GeneralUtility::makeInstance(ObjectManager::class) ->get(Dependency::class); This is done to create an instance of an object along with it's own dependencies. Using the object manager directly is bad practice. Mandatory dependencies should be injected via constructor injection while optional dependencies may be injected via method and property injection. In both cases however, the underlying object container takes care of the dependency injection. This patch intentionally does not add a trigger_error call as the core itself still is a bad example and uses that technique itself a lot. Version 11.0 will remove all such usages and introduce the trigger_error call for user land code until the object manager is finally removed in version 12.0. Releases: master Resolves: #90803 Change-Id: Ie7d678fbb9c3b3041a17a4216f292035cd4c9b30 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63826 Tested-by: -
Susanne Moog authored
To ensure maximum compatibility, we only enable the new page module for new installations (or by manually enabling the feature flag) not for upgrades. Resolves: #91142 Releases: master Change-Id: I90f75c3caf1dd7447e4e406ee55303694f8f327d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64256 Reviewed-by:
-
Markus Klein authored
Make sure the TSFE fetched in TemplateService really is a valid TypoScriptFrontendController. This way any kind of "fake Frontend" built in Backend does not break the functionality. Resolves: #91139 Releases: master Change-Id: I571130de635f2be79301f747c5b3e1ad40987fec Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64255 Tested-by:
-
Claus Due authored
Refactoring with the goal of: * Restoring entity-like nature of BackendLayout * Decreasing coupling between components of the page module processing and rendering. Implements a PageLayoutContext to hold all context-related objects and methods and passes the context to objects instead of passing the BackendLayout. Reduces number of methods on DrawingConfiguration so the configuration object only holds output- and behavior-related options and does not hold things like permission checks. Releases: master Resolves: #90882 Change-Id: I09f1d97a53a76ea96d6cbc18bb5549127b5a1a71 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64002 Tested-by:
-
Oliver Hader authored
This change aims to reduce the amount of inline JavaScript by removing `onchange` or `onclick` events and dynamically created JavaScript code/settings. There are still a couple of aspects that need to be solved in a general way - e.g. assigning global language labels (`TYPO3.lang`) or settings (`TYPO3.settings`). * extracts inline JavaScript from controllers & templates * GlobalEventHandler is extended to deal with custom scenarios that acutally would trigger a browser navigate events (e.g. changing a select drop-down leads to a document refresh) * ActionDispatcher is introduced to listen and delegate events to global TYPO3 modules in `top` window scope Resolves: #91015 Releases: master Change-Id: I67bf70bba1890c0ef966a08d96823ad91b1d4167 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64130 Tested-by:
-
Xavier Perseguers authored
Resolves: #91130 Related: #82990 Releases: master, 9.5 Change-Id: I8337f8d24fff67ac2c8f05f16de642f46e86cfd5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64250 Tested-by:
-
Christian Eßl authored
If a requested page in the view module is missing a site configuration, catch the related exception and show a meaningful flash message instead. Resolves: #91088 Releases: master Change-Id: I07e35c204ed3198530d57dd97e228fb950baf85c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64211 Tested-by:
Jonas Eberle <flightvision@googlemail.com> Tested-by:
-
Gerrit Mohrmann authored
To fire the LoginConfirmedEvent and LogoutConfirmedEvent even when redirects are active the redirect handling are moved after the events. Resolves: #91023 Releases: master Change-Id: I11fd2aba206edb68426039de7dbfa6e92d79c8a7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64165 Tested-by:
-
Andreas Fernandez authored
The backend already provides the possibility for a backend user to use the first available module as "start module". However, if the UC of backend user is empty, its start module is set to "help_AboutAbout" explicitly, which contradicts the mentioned feature. Additionally, EXT:about is an optional dependency which may break the backend at this point. Because of the listed reasons, explicitly setting "help_AboutAbout" has been removed as well as the override by EXT:dashboard. Resolves: #91127 Releases: master Change-Id: I04fb79f8b59f7e8a07736ffc0d328979075f09a4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64247 Reviewed-by:
-
Andreas Fernandez authored
Command executed: composer require --dev typo3/testing-framework:^6.2.3 Resolves: #91138 Releases: master Change-Id: I7047698dccc8b6bafbcb61b81f4723a1b9bba2ac Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64254 Reviewed-by:
-
