- Nov 23, 2021
-
-
Nikita Hovratov authored
By setting the display property of buttons inside of input-groups to "flex", the height of the element inside the button can be easier controlled. Resolves: #95451 Releases: master, 11.5 Change-Id: Ia41d6bf4421d8ad078509893c8b0177708767e5c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71459 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
- Nov 15, 2021
-
-
Benni Mack authored
Bootstrap 5 ships with "text-end" which is semantically more correct than "text-right". This change adapts the needed places in TYPO3 Core to use "text-end". Resolves: #95974 Releases: master Change-Id: I9c72b5004594ef46faba79e0ea78fe24025a93a1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72172 Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
-
Benni Mack authored
Used commands: > yarn add "bootstrap@^5.1.3" > yarn add "@popperjs/core" > grunt build Resolves: #95975 Releases: master Change-Id: Icacbf8d51c4e3345b9c549433c5ae28ba88848d9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72173 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
- Nov 10, 2021
-
-
Oliver Bartsch authored
The contents of the toolbar dropdown menus for bookmarks and open documents are dynamic. Having e.g. a lot bookmarks previously lead to the most recent bookmarks might be cut of at the bottom of the screen. This is now fixed by using a maximum height and allowing vertical scroll. Resolves: #94641 Releases: master Change-Id: I50b799c628e51fbcb8b59ad5eb64d369647c27fe Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72140 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
- Nov 05, 2021
-
-
Jochen Roth authored
In the cropper modal the initial aspect ratio is not respected. This has been fixed by triggering the update method when the cropper modal is initialized. Also by using CropperJs' built-in responsive feature we avoid tinkering with pixel sizes when window is resized and optimize ui to be more responsive. Resolves: #95204 Releases: master Change-Id: I5fe135220ffa88780b10ac38fa2d14e08bdd7a2e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71087 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
- Nov 04, 2021
-
-
Jonas Eberle authored
This fixes cut modulemenu icons on Firefox when scrollbars are shown. It has been fixed before, but since then seemingly unrelated changes had the problem resurface. This time we set a min-width: for these links to prevent them from shrinking even if the #modulemenu around them decides to give some space to the scrollbar. Resolves: #95656 Resolves: #94146 Related: #94633 Releases: master Change-Id: I610f62f7f4730250c554c81edac91d5f9b37bb98 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71795 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
Nikita Hovratov authored
Because of normal selectSingle fields having the css property "width: auto", very long text forces those fields to span the whole width of the text. To fix this problem, the entire table layout has to fall. FormEngine fields have now a solid grid layout. This allows us more control over the layout. With this in place the fix is pretty straight forward: "overflow: hidden" for the wrapping div of the select field. In addition, some cleanup has been done in GroupElement: Empty aside divs are no longer rendered. Resolves: #94688 Releases: master Change-Id: I01a14dd2b2294d3260a90c1efecc402f742fabfb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71798 Tested-by:
-
Jochen Roth authored
A long database name currently causes the modal to show scroll bars. This has been fixed by setting word-wrap for list items. Resolves: #95864 Releases: master Change-Id: If8f5fe51f29a6ee44f8d094e735e3876dcead52d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72041 Tested-by:
-
- Oct 13, 2021
-
-
Nikita Hovratov authored
While fixing an issue with sticky icons, the borders below th elements with "position: relative" got removed. This is fixed by adding the css property "background-clip: padding-box" to them, as this prevents the drawing of background beneath borders. Resolves: #95605 Related: #95455 Releases: master Change-Id: Ic1773aae97f466a894fb80c7e3bff35233f76a5c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71596 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
- Oct 12, 2021
-
-
Oliver Bartsch authored
Resolves: #95450 Releases: master Change-Id: Ifc008b06c3db26a835d50fa7f07caa23600c9795 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71555 Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
-
- Oct 06, 2021
-
-
Oliver Bartsch authored
This fixes some visual errors of the chosen component, when used inside a bootstrap input-group. This was due to bootstrap's change to flex-form. Resolves: #95492 Releases: master Change-Id: Ib19e049d6afa8b2052d1739d902f9b65849bb354 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71462 Tested-by:
-
- Oct 04, 2021
-
-
Oliver Bartsch authored
Resolves: #95455 Releases: master Change-Id: I0d5c99a93ce95e9c552440983369f6702cfbd772 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71431 Tested-by:
Helmut Hummel <typo3@helhum.io> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
-
- Oct 01, 2021
-
-
Oliver Bartsch authored
Previously, when a folder was empty or no files were found for a search term, the filelist still displayed the table header. This was related to the Drag&Drop functionality, which internally reads data from the table header. However it's also sufficient to just hide the table header and to show proper messages, including direct actions, e.g. "reset search" or "upload files". Therefore, also the Drag&Drop functionality is improved. The draggable area now covers the whole module, so the user does no longer have to strike a 70 pixels box. Besides, a couple of bugs in the Drag&Drop implementation are fixed: - When uploading files in "active search" mode, the file path is now properly added to the row - After all files were uploaded, the user is now able to reload the module via a notification action - Drag&Drop in FormEngine does no longer add the selector / checkbox field to the row - When dragging files in and out of the dropzone, the dropzone is now hidden again after "dragleave" (only for filelist) - The dropzone is now also hidden on "drop" (uploading the dragged files) - The dropzone is not "activated" when not in the current visible scope (e.g. in another FormEngine tab) - The checkbox is now also activated for uploaded files (without module reload) - The full sized drozone can be closed with the ESC key - JavaScript SyntaxError, triggered by a server error, such as "POST Content-Length" exceeds limit, is now properly handled Resolves: #95403 Resolves: #95421 Releases: master Change-Id: Id9de5065544aa57deaa11b8b4f9158b869a72427 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71375 Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
-
- Sep 30, 2021
-
-
Oliver Bartsch authored
Resolves: #95409 Releases: master Change-Id: Id57cc977c3f70b43a63135708bf8c055e10d9840 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71381 Tested-by:
-
- Sep 28, 2021
-
-
Helmut Hummel authored
Since TYPO3 core packages (extensions) are independently published and might be installed in arbitrary file locations in the near future, referencing assets in package A from a CSS file package B will likely not work. Therefore all assets that are referenced from a CSS file are now moved to the package that contains this CSS file. Also references of assets in CSS that already were located in the same package are cleaned up to not assume a hard coded path name (breaking out of Resources/Public directory). Resolves: #95372 Releases: master Change-Id: I6d7d7557d8ea7b293c81b50bc4172019a088f7b7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71332 Tested-by:
-
- Sep 27, 2021
-
-
Benjamin Kott authored
Resolves: #95353 Releases: master Change-Id: Ibce6c125438a6dcd73295069d6cea45dd3d4ebae Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71234 Tested-by:
-
- Sep 23, 2021
-
-
Oliver Bartsch authored
The file listing in the link browser is using bootstraps' "List group" component. In case a list group item is active, it receives "z-index: 2", to slightly overlay the neighbor items. To avoid conflicts with element browser components, which also use "z-index: 2", this patch increases the z-index of those components to "3". Resolves: #95323 Releases: master Change-Id: Ibd18992797cc8500518f589d4bebed9640b318f8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71217 Tested-by:
-
Oliver Bartsch authored
Revert a style change, added in #95325, which led to disabled checkboxes are being shown, while only their label should be visible. Those checkbox classes hide the actual checkbox, while the label acts as one. This allows extended styling, e.g. "icon checkboxes" or "toggle checkboxes". Instead add the disabled style to the correct checkbox component, which is acutally using the checkbox element and no label. Resolves: #95325 Releases: master Change-Id: I0842c184e629a3c4327c18db92affde58c32924d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71213 Tested-by:
-
- Sep 22, 2021
-
-
Oliver Bartsch authored
With #93526, multi-factor authentication was introduced to TYPO3. This came with several configuration options, such as the possibility to require MFA for specific users and user groups. Previously, the only result of this option was a warning, displayed in the MFA configuration module. Obviously, this did not really help administrators, trying to enforce MFA in their system. Therefore, this patch adds the missing endpoint, which is automatically called for all users, required to set up MFA, as soon as they have successfully passed the first authentication step (e.g. username + password). While it's a new endpoint, the actions still call the MFA providers the same way, the MFA configuration module does. Therefore, no changes to the API. Resolves: #95287 Releases: master Change-Id: Ib82ae53cbd5bd0782418d81d166c1f3d7e9a7ab1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71132 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
Oliver Bartsch authored
A couple of patches changed the amount of columns, shown in the filelist module listing. For example, since column selector component. Also multi record selection, introduced in #94906, adds an additional column, providing the checkbox. This patch therefore adjusts the DragUploader component to take this into account while dynamically adding rows for uploaded files. Resolves: #95300 Related: #84184 Related: #94906 Releases: master Change-Id: I0fcadc1c38da94a3365f6524c5407fe487fc4e21 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71166 Tested-by:
-
Benjamin Franzke authored
This change allows module URLs to be automatically framed by the TYPO3 main controller whenever they are directly opened in the browser address bar in a secure environment (e.g. https:// or .localhost TLD) (In this case the Sec-Fetch-Dest=document is sent by browsers). See: https://w3c.github.io/webappsec-fetch-metadata/#sec-fetch-dest-header Note: This header is already supported by Chrome, Edge and Firefox nightly, only Safari does not deliver this header yet. Non supporting browsers or unsafe http connections will gracefully fallback to showing the module contents without the TYPO3 main frame being added. This fallback behaviour is only triggered when a link is opened in a new tab. Regular clicks are intercepted and directly dispatched via module-router/iframe, as before. This change allows to render the module menu with anchor tags instead of buttons which lets users decide how and where a module should be opened. Long term goal is to improve accessibility by using real links not only in module menu (as we had in TYPO3 v7), but actually everywhere (for example in the database record list), in order for the user to decide whether to open a link in the current or a new tab. This will require enhancing FormEngine routes with module information and is therefore out of scope for this change. Resolves: #94084 Releases: master Change-Id: Iaad8fe62644ec6c9cb1aaa4c92ce2e8e3eeab7bd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69058 Tested-by:
-
Benni Mack authored
Resolves: #95299 Releases: master Change-Id: I4882a9ca07948718afdeb1a5fb5b3a518eb86c38 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71163 Tested-by:
-
- Sep 21, 2021
-
-
Oliver Bartsch authored
The clipboard component still suffers a lot of problems, due to its static integration in the list modules. For example, when clearing the clipboard, it's no longer possible to copy / cut a record via context menu, since the the previous GET parameters are included in the return URL, directly reverting the operation. The list modules should therefore not longer handle any clipboard logic directly, especially not via GET. This patch does the first step towards this goal and introduces a dedicated endpoint, only available via POST. The clipboard panel, used in recordlist and filelist is furthermore now integrated as a web component, making any form submit in the main module superfluous. Additionally some related bugs are fixed: * Elements moved to clipboard via context menu can now be remvoed from clipboard again * Non related elements are now always properly styled * File elements now correctly link to their parent folder in filelist * Buttons are only shown for the clipboard they influence Resolves: #95268 Resolves: #95267 Releases: master Change-Id: I7b1050c9b0f11a1e495ef09df4d0560dd84df882 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70978 Tested-by:
-
Benni Mack authored
This change removes the language title and flag from each CE, and instead adds only the flag if the content element is set to "All Languages" (-1). In addition, the header is now based on flex-box instead of floats. Resolves: #95302 Releases: master Change-Id: I6d1a180915fba9f2ccf8df3979a2256134d18379 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71116 Tested-by:
Rachel Foucard <rfoucard@w-seils.com> Tested-by:
-
- Sep 17, 2021
-
-
Rachel Foucard authored
The drop zones added space when they appear during a drag and drop action and it changed the mouse position. Also each content had a “new content” button relative to it and this button was dragged with it. This fixes both problems. Resolves: #95231 Releases: master Change-Id: I03f2219726ce1b7563409198449ed20dfc681a7e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71105 Tested-by:
Jonas Eberle <flightvision@googlemail.com> Tested-by:
-
Jochen Roth authored
EXT:recycler and EXT:workspaces use nearly the same code for their custom JavaScript based pagination. Therefore, both are adjusted accordingly. All buttons are now always equal height, since the "page-link" class now uses the full parent container space. The prev / next buttons now use the TYPO3 icon element instead of font awesome, making additional classes superfluous. All buttons are now "buttons", since they do not contain a target. This also brings previously missing user agent styles, such as cursor:pointer. Also the full area is now clickable. Additionally, a left over code block from #81086 is removed in the Recycler JavaScript module. Resolves: #95251 Releases: master Change-Id: I5456d0edd566cdc6dc3fb3a8e26d7dc959bd27f4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71104 Tested-by:
-
- Sep 16, 2021
-
-
Rachel Foucard authored
The unused elements in the page module have a specific styling (orange heading). When the items are drag&drop'ed into an active colPos, they previously kept their unused styling. This change gives the "Unused elements" a global warning background and removes the warning style from the content items so that they don't stay orange after a drag and drop in a real colPos. Resolves: #95230 Releases: master Change-Id: Idaa323166ec2c8f62b6f0fe747e7965910dbd4b8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71103 Tested-by:
-
- Sep 08, 2021
-
-
Oliver Bartsch authored
Using tables in panels requires the tables to avoid any margin-bottom, since the panel already defines such. A special case is using the wrapper class "table-responsive", placed between the panel and the table element. This use case was previously handled by bootstrap directly, but got removed with v5. We therefore, handle this case now on our own. Resolves: #95147 Releases: master Change-Id: I9c27bf9f5100b1ee1037ea30519a9a6ad7f7d77d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70969 Tested-by:
Jorgen van der Kroon <jurgen@alternet.nl> Tested-by:
Dennis Prinse <dennis.prinse@maxserv.com> Tested-by:
-
- Sep 07, 2021
-
-
Andreas Fernandez authored
Update browserslist package to update the browser versions we're supporting and respect their capabilities when building assets. Executed commands: npx browserslist@latest --update-db grunt build Resolves: #95130 Releases: master Change-Id: I0dd9634648a1df72c1449047d601ac52b758917c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70922 Tested-by:
-
- Sep 03, 2021
-
-
11nd11 authored
Streamline and optimize styling and markup of the new form wizard of form manager. * Clean up markup and use common colors of TYPO3 v11 * Optimize UX and Overview of the new form wizard * Use new common styles and elements for better overview and modern look Resolves: #94805 Releases: master Change-Id: I0be4753be8d414db848453a0e4db941a8b127676 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70681 Tested-by:
Tobias Siegler <siegler.tobias@googlemail.com> Tested-by:
waldhacker <hello@waldhacker.dev> Reviewed-by:
-
- Sep 01, 2021
-
-
Benni Mack authored
This change adds a new button to all files and folders to directly download a specific file from the file list or the context menu. In case a folder or multiple files/folders are selected, a zip file is created on-the-fly. Resolves: #90548 Releases: master Change-Id: I666d4b377b995bd95c0a8f0ca95b03fd45d05a0b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70820 Tested-by:
-
- Aug 30, 2021
-
-
Benni Mack authored
This change introduces a "secondary menu" for all trees and moves the "reload tree" into the secondary menu. In addition, a new icon "Collapse All" is introduced to be in line with the FormEngine Tree Renderer to also have this feature available in all SVG-based trees. Resolves: #95035 Resolves: #91858 Resolves: #94152 Resolves: #92459 Releases: master Change-Id: Id745ff1447bab9c481d9fbc46b2f80d2fb31ad72 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68456 Tested-by:
-
Oliver Bartsch authored
The multi record selection component, introduced in allows to remove the custom checkbox logic next to further improvements. For example, one can now execute actions only for tasks of a specific task group. This is possible since the multi record selection component handles each task group as a separate instance. This is achieved by applying the "multi-record-selection-identifier" to each task group container. Besides, this patch does the following: * Remove any dependency to EXT:recordlist * Fix collapsing of task groups and toggling of icon * Fix tablesort styling, applied to the header cols * Remove unused span tags from the table listing * Always execute tasks via POST Resolves: #94918 Related: #94906 Releases: master Change-Id: Iecc2874cdb32e6c4a2d0552f78a19c61052c046e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70675 Tested-by:
-
- Aug 24, 2021
-
-
Christoph Schwob authored
Remove duplicate styles but some overrides for e.g. border already needed. Changed class .card-content to .card-body Add card-size-medium to card on ElementInformation to use some empty space, cause there's only one card. Resolves: #94529 Releases: master Change-Id: I1e8d3cdfe8e622806eff4f1e52f3a2bad1740fad Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70480 Tested-by:
-
- Aug 23, 2021
-
-
Oliver Bartsch authored
Resolves: #94942 Releases: master, 10.4 Change-Id: I59685f499f9a86e266b6b012a88e80bdef4d3c3b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70685 Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Tested-by:
-
- Aug 19, 2021
-
-
Oliver Bartsch authored
This does a few follow up changes to increase consistency and allow further use cases. * Introduce a wrapper class to prevent jumping of the multi record selection actions and to unify the space between the actions and the record listing * Introduce new event listener for the actions, allowing JavaScript modules to influence the display based on their custom logic * Allow defining the actions multiple times on the same page (e.g. above and below the records listing) * Move "Selection:" label to EXT:core, while using it in both, filelist and file selector now Resolves: #94928 Related: #94906 Releases: master Change-Id: Ia1c972e8d5005d895476ad7e7322e39b37036669 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70679 Tested-by:
-
- Aug 18, 2021
-
-
Jochen Roth authored
With #94778 the backend logo has been scaled down to fit into the topbar. This worked but also led to issues with smaller, such as the default TYPO3 logo, as those were now stretched. This is now fixed by removing the "height: auto" property. Resolves: #94914 Releases: master Change-Id: Id3321bf739d0b064b7113ff6a152a088860f44f6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70672 Tested-by:
-
- Aug 12, 2021
-
-
Jochen Roth authored
The custom backend logo could break the layout if not properly scaled. This issue is fixed by setting max-width and max-height for the image. Resolves: #94778 Releases: master Change-Id: I98221c721e8f9d7a7a648807ce31c0e9a00390a6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70397 Tested-by:
-
Alexander Nitsche authored
This patch serves as a basis for further improving the UX and new features for import / export. * Better separation between controllers and worker services * Refactor code & streamline wording * More strict typing and some PHP 8 related fixes * Streamline exception handling * Support full import configuration in CLI command impexp:import * Functional tests with increased coverage and less mocking * A set of acceptance tests for the backend interface * Minor bug fixes Note: The output of the extension has not been changed in any way, e.g. the format of the export file remains the same. Only the internal processes have been optimized. Resolves: #94772 Releases: master Change-Id: I4df66a6f615e07d6d9767723a12a769aedeb341b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70332 Tested-by:
-
Oliver Bartsch authored
Bootstrap 5.1.0, we updated to in #94752, introduced a `.vr` (vertical rule) class. This collided with our access module related styles, since we also use a `.vr` class for the legend here. To resolve the collision, our own implementation, which is only used in the access module, is now prefixed with `t3`. Resolves: #94826 Related: #94752 Releases: master Change-Id: I493baa3d0af41b78f42c9e73c9c121b29f417edd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70456 Tested-by:
-
