- Nov 23, 2021
-
-
Nikita Hovratov authored
By setting the display property of buttons inside of input-groups to "flex", the height of the element inside the button can be easier controlled. Resolves: #95451 Releases: master, 11.5 Change-Id: Ia41d6bf4421d8ad078509893c8b0177708767e5c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71459 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
- Nov 22, 2021
-
-
Jochen Roth authored
Currently when a language in site configuration is removed the modal cancel button does not remove/cancel the modal. This has been fixed by adding a trigger to close the modal when the cancel button was clicked. Resolves: #96016 Releases: master, 11.5 Change-Id: I100d84a7fa5f6a84d1045fec0a63d7c20789b42d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72219 Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
-
- Nov 19, 2021
-
-
Oliver Bartsch authored
The RequestUpdate component, handling the TCA "onChange" functionality, adds an event listener to the main HTML field. In case of TCA type "input", this field never dispatches such event, because the user always changes the "human readable" field in the GUI. The main field is only updated manually by FormEngine after validating the new value. Therefore, the "onChange" property never had any effect for TCA type "input" fields. This is now fixed by dispatching a "change" event for the main field after its value has been updated. Resolves: #93613 Releases: master, 11.5 Change-Id: I9facf3548619b3733975fb5c8f28622d03002e7b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72205 Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
-
- Nov 18, 2021
-
-
Oliver Hader authored
Closing a popup window does not use inline JavaScript code anymore. Resolves: #96019 Releases: master, 11.5 Change-Id: Iea2354e30d51ddcd24d9288fe5fa87b924259c13 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72222 Tested-by:
Torben Hansen <derhansen@gmail.com> Tested-by:
-
Oliver Hader authored
When resolving inline JavaScript invocations in issue #95954 it looked like AJAX-aware elements in FormEngine would share a common abstract implementation in the client-side handling. Actually AJAX response handling is independent for each of those elements... This change now applies changes, that previously have been made to `TYPO3/CMS/Backend/FormEngine/InlineRelation/AjaxDispatcher`, to `TYPO3/CMS/Backend/FormEngine/Container/FlexFormSectionContainer`. Resolves: #96027 Releases: master, 11.5 Change-Id: Icf507a32399f72182597e9c8d650fb2d9a35e480 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72231 Tested-by:
Jörg Bösche <typo3@joergboesche.de> Tested-by:
-
- Nov 16, 2021
-
-
Oliver Bartsch authored
In #94688, the table layout of form fields had been replaced by a grid layout. However, some places did not receive the new classes, leading to display error. This is fixed by adding the corresponding classes to those places. Resolves: #95994 Relates: #94688 Releases: master Change-Id: Iba3ea2d3f665d055864edd9c8329dac939aa2642 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72191 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
- Nov 15, 2021
-
-
Oliver Hader authored
Reduces amount of `requireJsModules` and `scriptCall` invocations in AJAX response handling and migrates to new `scriptItems` which is forwarded to JavaScriptHandler.js. Resolves: #95954 Releases: master Change-Id: I258da49fef46ccc36c602e0fd7c9a14ddb3cec1d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72154 Tested-by:
-
Benni Mack authored
Bootstrap 5 ships with "text-end" which is semantically more correct than "text-right". This change adapts the needed places in TYPO3 Core to use "text-end". Resolves: #95974 Releases: master Change-Id: I9c72b5004594ef46faba79e0ea78fe24025a93a1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72172 Tested-by:
-
Benni Mack authored
Used commands: > yarn add "bootstrap@^5.1.3" > yarn add "@popperjs/core" > grunt build Resolves: #95975 Releases: master Change-Id: Icacbf8d51c4e3345b9c549433c5ae28ba88848d9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72173 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
- Nov 11, 2021
-
-
Gabe Troyan authored
Currently, the value of `USdateFormat` is disregarded because the corresponding property, `FormEngineValidation.USmode`, is set to zero regardless in `FormEngineValidation.initialize()`. This change will ensure that `USmode` will remain 1 without conflicting with core functionality that relies on `USmode` being set *before* `initialize()` is called. Resolves: #86679 Releases: master, 10.4 Related-to: #91105 Change-Id: I5584ca7fe92742e28147f9883fedf53e0556f1b1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72034 Tested-by:
-
- Nov 10, 2021
-
-
Oliver Bartsch authored
The contents of the toolbar dropdown menus for bookmarks and open documents are dynamic. Having e.g. a lot bookmarks previously lead to the most recent bookmarks might be cut of at the bottom of the screen. This is now fixed by using a maximum height and allowing vertical scroll. Resolves: #94641 Releases: master Change-Id: I50b799c628e51fbcb8b59ad5eb64d369647c27fe Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72140 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
- Nov 09, 2021
-
-
Oliver Bartsch authored
In case only one localization mode is available, e.g. because a localization mode was already defined for the translated page or only one mode is allowed by configuration, the selection step is superfluous and therefore now skipped. Resolves: #95909 Releases: master Change-Id: I4a842b0758c9c95744f31f8074a09a1c29f53af2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72079 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Oliver Bartsch authored
In prior versions, creating a new page via the context menu inserted the new page "inside". This however changed to "after" in v8, leading to misbehavior, especially for non-admins, as they are usually not allowed to create pages on pid=0. This is now fixed by restoring the previous behavior of inserting pages "inside" instead of "after". Resolves: #81405 Releases: master, 10.4 Change-Id: I6a941c3e015189a471d0c136c81f1e5698426dbb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72093 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
- Nov 05, 2021
-
-
Jochen Roth authored
In the cropper modal the initial aspect ratio is not respected. This has been fixed by triggering the update method when the cropper modal is initialized. Also by using CropperJs' built-in responsive feature we avoid tinkering with pixel sizes when window is resized and optimize ui to be more responsive. Resolves: #95204 Releases: master Change-Id: I5fe135220ffa88780b10ac38fa2d14e08bdd7a2e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71087 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
- Nov 04, 2021
-
-
Jonas Eberle authored
This fixes cut modulemenu icons on Firefox when scrollbars are shown. It has been fixed before, but since then seemingly unrelated changes had the problem resurface. This time we set a min-width: for these links to prevent them from shrinking even if the #modulemenu around them decides to give some space to the scrollbar. Resolves: #95656 Resolves: #94146 Related: #94633 Releases: master Change-Id: I610f62f7f4730250c554c81edac91d5f9b37bb98 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71795 Tested-by:
-
Nikita Hovratov authored
Because of normal selectSingle fields having the css property "width: auto", very long text forces those fields to span the whole width of the text. To fix this problem, the entire table layout has to fall. FormEngine fields have now a solid grid layout. This allows us more control over the layout. With this in place the fix is pretty straight forward: "overflow: hidden" for the wrapping div of the select field. In addition, some cleanup has been done in GroupElement: Empty aside divs are no longer rendered. Resolves: #94688 Releases: master Change-Id: I01a14dd2b2294d3260a90c1efecc402f742fabfb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71798 Tested-by:
-
Jochen Roth authored
A long database name currently causes the modal to show scroll bars. This has been fixed by setting word-wrap for list items. Resolves: #95864 Releases: master Change-Id: If8f5fe51f29a6ee44f8d094e735e3876dcead52d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72041 Tested-by:
-
- Nov 03, 2021
-
-
Jochen Roth authored
The page tree delete modal labels have been changed to align with all other delete modals. Resolves: #95817 Related: #94780 Related: #92670 Releases: master Change-Id: I44c2b432c185acbecc4d6ad0eebba70391b6a37f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72004 Tested-by:
-
Oliver Hader authored
Instead overriding class member variables externally, existing initialize() method has been extended to support options. This is a preparation to reduce the amount of inline JavaScript later. Resolves: #95845 Releases: master Change-Id: I7d76761e6b57a6e97163ca2ad721a2b1c8775e3c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72022 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
- Nov 02, 2021
-
-
Simon Gilli authored
In some places the file extensions of language files are missing and properly added with this patch. Resolves: #95842 Releases: master Change-Id: Iea638f9386a094214115d2c7c2c039b2c0f37f82 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72018 Tested-by:
-
- Oct 23, 2021
-
-
Christian Kuhn authored
finediff is used in various core places to render a HTML "diff" view of two strings. The library didn't see changes since 2014. With PHP 8.1, it started mumbling about \ArrayAccess signature shenanigans. We forked the lib to lolli42/finediff as drop-in replacement, modernized the codebase a bit and added multibyte support along the way - that's the reason this patch is a bug fix. composer req lolli42/finediff:^1.0 composer rem cogpowered/finediff composer req lolli42/finediff:^1.0 -d typo3/sysext/core --no-update composer rem cogpowered/finediff -d typo3/sysext/core --no-update Change-Id: Ib00b8073253709459b56e3080d9361c46f913e4c Resolves: #95742 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71945 Tested-by:
Simon Gilli <typo3@gilbertsoft.org> Tested-by:
-
- Oct 13, 2021
-
-
Nikita Hovratov authored
While fixing an issue with sticky icons, the borders below th elements with "position: relative" got removed. This is fixed by adding the css property "background-clip: padding-box" to them, as this prevents the drawing of background beneath borders. Resolves: #95605 Related: #95455 Releases: master Change-Id: Ic1773aae97f466a894fb80c7e3bff35233f76a5c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71596 Tested-by:
-
- Oct 12, 2021
-
-
Oliver Bartsch authored
Resolves: #95450 Releases: master Change-Id: Ifc008b06c3db26a835d50fa7f07caa23600c9795 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71555 Tested-by:
-
Georg Ringer authored
To make it easier for developers and integrators, the table name is now shown in the backend when debugging is active. Resolves: #92427 Related: #83461 Releases: master Change-Id: I2c7413b5deac43490b6a7392060da76992a69bd9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65892 Tested-by:
-
Oliver Hader authored
Allow a list of HTML tags in the help content just as for the configuration details. Resolves: #95152 Releases: master Change-Id: Icc2e0b60a1ed86f67604e276322ec24162234a95 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70980 Tested-by:
-
- Oct 06, 2021
-
-
Oliver Bartsch authored
This fixes some visual errors of the chosen component, when used inside a bootstrap input-group. This was due to bootstrap's change to flex-form. Resolves: #95492 Releases: master Change-Id: Ib19e049d6afa8b2052d1739d902f9b65849bb354 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71462 Tested-by:
-
- Oct 04, 2021
-
-
Oliver Bartsch authored
Resolves: #95455 Releases: master Change-Id: I0d5c99a93ce95e9c552440983369f6702cfbd772 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71431 Tested-by:
Helmut Hummel <typo3@helhum.io> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
-
Benni Mack authored
Previously, the "pagesOnly" argument was used to link to the PagePositionMap for new pages. This is now resolved by using an actual separate route "db_new_pages" to link to the PagePositionMap to avoid the "special" handling of "pagesOnly", which still works but creates a redirect to the new route. Resolves: #95408 Releases: master Change-Id: I5f9c22751d21c976fff218d942d8674676a64b2c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71337 Tested-by:
-
Oliver Bartsch authored
Due to the bootstrap migration, the spacing of the login forms (username+password and MFA), was lost. This is now fixed by using a consistent space of 0.5rem for the different components (form fields, links, error messages). Resolves: #95220 Resolves: #95347 Releases: master Change-Id: I9eccf90038ebaa8d7620662859e94f8a91aeeab8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71427 Tested-by:
-
- Oct 02, 2021
-
-
Oliver Hader authored
To reduce arbitrary inline JavaScript, requireJS callbacks used in FormEngine are streamlined to be more explicit - allowed instructions are `load` (module), `invoke` (a method), (create a new) `instance`. This change is an intermediate preparation for delegating loading, assignment and invocation directly to JavaScript processes. Relevant parts have been extracted from corresponding client-side handling in https://review.typo3.org/c/Packages/TYPO3.CMS/+/64123 The possibility to load and append arbitrary inline JavaScript to FormEngine segment `requireJsModules` is deprecated. Instructions need to be declared using new `JavaScriptModuleInstruction`. Resolves: #95200 Releases: master Change-Id: Ic93ffc7b478dea44dfa5cffe9606f81eea2e64b0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71044 Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
-
Oliver Bartsch authored
The Drag&Drop component previously misused the new content element wizard related “t3js” class to check whether content can be created or not. This had two side effects: * Drag&Drop was never possible when new content element wizard was disabled * Since #95277 Drag&Drop was completely unusable, because the mentioned class got removed in favor of a new web component We already had the same issue with the paste button in #95117. Therefore this is now fixed in the same way. In the fluid based page module, the `.t3js-page-new-ce` class is always present, in case content creation is allowed. Therefore it's sufficient to just check for this class. This also makes the `else` part superfluous. Conclusion: Drag&Drop is now always working, no matter if new content element wizard is enabled or not, as long as content creation is allowed for this column (e.g. no access restricted colPos). Resolves: #95440 Releases: master Change-Id: I4d07d523f3b8394edccc88dbc414876f9b33ab53 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71411 Tested-by:
-
- Oct 01, 2021
-
-
Oliver Bartsch authored
Previously, when a folder was empty or no files were found for a search term, the filelist still displayed the table header. This was related to the Drag&Drop functionality, which internally reads data from the table header. However it's also sufficient to just hide the table header and to show proper messages, including direct actions, e.g. "reset search" or "upload files". Therefore, also the Drag&Drop functionality is improved. The draggable area now covers the whole module, so the user does no longer have to strike a 70 pixels box. Besides, a couple of bugs in the Drag&Drop implementation are fixed: - When uploading files in "active search" mode, the file path is now properly added to the row - After all files were uploaded, the user is now able to reload the module via a notification action - Drag&Drop in FormEngine does no longer add the selector / checkbox field to the row - When dragging files in and out of the dropzone, the dropzone is now hidden again after "dragleave" (only for filelist) - The dropzone is now also hidden on "drop" (uploading the dragged files) - The dropzone is not "activated" when not in the current visible scope (e.g. in another FormEngine tab) - The checkbox is now also activated for uploaded files (without module reload) - The full sized drozone can be closed with the ESC key - JavaScript SyntaxError, triggered by a server error, such as "POST Content-Length" exceeds limit, is now properly handled Resolves: #95403 Resolves: #95421 Releases: master Change-Id: Id9de5065544aa57deaa11b8b4f9158b869a72427 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71375 Tested-by:
-
Oliver Bartsch authored
With #95406, an instance of check was added to the Notification component, to prevent a TypeError in case the action is not defined. That was actually a sign of a bad usage (e.g. passing null), and therefore the action is now made optional instead. Resolves: #95420 Related: #95406 Releases: master Change-Id: I52c519817225f0a874788095a912c808528d031d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71388 Tested-by:
-
- Sep 30, 2021
-
-
Oliver Bartsch authored
Resolves: #95409 Releases: master Change-Id: Id57cc977c3f70b43a63135708bf8c055e10d9840 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71381 Tested-by:
-
Oliver Bartsch authored
The Notification JavaScript module previously failed to check a given action before executing it. This is now fixed with an "instance of" check. Resolves: #95406 Releases: master Change-Id: I4a620d42f822baa1a54a441281e9291af4649d29 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71379 Tested-by:
-
- Sep 29, 2021
-
-
Oliver Bartsch authored
In #95372 the errorpage.css, used for the standalone ErrorPage template, was moved from EXT:core to EXT:backend, since it had dependencies to this extension. However, it actually belongs to EXT:core. The ErrorPageController is used for both, backend and frontend. A side effect of the relocation to EXT:backend: The errorpage.css was now always loaded in the backend, overriding a couple of classes, which then led to display errors. This is now fixed by removing any dependency to EXT:backend and moving the stylesheet back to EXT:core. As a side effect, the "typo3_orange.svg" file is removed from EXT:backend and EXT:install, since it's now available in EXT:core. All places are adjusted accordingly. Resolves: #95388 Related: #95372 Releases: master Change-Id: I697aa0f98dbd989f68779690d466c7bfdce60c2b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71343 Tested-by:
-
Oliver Bartsch authored
This patch cleans up the NewContentElementController, used for the "new content element wizard". All inline JavaScript is removed, in favour of a custom web component and an improved JavaScript module, handling the two modes (create content with known colPos and create content while selecting the desired colPos). Previously, the wizard was triggered by a t3js-* class. Since e.g. the fluid based page module related templates might be overridden in extension code, a fallback layer is present to still support this way of initialization in v11. Due to the necessary refactoring, some related bugs are fixed: * Accessing the wizard via the context menu now works correctly * The "saveAndClose" feature is now also respected in case the user has to choose the desired colPos * Using a custom wizard endpoint (mod.newContentElementWizard.override) does no longer initialize the TYPO3 related JavaScript, which previously led to a JavaScript TypeError * A duplicated clear "icon" in the elements filter is removed Resolves: #95277 Resolves: #95375 Resolves: #95376 Releases: master Change-Id: I6e9b260938c934222e479c1a93c69ba6f27eec4b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71318 Tested-by:
-
- Sep 28, 2021
-
-
Helmut Hummel authored
Since TYPO3 core packages (extensions) are independently published and might be installed in arbitrary file locations in the near future, referencing assets in package A from a CSS file package B will likely not work. Therefore all assets that are referenced from a CSS file are now moved to the package that contains this CSS file. Also references of assets in CSS that already were located in the same package are cleaned up to not assume a hard coded path name (breaking out of Resources/Public directory). Resolves: #95372 Releases: master Change-Id: I6d7d7557d8ea7b293c81b50bc4172019a088f7b7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71332 Tested-by:
-
Oliver Hader authored
Substitutes deprecated invocation of `TBE_EDITOR.fieldChanged`. Relevant processing has been duplicated from `TBE_EDITOR` to corresponding `FormEngine` event handler. Throwing a new `change` event from a `change` event handler is counterproductive and would lead to an endless loop. Resolves: #95352 Releases: master Change-Id: I61daee4457ec5d2bb36d1bcc773178c25e00cb8e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71229 Tested-by:
-
- Sep 27, 2021
-
-
Benjamin Kott authored
Resolves: #95353 Releases: master Change-Id: Ibce6c125438a6dcd73295069d6cea45dd3d4ebae Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71234 Tested-by:
-
