- Nov 23, 2021
-
-
Nikita Hovratov authored
By setting the display property of buttons inside of input-groups to "flex", the height of the element inside the button can be easier controlled. Resolves: #95451 Releases: master, 11.5 Change-Id: Ia41d6bf4421d8ad078509893c8b0177708767e5c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71459 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
- Nov 22, 2021
-
-
Ingo Fabbri authored
The backend usergroup compare view requires to fetch the group data of the groups to compare. Since this operation depends on a user array, UserInformationService creates such dummy user. Since #93233 the dummy user array also contains a workspace id `-99`. To successfully overcome workspace access-checks, set the admin-flag for this fake-user. Use workspace uid 0, to avoid any database operations on workspace access checks. Workspace 0 additionally prevents the log-message, which led to the exception message described at #93894. Resolves: #93894 Related: #93233 Releases: master, 11.5 Change-Id: Ieb5da95082cb6dfd5c030fbd04d735863d587510 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70056 Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
-
Stefan Bürk authored
TCA slug field generator option 'prefixParentPageSlug' has been added to be used for page records only. Slug generation for non-page records with pid=0 has been fixed with #94655 which introduced a endless loop if 'prefixParentPageSlug' is used as slug field generator option for record tables. This patch only process 'prefixParentPageSlug' for page records, thus ignoring it for non-page records and avoiding the endlees loop and as such prevent segmentation faults or memory_limit fatal errors. Resolves: #95485 Related: #94655 Releases: master, 11.5, 10.4 Change-Id: I20e1ac68bad6ad9447b03debbedb646495045ac3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72168 Reviewed-by:
-
Rudy Gnodde authored
Add option to copy page access settings from the parent page. Set by setting Page TSconfig TCEMAIN.permissions.* to "copyFromParent". Can be set for groupid, userid, user, group and everybody. For example: TCEMAIN.permissions.groupid = copyFromParent Resolves: #89917 Releases: master Change-Id: I4dd11177f533fd752f3b75287db2d8cb60c67005 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62750 Tested-by:
-
Jochen Roth authored
Currently when a language in site configuration is removed the modal cancel button does not remove/cancel the modal. This has been fixed by adding a trigger to close the modal when the cancel button was clicked. Resolves: #96016 Releases: master, 11.5 Change-Id: I100d84a7fa5f6a84d1045fec0a63d7c20789b42d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72219 Tested-by:
-
- Nov 21, 2021
-
-
Anja Leichsenring authored
For easier testing, ext:irre_tutorial "foreignfield" setup is extracted to a dedicated extension. Tests concerning these tables can now load the smaller test extension, which reduces system load and simplifies maintenance. Resolves: #95952 Releases: master, 11.5 Change-Id: I6fc581ac20821a4dcaff724cef4b3768e7f33dec Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72208 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
- Nov 20, 2021
-
-
Christian Kuhn authored
Using the "translate" button in page module and localizing records from non-default language may lead to funny content element sorting in the target language. This has been mitigated with probably #85300 and #84951 a while ago already, but there still exists a codewise misbehavior in DataHandler::getPreviousLocalizedRecordUid(). The patch streamlines the method and applies a fix so records calculate the correct "before" uid even in "localization of a localization" context. Resolves: #83079 Resolves: #83469 Related: #85300 Related: #84951 Releases: master, 11.5 Change-Id: I03c566054bd4939fed96206f62633b2abe4f195f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/54750 Tested-by:
-
- Nov 19, 2021
-
-
Oliver Bartsch authored
The RequestUpdate component, handling the TCA "onChange" functionality, adds an event listener to the main HTML field. In case of TCA type "input", this field never dispatches such event, because the user always changes the "human readable" field in the GUI. The main field is only updated manually by FormEngine after validating the new value. Therefore, the "onChange" property never had any effect for TCA type "input" fields. This is now fixed by dispatching a "change" event for the main field after its value has been updated. Resolves: #93613 Releases: master, 11.5 Change-Id: I9facf3548619b3733975fb5c8f28622d03002e7b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72205 Tested-by:
-
Jochen Roth authored
Given you have a user which has no access to the current page or no page at all, a "access array offset on value of type" is thrown in PHP8. This has been fixed by adding a fallback in case the array key does not exist which then throws the expected exception. Resolves: #96026 Releases: master, 11.5 Change-Id: I335a74fb6c2566d7a3e65632977dbc2740249414 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72228 Tested-by:
-
Eric Chavaillaz authored
This adds the NumberedPagination class from the ext:numbered_pagination of Georg Ringer as "SlidingWindowPagination" to the Core. Resolves: #94625 Releases: master Change-Id: If8631da405d95103c7a2f3a58a831835f08e45b9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70069 Tested-by:
Torben Hansen <derhansen@gmail.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Oliver Bartsch authored
When comparing user groups, a fake user record is created to fetch the group data for. This led to a couple of undefined array key warnings, which are now fixed. Resolves: #96038 Releases: master, 11.5 Change-Id: Ia1ed0dcf4483bf5b8bef26992c8943284c32de29 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72238 Tested-by:
-
linawolf authored
New changelog entries now go to the release that they will be integrated in, currently 12.0. Updated the Howto.rst to adhere to current documentation standards and use current branches and versions as examples. Updated the section about where to put .rst files in the Changelog. Fixes: #96036 Releases: master Change-Id: Id5eef8caa3b53137507b283387884148ea8c63f2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72235 Tested-by:
-
frpuser authored
Releases: master, 11.5, 10.4 Resolves: #96040 Change-Id: Idc83eedacc1ab00f761e179e394e173a071b6b0d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72239 Tested-by:
-
Benjamin Franzke authored
This applies to rendering of database mounts (from groups or from workspaces): They are now shown as children of the virtual root page (uid=0) as it used to be in TYPO3 v8. This is to allow workspace users to get an overview of all changes of all mounts by navigating to the virtual page uid=0. Releases: master, 11.5, 10.4 Resolves: #95854 Related: #95972 Related: #91145 Change-Id: I7f6370f327711396193cf56b63f15876350c2559 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72028 Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
-
Simon Ackermann authored
Return an empty array if the key does not exist. Resolves: #96023 Releases: master, 11.5 Change-Id: I41cbea8c74ac91062c2e46efc16b4b6580be066b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72225 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
- Nov 18, 2021
-
-
Christian Kuhn authored
The DataHandler 'regular' functional import DataSet uses a duplicate sorting value for tt_content records 296 and 297. This is an artificial setup - the DataHandler won't create this itself. To make sorting values in tests easier to understand and follow, the import set is adapted to use distinct sorting values for these rows. This is a pre-patch to fix a localization related sorting issue. In case the "duplicate sorting value" scenario should be tested, it should receive dedicated tests. Resolves: #96035 Related: #83079 Releases: master, 11.5 Change-Id: I281eae5ca8f57ed8e16e147d27ce7c40f07b7ffe Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72234 Tested-by:
-
Oliver Hader authored
Closing a popup window does not use inline JavaScript code anymore. Resolves: #96019 Releases: master, 11.5 Change-Id: Iea2354e30d51ddcd24d9288fe5fa87b924259c13 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72222 Tested-by:
-
Anja Leichsenring authored
There was a copy&paste leftover, leading to translated records being related to the wrong table. By fixing the wrong TCA configuration, sys_refindex entries in several test fixtures had to be adjusted. Resolves: #96025 Releases: master, 11.5 Change-Id: I197688e80e98a45a595e5304a49249ecfdcbfe91 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72230 Tested-by:
-
Oliver Hader authored
Uses GlobalEventHandler functionality instead of onchange events. Resolves: #96018 Releases: master, 11.5 Change-Id: Ib217b294b9f3d0ff27c005b0d4f397aa2bfd665c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72221 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Oliver Hader authored
When resolving inline JavaScript invocations in issue #95954 it looked like AJAX-aware elements in FormEngine would share a common abstract implementation in the client-side handling. Actually AJAX response handling is independent for each of those elements... This change now applies changes, that previously have been made to `TYPO3/CMS/Backend/FormEngine/InlineRelation/AjaxDispatcher`, to `TYPO3/CMS/Backend/FormEngine/Container/FlexFormSectionContainer`. Resolves: #96027 Releases: master, 11.5 Change-Id: Icf507a32399f72182597e9c8d650fb2d9a35e480 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72231 Tested-by:
Jörg Bösche <typo3@joergboesche.de> Tested-by:
-
Helmut Hummel authored
Calling the TYPO3 extension installer with a root package of a different type will lead to an exception to be thrown. Move the install path check after the type check, to be sure to call the installer only with extension types. Resolves: #96028 Related: #96021 Releases: master, 11.5 Change-Id: Icdebc1a541a0b43461559e8f7a4a999fb1b327f3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72229 Tested-by:
Simon Gilli <typo3@gilbertsoft.org> Tested-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
-
Oliver Hader authored
Resolves: #96022 Releases: master Change-Id: I6d9be94a4013d1380f75ef6f6f8f7f330d15f9f5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72224 Tested-by:
-
Helmut Hummel authored
In case extensions are installed in vendor (in a future version of composer installers), linking an extension root package to the target location (vendor) does not make sense and is now skipped. Resolves: #96021 Releases: master Change-Id: Ifdee432c10135df35f3a47e54d2c366714ca32ba Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72223 Reviewed-by:
-
- Nov 17, 2021
-
-
Simon Gilli authored
Composer 2.1 supports PHP 5.3 and higher and to avoid issues during the deployment or on systems where the CLI version is not equal to the FPM version, the PackageArtifactBuilder is relaxed to also support PHP 7.1 and higher. Resolves: #96017 Releases: master Change-Id: I008368c2dbdb2023eb95bdc3650f2e00f528eb23 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72220 Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Oliver Hader authored
Due to a bug, inline form fields were initialized twice, causing internal application state issues in FormEngine and Modal handling. Resolves: #96009 Releases: master Change-Id: I07f75ae90826eec77515ec84e69f4154828295a1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72214 Tested-by:
Chris Müller <typo3@krue.ml> Tested-by:
-
Oliver Bartsch authored
Resolves: #95729 Releases: master Change-Id: I5020a42d156dbd15202228e963fd8853e123b8bf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72209 Reviewed-by:
-
Oliver Bartsch authored
The FilesProcessor previously exploded the comma separated list of file collection uids with trimExplode. However, the underlying FileCollector method expects the uids to be of type int. Therefore, the data processor now uses GU::intExplode(), like already done in FileContentObject, instead. Resolves: #93193 Releases: master Change-Id: Ib0923b1484993793e1dd50be395fac78aa61cda7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72204 Tested-by:
-
Oliver Hader authored
Resolves: #96014 Releases: master Change-Id: Ia6fea96a2af2572f5e2c0115aed99c514a168b8d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72215 Tested-by:
-
Simon Gilli authored
docker on mac and windows WSL2 encapsulate a VM into the system. The current xdebug remote config does not work in those cases since the host IP can not be determined with the current solution. Switching to host.docker.internal works for macOS and WSL2, and works for linux too in combination with an extra_hosts setting. This requires linux to use at least docker 20.10, which shouldn't be a huge issue with casual developer machines. Resolves: #95999 Resolves: #94932 Releases: master, 10.4 Change-Id: I02acfeefc08f338841b4fecdb952c7da37ff65e1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72194 Tested-by:
-
Christian Kuhn authored
Switching to 20.10 gives us a feature we need in runTests.sh. Resolves: #96013 Related: #94932 Related: #95999 Releases: master, 10.4 Change-Id: I7eef83c130b76cab84dff7d595b7807d34b22ce7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72212 Tested-by:
-
Oliver Hader authored
HtmlWorker (triggered by f:transform.html view helper) issued a PHP warning concering an empty Document Fragment when the markup to be parsed is an empty string (`''`). Resolves: #95867 Releases: master Change-Id: I9018274d9f16b20550a8ac5b740753e33737b867 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72210 Tested-by:
-
Oliver Bartsch authored
The example for the CommaSeparatedValueProcessor was missing a value for the fieldEnclosure property. This might lead to the assumption that this property can be "unset", which is not the case as it always defaults to a quotation mark ("). This is now fixed by adding an example value. Resolves: #93190 Releases: master Change-Id: If4ee5f358f71d83d0117cf0e9c2e07c619966b9f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72203 Tested-by: -
Sybille Peters authored
Fix a problem in the GUI where the previous page "depth" selector ("Show this level") was not remembered when selecting a different page in the page tree. Resolves: #95893 Releases: master Change-Id: Ifdb90ac21701dd9ad2a87a1864f24d32e6dd1f8f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72197 Tested-by: -
Torben Hansen authored
Ensure the first argument passed to $this->cImage() is a string if file is not defined in conf array. Resolves: #96008 Releases: master Change-Id: Icf84fd7fad66da4f248e3216ab4b79ac995a69c1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72200 Tested-by:
-
Helmut Hummel authored
Fatal error can occur, when the file variable isn't a string, which only happens, when file processing failed or the resolved file isn't an image. Nevertheless the fatal error should be avoided. Also clean up some variable usage to not change the type of variable and remove some not needed isset() check for better readability. Resolves: #91681 Releases: master, 10.4 Change-Id: Ibde8e1105fa7c0e233656b5dd49e083b6c7259ab Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64908 Reviewed-by:
-
Helmut Hummel authored
With the introduction of site settings being exposed to TypoScript with https://review.typo3.org/64128 it has become important to allow more characters as TypoScript keys. Allowing a slash in addition should cover cases where paths are exposed as keys. Additionally the above change reveals, that the ArrayUtility::flatten method does not properly handle array keys that has dots in between, as those must be escaped to produce a correct result. This change introduces a new flatten method after several failed attempts to guess what fixes might not be breaking. The new method is used in places where no TypoScript is used, as in those the weird edge case behaviour of the flatten method isn't expected anyway. The new method is marked internal until it is decided how to proceed with the flatten method. Resolves: #94646 Releases: master, 10.4 Change-Id: I4ebad8a0beece975702d8601a343aa1fdaaa285c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70115 Tested-by:
-
Daniel Goerz authored
EXT:impexp EXT:indexed_search EXT:info EXT:install Resolves: #94264 Releases: master Change-Id: I0799fce1f3f316a4b6e0925f6813738a2c53f8a9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69394 Tested-by:
-
- Nov 16, 2021
-
-
Florian Rival authored
Resolves: #95993 Releases: master Change-Id: I8eb6e779ae1d0f02bf8ef0fe3fb5dd02b751cb47 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72190 Tested-by:
-
Oliver Bartsch authored
In #94688, the table layout of form fields had been replaced by a grid layout. However, some places did not receive the new classes, leading to display error. This is fixed by adding the corresponding classes to those places. Resolves: #95994 Relates: #94688 Releases: master Change-Id: Iba3ea2d3f665d055864edd9c8329dac939aa2642 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72191 Tested-by:
-
Oliver Bartsch authored
Resolves: #95995 Releases: master Change-Id: I6faea581aba0ca9171a6b79c94c1371c56b60387 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72192 Tested-by:
-
