- May 31, 2019
-
-
mkoitka authored
Since PHP 5.4 it's possible to disable escaping for unicode characters and slashes, which results in a much cleaner, leaner and most importantly readable TYPO3 log output. Releases: master, 9.5 Resolves: #88120 Related: #77274 Change-Id: I5b331e29e0f036d3d95b0f1045c269a28fec6abb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60431 Reviewed-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Tomas Norre Mikkelsen <tomasnorre@gmail.com> Reviewed-by:
Frank Naegler <frank.naegler@typo3.org> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
-
c.essl authored
Ensure the uid fields in the SeparateSysHistoryFromSysLogUpdate that are passed to RecordHistoryStore::addRecord() and RecordHistoryStore::deleteRecord() are type casted to integers. Resolves: #88270 Releases: master, 9.5 Change-Id: I941f5a82d73b9d76b26355fe126ba8d4a2a15d26 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60827 Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Reviewed-by:
Tobi Kretschmann <tobi@tobishome.de> Reviewed-by:
-
c.essl authored
There is a "document size" row in the info module of the adminpanel. Currently the value is outputted as integer, which strips out its unit. This patch fixes that. Resolves: #88439 Releases: master, 9.5 Change-Id: I97591bd1799923e5da5604992cd77546bccb1f51 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60823 Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Tested-by:
-
- May 30, 2019
-
-
Benni Mack authored
The functionality "ftu" ("Frontend Track User"), which allows to send the session through GET parameter within the site has been removed. It was used to hand in a session via `config.ftu = 1` and the GET parameter "ftu=a-32-character-string", which then started a session which was added to any link generated. This way, sessions could _have_ been transferred across domains but only if cookies would not be activated by the browser, which is unreliable. In order to pave the way to modern standards (OTP or JWT), this functionality is removed, as the ftu functionality has some flaws, conceptually and security wise. Removed public properties * AbstractUserAuthentication->get_name * AbstractUserAuthentication->getFallBack * AbstractUserAuthentication->getMethodEnabled * AbstractUserAuthentication->get_URL_ID * TypoScriptFrontendController->getMethodUrlIdToken Removed TypoScript: * config.ftu = 1 Removed TYPO3_CONF_VARS * $TYPO3_CONF_VARS[FE][get_url_id_token] GET Parameter "ftu" has no special meaning anymore. Resolves: #88458 Releases: master Change-Id: I664be44228b2180909f6abfda8acfcd5fe36aa5a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60840 Tested-by:Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
- May 29, 2019
-
-
Anja Leichsenring authored
phpunit/phpunit changed in their latest release the handling of interface constructor mocking. Some of the tests reacted to this change and needed to be adjusted. Resolves: #88453 Releases: master, 9.5 Change-Id: Ie4c42bdfe93a9b092d118e3010a22db5b088c720 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60835 Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by:
Jan Stockfisch <typo3@jan-stockfisch.de> Reviewed-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
- May 27, 2019
-
-
c.essl authored
Fix a few typos in comments with the word "exits". Resolves: #88396 Releases: master, 9.5 Change-Id: Ie1bff70e9f451c41e537c0637d63fe55999363fa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60829 Tested-by:
Sebastian Michaelsen <michaelsen@t3seo.de> Reviewed-by:
aslam idrisov <aslambek.idrisov1@swisscom.com> Reviewed-by:
-
Susanne Moog authored
The link browser now respects the sys_language_uid of the active page record when selecting content elements to link to instead of showing all content elements on that pid. Resolves: #88382 Releases: master, 9.5 Change-Id: I3f292f7af3bdfb746811f8f3937216b18a777520 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60775 Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
- May 24, 2019
-
-
Andreas Fernandez authored
The file `md5.js` used to generate a MD5 hash in JavaScript is deprecated and replaced by an AMD module `TYPO3/CMS/Backend/Hashing/Md5`. Resolves: #88432 Releases: master Change-Id: Ibc4db2af011e79f304cee5bd9de91e6505a9c138 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60790 Tested-by:
Susanne Moog <look@susi.dev> Tested-by:
-
Markus Poerschke authored
HTTP allows to send multiple headers with the same name. Espacially this is needed for the "Set-Cookie" header to send more than one cookie at the same response. Resolves: #88420 Releases: master, 9.5 Change-Id: I4fd3573424e2ebf954cc5ebd043bd710226897fa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60800 Tested-by:
-
Tomas Norre Mikkelsen authored
The Scheduler system extension requires a valid cron command or seconds between scheduler runs. With this commit, the Scheduler now allows "15 2 * * *" as well as "15 02 * * *". The latter one was not accepted till now. The "02" for the hours or minutes are valid cron times, and therefore it should also be allowed in the Scheduler. Resolves: #88371 Releases: master, 9.5 Change-Id: I2ed3d6c4cf445bf0692726c49b5c9207af2e9628 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60770 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
-
Andreas Fernandez authored
The global JavaScript function `top.openUrlInWindow()` has been marked as deprecated. This method was used to open links in a full size popup. Resolves: #88433 Releases: master Change-Id: Ia2bfafff2a3144a3a7fac5356e6cb26085fd182d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60810 Tested-by:
-
Frank Naegler authored
The js module „TYPO3/CMS/Backend/Wizard/Colorpicker“ is not used anymore. The PHP code was removed with #80913. This leftover will now get deleted. Resolves: #85401 Related: #80913 Change-Id: I07da7ac84ee88a36e87ac537ce83464c4d3ebf16 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60809 Tested-by:
-
Alexander Schnitzler authored
- Use strict type mode - Use type hints whereever possible - Use strict type comparison for in_array Releases: master Resolves: #87598 Change-Id: I639fbe1edd291af1a183171d59b0bf42988a0613 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59593 Tested-by:
Stefan Froemken <froemken@gmail.com> Reviewed-by:
-
Andreas Fernandez authored
The global JavaScript functions `top.rawurlencode()` and `top.str_replace()` were introduced in 2009 and have been marked as deprecated now. The code is not required and some special handling used in these functions may get achieved with native JavaScript functions. Resolves: #88428 Releases: master Change-Id: Ie2c2fd42da89b00e3c9a0137231b16c2cbd21396 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60805 Tested-by:
-
Andreas Fernandez authored
In rare cases it might occur that jquery is not available on ckeditor initialization, but it's used already. Interesting is that jquery is explicitly required two lines later. The code is now changed to require jquery before using its document.ready() handling. Resolves: #88429 Releases: master, 9.5, 8.7 Change-Id: I52d5a381f6415dc7680acb5d23138858dc4e96a6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60806 Tested-by:
-
Benni Mack authored
The TypoScript option config.defaultGetVars is not evaluated anymore, as this conflicts with TypoScript logic itself: After TypoScript parsing and condition evaluation in a Frontend Request, config.defaultGetVars is set, this would effectively mean that TypoScript parsing should be re-done in order to meet new possible matches in Conditions. As this logic is flawed and should now easily be handled via a custom middleware (previously this was helpful for setting e.g. L=0 for default pages with RealURL), it is now removed from Core. Resolves: #88419 Releases: master Change-Id: Ic286c96f71953062d7649d71abb72f8f0f20f1a9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60799 Tested-by:
-
Andreas Fernandez authored
The file `jsfunc.evalfield.js` responsible for form value evaluation and validation has been removed. This job is now done by `TYPO3/CMS/Backend/FormEngineValidation` since TYPO3 7.4. Resolves: #88427 Releases: master Change-Id: Ib366ccbc5795b9c428743f52098c0a6fbca47735 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60792 Tested-by:
-
Andreas Fernandez authored
This patch refactors the IRRE handling on client side, the JavaScript land has been rewritten to have a better structure and do less repeating on-the-fly calculations. Each IRRE container is represented by a independent instance of InlineControlContainer. Most of the internally used `scriptCall` directives have been removed. Currently, `scriptCall` can't get removed completely, as further refactorings in different areas are required. All of the "external" communication via `inline.foobar()` has been replaced by a event-driven approach. This also affects ElementBrowser windows, those use a minimalistic API based on postMessage. Some code that was never evaluated in ElementBrowser is considered dead and has been removed regarding inserting multiple items. A new sorting library has been added in order to replace jqueryui piece by piece. Executed command: yarn add --dev sortablejs On PHP side, some code has been removed as well since the rewritten client code is event-based and doesn't depend on external calls anymore. Resolves: #88182 Releases: master Change-Id: I4176483d2882cef49fbaddb5e2e1914c1f76c908 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59324 Tested-by: -
Stefan Frömken authored
Releases: master Resolves: #88409 Change-Id: Iff722b6b6f4206e4912fd2d2f7bc8e55d860133f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60788 Tested-by:
Josef Glatz <josefglatz@gmail.com> Tested-by:
-
Frank Naegler authored
This commit also removes superfluous code and streamlines the search template. Resolves: #88333 Releases: master Change-Id: Id6761796dd8e774497223fe7de6f811b4610e245 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60730 Tested-by:
-
GeraSchneider authored
The documentation had no information where to create custom workspaces in the backend. That information has been added. Releases: master, 9.5 Resolves: #88378 Change-Id: I8bd6d7ad2ac291e3576b89d39f9698ce16a5572c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60772 Tested-by:
-
Frank Naegler authored
Resolves: #88345 Releases: master Change-Id: I1da8e97558b0a4697db8aae6b1a098e2628fa519 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60315 Tested-by:
-
Andreas Fernandez authored
This patch removes the TBE_EDITOR.typo3form object, which is unused for a long time now. This "API" was used to either get or set values of form fields in a very old iteration of the FormEngine. Resolves: #88411 Releases: master Change-Id: If7d6e1d13c89944383d06c42d63f2f3a3b40d999 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60791 Tested-by:
-
- May 22, 2019
-
-
Benni Mack authored
Having Site Handling in place, the option "useCacheHash" rendered useless as it is added by TYPO3 Core automatically when necessary with SiteHandling. Any Fluid Arguments haven't been deprecated as this was part of the the legacy functionality. Now the options are still available, but trigger a deprecation message that the option is superfluous and should be removed. Calling typolink.useCacheHash will now trigger a deprecation message. Resolves: #88406 Releases: master Change-Id: I2243a335188c3466b8f8f59e8d3e417f13bf854d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60774 Tested-by:
-
Georg Ringer authored
The argument `showLabel` must be used while creating a button. Resolves: #88408 Releases: master, 9.5 Change-Id: I5bfcc25d03aac9da6ca11b651658749bf25d7bf1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60789 Tested-by:
-
- May 21, 2019
-
-
Anja Leichsenring authored
assertNotNull takes only one parameter, but due to a left over from former refactoring, it got two, and the first one was a static string. So the test actually did not test what it was supposed to test. Resolves: #88387 Relates: #87764 Releases: master Change-Id: Ib39d4eb623f7b079a5a4a6159ffc7520ac70642b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60778 Tested-by:
-
Frank Naegler authored
The following methods changed from protected to private: ConditionMatcher->determinePageId() ConditionMatcher->getPageIdByRecord() Resolves: #88407 Related: #87193 Releases: master Change-Id: Iea9789aeb7f74ed3dad55ee81245b7ebb5806fde Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60786 Tested-by:
-
Benni Mack authored
With the introduction of site handling, the old "pageNotFound_handling" mechanisms can be removed. If a site configuration hasn't configured a error handler, a 404/403/500 response with the default error renderer is now returned. Making PageNotFoundExceptions rendering the frontend very seldom. The following options are removed: - $TYPO3_CONF_VARS[FE][pageNotFound_handling] - $TYPO3_CONF_VARS[FE][pageNotFound_handling_statheader] - $TYPO3_CONF_VARS[FE][pageNotFound_handling_accessdeniedheader] - $TYPO3_CONF_VARS[FE][pageUnavailable_handling] - $TYPO3_CONF_VARS[FE][pageUnavailable_handling_statheader] Tests have been adopted to check against status code / message rather than on the exceptions (not) thrown (anymore). In addition, a JsonResponse is now returned if JSON was requested, instead of the regular HTML content. Resolves: #88376 Releases: master Change-Id: I6be57fadaa0ddf83039fbdcc9186ef93d5a51158 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60453 Tested-by:
-
- May 20, 2019
-
-
Anja Leichsenring authored
commands: composer update typo3/testing-framework composer require --dev codeception/codeception:^3 composer update codeception/codeception --with-dependencies Leads to: typo3/testing-framework 5.0.9 codeception/codeception: 3.0.0 phpunit/phpunit: 8.1.5 Resolves: #88388 Releases: master, 9.5 Change-Id: Ic394bdf21025705534a6f7b74ca78e155dba6a39 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60779 Tested-by:
-
Benni Mack authored
A few places still use t3ver_state instead of the available constants in VersionState. To increase the semantics of the used code, the constants are used instead. Resolves: #88395 Releases: master, 9.5 Change-Id: I3c2927c2d4c8814d581f06f84de8f4c85d6226a1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60780 Tested-by:
-
- May 16, 2019
-
-
Benni Mack authored
Due to some heavy history on the caching framework, all Database caches start with "cf_cache_", which is optimized so they are only called e.g. "cache_pagesection" in the database tables. In addition, the prefix "cache_" (in e.g. "cache_core") is unnecessary, and also there due to legacy reasons, reading $this->getCache('cache_runtime') seems very illogical. The following caches have been renamed: - cache_core => core - cache_hash => hash - cache_pages => pages - cache_pagesection => pagesection - cache_runtime => runtime - cache_rootline => rootline - cache_imagesizes => imagesizes Old identifiers can still be called within PHP, but the caching framework throws a deprecation message on setting up such a cache. A silent upgrade wizard will update one's LocalConfiguration to use the new naming scheme. The result is a cleaner, more readable and more streamlined code base (we have caches like "extbase" or "assets" where there is no prefix) and database structure. The patch is breaking due to the change in the database tables. Resolves: #88366 Releases: master Change-Id: I13dcdb0d1bf78f0899615e850856de081b715358 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59661 Tested-by:
-
- May 15, 2019
-
-
Benni Mack authored
This change removes the compatibility layer of Site Handling, called "PseudoSite" handling. Any TypoScript-related Language properties are removed. - config.sys_language_uid - config.sys_language_mode - config.sys_language_overlay - config.locale_all - config.language - config.typolinkEnableLinksAcrossDomains - typolink.useCacheHash The hook $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['t3lib/class.t3lib_tstemplate.php']['linkData-PostProc'] is removed. In addition, all tests related to PseudoSite and linking without SiteHandling are removed, linking to pages without a site will not be linked anymore. Adding `useCacheHash` to typolink triggers a "this does not do anything anymore" deprecation message. Further related removals (old "pageNotFound" handling and "useCacheHash" in all viewhelpers), are removed separately. Resolves: #88363 Releases: master Change-Id: I14f2f854e69c98df7fab8b14f92f1ec2440a15a0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59366 Tested-by:
-
Nicole Cordes authored
This patch provides the current set database value in a hidden field as early as the whole select tree JavaScript is provided. This prevents data loss if the current record is saved before the select tree was loaded. Resolves: #86954 Releases: master, 9.5, 8.7 Change-Id: I467b2a52d34b806713cd201a8a2a4f9bb8e92c71 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60415 Tested-by:
-
Benni Mack authored
The database field "t3ver_id" which is managed by TYPO3 to store the number of the version for a specific version is not in use anymore, as this was related to the non-workspace managed versioning concept. This linear versioning concept was removed, so the database field is not needed anymore. It is recommended for all extensions with TYPO3 v10.0+ compat only to remove this field. Resolves: #88143 Releases: master Change-Id: I283e8e2ba2d755dcc8b2054e2439f9fef5462511 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60459 Tested-by:
Achim Fritz <af@achimfritz.de> Reviewed-by:
-
Oliver Hader authored
https://github.com/TYPO3/phar-stream-wrapper/releases/tag/v3.1.2 * #34: Normalize resolved Windows path to Unix-style * #42: Avoid analysing non-phar files on alias resolving * #40: Add Windows tests using AppVeyor * #33: Add alternative mime-type resolving (without ext-fileinfo) composer require typo3/phar-stream-wrapper:^3.1.2 Resolves: #88354 Releases: master, 9.5, 8.7 Change-Id: I4560881006a6f9c48761161f0b96b78f02c0659d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60754 Tested-by:
-
Benni Mack authored
All functional tests that run a frontend subrequest should be tested against Site Handling, as the PseudoSite Handling is about to removed. This patch is actually a precursor to make sure that all tests work with site handling now. The AbstractDataHandlerActionTestCase adds e site configuration on each setUp(). This way, all DataHandler-related tests are running with a Site configuration of three languages. In addition, when "localizing" something, a translated page needs to exist, so most DataHandler related changes add this functionality. For some DataHandler tests, the SiteConfiguration is adapted to define the previous behavior built in TypoScript. One addition in PageResolver is made: If an GET / POST &id query parameter is given, and it is not accessible, it will fail now. Resolves: #88357 Releases: master Change-Id: I3dafec3382d8c6797f32b3acde2763dacd13e0f3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60757 Tested-by:
-
Daniel Dorndorf authored
A wrong evaluation of the null coalesce assignment (?? is evaluted and && later-on), the if() condition was always true for any previews of records with versioning enabled. The Backend API is used instead. Resolves: #88356 Releases: master, 9.5 Change-Id: I89ba14bd99bbeb17637b64d99a8d6de265a6e7c4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60758 Tested-by:
-
Oliver Hader authored
Given that e.g. public/typo3conf/ext/my_extension is symlinked to packages/my_extension, PharStreamWrapper denies invocation since realpath is resolved. For the specific PharStreamWrapperInterceptor it is okay to avoid realpath resolving. Resolves: #88340 Releases: master, 9.5, 8.7 Change-Id: I46b7100547dd0e40d1d4d76a71047ef977d8ce63 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60739 Tested-by:
tomalo.stuttgart <loeffler@spooner-web.de> Tested-by:
Rudy Gnodde <rgn@windinternet.nl> Reviewed-by:
Kevin Meckl <kevin.meckl@zdrei.com> Reviewed-by:
Richard Haeser <richard@maxserv.com> Reviewed-by:
-
Anja Leichsenring authored
Resolves: #88335 Releases: master, 9.5 Change-Id: I40569702c9cec50aa9150c666488c7a71c28b47b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60732 Tested-by:
-
- May 13, 2019
-
-
Susanne Moog authored
Resolves: #88334 Releases: master, 9.5 Change-Id: I380c0aa3dd63ab6d1a8587138e0ff33df6941ca4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60731 Tested-by:
Jonas Eberle <flightvision@googlemail.com> Tested-by:
-
