- Mar 08, 2020
-
-
Oliver Hader authored
When using a CGI wrapper to dispatch the PHP process `ORIG_SCRIPT_NAME` contains the name of the wrapper script (which is most probably outside the TYPO3's project root) and leads to invalid prefixes, e.g. resolving the `siteUrl` incorrectly as `http://ip10.local/fcgi/` instead of actual `http://ip10.local/`. Resolves: #89312 Releases: master, 9.5 Change-Id: Ib0732344deb0f2e71e06a4a1929bb712cd4f2239 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63602 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Tested-by:
Susanne Moog <look@susi.dev> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Christian Eßl authored
Since "free mode" has been introduced in #86762 for site languages, the previous onChange="reload" mechanism, when a fallbackType was changed, is now unnecessary and is now removed. Resolves: #90642 Relates: #86762 Releases: master, 9.5 Change-Id: I8bbf9a224dc47c14e4b4ec06961244b6903fbc69 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63606 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
- Mar 07, 2020
-
-
Georg Ringer authored
As the element `style` is listed in the removeTags section, there is no need to have it in the allowTags section as well. Resolves: #88561 Releases: master Change-Id: If0848c2c7533e876e500f2d7378c733f54e1f352 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63608 Reviewed-by:
Daniel Goerz <daniel.goerz@posteo.de> Tested-by:
-
Kevin Ditscheid authored
This commit fixes the setting of the select-attribute for menu items, that have a different arguments-array given to them, but the same controller => action combination as other menu items. Resolves: #87182 Releases: master, 9.5 Change-Id: I7f82be3fd3af73959f671aad781d88e4b0362fc5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59176 Tested-by:
-
As the preferred and future-proof way of creating commands is using symfony commands (as a base for scheduler tasks), the documentation has been adjusted to reflect that, by avoiding promoting the scheduler's own tasks. Resolves: #86089 Releases: master Change-Id: I12e385aaf433ad8caf5d4d43ecf41cf2ff7ceee6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63600 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
Daniel Siepmann <coding@daniel-siepmann.de> Reviewed-by:
-
Georg Ringer authored
The variable ###SITEROOT### can only be correctly substituted if the DatabasePageRootline provider is used. There it is added to the flexFormSegment as well. Resolves: #81022 Releases: master, 9.5 Change-Id: I49ecc8cb3c98b7436a013c090618960368f2b37a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63594 Tested-by:
Christian Eßl <indy.essl@gmail.com> Tested-by:
-
Andreas Fernandez authored
This patch replaces jQuery in the ClearCache module used in RecordList with Core APIs in regards of AJAX and event handling. Resolves: #90663 Releases: master Change-Id: I526a2136462c3cd494a8d3191b87f64257114b1a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63562 Tested-by:
Roland Golla <rolandgolla@gmail.com> Tested-by:
Frank Nägler <frank.naegler@typo3.org> Tested-by:
-
Susanne Moog authored
Resolves: #90415 Releases: master, 9.5 Change-Id: Icb403e6ef2892ff7988a34652d6cdfa8f8bd1cfd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63601 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
Christian Eßl authored
Do not register InMemoryLogWriter in cli mode, as it is not needed here or used later in any way, and will just fill up the memory and slow down the script execution, if many log messages are written to it. Resolves: #89928 Releases: master, 9.5 Change-Id: I6500fe8a1ba534a669ee1a6b8a4df0857be54e38 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63555 Tested-by:
-
Susanne Moog authored
When an argument definition of a console command changes for a scheduled task, it rendered the whole backend module unusable. We already had exception handling for options and missing arguments in place, now the InvalidArgumentException handling has been added as well. Resolves: #89057 Releases: master, 9.5 Change-Id: I8e182ed555a10672b0fd1c5c7249a3e8cfc5e6ad Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63599 Tested-by:
-
Jigal van Hemert authored
To prevent memory issues with huge sys_history tables and to prevent timeouts when handling large amounts of data the wizard processes small batches of records at a time, keeps track of its progress in the registry and this way allows repeated runs without losing data. If both the registry and sys_history share the same connection a database transaction is used to make sure that modifying data and progress tracking are in sync. Resolves: #88487 Releases: master, 9.5 Change-Id: I7d323ac3dae1d416f5883b2e52f94ee50bd66327 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61654 Tested-by:
-
- Mar 06, 2020
-
-
Georg Ringer authored
Urls starting with `//` should have a proper fallback to avoid warnings e.g. in InputLinkElement that this type of url is unknown. Resolves: #90171 Releases: master, 9.5 Change-Id: Ic3910f98c3993fb5db523ba1b360eabb49bf0696 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63543 Tested-by:
-
Benni Mack authored
Updating core's latest prophecy to v1.10 instead of v1.09 which then allows to enable phpunit v9 at a later stage. used composer command: composer update phpspec/prophecy --with-all-dependencies Updating phpdocumentor/reflection-common (1.0.1 => 2.0.0) Updating phpdocumentor/type-resolver (0.5.1 => 0.7.2) Updating webmozart/assert (1.6.0 => 1.7.0) Updating phpspec/prophecy (1.9.0 => v1.10.3) Resolves: #90671 Releases: master Change-Id: Idf4c2f559e769311c608bb69c46dedb9b4bdc549 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63571 Tested-by: -
Benni Mack authored
This feature adds a link on TYPO3 Backend's login form to reset a backend users' password if the user has forgotten the password. Key changes: * Only enabled for backend users with an email address and a password set * Enabled by default but can be disabled completely * Optionally only works for non-admins via TYPO3_CONF_VARS * Only send out emails to users within the system, but no information disclosure * If multiple valid users have the same email address, a different email is sent out * TCA be_users.email is not set to eval=email (due to backwards-compatibility) * Password resets are only valid for 2 hours (non-configurable) * Not extensible for third-party authentication methods yet * Rate limiting is enabled per email address for 3 attempts per 30mins (non-configurable) * When logging in, all previous tokens are removed * When requesting multiple resets, only the last email is valid * A CLI command "backend:resetpassword $backendUrl $emailAddress" sends ou...
-
Susanne Moog authored
The scheduler exception handling on editing silently ignored most exceptions. The one exception was a specific exception that did not even exist anymore. The handling was changed to only ignore those exceptions with existing handling and adding messages for all others. Resolves: #80299 Releases: master, 9.5 Change-Id: I9b2a91f244bec99deb79da93a4e33680e862d16c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63568 Tested-by:
-
Tymoteusz Motylewski authored
Added cache type definition Releases: master, 9.5 Resolves: #89340 Change-Id: I05634dc0e9ef22ad9764635965c197f494d3a14b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61853 Tested-by:
-
Christian Eßl authored
According to the documentation, the boolean checkbox for type "comment" should behave in the following way: - checked= “” - not-checked = “#” The handling of this behaviour was faulty in the TypoScript Constant Editor. This means, every time the constants were saved without changing the "comment" checkbox, its value was reversed. Further information: https://docs.typo3.org/m/typo3/reference-typoscript/master/en-us/UsingSetting/TheConstantEditor.html Resolves: #82208 Releases: master, 9.5 Change-Id: I1473b435e37b47c4563f0d245e09b1680c738bcd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63518 Tested-by:
-
Susanne Moog authored
As the path to the TYPO3 binary in composer mode depends on composer bin dir and the sysext path should not be used the message displayed in the scheduler was changed to not provide faulty information. Resolves: #85468 Releases: master, 9.5 Change-Id: Ibbee8a417130a1235f419cef471c349ead59bf0e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63566 Tested-by:
-
Alexander Schnitzler authored
Releases: master Resolves: #90665 Change-Id: I55c08b826d6e4560cbfbcde99e795f55036b049c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63565 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
Christian Eßl authored
In a TabsContainer, if all the fields of a tab are hidden to the editor (by disabling them in PageTS), the tab would still become assigned in the 'items' fluid variable. The empty, but invisible, tab would then still be considered for determining the active tab in the view. If the first tab was disabled in this way, the editor would see no active tab at all. To prevent this from happening, the tab elements are now never assigned, if their content is completely empty. Resolves: #89094 Releases: master, 9.5 Change-Id: I3cbe98e7e25b7827fdc68583387343f5f0cb64ca Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63512 Tested-by:
-
Andreas Fernandez authored
To log the exception properly, the variable `$defaultLanguageUid` is now used instead of the undefined `$localizedUid`. Resolves: #90664 Releases: master, 9.5 Change-Id: I975868f95e7fb789ce31c260185b1a62654fd8fe Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63564 Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Reviewed-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
-
Gerrit Mohrmann authored
Argon2id should never be set automatically for compatibility reasons. At some places the array sorting will give the priority which password hashing type will be used, but the priority value from the preset is also used. To make sure Argon2i is set for new installations, priority of Argon2id is set below Argon2i. Resolves: #90643 Releases: master Change-Id: Idb96b17eda80a783d2de0d228f7381bfd674ce54 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63550 Tested-by:
-
Susanne Moog authored
Add "distinct" into the whitelist of allowed select parts. Resolves: #43114 Releases: master, 9.5 Change-Id: I8ae6561ff6067117b9d5acb6c976966fecaee96a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/38372 Tested-by:
-
Anja Leichsenring authored
The parent class states an integer value is returned, but most core commands did not follow that rule. Now they got according return statements to fulfill that contract. Resolves: #90652 Releases: master Change-Id: I58ad434404ce3537a4eb7ae34b88884b6962047f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63557 Tested-by:
-
Alexander Schnitzler authored
phpstan identified a bunch of possibly undefined variables which is fixed with this patch. Releases: master Resolves: #90581 Change-Id: If41bee3dcd972d26f8eff18dbcbc61ad1fe79e7f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63483 Tested-by:
-
Benni Mack authored
Most access to the configuration options are made against AbstractFile objects in FAL, which is now centralized in one place in AbstractFile. This reduces errors when checking for file patterns. Resolves: #90305 Releases: master Change-Id: I7835d877bae1addf830ede3645ff8f1faa113052 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63155 Tested-by:
-
Oliver Bartsch authored
With #90608 the PageLayoutView was extended to also take `tables_modify` for `tt_content` into account. Unfortunately the newLanguageButton was forgotten, which also needs to be checked regarding proper edit permissions, as without these, translating a `tt_content` record is not possible. Resolves: #90632 Related: #90608 Releases: master Change-Id: Ia6f2ff02dbc3cda09a40fb5d22d9b7b9ef56c58f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63547 Tested-by:
-
Benni Mack authored
Extbase's SignalSlot Dispatcher has had its good run - it served as a possible successor instead of Hooks but lacked a good standardized API for stopping propagation, and defining interfaces for slots. The new PSR-14 based event system has superseded SignalSlot logic from Extbase. Everybody is encouraged to not use Signal Slot logic anymore. TYPO3 Core does not use SignalSlots anymore, and the SignalSlot Dispatcher will be removed in TYPO3 v11.0 - and is therefore annotated as deprecated. Several advantages of PSR-14 over Signal Slot logic defined here again: - PSR-14 has a stoppable interface so event listeners can define that an event should not propagate anymore. - PSR-14 events are pure and plain PHP classes so it is VERY clear what can be read or modified. - TYPO3's implementation is fully compatible with other frameworks PSR-14 event-based system, so everything can be developed against the interface, not a concrete implementation (thanks to DI), and TYPO3 can exchange its own implementation against a different one. - All available listeners are registered during "DI-build-time" and not in ext-localconf.php anymore which can have an impact on performance. Please note that using SignalSlot Dispatcher will not trigger a deprecation warning as it is still used throughout many extensions. Resolves: #90625 Releases: master Change-Id: I09764b5056777fd3673a9e158762c9d5a9182997 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63099 Tested-by:
-
Andreas Fernandez authored
This patch removes all occurrences of bootstrap-slider in Core with the native `range` input type. To ensure a consistent styling across all platforms, new CSS is in place. However, we can't recover the same styling as used with the bootstrap-slider either due to inconsistent browser support of selectors or missing features. In the `ValueSlider` module, which is only used by FormEngine, any usage of jQuery has been removed as well. Resolves: #90649 Releases: master Change-Id: Ic2e0cb7aa9305159c33f14130d3fe6e62d2fd1da Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63523 Tested-by:
-
Benni Mack authored
If a treedataprovider (e.g. from news) extends from Core's constructor, Core hands in various multiple arguments. However, Core is configured to only hand in one argument, which is auto-wired. So there are multiple options: - Third-party extensions would need to be autowiring their signatures as well, however would never receive the EventDispatcher object. - Reflect on the constructor method and hand in the EventDispatcher manually, but also with the custom arguments as an additional argument - throw away the custom configuration options and use setter injection for the options Resolves: #90302 Releases: master Change-Id: I5874e5819f2bda3b4470cf7bd447e0161169536f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63184 Tested-by:
-
Benni Mack authored
Various GeneralUtility::_GET() calls are now replaced by using the PSR-7 Request object, reducing the need for accessing global scope variables $_GET and $_POST. Resolves: #90655 Releases: master Change-Id: Ia636df18396f27db5edab3533371d25d98324831 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63559 Tested-by:
-
Benni Mack authored
Guzzle 6.5.0 introduced an issue with umlaut domains which was fixed in Guzzle 6.5.1 and Guzzle 6.5.2 respectively. The conflict section in composer.json is now updated, in order to allow composer-based TYPO3 installations to a) allow TYPO3 updates to 10.3.x/9.5.14/8.7.31 even if guzzle has been locked in composer.lock to 6.5.2 already b) allow to use the latest Guzzle fixes again Used composer command: composer update --lock See https://github.com/guzzle/guzzle/issues/2448 which was integrated in Guzzle 6.5.1 (which was released AFTER our core release in December 2019) Resolves: #90634 Releases: master, 9.5, 8.7 Change-Id: If6c2f3ef6529109148569f1af9472b0bcb44c9b9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63548 Reviewed-by:
-
Georg Ringer authored
As the PageBrowsingViewHelper actually renders a HTML tag it should extend AbstractTagBasedViewHelper. This also allows integrators to define the well known attributes like class. Resolves: #90484 Releases: master Change-Id: If20250cb834b8cb21ae0e30c9e4e7e373643e374 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63542 Tested-by:
-
- Mar 05, 2020
-
-
Anja Leichsenring authored
The parent class defines a return value of type int, but the command does not provide one. This causes a test failure after latest dependency update of codeception version 4. Resolves: #90651 Releases: master Change-Id: Iecb1f3aa95feee6a0276ad1a0660999523490a53 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63556 Tested-by:
Richard Haeser <richard@maxserv.com> Tested-by:
-
Anja Leichsenring authored
The test used to use the iFrame id, but some updated dependency caused this misuse to fail. Using the proper name attribute for navigation fixes the test. Resolves: #90650 Releases: master Change-Id: I379d5b44e1f20e53120f2b066af739716e0b5726 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63554 Tested-by:
-
Georg Ringer authored
Let the Install Tool check also for PHP extension PDO. With #85803 the requirement has also been added to the composer.json files. Resolves: #88141 Releases: master Change-Id: I9eb10f71db3d5111362833b3f07f2f687bf0ee69 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63553 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
Anja Leichsenring authored
The version contains a bugfix, that caused acceptance test to fail due to missing method declaration. Using ^1.1 as minimum requirement prevents acceptance tests from failing with usage of low codeception packages after codeception version 4 release. composer require codeception/lib-asserts:^1.1 --dev Resolves: #90647 Releases: master Change-Id: I77c93efd47ee5b6d6195c16f38065edac3e05ba5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63552 Tested-by:
-
Gerrit Mohrmann authored
In the initializeLoginAction the view is not available. Move the events to loginAction to make it possible to dispatch the LogoutConfirmedEvent. Resolves: #90644 Releases: master Change-Id: I21cb0dcb77a7ef2d2667101792bb53209c908f78 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63551 Tested-by:
-
- Mar 04, 2020
-
-
Christian Eßl authored
The changes made in #88499 removed the support for "default urls". This left broken view buttons in the redirects module for redirects with '*' set as source host, where no domain could be determined. Resolves: #90630 Related: #88499 Releases: master Change-Id: Idc9c8a8638ccf58be2493ebd7a0290c47b4de18f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63540 Tested-by:
-
Georg Ringer authored
This is a followup to #81964 which removed the exclude configuration from the fields width & height. However, if EXT:filemetadata is installed, this overrides the TCA again. This patch removes the information there as well. Resolves: #90637 Releases: master Change-Id: Iaf3907e14484052714172320f8e5b86c452b82df Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63549 Tested-by:
Stefan Froemken <froemken@gmail.com> Tested-by:
-
