- Nov 30, 2021
-
-
Oliver Hader authored
Removes deprecated BackendUtility::viewOnClick, which should have been replaced with \TYPO3\CMS\Backend\Routing\PreviewUriBuilder. Resolves: #96141 Releases: main Change-Id: Iae391d10cba9880c23bf124e0905993fd315c405 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72376 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Oliver Bartsch authored
It's no longer possible to pass a records' uid to AbstractTreeView::getIcon(), since the methods first argument "$row" is now type hinted "array". Resolves: #96144 Related: #92922 Releases: main Change-Id: I0cf19bb361720905ee05140c611a7d8fafa00df5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72380 Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
-
Oliver Bartsch authored
The single field configuration "special" of TCA type "select" was mainly used in core only, and was therefore replaced by the dedicated TCA type "language" and proper itemProcFunc's. The corresponding method "addItemsFromSpecial" in AbstractItemProvider is therefore now removed, making the "special" TCA option obsolete. Resolves: #96150 Related: #93837 Releases: main Change-Id: I070773aa259e5f49131a77ddeddd27f03042b3f3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72387 Tested-by:
-
Oliver Bartsch authored
GeneralUtility::stdAuthCode is unused since at least v9 and is therefore now removed. Resolves: #96140 Related: #94309 Releases: main Change-Id: Idc68fff1c946e7f2f30645a6a3510d95f8e272bf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72375 Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
-
- Nov 29, 2021
-
-
Oliver Hader authored
To avoid introducing new components that rely on inline JavaScript, Content-Security-Policy HTTP headers for the TYPO3 backend are enabled when executing automated tests. Resolves: #95898 Releases: main, 11.5 Change-Id: I2bbc1ce055d066381cd53449d1b37fd2cafe0168 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72137 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Oliver Hader authored
Resolves: #96133 Releases: main, 11.5, 10.4 Change-Id: Ic1924bbf34b746bf1891419da6cb54e547a509a8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72351 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Christian Kuhn authored
AbstractService is not used anymore and is now removed. Resolves: #96129 Related: #94313 Releases: main Change-Id: I8a23b80f8d36b446a4ae0bcd1b2d701ec1eade20 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72348 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Susanne Moog <look@susi.dev> Reviewed-by:
-
Christian Kuhn authored
Change-Id: I13ca3c60a040c15aca8e259e7c65d33682f37c44 Resolves: #96131 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72349 Tested-by:
-
- Nov 28, 2021
-
-
Benni Mack authored
The option to use the @import syntax in TypoScript "page.includeCSS" and "page.includeCSSLibs" (.import subproperty per CSS file) will not work anymore. Resolves: #96118 Related: #95349 Releases: master Change-Id: Ibcbcf091eca00d061cc79b551f87995ddf47c1a0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72338 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
-
Benni Mack authored
The methods `PageRepository->fixVersioningPid()` and `BackendUtility::fixVersioningPid` are removed, because they are not needed anymore since TYPO3 v11.0 with the removal of various VersionState (t3ver_state). Resolves: #96120 Related: #92598 Releases: master Change-Id: I029169563e094b42a2e8a1a52d0a6533984436d9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72341 Tested-by:
-
Christian Kuhn authored
Resolves: #96126 Related: #94209 Releases: master Change-Id: If2edcfdbf6ab2e206c43c634fa58ccf75c75ab38 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72343 Tested-by:
-
Benni Mack authored
The hook $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['typo3/browse_links.php']['browserRendering'] is replaced in favor of the Element Browser registry. Related: #95322 Resolves: #96123 Releases: master Change-Id: If362551cf7c4a093cde4e0742037155afedbea32 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72345 Tested-by:
-
Stefan Bürk authored
CleanerTaskTest dynamically calculates the needed 'period' time to use for testing, if one page records will survive the cleaning task, as not being outside this periode grace time. This has worked quite some time, but may crash now in a quite narrow timeframe, which failed core ci tests, if they were run in this timeframe - and made it reproducible only for a night owl, as the timeframe lays between UTC '00:00-01:00'. PHP8.1.0RC6 included a regression bugfix which introduced another bug, which leads to inconsinstent calculation behaviour for using 'diff()' method of '\DateTime' or '\DateTimeImmutable', if timezone switches are needed and there are the first hour leap (or two hour in summer time). This is already fixed in PHP8.1.0 release. As we do not really need that 1 hour leap calculation here, we are able to tighten the test setup here and calculate the needed dynamic period in way to work around this bug for PHP8.1.0RC6, be backwards compatible and also being safe for 8.1.0 release. PHP regression fix introduced new bug (8.1.0RC6): https://github.com/php/php-src/commit/904933e9185664148ce54 PHP bugfix released with 8.1.0: https://github.com/php/php-src/commit/e4679ef0c2d5a0a81cb6e This patch uses '00:00:00' for the time part of both dates and further uses 'UTC' timezone enforcement to calculate the period time, which stabilizes this testcase and lets night owls do their stuff undisturbed. Resolves: #96128 Releases: master, 11.5 Change-Id: Ib1f4201ce8556ae8f22eeb4463732c62394e3c14 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72346 Reviewed-by:
Stephan Großberndt <stephan.grossberndt@typo3.org> Reviewed-by:
-
Stefan Bürk authored
Creating auto redirects, if page slug is changed, has been extended to add the target with LinkHandler 't3://' uri schema with #89327, adding language argument '_language' to enforce the language for the redirect, missing that that did not worked, which was solved through adding '_language' argument handling in #96043. As languge arguments '_language' and 'L' are ignored, if the provided page uid is already the uid of the localized page, the parameter was meaning less. Further this breaks language fallback handling, if the localized page record is deleted. This patch uses now the default language page uid for creating target of auto-redirects to mitigate the issue that redirect will break if localized page is deleted but language fallback is configured. Resolves: #96103 Related: #96043 Related: #89327 Releases: master, 11.5, 10.4 Change-Id: I2ece06bf053bda4edb542910c3f51b1e6c8e052c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72327 Tested-by:
-
Christian Kuhn authored
Resolves: #96127 Related: #94654 Releases: master Change-Id: I95b1c675221ffa5b53f31757b1788cfe20652bcf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72344 Tested-by:
-
Georg Ringer authored
The translations need to use the language of the current backend user and not the one of the current language of the site in the frontend. Resolves: #96004 Releases: master, 11.5, 10.4 Change-Id: Id409e759de4f0324835cc932f87719147b6e1b0f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72196 Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Sybille Peters <sypets@gmx.de> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Reviewed-by:
-
Benni Mack authored
Globally configured ATagParams via config.ATagParams are now always added. Resolves: #96119 Related: #95219 Releases: master Change-Id: Id862c7790c8a509f604278bd1323ad0b262b2c83 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72339 Tested-by:
-
Benni Mack authored
The hook has been replaced with the PSR-14 event "TYPO3\CMS\Core\Resource\Event\ModifyFileDumpEvent" and is thus removed. Resolves: #96117 Related: #95080 Releases: master Change-Id: I0ff076381e1629028a2ca236b23121dfdffdb05c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72337 Tested-by:
-
Christian Kuhn authored
Resolves: #96115 Related: #94665 Releases: master Change-Id: Id7702f2328a0ca848656caae8350d6facc65068a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72336 Tested-by:
-
Christian Kuhn authored
Resolves: #96114 Related: #94664 Releases: master Change-Id: I6ada8e2b4249f2f38cdab2b1074333d8ac8e03d7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72335 Tested-by:
-
Christian Kuhn authored
Change-Id: I417f0f896e07b05d4577c865195724955fa7bc45 Resolves: #96113 Related: #92080 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72334 Tested-by:
-
Sybille Peters authored
This patch handles problems which occured with a large number of pages and also for a large number of records to be checked for broken links. The problems previously resulted in "Prepared statement contains too many placeholders" exceptions and consumption of too much RAM and (possibly) out of memory errors. Technical details about the implementation follows because this is handled slightly differently than in other areas of the core. LinkValidator used named placeholders to build database queries, and the EditableRestriction class also used a number of placeholder. Technically 'doctrine/dbal' explodes named placeholders for array values with quote type 'PARAM_INT_ARRAY' or 'PARAM_STR_ARRAY' to single unnamed placeholders for each value, using one placeholder for each array value. If multiple array value placeholder are used with a large number of values this could quickly emit the "Prepared statement contains too many placeholders" error as the limit is reached. The limit differs beetween the various database systems. One way to work around this issue is to do database operations in chunks, but it could become quite difficult to calculate the chunk size beforehand. Array values are mainly used for 'in()' or 'notIn()' query expressions, which naturally do not not have direct limits for the value count in it through all supported dbms systems. This opens the possibility to use direct value lists for these expressions. There are other dbms limitations depending on the used dbms (for example on mariadb/mysql 'max_allowed_packets', max query size setting for SQLite), which may be adjusted in some cases. However we could not safely expect that these values are monitored and adjusted, so we still need to do database operations in chunks, but make it a little easier for 'chunksize' calculations. During testing on an instance with a large number of pages, it was found that LinkValidator used up a lot of memory, reaching the configured memory limit of 2G on that system, which itself was very high already (and far beyond the recommended 256MB limit). Instead of collecting unlimited results in an array before checking links against this array, doing this for each record directly avoids excessive memory consumption during link checking. It was decided to do this in this patch directly instead of a separate patch, as this patch otherwise would not be testable in real instances. This patch does the following: * introduce two method to implode value arrays in QueryHelper * replace placeholder in EditableRestriction with quoted values * replace placeholder in BrokenLinksRepository with quoted values * introduce chunk database operations in BrokenLinkRepository * introduce chunk database operations in LinkAnalyzer * move $results array and call checkLinks() on it to the inner loop to process this for each record (instead of accumulating the results in a huge array. In the future we need to investigate and find a more generic way to handle such scenarios for larger instances. This may take some time and investigation to do this properly and in a reusable way. To not stall the bugfix further, we are doing the workarounds in this patch to solve these issues in the meantime. Resolves: #92493 Releases: master, 11.5 Change-Id: I9a596df6749d07afee9c5ac37266b876ddc6e297 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66896 Tested-by:
-
Nikita Hovratov authored
The JavaScript method "scrollIntoView" does not work for elements inside a modal or similar. It only scrolls the main page. A quick and easy alternative is to set "scrollTop" to a very high value. Resolves: #96070 Releases: master, 11.5 Change-Id: Ic5cea96177442acc57ea78cfa66b698c0dfd0f81 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72280 Tested-by:
-
Stefan Bürk authored
The json_response functional test extension will soon avoid returning json encoded responses. This will make the functional frontend test suite fully transparent regarding responses. This patch prepares a couple of frontend functional tests towards this change. Resolves: #96112 Releases: master, 11.5 Change-Id: I8116caf08e4b8b76ad5d23b49954d9cb78d1c4de Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72319 Tested-by:
-
Torben Hansen authored
When performing a search in the configuration module, a JavaScript error will occur, if a possible expanded tree node is not part of the search result. This patch adds checks for existence of the scrollElement variable. Resolves: #96097 Releases: master, 11.5 Change-Id: I5977dd48487563ae30407f8cf126724acc9bcb0a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72320 Tested-by:
-
Jochen Roth authored
The NoteController, used to display system notes in a couple of modules, e.g. page layout, does now properly check the corresponding user permissions (show/edit/delete). Resolves: #96037 Releases: master, 11.5 Change-Id: Ic0e6670f7befa23802382c0818454c4e7c34a253 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72237 Tested-by:
-
Helmut Hummel authored
Remove unnecessary bloat from the composer.json Releases: master Resolves: #96102 Change-Id: Id5353c509ec2af23baae555f63cd3f123403364e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72332 Tested-by:
-
Christian Kuhn authored
Resolves: #96111 Releases: master, 11.5 Change-Id: Id8b381371ea257eb85e2ff59d5aeb1fbb7786db7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72333 Reviewed-by:
-
Henrik Elsner authored
Resolves: #95486 Releases: master Change-Id: I6f9927e524e9d44e4e976ec948614d02d3a24edc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71452 Tested-by:
-
- Nov 27, 2021
-
-
Nikita Hovratov authored
The method getVal now always returns an array with a string at index 0 and an array at index 1. Resolves: #96001 Releases: master, 11.5 Change-Id: Ia1b321694767fa01b1de9176b87470522511d150 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72195 Tested-by:
-
Christian Kuhn authored
When TYPO3 is 'natively' called by a web server call, the main application entry point is AbstractApplication run(). When using a PSR-15 from within some other application, a request should be hand over to Application->handle(), expecting a response object. Now we have that ImmediateResponseException thrown by TYPO3 at some places. ImmediateResponseException is only caught within run(), not within handle(). A PSR-15 call to handle() will thus not catch ImmediateResponseException, it bubbles up to the calling application. PSR-15 section 1.4 of https://www.php-fig.org/psr/psr-15/: "It is RECOMMENDED that any application using middleware includes a component that catches exceptions and converts them into responses." The patch changes AbstractApplication to follow this: The ImmediateResponseException is a TYPO3 internal management exception, a calling application should never need to deal with it, but can expect to receive a response object instead. Change-Id: I2857efd2b575a9b324d3d7a23df0bca5763a8839 Resolves: #96099 Releases: master, 11.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72321 Reviewed-by:
-
Sybille Peters authored
The title and description texts as well as the README.rst for system extensions are unified and some texts updated to reflect changes. Since the description and README.rst are also displayed on Packagist, the text should be chosen so that it helps people not familiar with TYPO3 know what the package is about (e.g. by preceding the description with "TYPO3 CMS"). Descriptive texts for extensions are in these files: - composer.json - ext_emconf.php - README.rst The information is displayed in the Extension Manager (ext_emconf.php), on extensions.typo3.org, on Packagist (composer.json and README.rst) and on GitHub (README.rst). We reuse the same text blocks in the following manner: 1. Extension title - used in ext_emconf.php:title and composer.json: description 2. Extension description (short) - used in ext_emconf.php:description and composer.json:description 3. Title and extension description (long) - used in README.rst. In most cases, the short description is reused, in some cases it is augmented with more information. In composer.json, the description consists of: '<title> - <description>' Also, - In the title all words are capitalized (common name) - The title always starts with "TYPO3 CMS" - The description ends with a period. Resolves: #96059 Releases: master Change-Id: I57388ff96c5fcf9a8e64cd86ed8427f70d7ef23d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72288 Tested-by:
-
Jochen Roth authored
Currently language:update command fails when a translation of a extension is missing. This has been fixed by returning a successful status code even though the file was not found on the translation server. With the additional option '--fail-on-warnings' the command fails if the download of a language pack was not successful. Missing files are still reported in CLI stdout and it still fails if the server is not reachable. Also missing translations are now logged. Resolves: #95700 Resolves: #96054 Resolves: #96055 Resolves: #96053 Releases: master, 11.5 Change-Id: I9a19de919e99b591dcf02a5cf70465ad9c5c76b7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72274 Tested-by:
-
Torben Hansen authored
The feature page.includeCSS.inline checks the existence of the given file with `is_file()`. This does not work for files included with the EXT: prefix, since the path to the filename is not fully resolved any more since https://review.typo3.org/c/Packages/TYPO3.CMS/+/71457 This patch processes the given file using the `getStreamlinedFileName` function in order to resolve the relative path to the file. Resolves: #96098 Releases: master, 11.5 Change-Id: I2958eb13228622e724b5d4db1919a982fcd6247e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72324 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
Daniel authored
Array access with undefined key emits undefined index warning. This patch sanitize the calls to mitigate these warnings. Releases: master, 11.5 Resolves: #96072 Change-Id: Ic86781728fcb61b4dc3d9442fe5228c6b8a81474 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72282 Tested-by:
-
Christian Kuhn authored
Deprecation removal main boilerplate .rst file with a dummy entry for each section. Resolves: #96108 Related: #96107 Releases: master Change-Id: Id94f0b33ff93885caf61814d93d14965e4566b04 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72330 Tested-by:
-
Helmut Hummel authored
In preparation of renaming the main development branch, the alias for the new name is added. This makes it possible to rename the branch and have a working alias, without needing to add further commits to it. composer up --lock Releases: master Resolves: #96102 Change-Id: Id01c6d562a2bdd0c42a7b6ad69019b19181c94ee Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72325 Tested-by:
-
Christian Kuhn authored
* TYPO3_TESTING_FUNCTIONAL_REMOVE_ERROR_HANDLER is obsolete * phpunit 9.5 is minimum requirement * An acceptance test setup detail has been activated in testing-framework by default Change-Id: Idaafa923fe8544fdd9f20395de6557be709562cb Resolves: #96106 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72329 Tested-by:
-
Christian Kuhn authored
* Obsolete importScenarioDataSet() by using importCSVDataSet() directly with absolute paths. IDE's now resolve these paths so they can be clicked to open, which is *much* more convenient when working with the .csv files. * Similar, obsolete assertAssertionDataSet() by using assertCSVDataSet() directly. * Protected constants. * Late static binding for workspace init in setUp() to simplify and streamline workspace test inheritance. * A couple of minor streamlinings. Change-Id: I9e814335b863da278e814641f6995a24778da95b Resolves: #96104 Releases: master, 11.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72326 Tested-by:
-
Sybille Peters authored
Different labels for various fields of a redirect record were used in redirect list and redirect edit form. For example, both "Destination" and "Target" were used for the same field. This patch unifies the labels, preferring labels from the edit form (locallang_db.xlf). This frees up some language labels which can be removed in v12. Resolves: #95832 Related: #96015 Releases: master, 11.5 Change-Id: I2950a29ed5f20f74de3091d391e44bba292563af Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72217 Tested-by:
-
